From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.44; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0044.outbound.protection.outlook.com [104.47.1.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 203A82215BD92 for ; Mon, 29 Jan 2018 07:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kai4pNyF2JCSEcDAyhBMUXqBto5sXPyIjZV86rzP5sw=; b=p06kVwMwhmCOK5i0XzHNwSJpTTz/igxpwo2moBvsiOEQ4mdGzgO8CcJMBuUiY1GFqrMXhkVv3pDIps8DrPW92cvmsXy/B1qHZ9bflMe0pCnV0sHnfYuZRQ1eHPYif5NJ6getNUEIDUEslD6WJ+G3L7sozCRkEn5ebPLLwPWalmc= Received: from HE1PR08MB2923.eurprd08.prod.outlook.com (10.170.245.152) by HE1PR08MB1001.eurprd08.prod.outlook.com (10.166.125.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 29 Jan 2018 16:01:47 +0000 Received: from HE1PR08MB2923.eurprd08.prod.outlook.com ([10.170.245.152]) by HE1PR08MB2923.eurprd08.prod.outlook.com ([10.170.245.152]) with mapi id 15.20.0444.016; Mon, 29 Jan 2018 16:01:47 +0000 From: Thomas Abraham To: Leif Lindholm CC: "edk2-devel@lists.01.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [PATCH] Platform/ARM/VExpress: refine the check for DVI support Thread-Index: AQHTmRCb67g0ia09t0WcZs+UsVN8SqOLAWDw Date: Mon, 29 Jan 2018 16:01:47 +0000 Message-ID: References: <1516986299-1616-1-git-send-email-thomas.abraham@arm.com> <20180129145104.hwd4afi4l3kjf6an@bivouac.eciton.net> In-Reply-To: <20180129145104.hwd4afi4l3kjf6an@bivouac.eciton.net> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=thomas.abraham@arm.com; x-originating-ip: [217.140.105.40] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR08MB1001; 7:bWrfp4oRd2IP8rgYC1Lnddw3jZQn4mjrKHzMNajq7Mb3ihVc3uxQGoM9BHVNn2vO/ST3phm1s0EgRLhMAd8m46AI3xh4Wno7utaS2C6ds7kuV/s/Dy24k3Fehhm1nmtOmSYV9eRYvOO7gTQ9NySHdNJ+R2A18icWwem7WHynrDZA6KCIhSYUaBa0V0jpsjr2a6DGlXBHL0JIfyxVAOI4gcWnj+8ly9mt/B6vLnBlo23ZDf/OrVzM6xqpc+EshOKM x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7615c23d-b627-40a8-b79d-08d567319a14 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR08MB1001; x-ms-traffictypediagnostic: HE1PR08MB1001: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(944501161)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041288)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR08MB1001; BCL:0; PCL:0; RULEID:; SRVR:HE1PR08MB1001; x-forefront-prvs: 0567A15835 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39380400002)(39860400002)(396003)(40434004)(199004)(189003)(86362001)(186003)(5660300001)(6916009)(26005)(316002)(3280700002)(54906003)(6436002)(81166006)(4326008)(2950100002)(77096007)(97736004)(66066001)(99286004)(81156014)(55016002)(105586002)(3660700001)(5890100001)(8936002)(74316002)(14454004)(305945005)(7736002)(2900100001)(7696005)(9686003)(68736007)(53936002)(478600001)(6246003)(6506007)(53546011)(59450400001)(3846002)(25786009)(102836004)(8676002)(6116002)(33656002)(106356001)(229853002)(2906002)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB1001; H:HE1PR08MB2923.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dQWZWgU1B+dKnygqd5jcmvdTFt4LSw8vZr6rQp6PnzcyMxHCj8nGQBoVvNgNg2kxsuyh0c7i90CPw/nPdWG+tg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7615c23d-b627-40a8-b79d-08d567319a14 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2018 16:01:47.7494 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB1001 Subject: Re: [PATCH] Platform/ARM/VExpress: refine the check for DVI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 15:56:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > On Mon, Jan 29, 2018 at 8:21 PM, Leif Lindholm = wrote: > On Fri, Jan 26, 2018 at 10:34:59PM +0530, Thomas Abraham wrote: > > The base models could have different values for the revision ID field > > in the System ID register. Base models do not have support for DVI and > > so the revision ID field should also be masked out when checking for > > the presence of DVI support. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Thomas Abraham > > --- > > .../VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c = | > 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > > a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > > Express.c > > > b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > > Express.c > > index 3f3ceb3..89ba130 100644 > > --- > > > a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > > Express.c > > +++ > b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111Lcd > > +++ ArmVExpress.c > > @@ -264,7 +264,7 @@ LcdPlatformSetMode ( > > SysId =3D MmioRead32 (ARM_VE_SYS_ID_REG); > > if (SysId !=3D ARM_RTSM_SYS_ID) { > > // Take out the FVP GIC variant to reduce the permutations. > > - SysId &=3D ~ARM_FVP_SYS_ID_VARIANT_MASK; > > + SysId &=3D ~(ARM_FVP_SYS_ID_VARIANT_MASK | > > + ARM_FVP_SYS_ID_REV_MASK); > > if (SysId !=3D ARM_FVP_BASE_BOARD_SYS_ID) { > > // Set the DVI into the new mode > > Status =3D ArmPlatformSysConfigSet (SYS_CFG_DVIMODE, > > mResolutions[ModeNumber].Mode); > > I think this change makes sense (and should arguably have been there from= the > start). But I also think it highlights that the surrounding comments are = incorrect, > and get increasingly confusing with this modification. > > I would suggest that > // On the FVP models the GIC variant in encoded in bits [15:12]. > is replaced by > // On the FVP models, the build variant is encoded in bits [15:12]. > > and that > // Take out the FVP GIC variant to reduce the permutations. > is replaced by > // Ignore build variant and revision. > > If you're happy with that, I can fold these changes to the surrounding co= mments > in and commit. Yes, happy to have these changes folded in. Thank you!. Thomas. > > / > Leif IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.