Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen

["memristor2 via groups.io" <memristor2=proton.me@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 3634 bytes --]

Hello,
I looked into this driver and saw it was platform-independent. Why not add this into to the features directory? I wrote this driver from scratch and saw this patch later in my emails. it would facilitated my development if I saw it sooner if it were inside a directory that was platform-independent.
Thanks,
Memristor

Sent with [Proton Mail](https://proton.me/) secure email.

On Thursday, August 29th, 2024 at 10:46 AM, Nhi Pham via groups.io <nhi=os.amperecomputing.com@groups.io> wrote:

> Pushed as 9d8eda6ffff2..146cb5322498
>
> Thanks,
> Nhi
>
> ---------------------------------------------------------------
>
> From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Nhi Pham via groups.io <nhi=os.amperecomputing.com@groups.io>
> Sent: Friday, August 23, 2024 9:51 AM
> To: Chuong Tran OS <chuong@amperemail.onmicrosoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>
> Cc: quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebecca@os.amperecomputing.com>
> Subject: Re: [edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen
>
> Thanks for the review. I will push after the IPMI SSIF support is merged.
>
> -Nhi
>
> ---------------------------------------------------------------
>
> From: Chuong Tran OS <chuong@amperemail.onmicrosoft.com>
> Sent: Thursday, August 22, 2024 3:22 PM
> To: Nhi Pham OS <nhi@os.amperecomputing.com>; devel@edk2.groups.io <devel@edk2.groups.io>
> Cc: quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebecca@os.amperecomputing.com>
> Subject: Re: [PATCH 0/2] Ampere: Add BMC Configuration Screen
>
> Reviewed-by: Chuong Tran <chuong@os.amperecomputing.com>
>
> Thanks,
> Chuong
>
> On 8/14/2024 10:18 AM, Nhi Pham wrote:
>> This implements BMC Configuration Screen and supports on Ampere Mt. Jade platform.
>>
>> Nhi Pham (2):
>> AmpereSiliconPkg: Implement BMC Configuration screen
>> JadePkg: Add BmcConfigDxe
>>
>> Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 8 +-
>> Platform/Ampere/JadePkg/Jade.dsc | 1 +
>> Platform/Ampere/JadePkg/Jade.fdf | 1 +
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.inf | 44 +++
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.h | 35 +++
>> Silicon/Ampere/AmpereSiliconPkg/Include/Guid/BmcConfigHii.h | 19 ++
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigVfr.vfr | 42 +++
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.c | 326 ++++++++++++++++++++
>> Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.uni | 18 ++
>> 9 files changed, 493 insertions(+), 1 deletion(-)
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.inf
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.h
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Include/Guid/BmcConfigHii.h
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigVfr.vfr
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.c
>> create mode 100644 Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe.uni
>>
>> --
>> 2.25.1
>>
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120460): https://edk2.groups.io/g/devel/message/120460
Mute This Topic: https://groups.io/mt/107889120/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7661 bytes --]