From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2D5AD740048 for ; Thu, 9 Nov 2023 10:12:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=n/Y2u6qdxwwlIPkqr5eulLdZq0EqDsspN+pHBLjF6ag=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699524748; v=1; b=wuMSSGAfjq+SJXKJXjxkd93GBPYAaKEDp6dhqUMPmm9NG2LjyNtlxNbxsJOvMEbmLdIQ7udO UmN+NN9hHEVoNkh+iV59vAOCkgvIROaN6bBWZzzLmbZjbaZ+fbSPbPuATAHz+tlZ8Rd0Q+1oF+w jgdMTMokVAZiRu8V/1JtGVUI= X-Received: by 127.0.0.2 with SMTP id uhmFYY7687511xFwjVW7hYwR; Thu, 09 Nov 2023 02:12:28 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web11.118373.1699524748292329684 for ; Thu, 09 Nov 2023 02:12:28 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="8605138" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="8605138" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 02:12:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="829261125" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="829261125" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 02:12:27 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 02:12:26 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 02:12:26 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 02:12:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GrXQbZIMAe+wLz95w05TsRU5bfuKU3R+mHx8XxCez5vQP56qy4UbwSnSS35+sMxWLUY0jhTbsOTvP3baIcgi9o2N3g8BCHkyXG29c/nBaEUojPak2toi2SjCv/SF559tlrHn3D+Fef7q5ZxCXORodq2NIkF70YShFaSdHvSDnFWtrZxHbudGEvw3R9ti0FuV5+Tr0HbFWmPrKTHU0D24pzIx55c3X1TgBVablV5pKQWnPckoYRy7KL1fquk/G6x5jPdFYHlp63IV6pLI9sPJOXdAHyfT9kghoK/sNpDheaW7Mv29x45guQLrCYFo/2+3mJYpQsOM9hAW6WIlwZJ8/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wRCtpFmJmxD12JHrM4Ix2Dj1CKvqxlKSfiay9vI1uww=; b=E1DdeRw2cpInoz0wNlr4ShSOEiVjD93RQ1nfRTZ0aDOm6keXc/2+aS3uYO7yNw4LEE+lYcr+dTIxOe4yOKU8a721odO79kCqxlY2jOkpbZFUn+1+CXlhHROaIrFjvJl3g6uTkMyxLXnzHfTo6Nih28RSMBczjwU1NxAFyO1ijA8eL5sgV8du0bjbF+zpp70KdEvjQU6EcHtP6k9oY9UG5PAomMXC35mGYvNR3Fc5fNeyErmRBZatLBEH4shVIwY5VsDVPE6xa21//mCP2IWXaRVscqMVQiTqjsPNaZIEQMQqTzjA+FbuoSuSKT5pv22NLMEwmmeJq7PEiGzsS63Z8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from IA0PR11MB7935.namprd11.prod.outlook.com (2603:10b6:208:40e::18) by SN7PR11MB8284.namprd11.prod.outlook.com (2603:10b6:806:268::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Thu, 9 Nov 2023 10:12:24 +0000 X-Received: from IA0PR11MB7935.namprd11.prod.outlook.com ([fe80::3c38:e0e0:d186:3a5]) by IA0PR11MB7935.namprd11.prod.outlook.com ([fe80::3c38:e0e0:d186:3a5%6]) with mapi id 15.20.6954.029; Thu, 9 Nov 2023 10:12:24 +0000 From: "Chen, Gang C" To: "Guo, Gua" , "Hsu, JasonX" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Chiu, Chasel" , "Duggapu, Chinni B" , "Kuo, Ted" , "S, Ashraf Ali" , "Mohapatra, Susovan" , "Lu, James" Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Add variable initialization Thread-Topic: [PATCH] IntelFsp2WrapperPkg: Add variable initialization Thread-Index: AQHaEvOuZOH3AtOMrkubkWkllPxQM7BxwxuAgAABOwA= Date: Thu, 9 Nov 2023 10:12:24 +0000 Message-ID: References: <45e974f7a6fdb497e243b8c61ea50b60e63bb501.1699523871.git.jasonx.hsu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB7935:EE_|SN7PR11MB8284:EE_ x-ms-office365-filtering-correlation-id: 3b38868e-6eca-4870-40dd-08dbe10c5e5b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: uVHzcbQNro+0bbvdv/fGdkwP0x5+mBziE/VlwniBD5gvT9bAV4NketFoV8Lj+LlaDwXRWg1ymFoYQgsSsVEP8BnpOUdAnvR0tQ+SjTz/eN/RHEFOvcFPJ9Igd6jQFOpQipGG+UaVDn9ePxRijG3v5hjECdxD3hdfJ5wOLBdaQxtXSQ19o/Ol+Ro1evATES673cv61DU3CrpJdSbhdVIzyAdoQMgSrzsC+ZQMw+c0XdRwX87aFLum+T+iDCXlkDTIT/Wr2HBAQjyNfuFp4ovQjWJVvqHgBhbAfT+Je0h+nyzaEkntZHBOLU8BY8iwWY4b/RkHJAwrJKWBjuaD97x+QuRtYnHofgl+33Py0IAu58fnsTJ4sKmtHZapi31SxqqPRgVwA77RZeJPkQgZ2G53Fq/fBIrL1Edi0IeTQ/mys8X0bTXqBI4CWjXnFsJpQOE43HZGlqnpujSS/nBa3K8wcmHsMcO8onEgTmoEzAYX2dh5SfMvhBb69VBlPcCJeSNNkYe4+UEfZnyUEL67dOhSYIGbk2V+wXlSVWvhL7kW2vFxXUdyOw6K9r0IjExueZNxmHjZ0rSTo13+1n4dGQRMeXEA25CXW2le6Gm8uBk+V/o= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+/1abPRrbCQL3ZKhRjvXdJYiQZpuwaiVlozIYFblHwou5Wyoh/nsOgaD49gd?= =?us-ascii?Q?8+hNmzKHAJYMMfzW8S/hZvIvNdqpw0Ho/PzxbiQ5Kh7c//p2nYk5YuBnFdU+?= =?us-ascii?Q?zzEq9WRQrX4hiNPqUGUzA+OIWn66E7rRK1rPx8q+STwZuRUWLfCK7IzvrrbQ?= =?us-ascii?Q?DlXuGQY9ChtW/6h3NLQ31yo01/6a9DqrpHTJW38KOTWEy9JK1C79eEPWxGWB?= =?us-ascii?Q?tLMeOY51ouzLFkMvEkHwfIjK6DE+zz2jDb1g2ksfFIpNaWBf/ZqWNbolFwHo?= =?us-ascii?Q?GL9ed9PAsAxxCIZBtPKUr9ESMoDAkG/OihkZengboccq4IIrvZclntjhdEfM?= =?us-ascii?Q?Dx+Efid3rCfQq9WAXBKArrTw8ebYasNogha8/lGfY182aScl77MGkxSLI8z+?= =?us-ascii?Q?RqDGXWkhnkf7nXuP8kkQvyLyRylVo1y/NaQ7KgSlLp4gt7uIecBMW2alp/LT?= =?us-ascii?Q?KIdsdZ14uFmjy+Agp/MSdET+kKl8mbv1Gk2DOW6w09OckyVm2l9EPQIb8y29?= =?us-ascii?Q?991bHMvDownec0KvgzSqJk5aJEb/Q8V1opjvjp36qdDighMuuhzDQQT5YYe2?= =?us-ascii?Q?8Sf/kHWibKuONd7dwQjKlX66w15Kj0XNkYKnohX9nk2pdL24lUIMgavfR1Ml?= =?us-ascii?Q?e5mkAwtODC2Zlw+yN4GpcZV+PRSXg3KT7qa+6sKsBk8+DfTfBbrxFdiSRCTm?= =?us-ascii?Q?0Adrx5P/Wf9Yib6wDYqCziRftZY8QpxmKZSdA8IgjH2WKjNZQlAM+VW2LhV0?= =?us-ascii?Q?cxe4Gb//ccboIKNcNSXqO7edAqT5mts0YYh3yfOpNIZi28fiAjtaJvtam4vm?= =?us-ascii?Q?QBpN8naLwvoOY+nTUygkeyz8BWCjY2slmxoiYWZlUM5+O2+AnCDQxR1sb1vY?= =?us-ascii?Q?oLTMbw8tzGwXN0BBLkBuvmlnLiGpIcoR/D3VOH3clXqlq5jV91KWc0e2LqKx?= =?us-ascii?Q?2SfqElwUBNJekdtTO64NzYu06pgDn5WlZaGy6lzXlek5waHP4loj4yE0cJwz?= =?us-ascii?Q?P1xM7+hmVNSHnkNp7kp+VVobSUcAfaM/ReojxY/cqT5mMSkrswTHSM+GuoaB?= =?us-ascii?Q?sYuOqZ7GIyNSND4ng46T3ztb7QHhjpcsLDyoVlWkcPJOmUCdSm/LFL5WrXnY?= =?us-ascii?Q?R6FHkhfK/d6sIq5EIc+mu8Kj6SYZ9qEaHJt7BnW7oNHppW7CjCU+h88JVboK?= =?us-ascii?Q?ipTGSf4Bw49zp8rl5aEwB1ff0Pqd36plKN72D+my/qhiVmmCJX4SZLiVIOBR?= =?us-ascii?Q?4ht0rjQZb02A35tGX2rIixyYibIjf4uECY97hhBW8bvSneU+wn2iGQ6hgHNu?= =?us-ascii?Q?IL8u4pLZ7oaH9He7dtb2/68vtVfI/I1gXSrQO/6E5bORisocjbOBVbkyTuXM?= =?us-ascii?Q?N9duW42RYdlIIGeVFe45bA2qs662xjywUQEWd4NnY0ZpuXG31x+TnEilBHYy?= =?us-ascii?Q?b6Hlt7CPQCLY4BmA388RHZMaxjcA1cSeXWobk1c0zuac+TR8bZa6ix59t9ey?= =?us-ascii?Q?hHmncYuxLU1FnhHwHPnIpBEH2YMSNxh7aVqPEDitD8CZVhqDU+u4E1G+Xua7?= =?us-ascii?Q?lYQOejHfEFfiKQq+T7q2X9qIReoMUUDgmYK+fhNy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB7935.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b38868e-6eca-4870-40dd-08dbe10c5e5b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 10:12:24.1551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TuK369JJcipsAe8b9DHLjTjlQGFGvNjpPCWMuFNKj5uXedm4LtbzsiTbGNDYh/M7C5xpGv81dgdUZoTErGhIxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8284 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gang.c.chen@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: E6UpEFR0TlwcYK1Pfony2AFix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wuMSSGAf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Chen Gang C BR Gang -----Original Message----- From: Guo, Gua =20 Sent: Thursday, November 9, 2023 6:07 PM To: Hsu, JasonX ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Kuo, Te= d ; S, Ashraf Ali ; Mohapatra, S= usovan ; Lu, James Subject: RE: [PATCH] IntelFsp2WrapperPkg: Add variable initialization Reviewed-by: Gua Guo -----Original Message----- From: Hsu, JasonX =20 Sent: Thursday, November 9, 2023 6:01 PM To: devel@edk2.groups.io Cc: Hsu, JasonX ; Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B <= chinni.b.duggapu@intel.com>; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susovan ; L= u, James ; Guo, Gua Subject: [PATCH] IntelFsp2WrapperPkg: Add variable initialization From: "JasonX.Hsu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4595 Fix build error when remove "-Wno-sometimes-uninitialized" option, Add vari= able "FspMultiPhaseApiOffset" initialization. Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Cc: Chen Gang C Cc: Duggapu Chinni B Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra Cc: James Lu Cc: Gua Guo Signed-off-by: Jason Hsu --- .../PeiFspWrapperMultiPhaseProcessLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/Pei= FspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMu= ltiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 834dca07a9..224c24881d 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrap= perMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspW +++ rapperMultiPhaseProcessLib.c @@ -80,6 +80,7 @@ CallFspMultiPhaseEntry ( BOOLEAN IsVariableServiceRequest; FSP_MULTI_PHASE_PARA= MS *FspMultiPhaseParamsPtr; + FspMultiPhaseApiOffset =3D 0; FspMultiP= haseParamsPtr =3D (FSP_MULTI_PHASE_PARAMS *)FspMultiPhaseParams; IsVari= ableServiceRequest =3D FALSE; if ((FspMultiPhaseParamsPtr->MultiPhaseActi= on =3D=3D EnumMultiPhaseGetVariableRequestInfo) ||--=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110964): https://edk2.groups.io/g/devel/message/110964 Mute This Topic: https://groups.io/mt/102482693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-