From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CEBFEAC0DF3 for ; Tue, 26 Mar 2024 09:09:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LpCR2P22a3yh2XfOv24EVKCe0kwZE9pPx73c89FUgeg=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711444171; v=1; b=NyGC4kY7QT4B1GMq1f1hMJRIvYpTaVrCD73SeLV27Yrax0LnUYPZOOURDl6vU05al09+O0vi Lbwtjlxhvc/JjxwpGk0qiCLS52Ru0aYcwHZp9S/YhukqzjM35cr7V4/1sbiAqu2bSDh32JDEWwb etUPpK60KBlCcykOso4O3QMsxzoc2JY1O38bDevGBNzLR51+hbNt4Zd1+cQH8zxnhPdtRzm8Mhu iQMcJC7mF2EPNGUcL+2+QRy+kbcoEk3SZGWmXaRxoA5ZncRLmmAwAl7FdymqHFlSL9p2tblpTUB lpejMBZtYw3NpHJnm0T3ZGAVQIe+SsuXk2cjNuxXFbOSw== X-Received: by 127.0.0.2 with SMTP id UfiMYY7687511xUAQhwgQW84; Tue, 26 Mar 2024 02:09:31 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web11.4261.1711444170663957196 for ; Tue, 26 Mar 2024 02:09:30 -0700 X-CSE-ConnectionGUID: vLaunvonQvmPCNxsu83i5Q== X-CSE-MsgGUID: T4U5qDfKR9Op0vu3tVkc3w== X-IronPort-AV: E=McAfee;i="6600,9927,11024"; a="31917424" X-IronPort-AV: E=Sophos;i="6.07,155,1708416000"; d="scan'208";a="31917424" X-Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 02:09:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,155,1708416000"; d="scan'208";a="20587010" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Mar 2024 02:09:04 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 26 Mar 2024 02:09:03 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 26 Mar 2024 02:09:03 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 26 Mar 2024 02:09:03 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 26 Mar 2024 02:09:02 -0700 X-Received: from IA0PR11MB8355.namprd11.prod.outlook.com (2603:10b6:208:480::14) by SJ0PR11MB5136.namprd11.prod.outlook.com (2603:10b6:a03:2d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Tue, 26 Mar 2024 09:09:01 +0000 X-Received: from IA0PR11MB8355.namprd11.prod.outlook.com ([fe80::d2f:72a5:6a4f:d7a8]) by IA0PR11MB8355.namprd11.prod.outlook.com ([fe80::d2f:72a5:6a4f:d7a8%4]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 09:09:00 +0000 From: "sunceping" To: "kraxel@redhat.com" CC: "devel@edk2.groups.io" , "Aktas, Erdem" , "Yao, Jiewen" , "Xu, Min M" , "Reshetova, Elena" , "Sun, CepingX" Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Thread-Topic: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Thread-Index: AQHadFI2hTrvbrZBC0u8PfZjHflJorEz8V0AgAFlYtCAAaUlgIAJRAbQgAAzcQCAAXE1oIAASHCAgAE0nYCAACYJgIAGSizA Date: Tue, 26 Mar 2024 09:08:59 +0000 Message-ID: References: <20240312235146.3777997-1-cepingx.sun@intel.com> <4t224udqjvt4kfg45skznhrj6n2ftez3eumgjerblbhl3iwv4c@zbvo45wwqksj> In-Reply-To: <4t224udqjvt4kfg45skznhrj6n2ftez3eumgjerblbhl3iwv4c@zbvo45wwqksj> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB8355:EE_|SJ0PR11MB5136:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 4fu9ngT1/t1mS8zyVM09aHE2ad/B/Vf21TMJoO73B036IZmK0XR04awuvtntHOP6O1N2UuO2UfpautaJbD1d6MTu5Zsg7xwQYTOlOj5aLRisf6S3doT1I8XlHjPI2BUoVQj5OQAA6y8qenzi7Yz9iQ6MDaIFnwgmLR0rw0PlAFu0bo4Dmlk0nv6b6FpKljw4e39k5OPYsl1JdJ3yTp0EHlZi4TZu56eDFa7lN6gweUVAagc6G64RZVIF5UV+604WyZRMLNmQBYUL5aZZIgAs2xTdoo6g+56qwiiDe6hNAqBicdpEm6AFrJpMI4QApxPVl0AKgJG1dE1P1qswWr4fT27Wf+KONg7IkqlmTtHkY1v3m8Pa0iffDol6vaKxQWX0UMynzODCjMbB257cgoeoSRi9H3RE9kJCgF3EbXOJjHbsFEw7bfog9L/oByVBIM79rnWCMRrKps42Mz8jEaqmkNgfdM9UT17KWEi++kD2H48QMoi4emqfFjfsgnJOA3FB1QJalFT84Rmg2RLPD5137Yd3YJ1o7nWiPubYpX3IYxkYz97WTTKc12jXm/QlDusBPJianCHTTqiett9ODQC3SV94hCLxCfPsJuuFWTB5pMM6lNGQkTvUfpFTHLtofpUz6c29gV6P07yJxLZ8wbfokFCR4vv4J7fW/orOMci0xtE= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Tr2aE93bgb0rX2C2zWXDAkwbHN7Q3poHJkiP/hf3xCqDB6ahtgiug67M9Eqh?= =?us-ascii?Q?PegYgZ3HTg2Qe57YRApj+en3UrT2YVYm9u/SKm72TjEbYiYMI+Dln3MqLuYH?= =?us-ascii?Q?xH8jnwu3FvYeWUIjfRIkGnNLwguxX9XH+V/LefLyyyoooK+Hz8jadl3aKaXX?= =?us-ascii?Q?+epZ/XUWJVoj7J8jYsAByjhJ9NcACx+IQVaEsj7SxXYk/19U2LtloStggY7a?= =?us-ascii?Q?aD3O5voKZ+t2idxdteAxTnwH+RBLp+LbjSfAhgZeum0SehvpJ5WZEk+4X/Bw?= =?us-ascii?Q?bdjBcrMfiDg8nQIq5cmtOfHIECoL5wjM6lqVihJaMG2dpGFCml+sSlglePFf?= =?us-ascii?Q?SfhrpTWvI8ru4Ok0gZXELMZV638Uf8KECo0vtyyZ3Tn9E03JGLN3Zj60VZVW?= =?us-ascii?Q?uRceyyoZcd6nVxSG6bcVJE5Z2XqleYHlRvcH2vIRMnjJ8mhSGkFAEbC7pipl?= =?us-ascii?Q?P8hO5Lpn5VcQVKE/jMi2lNMgAJIh0yPft6Mr+KQTngYU5x+55ZQsGRJcZFzO?= =?us-ascii?Q?woNIfb1zUaZLg00trFsVGZ0YoO5pBPkJLHbbhAvD3JM31PEKni8e6nZg2zZW?= =?us-ascii?Q?t3dffbsCtsFjRJ1VZ6r+RvaXRUO8bAq58wPaRSlcfwZRSyJ33nrNiKcS8Efw?= =?us-ascii?Q?H+num98x3W8JZEuBBxoS8VhcxkQS187JL/yNIJBV9up18P5tlZIO7b2Mux9+?= =?us-ascii?Q?3sPm2/MoqJwU/BfnVl5B9L8H8TrvurJllyfJ5LuPYuNDxPY4CJVNxLvJJOa7?= =?us-ascii?Q?TO30Nb9Eb2JoEHeYHBOYp1RsJlXFMjuY9a7owuWvhLFdURkhqM3Q+Kob/uPe?= =?us-ascii?Q?XDDmVihqmcTryDl6KeYjp0ZfVfVLJSnfOkGooiVXqDqEUm85qzgGud9WyNvd?= =?us-ascii?Q?WfDeRrdLdh++0kOHDF9nzafuGJVa4+8tKxJ9FNLwltjwYxdyMf9KEP3+b6XH?= =?us-ascii?Q?JxKSLREBnaMX3LKJfnZU8SYosFtEk6cjZ5MvvX6r15P5n0u7UlOdX7HtTrcI?= =?us-ascii?Q?gg+ZbIfhgGTYxP4G9jXV0BTFixhybiBaOVje26JLoTc3iC+S3mGHeP3unwyM?= =?us-ascii?Q?d2Cov4aj58p7IyLybPZkBLb0MfTPcrq1rji1CMHAHkhDEtPrH8+gggXajnuv?= =?us-ascii?Q?9rqUfxMbhJXKCY8yuoWu0pSSYbLX4LBnT80MVQnUriNAoBmO+NTuY+TSpxIu?= =?us-ascii?Q?c3W3I/ngnCSbbV0/lXECPbaK5lUadpYm9Gga38Zm7DqnBb+5AWDcp1fo+yDA?= =?us-ascii?Q?rGp6L0sHFmXXwCaQWphZ6/Wb+yRr2MfLQHE7TQwY+IbuXbQ8va4NPKVO0Lg/?= =?us-ascii?Q?RMSG75n3LcwoNYrnbS42LtIf5QLzrlppYx9hZlYX0ICytc30xqf14w0FfB4P?= =?us-ascii?Q?zFKsRV4Y/ckeQvcBxGN7zPEayu5DtomPXVDxxKc6VHT47Vh+eE0i2Ioh2y4F?= =?us-ascii?Q?El1GP5mBQaGGU7jOyBiNRJIkHenKwkqJpWDDkrVxGDNlRjz4c4dqWkPijNDg?= =?us-ascii?Q?+WeDQJWvISnIkmKInuM9A8FDWIC4nFd6DlvqGL91/Np2QN6pAy/kBgw7o2VT?= =?us-ascii?Q?XjAQCXBGRq9KDuVzADC00Tbunbx8i/MhatZczcTj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB8355.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b78c91b2-6210-437c-3f0e-08dc4d745fde X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 09:08:59.9477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L8v37VVmEO0DaKba00pT4Y+4pvbMEK5BewEf0h+9oOZsbPYveE1pbCE2j1BbDk+Bs+NDFA2IBFGDx0bupn2DKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5136 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 26 Mar 2024 02:09:30 -0700 Reply-To: devel@edk2.groups.io,cepingx.sun@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LC0jBgEAEokLHW1iqwphplHxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=NyGC4kY7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Friday, March 22, 2024 5:06 PM Gerd Hoffmann wrote: >=20 > > > But then you have to find and update all callsites (or at least the > > > ones where we care about measurement). > > In your solution, if we cache all items that need to be measured, we > > would have to add a new API (example: QemuFwCfgGetDataFromCache ()) to > get the data from cache. >=20 > No, we only need to update QemuFwCfgSelectItem + QemuFwCfgReadBytes to > support reading from the cache. Do you mean the existing API (QemuFwCfgSelectItem + QemuFwCfgReadBytes) nee= d to be changed to support reading from the cache? If that is the case, there are some concerns as below: 1: One or more new parameters (of QemuFwCfgReadBytes()) need to be added = to search=20 the item in cache, which is equivalent to adding a new API. 2: The current QemuFwCfgReadBytes can read in chunks from qemu (example et= c/e820)=20 If we call QemuFwCfgReadBytes to get data from cache , we also need to supp= ort reading in chunks. Then we have to add more parameters ( to set offset). This will make the AP= I more and more complicated. > QemuFwCfgGetDataFromCache() can be added as additional API, and callsites= have the option to either switch over, or continue to use the existing API= . Base above concerns, we think QemuFwCfgGetDataFromCache is must. Thanks Ceping -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117105): https://edk2.groups.io/g/devel/message/117105 Mute This Topic: https://groups.io/mt/104880546/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-