From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4164F941524 for ; Fri, 22 Mar 2024 08:29:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kNXdwGVeWJ94V1crk/gSGAs7vikqIrJ4QF+73lVUjRY=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711096186; v=1; b=c86UNB1jVAXW4ZLvl/N77sztT/fTOX5w8RTBWuGoB6n1JgIhWTGoC20EJjDXgLltl7dKqVQw 3wAMEcoupYG9rE6Gzt3SqdaxtwYl9QJ/d0OHeC0Nf/AJDe93xFEatd3sq4OY/mT+7cPSc5VUI/E 0+nGL+RWXRoq+kQrPYSQ1ERReWwIUC764xlWhEkA4Jhc1pY1VcDMjNzGMt7PnmazmGxV75ShVFw qhq+xeJSEG3hhhOHbAvbkSzwlwVvegmpO5Zyp0CqoDlti0SqeJSS//gNWewJWYzFwrhKIKjbncb Eax9J7//XqNR0NCQcRwngoePeDFdULsuBoKrB/+AtnjhQ== X-Received: by 127.0.0.2 with SMTP id QKh7YY7687511xXI5luzrAHA; Fri, 22 Mar 2024 01:29:46 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mx.groups.io with SMTP id smtpd.web11.8283.1711096186035665493 for ; Fri, 22 Mar 2024 01:29:46 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="9920978" X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="9920978" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 01:29:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,145,1708416000"; d="scan'208";a="19289049" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Mar 2024 01:29:31 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Mar 2024 01:29:31 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 22 Mar 2024 01:29:31 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Mar 2024 01:29:31 -0700 X-Received: from IA0PR11MB8355.namprd11.prod.outlook.com (2603:10b6:208:480::14) by PH0PR11MB4919.namprd11.prod.outlook.com (2603:10b6:510:34::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 08:29:28 +0000 X-Received: from IA0PR11MB8355.namprd11.prod.outlook.com ([fe80::d2f:72a5:6a4f:d7a8]) by IA0PR11MB8355.namprd11.prod.outlook.com ([fe80::d2f:72a5:6a4f:d7a8%3]) with mapi id 15.20.7409.010; Fri, 22 Mar 2024 08:29:28 +0000 From: "sunceping" To: "kraxel@redhat.com" , "devel@edk2.groups.io" CC: "Aktas, Erdem" , "Yao, Jiewen" , "Xu, Min M" , "Reshetova, Elena" , "Sun, CepingX" Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Thread-Topic: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait Thread-Index: AQHadFI2hTrvbrZBC0u8PfZjHflJorEz8V0AgAFlYtCAAaUlgIAJRAbQgAAzcQCAAXE1oIAASHCAgAE0nYA= Date: Fri, 22 Mar 2024 08:29:28 +0000 Message-ID: References: <20240312235146.3777997-1-cepingx.sun@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA0PR11MB8355:EE_|PH0PR11MB4919:EE_ x-ms-office365-filtering-correlation-id: a0f9bd08-77b5-4398-bac6-08dc4a4a30a0 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: NzODjBHfhHEH+cosXsvWSub8nvDUty4ix3EoTPzNMGW3GTtOK87+42XfC4U/9IGkc3clNrjTVOB23HsEoC+a9b0VQhbXaaEKGZJSS9VwDWPMDEfKVL2DCyJfMlBt8Esw1GYZJMXQjoQXqqSJuJyBPiRpPHweXi/SD0lIr9oCUPrgsuzmbntjquXsfw17pbdK9jWxa4JwO2KuHDDdd0CGwAAeKNVfTdT+aD2ys0K98SNngwxcosdH6hdMaGpkNjmYzct7yuQC1puY4SRvOvVcvsR16DzJFyAVHu1ekKi9rAgf/JfVruv0hom+91j0JG5gOfYvm/9RrNj8IqDG02/D0k3mdQVHBuwHq5s5h0jhiOc4+Swd28oUh4FIr9HGwdteMXgARsc7XJ8YFyo3WbV4ObebYF4LTM/j96dFr3W8Ctc1XhHmpexh5QgQBEGA4d+wOm/+UVKsnRGIl171kuaPFP5idFALBu1CDfXaHcRSxAFxE+AdbHTaL2uhV8o3JeuqIkxcrUG7zm1JBCJe7adpzWwIoTJYmlXjU8rzz2psCoXq7S3nSlofp/rGrMcOa/YffEUsJ/D9PMBQAUGqasD6rEqp3cTxf/WXcQ+R8baTzjbowKviJ3uoGNx76BBsOtibVVmsahCAwvy35q1ZaPk1b5Vw8bzu5aQegxXgVL4wSRw+wMH4puQbaBcdbHGOFZSkYOLLIxpPp+lGzja60iFm0ZU37ojOK177Ue8RZ306H+M= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?96wtil2BrxozcfL3Q2C9TGrysyH+w5SEuEQCBl4g7PEC7+42vjDBOq8DDVGD?= =?us-ascii?Q?/46d5SbF9AYpb5rN75rVwjHY2oQt/WW/nQ9Q/Kyk8RS6y5dhpxQ/Lba3JnTf?= =?us-ascii?Q?dVNt637cH8zDMgU/k3LgReeW0nXNGkazzG4FGOlPQC4CxH8t77poZW4N5klh?= =?us-ascii?Q?mHRAkrK6HlDX9hT3hLkfGhpK9xGtljAPWvbWdErpdVmv2shv803lmu3GLu7i?= =?us-ascii?Q?+zhE/4a/cbngxOkCnd93Ogds/GMI9GKHjOj897W9Q7KpSHCUzaadQISjXtSb?= =?us-ascii?Q?KMkNwE8KJvkA/x5202HNsWihXui2aHc1Ait4xdokB6Uu1u9K8NEZw0r2VIV/?= =?us-ascii?Q?0++VMnB/FlAsly3ZkYGdNS6RE3u+5fDCykU9JsDjlF+7RtIFPaCmlbsZRDwz?= =?us-ascii?Q?UfrWRM5E7LAdD1keU0yCfFGFcNE1pWwvntg6YHR4vgSyoyVy76rx3QdvHYc2?= =?us-ascii?Q?jlUb2REzM35vMkZcc6urBbBSmD5yVEMsv5R03i2TTbXTfgvynFwdi27kdexC?= =?us-ascii?Q?KveLjPsIw1FVfB5wAgi0Cktybkjm2ybQGAUhos9VNaTO8HpeZBirmkj0NWAY?= =?us-ascii?Q?uAPKnA9QBWErU24KaApetIfhy/QoIX3bJW1uPXgzCrXuexgr4sldoeVFGdfL?= =?us-ascii?Q?XBd9wrWpv9qAWiPq9sFrK9cQ7MX446JmiyRm6VFZV7zH/FSrTzAhAy45pS3t?= =?us-ascii?Q?GefbsH9YEfzfsoFM94ZToAdthdl8rP8c7eGDGo2zNN5pKV6rxvOLLX5MBZOZ?= =?us-ascii?Q?GqFo6c9ZQbASCYN1F2mKpIbmokfF5YtauBAAqKm8InB5dimPR9MQBEDNCZfk?= =?us-ascii?Q?NX1Q+pMLTC0tjFtNBTcXcloLAlJjdHiIStF2Yt5ggsrWqp9vi+GckFpL01c9?= =?us-ascii?Q?IcEtmMO80E3dqJa6aCngJtb8WKYWjybM8s/THVMSAQ9ZZ1+dXhVGY32Ym8Us?= =?us-ascii?Q?9QpxoTLeDYkNAPbLPHQrFTKAAwy4ayWgwQJSKNwt/L2hPUbLH2CEchraZsK5?= =?us-ascii?Q?fPB1Qod2zf2HkeWJMsjD94odb9W7hHJ5Z1da02FKJLGSI12e8HH9+oBKZjY4?= =?us-ascii?Q?kdy88S8snFSxddk1XbitU23SEAsp7elCUwmZCsAj5ZZ6tl1FT2wGpr4Qsppw?= =?us-ascii?Q?awILAPgI79hebWKW+ppCS1VT0BX6opYBAJ70MVsoUana/gWEZ5aD1jjCbt5r?= =?us-ascii?Q?/9s4lijN9H3xjiwDOz/G+m+gJBbcY7j9tqJ+HUmt2LMjtzWaUJoWgyWkDItD?= =?us-ascii?Q?58XAgOYJl105hMRciCIeS7bmsyKQcDXgPD8z8FsXmT8sNinT5KwJK7v1mK2F?= =?us-ascii?Q?ZBdcsilq2kK8kYwqZ7YiOC08CIwK8PUq7BXpUbTVbC4YTR2ZeB//sElEu81m?= =?us-ascii?Q?VlLdRiedixSeh9w8cfgzNPLvagv3p1T52b2fugJe9vPCoAk37bMzARoBu3bK?= =?us-ascii?Q?WcYIm9/KdHEcsr5/QpFL2E16vprJl94znO5RRcWWzz8jnB7Kag0plVVoCk0I?= =?us-ascii?Q?OWip2V+1DGSdaNP9rymNsGhWp2/Vvje97UcEySqUKEYz4ip+KRAbIcAyQU0l?= =?us-ascii?Q?emcy1Io7OO0trfuVZNvEoti3aop/URAjn/wdd2f2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA0PR11MB8355.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0f9bd08-77b5-4398-bac6-08dc4a4a30a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 08:29:28.2849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h3vz5+GOytw2MKtyKK5ii8F/WLyk06AACB6dQ7Bp8FWth3k0PZXwk5hGJXFJFu/yeoQTon/o0564M1JeZRZWdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4919 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 22 Mar 2024 01:29:46 -0700 Reply-To: devel@edk2.groups.io,cepingx.sun@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Kls6WL9ApXCHEjCMFvFnFuyUx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=c86UNB1j; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thursday, March 21, 2024 8:25 PM Gerd Hoffmann wrote: > Well, just try to read them. If present they can just be measured. > If not present we can either skip them, or measure with an empty data=20 > field to indicate it is not present. My understanding : If the fw_cfg is present, it must be measured and consumed later. Is this correct? > > > > We propose below solution : > > > > > > > > Add a new API in QemuFwCfgLib, > > > > RETURN_STATUS QemuFwCfgGetData(fw_cfg_name, *size, *value, > > > FW_CFG_GET_DATA_FLAG flag). > > > > > > I'd suggest to *not* touch the existing interfaces for reading entrie= s. > > > Instead change the existing functions to first check the cache, in=20 > > > case there is no cache entry go read from fw_cfg. > > Actually we don't touch the existing interface for reading entries. > > The API is newly added. >=20 > But then you have to find and update all callsites (or at least the=20 > ones where we care about measurement). In your solution, if we cache all items that need to be measured, we would have to add a new API (example: QemuFwCfgGetDataFromCache ()) to = get the data from cache. Then we also have to find and update all callsites. Thanks Ceping -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117028): https://edk2.groups.io/g/devel/message/117028 Mute This Topic: https://groups.io/mt/104880546/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-