* [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib @ 2023-04-27 6:58 JoeX Lu 2023-04-27 7:50 ` Yao, Jiewen 0 siblings, 1 reply; 6+ messages in thread From: JoeX Lu @ 2023-04-27 6:58 UTC (permalink / raw) To: devel; +Cc: JoeX Lu, Jiewen Yao, Jian J Wang CC: Jiewen Yao <jiewen.yao@intel.com> CC: Jian J Wang <jian.j.wang@intel.com> Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> --- .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c index eeb424b6c3..bf7a5fc65c 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.c @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( EFI_GUID *Identifier ) { - HASH_INTERFACE_HOB LocalHashInterfaceHob; + HASH_INTERFACE_HOB *LocalHashInterfaceHob; + HASH_INTERFACE_HOB *HobBuffer; - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); - return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); + HobBuffer = NULL; + LocalHashInterfaceHob = AllocateZeroPool (sizeof (HASH_INTERFACE_HOB)); + if (LocalHashInterfaceHob == NULL) { + return NULL; + } + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); + if (LocalHashInterfaceHob != NULL) { + FreePool (LocalHashInterfaceHob); + } + return HobBuffer; } /** -- 2.31.1.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib 2023-04-27 6:58 [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib JoeX Lu @ 2023-04-27 7:50 ` Yao, Jiewen 2023-04-27 7:58 ` JoeX Lu 0 siblings, 1 reply; 6+ messages in thread From: Yao, Jiewen @ 2023-04-27 7:50 UTC (permalink / raw) To: Lu, Pen-ChunX, devel@edk2.groups.io; +Cc: Wang, Jian J Hi I am not sure if I can understand the patch. Would you please clarify what the problem is in the original code? > -----Original Message----- > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > Sent: Thursday, April 27, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > Subject: [PATCH] Release build in GCC5 has warning message Wreturn-local- > addr in HashPeiLib > > CC: Jiewen Yao <jiewen.yao@intel.com> > CC: Jian J Wang <jian.j.wang@intel.com> > Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> > --- > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > index eeb424b6c3..bf7a5fc65c 100644 > --- > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > +++ > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > EFI_GUID *Identifier > ) > { > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *HobBuffer; > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > + HobBuffer = NULL; > + LocalHashInterfaceHob = AllocateZeroPool (sizeof > (HASH_INTERFACE_HOB)); > + if (LocalHashInterfaceHob == NULL) { > + return NULL; > + } > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > (LocalHashInterfaceHob)); > + if (LocalHashInterfaceHob != NULL) { > + FreePool (LocalHashInterfaceHob); > + } > + return HobBuffer; > } > > /** > -- > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib 2023-04-27 7:50 ` Yao, Jiewen @ 2023-04-27 7:58 ` JoeX Lu 2023-04-27 8:21 ` Yao, Jiewen 0 siblings, 1 reply; 6+ messages in thread From: JoeX Lu @ 2023-04-27 7:58 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Wang, Jian J Hi, It means the code might be possible return local variable address when we used the function. So I allocate a resource to local variable to avoid this. Best Regards, Joe Lu -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Thursday, April 27, 2023 3:51 PM To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io Cc: Wang, Jian J <jian.j.wang@intel.com> Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Hi I am not sure if I can understand the patch. Would you please clarify what the problem is in the original code? > -----Original Message----- > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > Sent: Thursday, April 27, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > Subject: [PATCH] Release build in GCC5 has warning message > Wreturn-local- addr in HashPeiLib > > CC: Jiewen Yao <jiewen.yao@intel.com> > CC: Jian J Wang <jian.j.wang@intel.com> > Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> > --- > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > index eeb424b6c3..bf7a5fc65c 100644 > --- > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > +++ > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > EFI_GUID *Identifier > ) > { > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; HASH_INTERFACE_HOB > + *HobBuffer; > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > + HobBuffer = NULL; > + LocalHashInterfaceHob = AllocateZeroPool (sizeof > (HASH_INTERFACE_HOB)); > + if (LocalHashInterfaceHob == NULL) { > + return NULL; > + } > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > (LocalHashInterfaceHob)); > + if (LocalHashInterfaceHob != NULL) { > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > } > > /** > -- > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib 2023-04-27 7:58 ` JoeX Lu @ 2023-04-27 8:21 ` Yao, Jiewen 2023-04-27 8:55 ` JoeX Lu 0 siblings, 1 reply; 6+ messages in thread From: Yao, Jiewen @ 2023-04-27 8:21 UTC (permalink / raw) To: Lu, Pen-ChunX, devel@edk2.groups.io; +Cc: Wang, Jian J Could you please show me how this function returns *local variable*? return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); I don't understand the analysis. > -----Original Message----- > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > Sent: Thursday, April 27, 2023 3:58 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib > > Hi, > It means the code might be possible return local variable address when we > used the function. > So I allocate a resource to local variable to avoid this. > > Best Regards, > Joe Lu > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, April 27, 2023 3:51 PM > To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib > > Hi > I am not sure if I can understand the patch. > > Would you please clarify what the problem is in the original code? > > > -----Original Message----- > > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > > Sent: Thursday, April 27, 2023 2:59 PM > > To: devel@edk2.groups.io > > Cc: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; Yao, Jiewen > > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > > Subject: [PATCH] Release build in GCC5 has warning message > > Wreturn-local- addr in HashPeiLib > > > > CC: Jiewen Yao <jiewen.yao@intel.com> > > CC: Jian J Wang <jian.j.wang@intel.com> > > Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> > > --- > > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > index eeb424b6c3..bf7a5fc65c 100644 > > --- > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > +++ > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > > EFI_GUID *Identifier > > ) > > { > > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > HASH_INTERFACE_HOB > > + *HobBuffer; > > > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > + HobBuffer = NULL; > > + LocalHashInterfaceHob = AllocateZeroPool (sizeof > > (HASH_INTERFACE_HOB)); > > + if (LocalHashInterfaceHob == NULL) { > > + return NULL; > > + } > > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > > + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob > > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > > (LocalHashInterfaceHob)); > > + if (LocalHashInterfaceHob != NULL) { > > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > > } > > > > /** > > -- > > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib 2023-04-27 8:21 ` Yao, Jiewen @ 2023-04-27 8:55 ` JoeX Lu 2023-04-27 9:10 ` Yao, Jiewen 0 siblings, 1 reply; 6+ messages in thread From: JoeX Lu @ 2023-04-27 8:55 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Wang, Jian J [-- Attachment #1: Type: text/plain, Size: 3846 bytes --] Theis patch just wants to remove the warning message in GCC5 release build just like attachment. -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Thursday, April 27, 2023 4:21 PM To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io Cc: Wang, Jian J <jian.j.wang@intel.com> Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Could you please show me how this function returns *local variable*? return BuildGuidDataHob (&mHashLibPeiRouterGuid, &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); I don't understand the analysis. > -----Original Message----- > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > Sent: Thursday, April 27, 2023 3:58 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message > Wreturn- local-addr in HashPeiLib > > Hi, > It means the code might be possible return local variable address > when we used the function. > So I allocate a resource to local variable to avoid this. > > Best Regards, > Joe Lu > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, April 27, 2023 3:51 PM > To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message > Wreturn- local-addr in HashPeiLib > > Hi > I am not sure if I can understand the patch. > > Would you please clarify what the problem is in the original code? > > > -----Original Message----- > > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > > Sent: Thursday, April 27, 2023 2:59 PM > > To: devel@edk2.groups.io > > Cc: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; Yao, Jiewen > > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > > Subject: [PATCH] Release build in GCC5 has warning message > > Wreturn-local- addr in HashPeiLib > > > > CC: Jiewen Yao <jiewen.yao@intel.com> > > CC: Jian J Wang <jian.j.wang@intel.com> > > Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> > > --- > > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > index eeb424b6c3..bf7a5fc65c 100644 > > --- > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > +++ > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > ei.c > > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > > EFI_GUID *Identifier > > ) > > { > > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > HASH_INTERFACE_HOB > > + *HobBuffer; > > > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > + HobBuffer = NULL; > > + LocalHashInterfaceHob = AllocateZeroPool (sizeof > > (HASH_INTERFACE_HOB)); > > + if (LocalHashInterfaceHob == NULL) { > > + return NULL; > > + } > > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > > + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob > > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > > (LocalHashInterfaceHob)); > > + if (LocalHashInterfaceHob != NULL) { > > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > > } > > > > /** > > -- > > 2.31.1.windows.1 [-- Attachment #2: Screenshot 2023-04-27 165409.png --] [-- Type: image/png, Size: 283378 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib 2023-04-27 8:55 ` JoeX Lu @ 2023-04-27 9:10 ` Yao, Jiewen 0 siblings, 0 replies; 6+ messages in thread From: Yao, Jiewen @ 2023-04-27 9:10 UTC (permalink / raw) To: Lu, Pen-ChunX, devel@edk2.groups.io; +Cc: Wang, Jian J This seems false alarm to me. Unless you can prove there is real issue, I don't think this is right patch. Nacked-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > Sent: Thursday, April 27, 2023 4:55 PM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib > > Theis patch just wants to remove the warning message in GCC5 release build > just like attachment. > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Thursday, April 27, 2023 4:21 PM > To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib > > Could you please show me how this function returns *local variable*? > > return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > > I don't understand the analysis. > > > > -----Original Message----- > > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > > Sent: Thursday, April 27, 2023 3:58 PM > > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.wang@intel.com> > > Subject: RE: [PATCH] Release build in GCC5 has warning message > > Wreturn- local-addr in HashPeiLib > > > > Hi, > > It means the code might be possible return local variable address > > when we used the function. > > So I allocate a resource to local variable to avoid this. > > > > Best Regards, > > Joe Lu > > > > -----Original Message----- > > From: Yao, Jiewen <jiewen.yao@intel.com> > > Sent: Thursday, April 27, 2023 3:51 PM > > To: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; devel@edk2.groups.io > > Cc: Wang, Jian J <jian.j.wang@intel.com> > > Subject: RE: [PATCH] Release build in GCC5 has warning message > > Wreturn- local-addr in HashPeiLib > > > > Hi > > I am not sure if I can understand the patch. > > > > Would you please clarify what the problem is in the original code? > > > > > -----Original Message----- > > > From: Lu, Pen-ChunX <pen-chunx.lu@intel.com> > > > Sent: Thursday, April 27, 2023 2:59 PM > > > To: devel@edk2.groups.io > > > Cc: Lu, Pen-ChunX <pen-chunx.lu@intel.com>; Yao, Jiewen > > > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com> > > > Subject: [PATCH] Release build in GCC5 has warning message > > > Wreturn-local- addr in HashPeiLib > > > > > > CC: Jiewen Yao <jiewen.yao@intel.com> > > > CC: Jian J Wang <jian.j.wang@intel.com> > > > Signed-off-by: JoeX Lu <pen-chunx.lu@intel.com> > > > --- > > > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > > > diff --git > > > > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > index eeb424b6c3..bf7a5fc65c 100644 > > > --- > > > > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > +++ > > > > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > > > EFI_GUID *Identifier > > > ) > > > { > > > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > > > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > > HASH_INTERFACE_HOB > > > + *HobBuffer; > > > > > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > > > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > > > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > > + HobBuffer = NULL; > > > + LocalHashInterfaceHob = AllocateZeroPool (sizeof > > > (HASH_INTERFACE_HOB)); > > > + if (LocalHashInterfaceHob == NULL) { > > > + return NULL; > > > + } > > > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > > > + HobBuffer = (HASH_INTERFACE_HOB*) BuildGuidDataHob > > > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > > > (LocalHashInterfaceHob)); > > > + if (LocalHashInterfaceHob != NULL) { > > > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > > > } > > > > > > /** > > > -- > > > 2.31.1.windows.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-27 9:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-04-27 6:58 [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib JoeX Lu 2023-04-27 7:50 ` Yao, Jiewen 2023-04-27 7:58 ` JoeX Lu 2023-04-27 8:21 ` Yao, Jiewen 2023-04-27 8:55 ` JoeX Lu 2023-04-27 9:10 ` Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox