From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.15084.1682582307907689590 for ; Thu, 27 Apr 2023 00:58:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=W2Cpj4ap; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: pen-chunx.lu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682582307; x=1714118307; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WrAxduxLwHZ4hemCvkdhMIAK7V0b/2toSsDjVkypib8=; b=W2Cpj4apqOuxShSsZGjTYujkbWPE5ffB2epoafqWw8TCQoZUL/8CKnF5 f3Os/B8X+iBDMcTQ8rxiZSw5PisDvEnyMM2nls4IWdRoFB5pM/tifT6El B6xCv3y/czdZ7xlbcwXvIi1PgdXe0xeF3Eyp8qnWARNo6Up0Kdjf835wx 1Fd1MAT+Af5J6EY9EyAzF39FRT8/dNN9F5nVxngba+R7b/82nGimyZogL yxVSSpYpm6tnYaG03BJIsTFGEDxrwxkW0qvtg7U6+NNCREVnGzp/WhiM3 SikDQt7oX5P3kaGQENhlpMidm6sSiMOPCfA6qvkqavr+wniwb1nRP+o/P w==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="326971698" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="326971698" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 00:58:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="1023979914" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="1023979914" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 27 Apr 2023 00:58:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 00:58:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 00:58:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 00:58:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAa09aWqYMVNObhnyFBjsWaMLaMkoSG46i1pfg17RrZBB/3kpXdpxQhjqwYHM/uWxkgfPOIZQKcuFfoXUTG3GpBIS3ZAXH8MxjFXdEaYRubpQqJZ7zBJ4plaab0W1K7kqyMRZqxud34uKL57qmIA9whfleo6+FizcUCHVp2IcvxM5kOL0DVn/zRXjfaV1U3O4ZcuPbdXWqGqDc13QpF58PR7w/nthKR8StToXATpg+O32cER/ZykbvQt27UHIz3tHjhfiQwE6XMubUfNQcm1uEAZGV8xlNYXvUxjxx1l4U+B114pw4Yfwn+lyGUsq0D/gtbI8DL0tfboJlLCmgEY4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ed26NUdj6sINesKIVVaLi8M7Hrb+XYqR9utbW21LAX8=; b=KzAVl2h9/TeVKQPWXUlbu5BYszkcgqdqZbzCoSoRysup/HzCVdkqeL4+EdyrmCqhCmi0BdQGe0GVjO86Q+zUrXyenWDRmmLlt5SkT9D/qk7So8fXKYD2eTHWvosZ2rf8CHuOhOmTnZEN6oDeBSYJTnwm2bVjkkJv+UK2XgcBk1ltRcKJIIf2/c/hCf2hkgyQs7N+hg2EJvIsXlIlD3Yd0W8jbF7bsd1CFkh3ieVoDObmTqXymCqkCKmAZbk1m10RelYIKS4JSSBCUJzRafnMQJcpPJZso4XfJ3G/5UZxdD56SSsCBacyoPiUEDT/lVJwFcKY4a1BBecF4UYBr1UwSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6073.namprd11.prod.outlook.com (2603:10b6:208:3d7::5) by DM4PR11MB6312.namprd11.prod.outlook.com (2603:10b6:8:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Thu, 27 Apr 2023 07:58:12 +0000 Received: from IA1PR11MB6073.namprd11.prod.outlook.com ([fe80::7c8b:3e5d:98a3:f55b]) by IA1PR11MB6073.namprd11.prod.outlook.com ([fe80::7c8b:3e5d:98a3:f55b%4]) with mapi id 15.20.6340.021; Thu, 27 Apr 2023 07:58:11 +0000 From: "JoeX Lu" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Topic: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Index: AQHZeNXMbvB/b3uowUO8Jhb7MIHt8q8+yEAAgAAAXzA= Date: Thu, 27 Apr 2023 07:58:11 +0000 Message-ID: References: <20230427065830.29735-1-pen-chunx.lu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6073:EE_|DM4PR11MB6312:EE_ x-ms-office365-filtering-correlation-id: c4a51aa1-579b-4af6-5899-08db46f52571 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qo8xKSKndwKrQNDZQhuzkxfztfFZ7wvBLuJvkRr3lbWZbmuaXPtfrGKT0BmH5kfxkhssKEKFQyn/WXQ4Z6w6GA1y+XGWd+dElx4/vZEcJqFEhj7M+juWQJ1hfUQ20gWPYiAjKTGP/efGnq9gPgnYcCzfTDtz85hLYArdLniaFjNwqh/KxGmm4W4ic6idmADloHWi01ELhI0fOgWmS5eoDK+TbcIFP7LMlTHYBEHmKqalEWqGwk/hSQyrqp9Tl6LAhNZHh9I5TF74n/yBwBOvktypi6HZKwVT2xDFrKkymJ6rnFgIpvXq68UWyDCh82vQj8LzDjBdaO9NVSx4KDQViWd/q8iTVtyOTmj1n90gRoAnsRykVygNT5nE6vxD9nZBNtf9zUvmgS+IIY7PWDKD7lG4z6fuCfGxtNuEEnQR4+Z1XU//sV8UArK4ehei1NN1uevSmTqXs/S8OcCUIv11oR3lwmYy1ak8boGkQ5Ay9QMCFZldyd1iN6H0fBZ+UTl4WHy3DwU12YeJVxw9FeSJImuKbtIbYiWNZUWH4YgNwLkcbFaaSTCc6uuiKPMkHKl/h4yJWyHOsOCPCJKdMofVWRJarfFwhhh+TMy8SkaTvJFRUFRpcINcZIsqbaCiGfRl76FhVT7LqNB+C7MatmZBgw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6073.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(396003)(39860400002)(451199021)(82960400001)(71200400001)(478600001)(83380400001)(7696005)(110136005)(186003)(38100700002)(66946007)(76116006)(66556008)(66476007)(316002)(4326008)(66446008)(64756008)(41300700001)(6506007)(26005)(9686003)(107886003)(86362001)(53546011)(8676002)(8936002)(33656002)(122000001)(38070700005)(55016003)(2906002)(5660300002)(52536014)(15650500001)(42972004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cz6gOJPT17E0LbR478L0eoINSBDpEro6SH+trujkawpsIISK3s3O0kKr0vV+?= =?us-ascii?Q?pYbs5Exd4/JzqOyEC97rXeyw3wAWW+0HR+01suvgGudPZ+R+SKMcXklctkiF?= =?us-ascii?Q?i1gK0kaL9fOKAQ6rR+HkqHnQ2ghtjfg3xxTeIr94kJ9hrrSSGWUp6eGl2PT/?= =?us-ascii?Q?K2JNu0z286dhOTHItPpCDc/9PZLKOFgpVCL3LgLEDKyvFM1W4d2Qay4UC/KU?= =?us-ascii?Q?kcMImw88hQ26RgLawOFcTBJiJ2GnHUGI+6ZTm0DT0dn9tdRoYl4L39kLz5K/?= =?us-ascii?Q?2dQprz8AOoLYApjdlqQtG4Urn75VVq1P9/qyf+GhFoUyrSjTHEnEN2KWosoq?= =?us-ascii?Q?RCFd30JZiNfN43p7jmMXXuY6PkY7M4EaPu3L+j2TcrgtUry5ira6yQmeUe9v?= =?us-ascii?Q?qsSVyMODEySwuspx6976+Ynbg++f4Cbc85HjthyWxn9UzwTnmR+xjqqJfyp8?= =?us-ascii?Q?V/0znrgeqXhIey5pSWQQKuzQRkz++hbMsV5JKwyH92esykvN3lYJAKS4BBgM?= =?us-ascii?Q?SUqF7nDZDAPQV/qlrsCvi/aoFLZ1Eg4g/yDTg6lcwfyAaf7i1/EbI8ISSO71?= =?us-ascii?Q?AuBR7NmIchiaYSb88Xu+zReKScZ2d5TiL9PkRJj4O/mF0BtwXv4cgy535+nn?= =?us-ascii?Q?TguxdRrO/J/OO1WTR+UGyAn9wXZHK6AlEnaqVlxg+pIthrLdUYA7KIjeuXlt?= =?us-ascii?Q?26yiIvorMTmgEoA0I5aw0iPDhUVizBYp/ACgDbqa2ndXjR4tkUSESkb8tgTj?= =?us-ascii?Q?1gePv3PoTo9ZJfOXMN/+MxSFCSupDmyknVKPmBBSbnbze3FUDJ1B7nfCAP0c?= =?us-ascii?Q?sXOqpfiFQataLj+FuMy4Hrqy1TIE0rNYOkMlFKe6Sql3I/zsFb776tIN/hq0?= =?us-ascii?Q?v09U3B5eoDHBCz5JCNQWJPsUAGa1Bmv1Wpcfz8db+UgH1yy7yA9WLfnRcI0U?= =?us-ascii?Q?/Ej0UHJS83jdPa1SB+qHU73XQu82qpl4/qRPlgkVsvoI8FNFWHmnO0ZX3Y0z?= =?us-ascii?Q?UGBsXNeUNPhVS45wMy0GnG2feTXbACgp8zaiI4/iPNxhhxcqUxbizvkZJKAD?= =?us-ascii?Q?D/Kwo8Q6X4Z208Jwoi1jpIVtE7/FLwV23JULQdSYKCIKdpVUVvOJC1VKHPAy?= =?us-ascii?Q?YCdIBVlJgrQV96UQYpefiXpI8o0vbFHEaP2iP/DSwsnevjnyR7ArOW5rAE5E?= =?us-ascii?Q?zrqy6uD7YPKyxl+2amiswFpsFhLxxhe0JQMvdJHAaDi3s925M8Uj3D7NoivL?= =?us-ascii?Q?kL7osj1IHTuRC8Uvg9d6vrq33YE+vGN9AByA+2dlfu95X0m9Hd2vl6sWMEiP?= =?us-ascii?Q?sT8b1wTsWSxqBu3REZB/6jaAdjR+mY5PxTTmz2WA3Lo4/0Jfp0eRRY4IyzNt?= =?us-ascii?Q?+o426rE8WciUTUTiaxwedHfAhUugqlQk4Dl2jwHu/wZfl8H8Z8uiv7KGi6fi?= =?us-ascii?Q?fP4hu0C6nmtUhOddUkRxEMnX2aj8lgAP7TWyAj5nG5VJmJ1P2UT779Fx7OQf?= =?us-ascii?Q?9rmfBKyzz8ulgSs6OYDwMyuTzGCGz6CDvZjNT04MSKl1aDJ/Abu/1qDNEeGF?= =?us-ascii?Q?TSknmmKWpX/uy9qRJcGI715UrsKwRKXkF0CYiqK8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6073.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4a51aa1-579b-4af6-5899-08db46f52571 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 07:58:11.1566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kF3YCO4rUwCAVETb2tw1dhXsBrPdaxqXpohQSbga1v+zQUdAqTGph6ZsS8xGO1Ld9rCAyaH0cxYsgwb/vSfMgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6312 Return-Path: pen-chunx.lu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, It means the code might be possible return local variable address when we = used the function. So I allocate a resource to local variable to avoid this. Best Regards, Joe Lu -----Original Message----- From: Yao, Jiewen =20 Sent: Thursday, April 27, 2023 3:51 PM To: Lu, Pen-ChunX ; devel@edk2.groups.io Cc: Wang, Jian J Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn-loca= l-addr in HashPeiLib Hi I am not sure if I can understand the patch. Would you please clarify what the problem is in the original code? > -----Original Message----- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 2:59 PM > To: devel@edk2.groups.io > Cc: Lu, Pen-ChunX ; Yao, Jiewen=20 > ; Wang, Jian J > Subject: [PATCH] Release build in GCC5 has warning message=20 > Wreturn-local- addr in HashPeiLib >=20 > CC: Jiewen Yao > CC: Jian J Wang > Signed-off-by: JoeX Lu > --- > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >=20 > diff --git > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > index eeb424b6c3..bf7a5fc65c 100644 > --- > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > +++ > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > ei.c > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > EFI_GUID *Identifier > ) > { > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; HASH_INTERFACE_HOB =20 > + *HobBuffer; >=20 > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > - return BuildGuidDataHob (&mHashLibPeiRouterGuid,=20 > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > + HobBuffer =3D NULL; > + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof > (HASH_INTERFACE_HOB)); > + if (LocalHashInterfaceHob =3D=3D NULL) { > + return NULL; > + } > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); =20 > + HobBuffer =3D (HASH_INTERFACE_HOB*) BuildGuidDataHob > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof=20 > (LocalHashInterfaceHob)); > + if (LocalHashInterfaceHob !=3D NULL) { > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > } >=20 > /** > -- > 2.31.1.windows.1