From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ADC67940F12 for ; Mon, 11 Sep 2023 02:30:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BwfzeStfhszU6Y3qybzkUF00IqZCfX51luyQu8whcd8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694399416; v=1; b=ebZU60pivhGQu2EXNeVWAhNPOARkNByrj+MFKODEpUiFCJ4mDcnzD+GFR0CM3vWnwX1Flevm RoLYAOSn4sTR0k+i9H4/NYkmPivRrQf2nfxO9Qv7caNh/MPHM5jPZZ7YEm32XqrIMhaCcMcuZoh e/NKggRBOKQw5YR1WvUod0xc= X-Received: by 127.0.0.2 with SMTP id Kmw5YY7687511xf4EZ8ocY1n; Sun, 10 Sep 2023 19:30:16 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.50362.1694399415690329818 for ; Sun, 10 Sep 2023 19:30:15 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="444392756" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="444392756" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2023 19:30:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="808658270" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="808658270" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Sep 2023 19:30:14 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 10 Sep 2023 19:30:14 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 10 Sep 2023 19:30:13 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sun, 10 Sep 2023 19:30:13 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 10 Sep 2023 19:30:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YwqgSDAAp61lW5y6M5o+DLQWKOZEjAvAurrJz+etF+gfxERGYDS4X6mFIk+2n4XHqgtcqHGyNLDwQ2V9Szn2gJ4xP9dD0gXWT5bbK+abEdMYoQHqKHk6CuhPhkGG2IxpHB/HQBsjdEDJALgcDlg95ymuBX6W3EdRQM9pnZzrSf+e+BUPMhTqZavQBMSlQ2GDD8VcWdz0HGmM5Hud8oeNFW/Ie658L9LM44YrnMZJTl/JQJyql13I1DgK3QwasMMm3BIpqe6grJOOC6Vc6NnWZWYpuhC88dGMQEAeZEQJPBQMUL5bz11uwK2YHMN+JLzxl7bgG9OVwDx2brx6NaGrDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ckVcobVewbqv+I0PchERPwYmLS4uerBnw9gZdNETqdI=; b=Xjh2alnUs61B//PasMq00MOU5jn0KTJLCUr0pxlvfZad9ApFjNn3EGNGmKtQj/DW4MgELVMCeZzqfJBgmoiGDebMBKudIc1PaiX5m5+/kBwYSSPGoNN2RhLHvQeuhWSMzdzgYiQma+GfMeX3HG/NM2vG86E2hcL4SUnTvyRQIjB0FGonVopJ9a3c2Q75vWv9p7eFIhKqP/xpaVX5nPL1n0HxW5TPG2llHdEsz4MXd1XnVV1OHxz3MWK1BBhUbMmgkXl1i6KGuBXZvvfCUgy+cd2RAL4kEsEYeh4rmgPG7DYUYEgO8UeGKh8SBxgZGc+1stRl+b4ui7hKaqhDrAmGLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from IA1PR11MB6170.namprd11.prod.outlook.com (2603:10b6:208:3ea::11) by PH7PR11MB6796.namprd11.prod.outlook.com (2603:10b6:510:1ba::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Mon, 11 Sep 2023 02:29:48 +0000 X-Received: from IA1PR11MB6170.namprd11.prod.outlook.com ([fe80::7e5c:bd6f:6f40:5585]) by IA1PR11MB6170.namprd11.prod.outlook.com ([fe80::7e5c:bd6f:6f40:5585%7]) with mapi id 15.20.6768.029; Mon, 11 Sep 2023 02:29:47 +0000 From: "Huang, Yanbo" To: "devel@edk2.groups.io" , "Huang, Yanbo" , "Gao, Liming" CC: Isaac Oram , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Topic: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report Thread-Index: AQHZ4GigTHS/j+6WGk26IFTpxyaNH7AU7oHg Date: Mon, 11 Sep 2023 02:29:46 +0000 Message-ID: References: <17822DD0A7D23F61.30276@groups.io> In-Reply-To: <17822DD0A7D23F61.30276@groups.io> Accept-Language: en-US X-Mentions: gaoliming@byosoft.com.cn X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6170:EE_|PH7PR11MB6796:EE_ x-ms-office365-filtering-correlation-id: fa497913-2d01-49fe-0113-08dbb26ef75a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: of6iZJYXm5xIFAsC+eko0EBNw3X5T5tTHq4Ssg7lwho5JO3QqGHCexEnjxvNVBT4mNjoWuiJuHHBLGghm2FOvrsqyssXmaBherWYhtKsES7bTPkFbumRgMkSI//xZgSaZg1E5BQpC9Yb0XATlyLgeaEstGeI9cPQgM3cH3vk0lUXfZ/GJFPMwMPGbsM7e5MUmjWAWsnDGvtYT+HZ+PEyA/wnPQi5HvYIRCQl75EZl4avQnE0Kd0+fsdOoY8jbIW3GXNS1FLw87YQsl7c7EEjmbWY+y93pRc65hz0LAon45hjSp2PiPBgVV1EW/rlrJwQd/zNWpmVos3BisKCYQhscRQsgz3pY5yxwAdI9GZjSxbVAMBZOm7ySK6jRLAg+wuyKIhRYJE0kLCJSUCoey8Zyf+Z7pg6uvOmkCUlmvrDYj8p6KT2LjNBy5KP3Ga+8lYBeK6Mh7EsFVi0S49CCnr5ZUdGGSuMChy0Wo6pGkRpkurxsSzmfaiZgbSFI+L/Rq0d7NVoylSOxPPMTuL7XB2kh5ND975slwJlsZHHQlWArcj1zi/+i/S4hOFPDfV3QZnkQ1zN9oirwuL/ZgwAyKMbfMTKTt6QWkmtN6VSmI2eN0lelqUV2PYmsOQNeXCe0PnP2m3l1EwOYXJKpJlwFBHz1g== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K8tQ787DH3tsECQi26DjoCzKGQHiEoNAYhD2DuqEWan3x2zobKxtPIoEQ3l9?= =?us-ascii?Q?sJR5ZeLtZGTmKn4MJnRxvfbLgSzcJv0JQnmtEk3LDgNgWd1bfMUxesBn5bk4?= =?us-ascii?Q?hyR84mRm+QcBxQLzAYi/8+Kmi+pfmzwz6F5jHjotssdpc/YM9Q5P3bGqbZNg?= =?us-ascii?Q?aYEeab2X5IzOfFdpq8dUxmGThL2/0sGZpofIbB25VaNCxBODCUFLuyss2yoE?= =?us-ascii?Q?eu4Gj/RVEeAUzbfpy67XLXG0JeaPrYu3GtHKeuCqjYEDlZ4soErue+tvz1HE?= =?us-ascii?Q?Rz8YuY8+oNqj7kxmnIX2K4u5oI9SibBB2VHF5D0K/2G8/KI9uOUwFobvcANm?= =?us-ascii?Q?2zWRF1wFWX7rYcvvJjSnxkGNeDKTRsom0uMEGgThN7T58nVb+Q0rCQbwHPzk?= =?us-ascii?Q?UoP8xo3bY2QGvunY2XIt5cYmVOy/4i7m+++Wz37GaMK2kb+zKXEWyhec8i+a?= =?us-ascii?Q?bKzVbVz6jethtvGXuLS3ihpSPqcdNG5WBGpzySfaAuC3Ehb3cO8Kq1+s/LpK?= =?us-ascii?Q?2eyNBFVFHTJVcUsodg7J9HgPzH6UqN/C1arbE4deSB0esNne/6E2ZTtxt5L7?= =?us-ascii?Q?hWAMxmzM7+euE3kle/UA/0x3t77Ke1Oer7o5/KR6gnOIYUOkaEprIVZEZDYc?= =?us-ascii?Q?NWUoywG6tyTFG08fa+Su6rsyXrS5c9Ps2k83iLnKZskSB7uVKNzdj6pykESq?= =?us-ascii?Q?NIWx9fWhAeTDErNqbAlDNrfpIr598HIgHhv64OyGKDqTasXdCJ0xBfxopylv?= =?us-ascii?Q?N0gAu+9hIkT9mDDQGxOGKE55biQW9c+Z4oxXz9OMiGdeLz1lBaG4guwqdv+h?= =?us-ascii?Q?sPA0zuUK6JmZ+unCZ8/jmGg9k7HBlFlYPmg1gjHlOrmc0B76wP7mDOGHFXWl?= =?us-ascii?Q?0ni1kl/KT+SFZiLj21lMKRelz3kGo1B7M2Afpsqw4jvt4Kr5r3SLVjLUzT7S?= =?us-ascii?Q?88JYvveS2i/AQHubWiQcYIWy5zAfwOzAHnyFM5ncvfHeL2MSCyHOj8UpIM+/?= =?us-ascii?Q?3PBfMzBKfbX5yOwWfH7fXpKRC68SwwvR2BcoCIVgNHwxmBxc2rHk2rxswKgQ?= =?us-ascii?Q?ln5S/jripSGbToaJw/Uqvv++zI8II/joAW135M0i3jjiqZxyDeYhOobaV1kN?= =?us-ascii?Q?8vis1Agg5kfRBfeCz9RWRvV/vSPsOvO50kZ2pvadEwzf0XgpQ40r83kS1RtQ?= =?us-ascii?Q?lG5zEb05A7DiBTsAamTuT2mz3Ctuy5Te6Nz1sAAjcjsuY9fRrDr6Px/aOsDZ?= =?us-ascii?Q?U9rQgpsS23N2/E6zUGDPp8kYg11Rn5KJ9vlE/PBDZFt+5zJ55jpS9wtkr+bK?= =?us-ascii?Q?w29LAVgCxt2lIb8fO62nmWx3ks2a2oxZkfBHa3nHhv+b74/tknJxzcoaUA0W?= =?us-ascii?Q?XijIi/zxlKVmVuyiK4vXU3UWyrlWu2tMcXj8MqGC7bQsAA1w4MMS1H72xM6g?= =?us-ascii?Q?z1ATOIKbPiRdua2gMJhd9Xd7Nfo3LXYNrLY7RXvGQb6DGJU6fZDE608XMouV?= =?us-ascii?Q?NM1YQxUYsE1YeiZCTP1slwG7VUWZjr35cAt7TmO/cbmKlIWBXQPIK/igjlUo?= =?us-ascii?Q?ne76a/SXZ0TT/bIP15ooNpAomWhG48KmWzTGn785?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6170.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa497913-2d01-49fe-0113-08dbb26ef75a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2023 02:29:46.8753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: etBEIlL8D9BJr7gUZbGZe5ydQCI+LuPhhFCESsvne/i8Tcw05wGVAe5M7OBb9AnB53/UwGKNFZlDKgVjifcjqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6796 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yanbo.huang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: A9vRVvbFe82CGC9jddpI1SVPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ebZU60pi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io @Gao, Liming Could you please help to review it?=20 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Huang, Yanbo Sent: Wednesday, September 6, 2023 10:19 AM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warni= ng report REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) {" will not be execute= d in current code, put it within "case SysInterfaceKcs:" to avoid this issu= e. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Yanbo Huang --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 36 ++++++++---------- .../GenericIpmi/Pei/PeiGenericIpmi.c | 36 ++++++++---------- .../GenericIpmi/Smm/SmmGenericIpmi.c | 38 +++++++++---------- 3 files changed, 49 insertions(+), 61 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 7113556df8..82f6d2a661 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -630,8 +630,8 @@ InitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -646,21 +646,19 @@ InitializeIpmiKcsPhysic= alLayer ( mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -669,12 +667,11 @@ InitializeI= pmiKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ssif.SsifInterfaceApiGuid ); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { @@ -683,9 +680,8 @@ InitializeIpm= iKcsPhysicalLayer ( &mIpmiInstance->IpmiTr= ansport2.Interface.Ipmb.IpmbInterfaceApiGuid ); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Pei/PeiGenericIpmi.c index 1d8266a0b1..ebc9e7085d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ +++ PeiGenericIpmi.c @@ -343,8 +343,8 @@ PeiInitializeIpmiKcsPhysicalLayer ( // Check interface data initialized successfully else register notify pr= otocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInstan= ce->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -359,42 +359,38 @@ PeiInitializeIpmiKcsPhy= sicalLayer ( mIpmiInstance->IpmiTransport2Ppi.Interface.KcsInterfaceState= =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Bt.InterfaceState= =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ssif.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.InterfaceSta= te =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2Ppi.Interface.Ipmb.Inter= faceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D RegisterPpiCallback (PeiServices, &mIpmiInstance->I= pmiTransport2Ppi.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Ge= nericIpmi/Smm/SmmGenericIpmi.c index 350d6afef5..2349373317 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/Smm= GenericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/ +++ SmmGenericIpmi.c @@ -210,7 +210,7 @@ SmmNotifyCallback ( &mIpmiInstance->IpmiTrans= port2 ); } - + ASSERT_EFI_ERROR (Status); return EFI_SUCCESS; } =20 @@ -335,8 +335,8 @@ Returns: // Check interface data initialized successfully else register notify = protocol. for (Index =3D SysInterfaceKcs; Index < SysInterfaceMax; Index++) { switch (Index) { - if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { - case SysInterfaceKcs: + case SysInterfaceKcs: + if (FixedPcdGet8 (PcdKcsInterfaceSupport) =3D=3D 1) { if ((mIpmiInstance->BmcStatus !=3D BMC_HARDFAIL) && (mIpmiInst= ance->BmcStatus !=3D BMC_UPDATE_IN_PROGRESS)) { BMC_INTERFACE_STATUS BmcStatus; mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitialized; @@ -351,42 +351,38 @@ Returns: mIpmiInstance->IpmiTransport2.Interface.KcsInterfaceState = =3D IpmiInterfaceInitError; } } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { - case SysInterfaceBt: + case SysInterfaceBt: + if (FixedPcdGet8 (PcdBtInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Bt.InterfaceState = =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { - case SysInterfaceSsif: + case SysInterfaceSsif: + if (FixedPcdGet8 (PcdSsifInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ssif.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ssif.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ssif.SsifInterfaceApiGuid); } + } + break; =20 - break; - } - - if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { - case SysInterfaceIpmb: + case SysInterfaceIpmb: + if (FixedPcdGet8 (PcdIpmbInterfaceSupport) =3D=3D 1) { if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.InterfaceStat= e =3D=3D IpmiInterfaceInitialized) { InterfaceState =3D IpmiInterfaceInitialized; } else if (mIpmiInstance->IpmiTransport2.Interface.Ipmb.Interf= aceState =3D=3D IpmiInterfaceInitError) { // Register protocol notify for SMBUS Protocol. Status =3D SmmRegisterProtocolCallback (&mIpmiInstance->Ipmi= Transport2.Interface.Ipmb.IpmbInterfaceApiGuid); } - - break; - } + } + break; =20 default: break; -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108472): https://edk2.groups.io/g/devel/message/108472 Mute This Topic: https://groups.io/mt/101185487/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-