From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 657CAD80084 for ; Tue, 24 Oct 2023 02:18:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EFz1mJ6ZlY8w2kHQXT0BoZJbZ89RLDSK4urXyjheccw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698113905; v=1; b=JVG2e5q41xyhnOtPH+wNHkVFEgAbfmJQ8xo0hLI3mMA/ViPqKwDGCwjKRQwgotH0Tuk5XOIz q46hJ9kz38udwnQceDt+LTfcAyK8BHZpMdknYArITs4mv49AGnyPbViZerLsK6Qd7wN6XoHx0CI axjHHAItMG7Bid5B+nBsy4/U= X-Received: by 127.0.0.2 with SMTP id hBNzYY7687511xJIluf94k5q; Mon, 23 Oct 2023 19:18:25 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.139331.1698113904939551926 for ; Mon, 23 Oct 2023 19:18:25 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="367199404" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="367199404" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 19:18:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="787640935" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="787640935" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2023 19:18:23 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 19:18:23 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 23 Oct 2023 19:18:23 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 23 Oct 2023 19:18:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YA1hM+/kYjkWxN/l800giW5WXicVlMKE86xubqsYTJV5JSBT+4DD2knh+v5+yX0CNdHSwZfzrDcyAlahr0t12EWXfj11+F7M+EM8k9x62gdQAAkYNvAZbsMfV6YK5JlMBstH6Vc6H1Ajk3WTgAVLWiHZ0hqSfLAcN/Xa8kmUyEoRiyxp0Ekuy1nDN0krTPVzyLDp6WBrU2gAVrzSCA939/QFoQdEUcQW9eCxBvLY1OjxqIJZxJ3xo2/Vm+M10UWpHWbWSaTJtY81i5at/Ck+FjG7DM0iw+2OvZZdoH5Eh2aRS0niy2kfKzDMotQcB84b4g4vicchBT5kEMD2Etgqcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yWXstrFZmB4zSSEWPv4zxOr3wyyxiKa/cSkvsNQNIMg=; b=UWIZsgjwBBE/9V5Y0veyPLb4FPG09tWNizY6D7Y8MLAPtQJ7BZs1rrcg+iLygY6FjGE3imq7ZOgB33qLUfTypct6L4jjz0FZtke7NXt4URAMAtwjUOv2hVn0UH4sUt9zpr7cJV0C3K0ySkWbJy0z6ndCiyjwNaOIrRqABf2s+jdL5HuMt8XIDnUw0nze99UaUqBnlRxoQY9iWfREJoVlQ2KxclbiIVKbHBabYTjMD+DUytbQTTkAJ5l3gjniNorpu8j5bPd/e+KEEKn2vkIAvX5TvWwA/8Eecp5PR6pGdiiBH32+OGv6iAxwSLlRwROMZEihdM7cMlMzmdJotiUxSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from IA1PR11MB6370.namprd11.prod.outlook.com (2603:10b6:208:3ae::8) by CY5PR11MB6342.namprd11.prod.outlook.com (2603:10b6:930:3d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 02:18:20 +0000 X-Received: from IA1PR11MB6370.namprd11.prod.outlook.com ([fe80::9176:f6ee:53d0:febd]) by IA1PR11MB6370.namprd11.prod.outlook.com ([fe80::9176:f6ee:53d0:febd%6]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 02:18:20 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "aaron.young@oracle.com" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath Thread-Topic: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize BmExpandPartitionDevicePath Thread-Index: AQHZ+4vv8DtJgp88+UqYOOiSAsJwRLBYSOMg Date: Tue, 24 Oct 2023 02:18:20 +0000 Message-ID: References: <20231010150644.37857-1-Aaron.Young@oracle.com> In-Reply-To: <20231010150644.37857-1-Aaron.Young@oracle.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6370:EE_|CY5PR11MB6342:EE_ x-ms-office365-filtering-correlation-id: 1f676205-8142-475a-6063-08dbd4377df8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: bwLkEYWQfY/bE3TnysJA7CEZUlgUOSXIrGWHZvfHwEBWsJSIaI4jZNKX0IeOS7DTRfVf5Ct16uqo8q3Ye86WoVGIhq9fbqtn2oeiTn5MzEV85bYDStDfK3ofc+PQI2NE51olrcSnRbF7gpg2cepc9915PvNaHt637ZxzZHMIXa2P/MCQ92odlLSFrnDSfPVjMtfUb+4mbHzrgQvkxmaYIpZB2HTD2xl8abLicUDwPBjOJarIhRLHzVmWl6UvAutiZ3w6oWMin+UGjenZLx/m70gV8CBel4IzN+P/rGj7W1/ZEHDwUkckqetsJ7sqF6ie+T2tfNHqPe9LLEzyDOo4Y5CPgoGdibPjhXNMGALiKLQ7KFAv7RZ+zMF0GvWksNtTlrA0b66SRf8NFQJEWR3RxZjPiZMOMQVc6/ngVV5cJA/l9x+57rlIvr/vPb7Rk8mJ2wyzkaQfLSpaVnTYnZ6XB8wVyNjasjiq6yo4OM/zMg4PYH1t5/i8TCfDFOXhpGhiFJXG6rP6xfQA1x7AL5+MB8ABFqarocU1VHpeWQ5n3SsUx4FONauF3glmBIwe0bS3MgiGtSjkETH2gt8ebvhqJqhR1CfeFd4AwuGJn4xOEmoE4ZX8/VuycGntNZBWUlqS0dre52KvCjCvm7mbWriSkg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/jDu6tJT3A179E1rpXCYGWT4Iwtq5qPNktfDewhfhymAQCaLkF+GYAM4mRzL?= =?us-ascii?Q?IAorIOPXycrv5idkjCBqFL5NUthU9mwktrA8NtmgNL2k+fOxnnlN1wtYlJ4g?= =?us-ascii?Q?sfascX/Eg25KDmbXzICOV55UAPJKetR5EMQnYkqFnpJrLWLCypzxF839UnSl?= =?us-ascii?Q?do0FyD5adpzU8WbUsm7iIX0W4oDEtcMC43nhfBBChOnals4W69+tYriLwI2T?= =?us-ascii?Q?syDzYFosfDgazOXzCvLv4TMesVSaHxfeNZR4pFPCcMta9xkQbuZanxu9+VD9?= =?us-ascii?Q?Dc3JnqNzqt5fhGsijPNCSkKpocFfwkQvcg5gwRaTByZrTfh9DRKZdPTkYchM?= =?us-ascii?Q?f89kIlwND3oGFsVoXr90ZX4VaGCdDcNxk9Xbar/t0wXjPvVBQuuFhfnpGFRr?= =?us-ascii?Q?2G5RX7ZSoOQYeOJunRQBmCKK4PJINIXX81ysEeOG8+nvzxko4dBlDmjyr7TX?= =?us-ascii?Q?bn9XbOuyn7qMXuNsp6fawoEV9Lku6h2u5Bj6WI7RTel+PiAnU2fECEKSIz1J?= =?us-ascii?Q?ZOIwoXPrBgHJjZ9mTTpkn8Vd4yc8jKVBdr4KpEbNMfgya8itDNU4ZoXZM/qk?= =?us-ascii?Q?2fO80Gu5ltq1ncyUliFQEt927ud5PDtiP9zdQFBKw3B7lvzuvGq9EQdEDD17?= =?us-ascii?Q?5BmoQAWLptenqnRqlNRr8TK6ZlA+hzIoYRnByJsjz0fNpYtZWDr6tXA8IufW?= =?us-ascii?Q?i1JGsPCuFDmw8BoM1j3ZnPZioTREYn/ymtxSLa0VaW5dMSTDYeJ8MVXWXpsO?= =?us-ascii?Q?157lvQuSbhHeYB9rTDa0UsHwl5hRZO2MxGm53rOAfGjWyI1QbLNHkJcdjDj2?= =?us-ascii?Q?FYULCIRf4sMJDdrvPfJB2cPmyS/Zl+sCoehtGlwAcjAV7uBe4mEx7sDvnxhE?= =?us-ascii?Q?8B9T3RXRST/3J5fR14xuVTsv1XAw+RhB2iMGKo1TQ4kuup1Zqw+BNEwaLbw/?= =?us-ascii?Q?op+WRam1EP8Et4hHS1kWMrPTs+W96kw+Kb/N38xlXMEVuFPpo+PCiDE1YONb?= =?us-ascii?Q?rtVL7Z03E1AKrldHfye3xQFBTKZp+CUsvkVDy18irhVwsiemeI+tDAsv3ZCr?= =?us-ascii?Q?6Vdgq/rzFeYlbHgryzTLI8w+wqh0aAdbft7j75aUO8gcjtT+wv6ZO5FkctP9?= =?us-ascii?Q?ww7qsxKrUoQmK4zznr3CMJOD+Gckvc7ZAUBvEeuDZQOW8gxBX1OeXXMOVYXQ?= =?us-ascii?Q?tsiS2NjNFst6JPGlfddGHbzeMvXDdyFBN6NRD+q/QLK7HmRQ4LAbXuq3Q1jR?= =?us-ascii?Q?yvIfjBf1lXzx55PkVBgS3L+Yo1+CMsgWwXKE8aJRFJ3VTRwsN3/5cNlZ2lL8?= =?us-ascii?Q?hG9Lp1oH7we1ebvXJngl6iQtu7RcLTVdFVFTA9dBunfEfekkCcKisfn3lsQM?= =?us-ascii?Q?mbdMcLBS7gCC5Z4ZfARFMRFQrMWmPOU/hLOEVIt+sxxkEkWMW+4rlKwcrKb0?= =?us-ascii?Q?ByrbaFFeOiBViOuYIjr14qkRDG1Y8hhaVqfXVwtuYJ38sWOKkEk3gk27tITn?= =?us-ascii?Q?9kPh/AwlzH3zaij+sRlzIfp5NJP98+U9g03wO6bADAMwKZ6rWG8DnqbQcuUs?= =?us-ascii?Q?FypzJzNqJIf4wg4fWLCKgoAHwnzYcf6qNrBTTjeA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f676205-8142-475a-6063-08dbd4377df8 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 02:18:20.4423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bH+VgfxxnlKMKPXV7IKzEkR/fWaI1JiEuuuEZ+wVat32QXwH8teF/smkd6sc5cNKyTXKgo0h5A/tLvYLyPxMlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6342 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q3VQWDLYChuI3Hp7Rt9WV4Axx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JVG2e5q4; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") The patch looks good to me. Reviewed-by: Zhichao Gao The comments of this patch and proposal would be taken care in another patc= h. Better to have a Bugzilla record for the planned change. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Aaron > Young > Sent: Tuesday, October 10, 2023 11:07 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Optimize > BmExpandPartitionDevicePath >=20 > Reference: https://github.com/tianocore/edk2/pull/4892 >=20 > BmExpandPartitionDevicePath is called to expand "short-form" device paths > which are commonly used with OS boot options. To expand a device path, it > calls EfiBootManagerConnectAll to connect all the possible BlockIo device= s in > the system to search for a matching partition. However, this is sometimes > unnecessary on certain platforms (such as OVMF/QEMU) because the boot > devices are previously explicity connected > (See: ConnectDevicesFromQemu). EfiBootManagerConnectAll calls are > extremely costly in terms of boot time and resources and should be avoide= d > whenever feasible. >=20 > Therefore optimize BmExpandPartitionDevicePath to first search the existi= ng > BlockIo handles for a match. If a match is not found, then fallback to th= e > original code to call EfiBootManagerConnectAll and search again. Thus, th= is > optimization should be extremely low-risk given the fallback to previous > behavior. >=20 > NOTE: The existing optimization in the code to use a "HDDP" variable to s= ave > the last matched device paths does not cover the first time a boot option= is > expanded (i.e. before the "HDDP" is created) nor when the device > configuration has changed (resulting in the boot device moving to a diffe= rent > location in the PCI Bus/Dev hierarchy). This new optimization covers both= of > these cases on requisite platforms which explicity connect boot devices. >=20 > In our testing on OVMF/QEMU VMs with dozens of configured vnic devices, > these extraneous calls to EfiBootManagerConnectAll from > BmExpandPartitionDevicePath were found to cause many seconds (or even > minutes) of additional VM boot time in some cases - due to the vnics bein= g > unnecessarily connected. >=20 > Cc: Zhichao Gao zhichao.gao@intel.com > Cc: Ray Ni ray.ni@intel.com > Signed-off-by: Aaron Young > --- > MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 90 > ++++++++++++-------- > 1 file changed, 56 insertions(+), 34 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > index c3763c4483c7..7a97f7cdcc6b 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c > @@ -880,6 +880,8 @@ BmExpandPartitionDevicePath ( > BOOLEAN NeedAdjust; EFI_DEVICE_PATH_PROTOCOL *Ins= tance; > UINTN Size;+ BOOLEAN MatchFound;+ = BOOLEAN > ConnectAllAttempted; // // Check if there is prestore 'HDDP' variabl= e.@@ > -974,49 +976,69 @@ BmExpandPartitionDevicePath ( > // If we get here we fail to find or 'HDDP' not exist, and now we need= // to > search all devices in the system for a matched partition //- > EfiBootManagerConnectAll ();- Status =3D gBS->LocateHandleBuffer > (ByProtocol, &gEfiBlockIoProtocolGuid, NULL, &BlockIoHandleCount, > &BlockIoBuffer);- if (EFI_ERROR (Status)) {- BlockIoHandleCount =3D 0= ;- > BlockIoBuffer =3D NULL;- }-- //- // Loop through all the device h= andles that > support the BLOCK_IO Protocol- //- for (Index =3D 0; Index < > BlockIoHandleCount; Index++) {- BlockIoDevicePath =3D > DevicePathFromHandle (BlockIoBuffer[Index]);- if (BlockIoDevicePath = =3D=3D > NULL) {- continue;+ BlockIoBuffer =3D NULL;+ MatchFound = =3D > FALSE;+ ConnectAllAttempted =3D FALSE;+ do {+ if (BlockIoBuffer !=3D= NULL) > {+ FreePool (BlockIoBuffer); } - if (BmMatchPartitionDevicePa= thNode > (BlockIoDevicePath, (HARDDRIVE_DEVICE_PATH *)FilePath)) {- //- = // > Find the matched partition device path- //- TempDevicePath =3D > AppendDevicePath (BlockIoDevicePath, NextDevicePathNode (FilePath));- > FullPath =3D BmGetNextLoadOptionDevicePath (TempDevicePath, NULL);- > FreePool (TempDevicePath);+ Status =3D gBS->LocateHandleBuffer > (ByProtocol, &gEfiBlockIoProtocolGuid, NULL, &BlockIoHandleCount, > &BlockIoBuffer);+ if (EFI_ERROR (Status)) {+ BlockIoHandleCount = =3D 0;+ > BlockIoBuffer =3D NULL;+ } - if (FullPath !=3D NULL) {- > BmCachePartitionDevicePath (&CachedDevicePath, BlockIoDevicePath);+ > //+ // Loop through all the device handles that support the BLOCK_IO > Protocol+ //+ for (Index =3D 0; Index < BlockIoHandleCount; Index++= ) {+ > BlockIoDevicePath =3D DevicePathFromHandle (BlockIoBuffer[Index]);+ = if > (BlockIoDevicePath =3D=3D NULL) {+ continue;+ } + if > (BmMatchPartitionDevicePathNode (BlockIoDevicePath, > (HARDDRIVE_DEVICE_PATH *)FilePath)) { //- // Save the matc= hing > Device Path so we don't need to do a connect all next time- // Fai= ling to > save only impacts performance next time expanding the short-form device > path+ // Find the matched partition device path //- = Status =3D gRT- > >SetVariable (- L"HDDP",- > &mBmHardDriveBootVariableGuid,- > EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE,- > GetDevicePathSize (CachedDevicePath),- CachedDevic= ePath- > );+ TempDevicePath =3D AppendDevicePath (B= lockIoDevicePath, > NextDevicePathNode (FilePath));+ FullPath =3D > BmGetNextLoadOptionDevicePath (TempDevicePath, NULL);+ FreePool > (TempDevicePath);++ if (FullPath !=3D NULL) {+ > BmCachePartitionDevicePath (&CachedDevicePath, BlockIoDevicePath); - > break;+ //+ // Save the matching Device Path so we don'= t need to > do a connect all next time+ // Failing to save only impacts perf= ormance > next time expanding the short-form device path+ //+ Sta= tus =3D gRT- > >SetVariable (+ L"HDDP",+ > &mBmHardDriveBootVariableGuid,+ > EFI_VARIABLE_BOOTSERVICE_ACCESS |+ > EFI_VARIABLE_NON_VOLATILE,+ GetDevicePathSize > (CachedDevicePath),+ CachedDevicePath+ = );+ > MatchFound =3D TRUE;+ break;+ } } }- }++ //= + // If we found a > matching BLOCK_IO handle or we've already+ // tried a ConnectAll, we a= re > done searching.+ //+ if (MatchFound || ConnectAllAttempted) {+ > break;+ }++ EfiBootManagerConnectAll ();+ ConnectAllAttempted = =3D > TRUE;+ } while (1); if (CachedDevicePath !=3D NULL) { FreePool > (CachedDevicePath);-- > 2.39.3 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109496): > https://edk2.groups.io/g/devel/message/109496 > Mute This Topic: https://groups.io/mt/101876973/1768756 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [zhichao.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109979): https://edk2.groups.io/g/devel/message/109979 Mute This Topic: https://groups.io/mt/101876973/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-