Please review
https://github.com/tianocore/edk2/pull/3793 for below questions.
Answer: Done
Answer: It’s BSD license, based on
public-mipi-sys-t/LICENSE at master · MIPI-Alliance/public-mipi-sys-t (github.com)
Answer: Done
#define VA_START va_start
#define VA_ARG va_arg
#define VA_END va_end
#define VA_LIST va_list
Answer: Done
Answer: Done, renamed to DxeSmmTraceHubDebugLibSyst.inf.
Answer:.
https://github.com/tianocore/edk2/pull/3793
thanks
From: Guo, Gua <gua.guo@intel.com>
Sent: Thursday, December 1, 2022 11:29 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Chan, Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com>; Lu, James <james.lu@intel.com>; Chen, Arthur G <arthur.g.chen@intel.com>; Chiu,
Chasel <chasel.chiu@intel.com>; Zimmer, Vincent <vincent.zimmer@intel.com>; Hsu, VictorX <victorx.hsu@intel.com>
Subject: RE: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT]
As we offline sync, there are below opens like below. Have any open, please also share for us.
Answer: Will update it in next patch
Answer: It’s BSD license, based on
public-mipi-sys-t/LICENSE at master · MIPI-Alliance/public-mipi-sys-t (github.com)
Answer: It’s MMIO address, we can change it to UINT64, it make sense to let the PCH more generic. Will update it in next patch.
#define VA_START va_start
#define VA_ARG va_arg
#define VA_END va_end
#define VA_LIST va_list
Answer: Will update it in next patch
Answer: MdeModulePkg/Library/TraceHubDebugLibSysT/DxeTraceHubDebugLibSyst.inf can take care for SMM case. We can rename it like below to make it more clearly.
MdeModulePkg/Library/TraceHubDebugLibSysT/DxeSmmTraceHubDebugLibSyst.inf
Answer: Will draft another PR and try to use gitsubmodule to check whether exist any predicament.
Thanks
Gua
From: Guo, Gua
Sent: Wednesday, November 23, 2022 3:29 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; gaoliming <gaoliming@byosoft.com.cn>;
devel@edk2.groups.io
Cc: Chan, Laura <laura.chan@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>; K N, Karthik
<karthik.k.n@intel.com>; Lu, James <james.lu@intel.com>; Chen, Arthur G <arthur.g.chen@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
Zimmer, Vincent <vincent.zimmer@intel.com>; Hsu, VictorX <victorx.hsu@intel.com>
Subject: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT]
@Kinney, Michael D and
@gaoliming
We want to add TraceHubDebug library support on Edk2. It’s new added library on Edk2, so it doesn’t have any backward and forward issue.
May I know have any process we may need to follow up. Have any comment or concern please also share for me.
Reviewers/Maintainers: @Prakashan, Krishnadas Veliyathuparambil,
@Chan, Laura,
@K N, Karthik.
USF UPL spec update: https://github.com/UniversalScalableFirmware/documentation/pull/52 (Done)
Edk2 Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4144 (On-Going)
Edk2 PR: https://github.com/tianocore/edk2/pull/3613 (On-Going)
Background:
About TraceHubDebugLibSysT:
Thanks,
Gua