From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.178365.1672221049315157945 for ; Wed, 28 Dec 2022 01:50:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FHeZmqYO; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: victorx.hsu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672221048; x=1703757048; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=60/fVQWpJ+OMbPQ4HiNwpbNQl3n2ITRoY063CY7ARpg=; b=FHeZmqYO0nAjrWdDz633U9k11IEfK2nQsuHCSwwlr1y1NNKdd7DXJJjU nTvryMLkmShFM1DlhRiRn1wN1EBHK/WjkaCXOQgHTypEuy3SUO5PNmu7F xdeef7J6Wib6wWJuve4E1fJomxypUwO8LrF8lOB/J93oZiDt/Pk46Ftcg KlsMpttvH7GGLg2mWKRTRle3OsEOc3wlIZv8Xwv43VnwWkCYAAT15AAyo C7H48jRLTUZbkg0XMjsupLxL4zL35jWnJlFeslGyY4yfMg+/Wpeaby0Ne 8wxKbGpBpfjmw6A6QCQtEw947N/f84impo/3iH8UGuqrZnEaV2aXO5dmm A==; X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="308598682" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208,217";a="308598682" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2022 01:50:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="795616173" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208,217";a="795616173" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 28 Dec 2022 01:50:47 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 28 Dec 2022 01:50:46 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 28 Dec 2022 01:50:46 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 28 Dec 2022 01:50:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4Z8I7DokyxXqkT7eEP/r+aK9zBtR/4lhlUOiUKARu4X7W6L2MZHc+1OXxb56Z/pXJnEra8/wqhJxTX2W0l24Ol+EAK7cP6Yr0c/33iNoeW3Pe9LXCbxBmaDjntMLgvRDzr6u08qO0hfj/w3iWZV4a7vfJC5NcgNGFIMS2EX8kbMjE5zSA5dz7raSTLphiLMFmlbrAIUGecRF96ZwqY2qpfXqY6Zd5ldDu+qUqX7kAjRaCi4RnZtlwUI2Lp9kkIV+CVRDZ+S8iWjYuUxaVoiS7Cc1xndt455kHTqnI1vK8nbC3OhugDkaVZt+1gy1RQCI+N/bMoxEvVj9VRNQbOZXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lyIRrv5WgiSUL8i6izag1Madkt8+XMF9CFtsDCd0upE=; b=YbnsWOXJi4LBeBMVTSYDOF5NSdjc7Hfy3YMOd0/zlOIh7WoixHWq1XzXv3By31gSVXvyHxBt8E10f0AxucckqEFxcr5mqlUYX/Ackpp3/CUDTrK3U6bRKjDCQs4EBKAqqklm8FNkKPJ6N/pBDjxYSV7hFbN3pK1tQt5plwOuMghHkB1orDIeOwkyubD5K86v0/4KbMbhwYdYhzg0MkdZYR38nEGl3Z41mBkUKgpI/BZ+1Sn1U1i9GR9I8Q1ak+6/H3qrK22sesDqdb1H+z7n74LFFqToL4sY4j3s8CSKDY9iLR1ivTHf1Lz7qNn5v1oDllIbCDMFJTzi8m0zr5ChwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6537.namprd11.prod.outlook.com (2603:10b6:208:3a3::14) by MW4PR11MB5892.namprd11.prod.outlook.com (2603:10b6:303:16a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 09:50:43 +0000 Received: from IA1PR11MB6537.namprd11.prod.outlook.com ([fe80::5c0d:a6b4:2509:acc1]) by IA1PR11MB6537.namprd11.prod.outlook.com ([fe80::5c0d:a6b4:2509:acc1%7]) with mapi id 15.20.5924.016; Wed, 28 Dec 2022 09:50:43 +0000 From: "Hsu, VictorX" To: "Guo, Gua" , "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" CC: "Chan, Laura" , "Prakashan, Krishnadas Veliyathuparambil" , "K N, Karthik" , "Lu, James" , "Chen, Arthur G" , "Chiu, Chasel" , "Zimmer, Vincent" Subject: Re: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT] Thread-Topic: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT] Thread-Index: Adj/DG92N3a/MEygSlmVUL50vBrmkQGJexEAA78T73A= Date: Wed, 28 Dec 2022 09:50:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-Mentions: michael.d.kinney@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6537:EE_|MW4PR11MB5892:EE_ x-ms-office365-filtering-correlation-id: ad74f520-52a1-4946-6379-08dae8b8fc7a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gktdbxdVya3C1nX8HEcnLhAwS8beqXEyYq56crU0gw1Wc4k2rsNFbIX74K+ROMMqLhnl5RXjh/FVdmW7nSWSEGUSxMToI1FBIHGnmjD6rNZ8TCk4uFwyAtz8FDzyQwPDMj7uHCXp7D/ChLqERQBC/qnz9rCR7N8Gu8cvJwPcIhepLhBj3lxn3Zs7eDbjVNFQCLcUTnAVl/ZjaR8Xt3i+tkged0/RdmaEPK7tksXPidCh8dRcTZkwAPf+GDi+5YkM+8Wr92PWxcRNnMN6DX3o+ohZe08hwAJv6Y5JQbzG7kZdbTZzwXLA0nHNU4lBNw4pBUgu3bq396mkjpcntXnVr074twe8ybsi0RhKeJVwaGZ7hWwQ601947vybk8cLOT3iV/YxV9VVpGq0WB2edqMi68AFP/e4Q9MA+ntjuw4n1s7tp4fqG2a+FDFuria19kWFDFp7P2Y17DtMBU90dgw/UE2dqB7Gw8Goi0tRKTV2Y+eKqw5icI5Iei0NOzMdJ1a0m1WQRMaH4SqDphxoISQj4aZaAbQJ5jxMr5a6aanroTumGpkBFKFwBDnvYsAs0G2zQ1Aeh096deMxnVeAQLOTs003t9JBDduuQxTiQfsYmWizZAzFm54jr5kyn6ZYm73oIo4y5MB8ruD5cdb/dIGXn+fmkzvIJWO8qAdR73+6gDLjb5/JYoBQkQ3tDONiJe3PM3o/KBk9iUSdH9ksQDq0Ius+evmKCS6/RjM2O1o/pi2spcwjTB4OFTZ6mtHR8nHvQcp0+Z+R2/6/dqEQLnRvAJNw+/KWXWc0vB8X1rWSOU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6537.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(396003)(346002)(376002)(39860400002)(451199015)(33656002)(110136005)(478600001)(107886003)(966005)(2906002)(54906003)(316002)(38100700002)(53546011)(166002)(38070700005)(83380400001)(122000001)(82960400001)(86362001)(26005)(7696005)(186003)(6506007)(9686003)(55016003)(71200400001)(5660300002)(52536014)(8676002)(4326008)(76116006)(64756008)(66446008)(8936002)(66556008)(9326002)(66946007)(66476007)(41300700001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+Q9MgZKEl/Z0Q0tTrL9z1Qo2WVj8mX8Wh/zx+ZIFDiKxuLhKdvI0GboqEAH5?= =?us-ascii?Q?4v/DdRwBk69dcZXPET0O2YtE3NGmdL36JfApC5REoHAGPr50WEyN1M107POh?= =?us-ascii?Q?D2D9FsfxCJOm4XII+FhDZZTp6bFgkE8bs05IZ0sFErjMz6muZ2dWXdKI1hss?= =?us-ascii?Q?aO366Ur8onUNSZFBN0wrZ9oeT+ztk91lD00n9OfF/3bwQKFLSjAPFJ/LYjnF?= =?us-ascii?Q?0Wjjh2mu82ZZFlQDaccAF/j0LVUtVBcNS+SA9rGlt4f8hIXlhGJj5QKozG6r?= =?us-ascii?Q?clsdJe3yxOLc6kxEQIEYV5MBf61UPghkQudTmV+nt5B1T0aZ9r58TXsneKYy?= =?us-ascii?Q?+ajt0lFvp7dZRSA3RG/FW8YZN2QR6k04MXX4hJHknA4XcVqnjR786PPMw8Lv?= =?us-ascii?Q?LcUWHaTl2zCm1qLiCM2Ax2adtfJf9pgMjyDmKd/mUkIavcmjcjK4aLwO+vXj?= =?us-ascii?Q?KC08c329NeSL/nSNITUe2137g59hEe7PThaQMBE8MMt1oPLQFmf2cc4NTnxe?= =?us-ascii?Q?m4ftFr3Sb039HxZWfYeI3QTPc0UHNVgAV2DrlaR0GEez4L7WMgy4AlFVcTUO?= =?us-ascii?Q?IZ/MLDqKxn5pJSb8W9VDOKH/7qQCXz2LiDxZRn9Cou3BfG5Dnz5P0h/mnMlW?= =?us-ascii?Q?PE+kbFauc+SmDkP9grOnQFEfQ/3vq6oDe8k0V/TOfwIElu9kMDCYUpb8fBf3?= =?us-ascii?Q?G6OU2YdM1uBcd3MWoTIwU1csL4+lQrNpBazWONN3w+0dc/l5R6KLfP8KdMys?= =?us-ascii?Q?Zfmky9FVZ2SJN0DE+kthx5RIJpPCSZhkr//z1XJWlF/AfHtu+ZZlCXoewo+r?= =?us-ascii?Q?W9xSXF4Pr8CpaQcw1egSspOagrEHd+lZOr2baf+uytJ9IFxOatpBE08WXe7f?= =?us-ascii?Q?Dbxc/raqeozMRYSWFGDNU1quK5wOP7c51v0AkwcGMrIWSldiCFBKGYIZkCSk?= =?us-ascii?Q?F2N2obfzRkjKAQiLTkVhRfjsONQJXTT06pZSGgjZQpg4lW54jM3mWWXwxQs1?= =?us-ascii?Q?zPuf7sa2x4BhvlLFQFQjaVEMplS5i2ADxAeJpgLkmw7XwVLBb7xEfqiK78vt?= =?us-ascii?Q?71GEQy9J/13CiXk8x2lPifFB9eIelBmyTkKCP93aGZ6NXnm8y7LELm3OZDaT?= =?us-ascii?Q?mUZsZ6024UKhhCHkxHVMC+bNvGd0Kn6OIM9ZPmE3YuQLL9+ctn1ACJv09nDb?= =?us-ascii?Q?zxrxl4myooYFEbpw9eGkR7HGDqPF1RguZpAC3KELeOvL04DhYe98DVdhhagV?= =?us-ascii?Q?i/+hB5IF3yVWSn2bDRLiq8Pn7JwkZTazcQ1SB8/deKlCc2PS6KJC1k3gncDt?= =?us-ascii?Q?s7A7XSsmDZ/V6f55ytCtCbqdbtJ7aK4ea0ZHrWqqlzz09axMPbqiWcgT4dJd?= =?us-ascii?Q?L9oFiXWBm0gGU739iRFAnTsQhslrawHYy0HdkeG81jS5Qx9FTi3iZvRUGaAD?= =?us-ascii?Q?Eh8Zd2mxL710efi2Ad6WL5CjwZxGr2ZOjyrY/iiMwMUjhamm//ieOjvQZEVV?= =?us-ascii?Q?j6zvqWIXx+Iizd2VTmugj7dsYIhbxe0lzwF2Ut2uDEpWlPRw/iPwfyryRbS5?= =?us-ascii?Q?yVKYOnPf2plUgd3pm+zWOHYbLKg98cgI93RGSysA?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6537.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad74f520-52a1-4946-6379-08dae8b8fc7a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2022 09:50:43.3696 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4hle5Y39LJdq470jk8Sn1bHJf2AB+s6txI7ggMS22gd+ZQuR3YXpMrQjy0ibJeCnWb7WvAm2hOgM5UckF+YtMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5892 Return-Path: victorx.hsu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_IA1PR11MB6537E7377F98EC8FAB8B6B44E2F29IA1PR11MB6537namp_" --_000_IA1PR11MB6537E7377F98EC8FAB8B6B44E2F29IA1PR11MB6537namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi @Kinney, Michael D Please review https://github.com/tianocore/edk2/pull/3793 for below questio= ns. 1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master * tiano= core/edk2 * GitHub Answer: Done 1. What about the license ? Answer: It's BSD license, based on public-mipi-sys-t/LICENSE at master * MI= PI-Alliance/public-mipi-sys-t (github.com) 1. Is PcdTraceHubDebugAddress MMIO address ? If yes, why we use UINT32 Answer: Done 1. For TraceHubWriteCataLog64_[0-6] try to use below macro to implement = it. #define VA_START va_start #define VA_ARG va_arg #define VA_END va_end #define VA_LIST va_list Answer: Done 1. Is have SMM or MM version ? Answer: Done, renamed to DxeSmmTraceHubDebugLibSyst.inf. 1. Whether have any chance to use .gitsubmodule to leverage https://gith= ub.com/MIPI-Alliance/public-mipi-sys-t. Answer:. https://github.com/tianocore/edk2/pull/3793 thanks From: Guo, Gua Sent: Thursday, December 1, 2022 11:29 AM To: Kinney, Michael D ; Gao, Liming ; devel@edk2.groups.io Cc: Chan, Laura ; Prakashan, Krishnadas Veliyathupara= mbil ; K N, Karthik ; Lu, James ; Chen, Arthur G ; Chiu, Chasel ; Zimmer, Vincent ; Hsu, VictorX Subject: RE: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugL= ibSysT] @Kinney, Michael D As we offline sync, there are below opens like below. Have any open, please= also share for us. 1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master * tiano= core/edk2 * GitHub Answer: Will update it in next patch 1. What about the license ? Answer: It's BSD license, based on public-mipi-sys-t/LICENSE at master * MI= PI-Alliance/public-mipi-sys-t (github.com) 1. Is PcdTraceHubDebugAddress MMIO address ? If yes, why we use UINT32 Answer: It's MMIO address, we can change it to UINT64, it make sense to let= the PCH more generic. Will update it in next patch. 1. For TraceHubWriteCataLog64_[0-6] try to use below macro to implement = it. #define VA_START va_start #define VA_ARG va_arg #define VA_END va_end #define VA_LIST va_list Answer: Will update it in next patch 1. Is have SMM or MM version ? Answer: MdeModulePkg/Library/TraceHubDebugLibSysT/DxeTraceHubDebugLibSyst.i= nf can take care for SMM case. We can rename it like below to make it more = clearly. MdeModulePkg/Library/TraceHubDebugLibSysT/DxeSmmTraceHubDebugLibSyst.inf 1. Whether have any chance to use .gitsubmodule to leverage https://gith= ub.com/MIPI-Alliance/public-mipi-sys-t. Answer: Will draft another PR and try to use gitsubmodule to check whether = exist any predicament. Thanks Gua From: Guo, Gua Sent: Wednesday, November 23, 2022 3:29 PM To: Kinney, Michael D >; gaoliming >; devel@edk2.groups.io Cc: Chan, Laura >; Prakas= han, Krishnadas Veliyathuparambil >; K N, Ka= rthik >; Lu, James >; Chen, Arthur G >; Chiu, Chasel >; Zimmer, Vincent >; Hsu, VictorX > Subject: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSy= sT] @Kinney, Michael D and @gaoliming We want to add TraceHubDebug library support on Edk2. It's new added librar= y on Edk2, so it doesn't have any backward and forward issue. May I know have any process we may need to follow up. Have any comment or c= oncern please also share for me. Reviewers/Maintainers: @Prakashan, Krishnadas Veliyathuparambil, @Chan, Laura, @K N, Karthik. USF UPL spec update: https://github.com/UniversalScalableFirmware/documenta= tion/pull/52 (Done) Edk2 Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4144 (On-Go= ing) Edk2 PR: https://github.com/tianocore/edk2/pull/3613 (On-Going) Background: * Problem: In the UPL (Universal Payload) binary which contains only = the Edk2 drivers, Tracehub debug message are missing during the execution o= f early DXE Core modules (before ReportStatusCode is ready). * Solution: Add TraceHub lib on Edk2, to be consumed by the UPL. About TraceHubDebugLibSysT: * Library is consumed by the DebugLib and StatusCodeHandler to send the= PostCodes, ProgressCodes and DEBUG messages to the TraceHub/NPK in MIPI Sy= S-T format. * The MIPI SyS-T APIs in this library are taken from the OpenSource imp= lementation: https://github.com/MIPI-Alliance/public-mipi-sys-t. * Library changes done for upstreaming: MipiSystLib is rewritten to co= mply EDK2 coding standards and changed ways to pass trace address/verbosity= with HOB directly instead of calling into TraceHubHookLib to get these inf= o. * Proposal With UPL: consume HOB gUniversalPayloadTraceHubDebugInfoGuid= to print TraceHub Debug message in DXE Core Thanks, Gua --_000_IA1PR11MB6537E7377F98EC8FAB8B6B44E2F29IA1PR11MB6537namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi @Kinney, Michael D

 

Please review https://github.com/tianocore/edk2/pull/3793 for below questions.

 

  1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master · tianocore/edk2 · GitHub=

Answer: Done

  1. What about the license ?

Answer: It’s BSD license, based on public-mipi-sys-t/LICENSE at master · MIPI-Alliance/public-mipi-sys-= t (github.com)

  1. Is PcdTraceHubDebugAddress MMIO address ? If yes, why we use UINT32

Answer: Done

  1. For TraceHubWriteCataLog64_[0-6] try to use below macro to implement it.=

#define VA_START va_start

#define VA_ARG   va_arg<= /p>

#define VA_END   va_end<= /p>

#define VA_LIST  va_list

Answer: Done

  1. Is have SMM or MM version ?

Answer: Done, r= enamed to DxeSmmTraceHubDebugLibSyst.inf.

  1. Whether have any chance to use .gitsubmodule to leverage https://gith= ub.com/MIPI-Alliance/public-mipi-sys-t.

Answer:. https://github.com/tianocore/edk2/pull/3793

 

thanks

 

From: Guo, Gua <gua.guo@intel.com>
Sent: Thursday, December 1, 2022 11:29 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Limin= g <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Chan, Laura <laura.chan@intel.com>; Prakashan, Krishnadas = Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com>;= K N, Karthik <karthik.k.n@intel.com>; Lu, James <james.lu@intel.c= om>; Chen, Arthur G <arthur.g.chen@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Zimmer, Vincent <vincent.zimmer@i= ntel.com>; Hsu, VictorX <victorx.hsu@intel.com>
Subject: RE: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHu= bDebugLibSysT]

 

@Kinney, Michael D

 

As we offline sync, there are below opens like below= . Have any open, please also share for us.

 

  1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master · tianocore/edk2 · GitHub=

Answer: Will update it in next patch

  1. What about the license ?

Answer: It’s BSD license, based on public-mipi-sys-t/LICENSE at master · MIPI-Alliance/public-mipi-sys-= t (github.com)

  1. Is PcdTraceHubDebugAddress MMIO address ? If yes, why we use UINT32

Answer: It’s MMIO address, we can chang= e it to UINT64, it make sense to let the PCH more generic. Will update it i= n next patch.

  1. For TraceHubWriteCataLog64_[0-6] try to use below macro to implement it.=

#define VA_START va_start

#define VA_ARG   va_arg<= /p>

#define VA_END   va_end<= /p>

#define VA_LIST  va_list

Answer: Will update it in next patch

  1. Is have SMM or MM version ?

Answer: MdeModulePkg/Library/TraceHubDebugLib= SysT/DxeTraceHubDebugLibSyst.inf can take care for SMM case. We can rename = it like below to make it more clearly.

MdeModulePkg/Library/TraceHubDebugLibSysT/Dxe= SmmTraceHubDebugLibSyst.inf

  1. Whether have any chance to use .gitsubmodule to leverage https://gith= ub.com/MIPI-Alliance/public-mipi-sys-t.

Answer: Will draft another PR and try to use = gitsubmodule to check whether exist any predicament.

 

Thanks

Gua

 

From: Guo, Gua
Sent: Wednesday, November 23, 2022 3:29 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Chan, Laura <laura.ch= an@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.vel= iyathuparambil.prakashan@intel.com>; K N, Karthik <karthik.k.n@intel.com>= ; Lu, James <james.lu@intel.com>; Chen, Arthur G <arthur= .g.chen@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Zimmer, Vincent <vincent.zi= mmer@intel.com>; Hsu, VictorX <victorx.hsu@intel.com>
Subject: Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDeb= ugLibSysT]

 

@Kinney, Michael D and @gaoliming

We want to add TraceHubDebug library support on Edk2. It’s new added = library on Edk2, so it doesn’t have any backward and forward issue.

May I know have any process we may need to follo= w up. Have any comment or concern please also share for me.<= /p>

 

Reviewers/Maintainers: @Prakashan, Krishnadas Veliyathuparambil, @Chan, Laura, @K N, Karthik.

 

USF UPL spec update: https://github.c= om/UniversalScalableFirmware/documentation/pull/52 (Done)

Edk2 Bugzilla: https://bugzilla.tianocore.org/show= _bug.cgi?id=3D4144 (On-Going)

Edk2 PR: https://github.com/tianocore/edk2/pull/3613= (On-Going)

 

Background:

  •   Proble= m: In the UPL (Universal Payload) binary which contains only the Edk2 d= rivers, Tracehub debug message are missing during the execution of early DX= E Core modules (before ReportStatusCode is ready).
  •   Solution: Add TraceHub lib on Edk2, to be consumed by the UPL.

 

About TraceHubDebugLibSysT:

  • Library is consumed by the DebugLib and StatusCodeHandler to send the= PostCodes, ProgressCodes and DEBUG messages to the TraceHub/NPK in MIPI Sy= S-T format.
  • The MIPI SyS-T APIs in this library are ta= ken from the OpenSource implementation: https://gith= ub.com/MIPI-Alliance/public-mipi-sys-t.
  • Library ch= anges done for upstreaming:  MipiSystLib is rewritten to comply EDK2 c= oding standards and changed ways to pass trace address/verbosity with HOB d= irectly instead of calling into TraceHubHookLib to get these info.
  • Proposal With= UPL: consume HOB gUniversalPayloadTraceHubDebugInfoGuid to print TraceHub = Debug message in DXE Core

 

Thanks,

Gua

--_000_IA1PR11MB6537E7377F98EC8FAB8B6B44E2F29IA1PR11MB6537namp_--