From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 041C5D800FD for ; Thu, 7 Dec 2023 04:25:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yFD3bd+lfWIprkkkYXOnXh0HZtM0y7tgaaOkuLEjwnQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701923114; v=1; b=oG4FOyXGfMMQWCf/DVwdl770Sse3H7SJJ8h1COEk7vvvo+6WAaUvk3Li0PlC/rU7gyTkb2ab omZNd//LQAUNkD/HEqv1FxiZaRl3yIQeK5iPAFPH/5NrnVTK5Qzse8n1m9WOyKdZO0I4GVqwAbG cSXp0PiSuQ+kul8jf8RbctCI= X-Received: by 127.0.0.2 with SMTP id hGIOYY7687511xdo9UIkAu3y; Wed, 06 Dec 2023 20:25:14 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.72]) by mx.groups.io with SMTP id smtpd.web10.76551.1701923113455871454 for ; Wed, 06 Dec 2023 20:25:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UT6N5kMHJAoZ20lT5rYKm1gd/Aij8LzJCQO3jRdMO1dj3z7SJvH7Fwnyalsm0DGTvkYjhRAQTz2yPP4Xj1HYGJ69yeDgjlGmVHwPwDY1nuJ0yKTdnVKa6kM+KoTPudZX69G2/XjoU8hnk+N816QPZHyw5xkFdBgPcnneea4PnEGqN0hNFQtsOJqsqmy/eCzt2lggcHzT/7SIxb0xx4oyrXTUYDH9AQe75LvzLNZXCxemTDIQMTXfUYPAb2N5AorsLGbN1opQD57LH9y7goDDwC+uqczKPVL6Gprj4DFwNxWDFfZixzcHIbXuF+e+zLuvxT6dboZbsWPjjCA4d7BYrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oqrd02RTC7lfcNuSyniDrKboaur1DMfaP/dca67ln2Q=; b=MYaV5IVu/6mtSIYBvAHx4ZadBW3FeFSI+qvK7bWuF+MjpoVqfEuSPMeX96pednIDctqJKBhfJ09bRpb9wIPlNRTd4Dr0BmDK7soqvMa8DmXZAY5BPD555/ReaqKP2SCupUUh+s2qkKPpL4TY89WDFxeLXC/3Wk5tTjbpdcRtY6H8rKOeXHzR6Ep6JHApfxZucbP2cspWOvYV2y4jk5mQjGS2+Y183WIaZkXijyAePZ7qoiBWhFB23WFMrANVg+t511LB3q4VJivN2BMRO8cWy4U+PWmDkzWZsHLuEm0EpG30W6dc+0/YYnqa1bgMMnhU2I4sQtMfbnlRXKMa3+c0pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by CYYPR12MB8750.namprd12.prod.outlook.com (2603:10b6:930:be::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Thu, 7 Dec 2023 04:25:10 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::c436:397e:a940:5e6d%4]) with mapi id 15.20.7068.027; Thu, 7 Dec 2023 04:25:09 +0000 From: "Abdul Lateef Attar via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Sai Chaganty , Isaac Oram , Nate DeSimone , Liming Gao Subject: Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Topic: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Index: AQHZxdStI00mTUSPDUmp/pQ29RYc+q/YH6yAgBYBArCAr94NsA== Date: Thu, 7 Dec 2023 04:25:08 +0000 Message-ID: References: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=4d35c1c1-1e2b-4353-a3a1-bde4e5e2cc0c;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-12-07T04:24:22Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|CYYPR12MB8750:EE_ x-ms-office365-filtering-correlation-id: 98d10afe-a0f6-4d6e-8fdf-08dbf6dc7f06 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2on2KV4mljW4tMdindJ8m1yoz+JffmN5dRpzWkyPl6SJXeMehSSRqFe+rWyP9roACPs1mA8FA+vYOcferrQAooYqSessposiiDj6nW16VRocooFTb6Ep8yHxgA2BGCl2B3NtqKaRqb4UE+p6P6GHAoPOY/jbc/9EvmDyBYll4uXFnikBsYDkFiL5rlKsaFgZ9o+0y8xPnBAgtUFLJqbi1g/F/XFqEoWdTgRJItopJGKMNE4ltliBKpJXYpPlYJnCrbTYa9TFtOV3q6GkcIs8WEfIBkT6gOpuVEanuiXWKyg1mV+qNJG8983kaPRvsFiyL54D13M+4ypyT7tETCa9kpX62vqXc0ZV5T7oaY8enQLbnv3fh35EknVA9nK7vd38Gk5UwWN26YOnXQsPKY1ck67D75ldynFVy3vF38atClbjIcikuHmWUBOx4czrczv0sbtEc32iZqe52xW6ohDCPWJLGApfe8jYkaCHnVWZafgm8h1av/F1iG0AVtKXBfX8XXZ1yqFGH04YbBXXTw6/YH9/NdUKVLe2V68FNiu3G1p5m2dNBW5ykNEY0xu6KxMJtbGgYacz1gnmwr9VoqW5HG5CSrxJJ2oSTsVohiTwtBef8o4D5JONqpBXrvwmYPmB x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hsn0H19x4+r+0szpRkKAyojIFCQGmyxK/cMzQIFWWM+zTx99iZgyyIQwuehZ?= =?us-ascii?Q?PPVi2GOQt3MM983njFi5Bq/yhKW/dxyo3gT/xm8HMBSEYfvFZ+EayP0MPfxK?= =?us-ascii?Q?cDLO0VD1pNDQXjpZUcBiEQJ0thlYhKB94SaxI5Gc86BrZS8AX8gx7m7tWOiz?= =?us-ascii?Q?7GFAIJN0jhOpGxBpAi32T6aSPNXowxnflsgBD6QNdnI9D1oDe7KVu4GgQpZ/?= =?us-ascii?Q?1MPtYUzce1vgOgnpp+VUllLOxHq45VhnNEzD5E6psBUqMk8/ilAdBUdin0OC?= =?us-ascii?Q?WyCYa4rhPnZex0eejWIGZYx5M8fSMynwmsvQbjevqrDMvxZeIQu8jcj2rrCs?= =?us-ascii?Q?D5YHWl3KTQFC7gcKmMy+rTTa54+vMiBqGas8QuLXENu8gfURSP7j5WH9qSKF?= =?us-ascii?Q?DVCuDcxkWgXGDsb2gFb0W8k0DFfk5ZKhEViPZaDUIE7UnPm4b5IuzcOSdT0v?= =?us-ascii?Q?j9Z7CGh6bnbiApZuIK0Cdl1N2UUQvi/D9CSzN5md03nzHyoJ43VbxMkIsqZ1?= =?us-ascii?Q?X3WUetVC3n8D8DS20ebZzCjeqT9ktcpeBF2OGTWceVfd2r46uIy2AvZf/F00?= =?us-ascii?Q?IkFi3X8rPxZWYozM0ImRLlQVDwQkN0HRvx9lValN+5M61tzejW+YZUdYsG9p?= =?us-ascii?Q?7TGFAnzDqnVhAH+oOE/l4H6g3ydxY2zsp4QyIsdL50yci0HUZH1SyAQallf5?= =?us-ascii?Q?ByK79cm5a6BE6MCmzwXji3BpzcvnV0wRgaAzu7MrLErsPBY40irFQimLWYW5?= =?us-ascii?Q?7sWrSYsoP8AFa7OUtGqpbUFpsAGJexd6Zzh70s360WpZcAS5qpV8TFs/Rl5V?= =?us-ascii?Q?MMAZ9Nklohw1NvVXMVqAQyqmcWWPiaBpsB7FxoWBODgZh7A0ijVdTXavRnSS?= =?us-ascii?Q?vd5tbI2Ue1q0JwAT0eXxQ9QHcjIrMazeq9o46Ig/GRGWJgggMfvjrILs04kS?= =?us-ascii?Q?zj4/A4adhBJKUbzvBlHikhqJ/Jhr88c0thZvhp7ghKbv1wVlJfoRcGnm0ibE?= =?us-ascii?Q?FyOnn2qL4hdvVlYHx9+31IKxkbx6VE6vMi/v2wzUmTkVpcNJ6aefVjYUpm40?= =?us-ascii?Q?AK/TIWVliHKTw6naSHEnZKfAcuelrWYq7QEGFcLiNkcX6KbOaKZUZ3aU5yPU?= =?us-ascii?Q?9v9WggpYpoM3+12/0KR0Iih2X51wEdjtjXy48MvbcE5uw1coFlE/BadY1f12?= =?us-ascii?Q?07elSpsvPUtSUNJMqctR88NMaeaBcXeSmk7ijm3LDc2pipvuf3ItCc0NHAV1?= =?us-ascii?Q?Hj5NLjuzua+l8pE6elWJPHQolSzZtpFHWDp7/xzCrwerMoZ118lnZ8rIBo0j?= =?us-ascii?Q?brTteIW/sIVZxYBn1I9CkRY7ba299u2RWaINZ+P8mSuGfzWvh/Pi23+9vwhN?= =?us-ascii?Q?ZQWScebFYMecW6vMDvHfq55kmqQlcDXz/GWTzoirFZOZIEdPd7gxPeogysoK?= =?us-ascii?Q?ap7APo5p+3ltryW5X50+WXQESqqrLlLWPteoEfz4uWnPxL4M919Ldb6jWoUJ?= =?us-ascii?Q?eRkKDTD/CPpqIZypfdZBvOW+Sz7J0D66ftQGdJogWzyIE1xNJ0HkmkycJX5y?= =?us-ascii?Q?ZOxQlBQ241v3eXQU+ps=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98d10afe-a0f6-4d6e-8fdf-08dbf6dc7f06 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 04:25:08.7406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u8j0jPRluJjbXfSRST3PXe4hN8lrJN0Kh8S/AfMwBRNQBumhGhlSKmjUT+dfI6t2JMtH6qckJOqL7mWxMv4ipw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8750 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nLqIHGlRl42C5jEMwQtSkg8Mx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oG4FOyXG; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [Public] Hi Maintainers, Could you please review and merge this patch. Thanks AbduL -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: Thursday, August 17, 2023 12:14 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Sai Chaganty ; Isaac Oram ; Nate DeSimone ; Liming Gao Subject: RE: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/= GSI Gentle reminder, review please. -----Original Message----- From: Chang, Abner Sent: Thursday, August 3, 2023 12:12 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai Chag= anty ; Isaac Oram ; = Nate DeSimone ; Liming Gao Subject: RE: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/= GSI [AMD Official Use Only - General] Acked-by: Abner Chang > -----Original Message----- > From: Abdul Lateef Attar > Sent: Thursday, August 3, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai > Chaganty ; Isaac Oram > ; Nate DeSimone > ; Liming Gao > ; Chang, Abner > Subject: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based > IRQ/GSI > > From: Abdul Lateef Attar > > Create a new PCD to hold the IRQ or GSI number for SPCR, with default > values of 4. > Update the ACPI SPCR table's IRQ value based on PCD. > > Cc: Sai Chaganty > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Abner Chang > Signed-off-by: Abdul Lateef Attar > > Change-Id: I7218903fa5572f8139ad45db598ab085f079713b > --- > .../OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec | 5 +++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf | 4 ++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.h | 3 +++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 7 ++++--- > 4 files changed, 16 insertions(+), 3 deletions(-) > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > index b084fad89220..d69d650f3f20 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > @@ -7,6 +7,7 @@ > # for the build infrastructure. > # > # Copyright (c) 2020, Intel Corporation. All rights reserved.
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +25,10 @@ > [Includes] [Guids] > gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { > 0xb8, 0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} > > +[PcdsFixedAtBuild] > + # SPCR default IRQ set to 4 > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt|4|UINT8|0x00000010 > + > [PcdsFeatureFlag] > > gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x > 00000001 > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > index 9a4f95e86bbf..cd43afea5242 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > @@ -24,6 +24,7 @@ [LibraryClasses] > UefiDriverEntryPoint > UefiLib > SpcrDeviceLib > + PcdLib > > [Packages] > MdePkg/MdePkg.dec > @@ -51,5 +52,8 @@ [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio > > +[FixedPcd] > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt > + > [Depex] > TRUE > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > index c11da439fcb8..245a847762c5 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > @@ -3,6 +3,8 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights > reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -23,6 +25,7 @@ > #include > #include #include > > +#include > > #include > #include > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > index 51449d0fad9e..e92db96caaa9 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > @@ -3,7 +3,7 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights > reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -83,8 +83,8 @@ > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE gSpcrInfo =3D { > }, > > 0x03, //INTERRUPT_TYPE, > - 0x04, //IRQ, > - 0x04, //GLOBAL_SYSTEM_INTERRUPT, > + FixedPcdGet8 (PcdSpcrInterrupt), // IRQ, > + FixedPcdGet8 (PcdSpcrInterrupt), // GLOBAL_SYSTEM_INTERRUPT, > 0x07, //BAUD_RATE, > 0x00, //PARITY, > 0x01, //STOP_BITS, > @@ -441,6 +441,7 @@ OutOfBandACPITableConstruction ( > gSpcrInfo.FlowControl =3D UART_FLOW_CONTROL_HARDWARE; > } > > + > if (HasIsaSerialNode(SavedDevicePath)) { > GetIsaTypeInfo (SavedDevicePath); > } else { > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112156): https://edk2.groups.io/g/devel/message/112156 Mute This Topic: https://groups.io/mt/100521521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-