Re: [edk2-devel] [Resend PATCH v5 0/4] DynamicTablesPkg: Adds WordIO and method invocation ability

["Abdul Lateef Attar via groups.io" <AbdulLateef.Attar=amd.com@groups.io>]

[AMD Official Use Only - General]

Hi Sami,
        Below mentioned patch looks good; https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocatio .
Please go ahead and merge the patch series.
Thanks
AbduL

-----Original Message-----
From: Sami Mujawar <sami.mujawar@arm.com>
Sent: Thursday, December 21, 2023 10:04 PM
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Pierre Gondois <pierre.gondois@arm.com>; nd@arm.com
Subject: Re: [edk2-devel] [Resend PATCH v5 0/4] DynamicTablesPkg: Adds WordIO and method invocation ability

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hi Abdul,

Can you check if the patch 4/4 at
https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_method_invocation_v5
looks ok to you,  please?

If you confim, I will apply the push label.

Regards,

Sami Mujawar

On 21/12/2023 01:56 pm, Sami Mujawar via groups.io wrote:
> Hi Abdul,
>
> Glad to see your contribution to the Dynamic Tables Framework. It
> would be great to hear how you are using this package.
>
> I have some minor comments for the last patch 4/4. If you can reply
> back, I will try to get the changes merged before the end of this week.
>
> Regards,
>
> Sami Mujawar
>
> On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>
>> PR: https://github.com/tianocore/edk2/pull/5171/
>>
>> V5: delta changes
>>    Addressed review comments.
>> V4:
>>    Address Pierre's review comments.
>>    Merged patch 4 & patch 5.
>>    Also added parameter logic suggested by Pierre.
>> V3: delta changes
>>    CI fix and error handling for
>>      DynamicTablesPkg: Adds API to generate a method with ArgN.
>>    Added new patch "DynamicTablesPkg: Adds wrapper API
>> AmlCodeGenMethodInvokeMethodArgn"
>> V2:
>>    Added new API to generate a method which
>>    invokes another method with argument.
>> V1:
>> Code changes to
>> Add API to generate word I/O ranges.
>> Correct the parameter to generate word bus number.
>> Corrects the function pointer typedef
>>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>
>> Abdul Lateef Attar (4):
>>    DynamicTablesPkg: AML Code generation for word I/O ranges
>>    DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters
>>    DynamicTablesPkg: Corrects function pointer typedef of
>>      AML_PARSE_FUNCTION
>>    DynamicTablesPkg: AML Code generation to invoke a method
>>
>>   .../Include/Library/AmlLib/AmlLib.h           | 187 +++++++++++++-
>>   .../Common/AmlLib/CodeGen/AmlCodeGen.c        | 235 +++++++++++++++++-
>>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   |  98 +++++++-
>>   .../Library/Common/AmlLib/Parser/AmlParser.c  |   3 +-
>>   4 files changed, 510 insertions(+), 13 deletions(-)
>>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112833): https://edk2.groups.io/g/devel/message/112833
Mute This Topic: https://groups.io/mt/103278517/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-