From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.66]) by mx.groups.io with SMTP id smtpd.web10.117.1689091411857632755 for ; Tue, 11 Jul 2023 09:03:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=GwFlnzKy; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.66, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6maaP+y3Qqy0Tc4iaPzJmcu1Nw7XwLWGOAUfGw3uUDBd8yVQ6e2ZHxHABin8a+A4d2UjLoBq/CBlfAxwTSQ31ZDgv8sBNgQNP+oKrhWNkaKDWKuLjOtvyQsH6Ycks+GSM5jZc7jyBVF6FUFG4Uo6ZeWs+4f0exLST3b0ou+gdAArjsA4jcfjU0UwsekATI6af8dACs5pXDgdayNH9Pw3wq1IntbnvoaldbyyfiaglTXiCLASMyjRJiPyKUuXOCR/fBSH3PFiTjgC6bFBsVrW06RbCTmI1RwPXNHOegUALef2m0whOB3A2mQyBy2IsqGv3cpmfhGUH9AhLeQo/VOGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBAqsX3tTnqo4w/ix5EEU1xcDeKxBxiW27GiZ5eVPJk=; b=AORK6ZOuE4IAH42IiAFo20J/+OD/z3mzUTrIcKqc+Zpi6hdAnyji7IxvnM+uVJIXWiHvxUp+dpYC/wk911Z0o902kDgClT5niCyKLcDkCmFjYmOTLpnZ52t4XwUfN14Vd0/HbMjyB7atH3fjBgLrDkDan1iZAkzMgwD8fRKui8SGCJk4EbAh+ajgeugJOyv31hO4dIOt7hqhtiGYzLtLDuPxhHCO1kc3QI5FgyjPfAKRf4l8LXTBibd/PNGxnob2CG+kWHqJ91hE8h7Tbx3gSdi2vmPkp01By1rz9MDMPJjvLQeyIvCZBi+ydHUbW9tnntQ/89bXQe4DG0DkSpTZEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBAqsX3tTnqo4w/ix5EEU1xcDeKxBxiW27GiZ5eVPJk=; b=GwFlnzKyEsqah6DrdwH9S76XIPExtoKmNGR0J5L87L2cxAw443oFiKcPNVGPZmJUNNlyAQdo1S+m/9GOBce4hvQptx+RdPNlpZgTiMEGj5/CPAjjcDhPFRWpoVVQKRARR6qBnEMXL56WOgQEyb1P33b7pSb74ERHN7Mg4NJjcjQ= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by CYYPR12MB8871.namprd12.prod.outlook.com (2603:10b6:930:c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.26; Tue, 11 Jul 2023 16:03:26 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::52d6:3130:de5e:c6da]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::52d6:3130:de5e:c6da%5]) with mapi id 15.20.6565.028; Tue, 11 Jul 2023 16:03:26 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "devel@edk2.groups.io" , "dun.tan@intel.com" , "Ni, Ray" , "Chang, Abner" Subject: Re: [edk2-devel] Use gMmst from MmServiceTableLib in MmSaveStateLib Thread-Topic: [edk2-devel] Use gMmst from MmServiceTableLib in MmSaveStateLib Thread-Index: AQHZrxyehADTUL7+sU627KUQ+0uppa+0QAeAgAAOyWCAAA1hgIAAZ9PA Date: Tue, 11 Jul 2023 16:03:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6dc398f7-412d-44ef-b71b-fb1cde65807a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-11T09:03:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|CYYPR12MB8871:EE_ x-ms-office365-filtering-correlation-id: 3fdbe1c7-035f-4bf9-8e2f-08db82285c78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7IfT6/2zBlrymzZetqmtUSP5wbRkWlDymb16JaS3BLZW3qbNDTwKQNwsgQn9jUkVmU/FMw73e/ysWZ3XMwPM298c0K49OW26VN1qxyYzYqD7ujrlDK2cOkZ+YoAxJj+qnIc8HgnQSuu+5bg+dIaErULw6Lk4B4Vi1aLm9BSCO08A8t5ohsXBngUcqYYRu27NpGfqz5ISSNCEOfcvlExB+vUNWMmrBRVbpNCEl1EClGII7wjOGe/KNKMdvj+LkzvPyT+uhcGhbtSKL2Z5DQ2j8elC7eFnb/RyDhz4U/yKjFm73CuE74ueFX6eSxDZ4ypkiV19OH7OG7vNqlXzim6+dNEaFpRBvSeWng8AnF4IEIq//s3MDlcDJ7KhXJxrV+FZcKuTVPu0y8W6f6v6p8WIE+Wo5IZVTUNvOkua0luU3opz39bDfjzCjQmjZl7/soJ4lm16nVmXDaHh4qFtxugzRdeN/0e7xYq+HyStjxQT0RbH4y1vgthtsIN5av4Biy4xrrJB3ACF24NgmaCn4HZrsyP9c4D4oOQfgcOruJiwkAhecZoJz/rMUxX4QnvSiOd9kSnd70fwzyBKC3HMqDUaGzY252POPpL0bzKs+5nJxUYFzZyxLimAS2yZU2X0zOh6PYAH+HjZB8+esG63vm/YIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(451199021)(8936002)(8676002)(9686003)(966005)(5660300002)(83380400001)(66899021)(52536014)(38070700005)(2906002)(55016003)(7696005)(71200400001)(66946007)(76116006)(64756008)(86362001)(66446008)(478600001)(66476007)(66556008)(316002)(38100700002)(6636002)(6506007)(53546011)(26005)(33656002)(186003)(19627235002)(110136005)(122000001)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cghfMfHkk9lTdhI31nc6GrhpxsHOcUYFlKINDPlT63kvKGCPq/BHLtXWpPHi?= =?us-ascii?Q?BRiFys5UlOK0U/Q8vdLrMBg8xyKTjcmbyxrTTRcbAAx3zT8P2e1WKhbPB1U3?= =?us-ascii?Q?YJQrB2YXrK7LxiYGvJdSFyWF/JIbqT+b+RpMnUwfKBU+8MnsNO2MjfqAOee9?= =?us-ascii?Q?no9pJceqjj6+0i7XCdgLKPlNwefJvkXuvJaJ8obfN08glHO0mYhWv37nHpEu?= =?us-ascii?Q?Lq+wRBPn8rzwpeIjlZZV8V+dYGNGiNtyK8xKg10Jh+EemaQbii+myaCoF/Ak?= =?us-ascii?Q?51+RQxnjtFqI/1+mzg5h/gb0RmX11DFyRQJg+oDLQh2Gm0yToZengARLCOeB?= =?us-ascii?Q?IX3tLsWsWTshbwWRjFklrp26i3QTSfse+mxNFCz0MrpGPvv46qR3PKJBEciW?= =?us-ascii?Q?lMQPx72DMgPxQNq8ln9CXgVVFBA/Yx4oDCCX/ILbtAqTMoIxc8MlnndhgYKj?= =?us-ascii?Q?d3l1098NPzBsbdiYQWqmhSG+jL0cakx1lUDWVlR7zD2jdZmZlpz8RZ1F9yXb?= =?us-ascii?Q?KvFiPp0mIhJUSfabYcD+lXeFcThkyLSH81ReIxQMWal2UkpRdUtnbw8dF38I?= =?us-ascii?Q?YKZwLmfQ4kr0lral3MeqpiUYWCWuUp1MoPCogipX4fK/WPmcw27qniz7dxM5?= =?us-ascii?Q?3TukdRJZ6EYMggYxUiALHrDU2Om4i6OA48XrPe+9VGx6NSghLuShXEc/Jx2Z?= =?us-ascii?Q?boRAjY52owwjFqZLUN/lHl/4+XLARRBgmsOrabl/YONkrubITNZCZV7wUzPM?= =?us-ascii?Q?3oGMax45QTlLUMQzRSZr1GNiuJS2CWABVK7MCSo0WLm1h0DmOoS9BgAr/Zaa?= =?us-ascii?Q?+/iRdGdN+xN6+gYnN226PAEoX6YF7y8DQwnygMA4NAyUXH0qxHnrUIyFHBq8?= =?us-ascii?Q?h2nM2uRs6p04e9KoJ8Ix48pt7ihc2Q1F217EeDndpjchwfeq6stzWGeqUkF4?= =?us-ascii?Q?Yp5/Q/wFcszvWIn/vI1VNBXJSAFkC5z/x5xpMCU0fjwDHW7MtBerWNiREDvF?= =?us-ascii?Q?xXY4V4TEaBnsUQit0+y53YQeYUYw95Mq765LGACbPmRZ/n9EWQSbK3TpU4ul?= =?us-ascii?Q?48jHdaoeCJdvxAd9xdyIlNAemLZNCziIXwvj9goo+RjUT85ClJj1kObz/KMW?= =?us-ascii?Q?0Du4UN2aRnoFfXKq3DscEA8S73igN3fYjw+uARj+IB/X7XXaoXYEjmQoT8qL?= =?us-ascii?Q?SagBxONy3qhMPyiuwXU2RE28F9sMjHdkaIluhy2aglkD0QvGC72rZm/TTAhz?= =?us-ascii?Q?so34A4j0PARPkim2isuGX3/h3e4fhGIXhrNxJp4O0ITugSL/aNEIh9dHMwHa?= =?us-ascii?Q?D5qm8D+4SVTU6+//JdY3Y3Nv/96/B+dU12X2G5daOB4JEuY2BUXkDtp7XKo+?= =?us-ascii?Q?MelJiD7wzqqtlciqoAGG0kARS/Bwbca02H3N8n7I9pK8BHyN/i4yqrnk3L1p?= =?us-ascii?Q?yXGOjS2GZuBvMBoDiqo4f/1bABPB4ZLYGVk+Asp9pQlJUvzT7dfUVHGQiYQb?= =?us-ascii?Q?p3jrr+PJwk5qCQqfpZZQzz+04og2Dj16qridm6lW6rkJas2lBHGsaqQtiCAB?= =?us-ascii?Q?zQZN9OuASA49zJabxtM=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fdbe1c7-035f-4bf9-8e2f-08db82285c78 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2023 16:03:26.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ObtVyekILJtz/HBb3E8JQCFQqKfsNZY1F9wZUdunVwR34AofzPCFAf+v/uanoGfGoyHZwrWd1d/SoJvWTEERMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8871 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks Dun for clarifying, I'll submit the patch. Regards, AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of duntan via g= roups.io Sent: Tuesday, July 11, 2023 3:21 PM To: Attar, AbdulLateef (Abdul Lateef) ; Ni, Ray = ; devel@edk2.groups.io; Chang, Abner Subject: Re: [edk2-devel] Use gMmst from MmServiceTableLib in MmSaveStateLi= b [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. AbduL, For the part ' preserve the SAVE_STATE pointed by gSmst(Instead of gMmst)',= do you mean the following code in RestoreSmmConfigurationInS3()? gSmst->CpuSaveState =3D gSmmCpuPrivate->SmmCoreEntryContext.CpuSav= eState; Acctually when PiSmmCpuDxeSmm uses MmServicesTableLib, the gSmst is the sam= e as gMmst. You can check the lib constructor MmServicesTableLibConstructor= () and SmmServicesTableLibConstructor. In the two constructor functions, th= ey both locate the same global pointer by gEfiSmmBase2ProtocolGuid/ gEfiMmB= aseProtocolGuid(same GUID) and assign the value to gSmst or gMmst. In this= case the only difference of gMmst and gSmst is the naming. So I think PiS= mmCpuDxeSmm can still consume the MmSaveStateLib even MmSaveStateLib use gM= mst. Thanks, Dun -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, July 11, 2023 5:06 PM To: Ni, Ray ; Tan, Dun ; devel@edk2.gr= oups.io; Chang, Abner Subject: RE: Use gMmst from MmServiceTableLib in MmSaveStateLib [AMD Official Use Only - General] Hi Ray, I think Michael raised the similar concerned during the patch revie= w. Its intentionally kept it as gSmst because of the below reason. 2. AmdMmSaveStateLib and IntelMmSaveStateLib depend on SmmServicesTableLib.= Can they depend on MmServicesTableLib instead? [Attar, AbdulLateef (Abdul Lateef)] MmSaveStateLib is mainly used by PiSmmC= puDxeSmm driver which still uses Smm convention and preserve the SAVE_STATE= pointed by gSmst(Instead of gMmst). Hence I don't think we can move to MmServicesTableLib. Thanks AbduL -----Original Message----- From: Ni, Ray Sent: Tuesday, July 11, 2023 1:40 PM To: Tan, Dun ; devel@edk2.groups.io; Attar, AbdulLateef = (Abdul Lateef) ; Chang, Abner Subject: RE: Use gMmst from MmServiceTableLib in MmSaveStateLib Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Abdul, Can you please send a patch to fix MmSaveStateLib to use gMmst (instead of = gSmst)? Using gSmst forbids the lib instance be linked by standalone MM modules. Thanks, Ray > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, July 5, 2023 4:42 PM > To: devel@edk2.groups.io; abdattar@amd.com > Cc: Ni, Ray > Subject: Use gMmst from MmServiceTableLib in MmSaveStateLib > > Hi Abdul, > > In the new MmSaveStateLib created in this patch set, gSmst from > SmmServiceTableLib is used. This causes that only DXE_SMM_DRIVER type > module can consume this lib but MM_STANDALONE type module cannot. > > In current edk2, there are different MmServicesTableLib and > SmmServicesTableLib: > StadaloneMmServicesTableLib(MmServicesTableLib|MM_STANDALONE): > initialize gMmst in standalone SMM env. > MmServicesTableLib(MmServicesTableLib|DXE_SMM_DRIVER): > initialize gMmst in legacy SMM env. > SmmServicesTableLib(SmmServicesTableLib|DXE_SMM_DRIVER): initialize > gSmst in legacy SMM env. > > If MmSaveStateLib uses gMmst from MmServiceTableLib instead of gSmst, > then MmSaveStateLib can be consumed by both DXE_SMM_DRIVER and > MM_STANDALONE module. > Could you pls send patch to fix this? > > Thanks, > Dun > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Sunday, July 2, 2023 12:14 PM > To: devel@edk2.groups.io > Cc: Abdul Lateef Attar ; Paul Grimes > ; Abner Chang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: [edk2-devel] [PATCH v15 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib > > Backward-compatibility changes: > This patch series removes the SmmCpuFeaturesReadSaveStateRegister > and SmmCpuFeaturesWriteSaveStateRegister interface/function. > SmmReadSaveState() and SmmWriteSaveState() now directly invokes > MmSaveStateLib > routines to save/restore registers. > > PR: https://github.com/tianocore/edk2/pull/4597 > > V15: Delta changes > Rebase the branch and fix the merge conflicts. > V14: Delta changes > Added @note to the MmSaveStateLib.h. > SaveState(Read/Write) of > EFI_SMM_SAVE_STATE_REGISTER_PROCESSOR_ID/EFI_MM_SAVE_STATE_REGIS > TER_PROCESSOR_ID > is handled by PiSmmCpuDxeSmm driver. > Fixed PatchCheck warnings. > V13: Delta changes > Address review comments from Ray Ni > Changed the BASE _NAME of AmdSmmCpuFeaturesLib. > Removed EFIAPI from local function. > Removed CpuIndex parameter from MmSaveStateGetRegisterLma > Modifed MmSaveStateGetRegisterIndex () to accept RegOffset > as second parameter. > Removed FILE_GUID library instance for intel implemention from > UefiCpuPkg.dsc. > V12: > Addressed review comments from Michael. > Added LibraryClasses to .inf file. > removed duplicate MACRO definations. > Moved related MACRO defination to respective file. > V11: Delta changes > Drop the OVMF implementation of MmSaveStateLib > V10: Delta changes: > Addressed review comments from Abner. > V9: Delta changes: > Addressed review comments. > Rename to MmSaveStateLib. > Also rename SMM_ defines to MM_. > Implemented OVMF MmSaveStateLib. > Removes SmmCpuFeaturesReadSaveStateRegister and > SmmCpuFeaturesWriteSaveStateRegister > function interface. > V8 delta changes: > Addressed review comments from Abner, > Fix the whitespace error. > Seperate the Ovmf changes to another patch > V7 delta changes: > Adds SmmSmramSaveStateLib for Intel processor. > Integrate SmmSmramSaveStateLib library. > V6 delta changes: > Addressed review comments for Ray NI. > removed unnecessary EFIAPI. > V5 delta changes: > rebase to master branch. > updated Reviewed-by > V4 delta changes: > rebase to master branch. > added reviewed-by. > V3 delta changes: > Addressed review comments from Abner chang. > Re-arranged patch order. > > Cc: Paul Grimes > Cc: Abner Chang > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Abdul Lateef Attar > > Abdul Lateef Attar (8): > MdePkg: Adds AMD SMRAM save state map > UefiCpuPkg: Adds MmSaveStateLib library class > UefiCpuPkg: Implements MmSaveStateLib library instance > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > UefiCpuPkg: Implements MmSaveStateLib for Intel > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > OvmfPkg: Uses MmSaveStateLib library > > UefiCpuPkg/UefiCpuPkg.dec | 4 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > UefiCpuPkg/UefiCpuPkg.dsc | 12 + > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 34 + > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 34 + > .../AmdSmmCpuFeaturesLib.inf | 38 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 74 ++ > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > .../Library/MmSaveStateLib/MmSaveState.h | 94 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------ > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > .../Library/MmSaveStateLib/IntelMmSaveState.c | 410 ++++++++++ > .../MmSaveStateLib/MmSaveStateCommon.c | 132 +++ > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > .../IntelSmmCpuFeaturesLib.c | 70 ++ > .../SmmCpuFeaturesLibCommon.c | 128 --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > MdePkg/MdePkg.ci.yaml | 4 +- > 24 files changed, 1809 insertions(+), 1508 deletions(-) create mode > 100644 UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > create mode 100644 MdePkg/Include/Register/Amd/SmramSaveStateMap.h > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c > > -- > 2.25.1 > > > > >