From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.69]) by mx.groups.io with SMTP id smtpd.web10.49818.1681721182973571541 for ; Mon, 17 Apr 2023 01:46:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=pr2evCXA; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.69, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUcdY+iMe15sqq0br3Z65CV2jvAa/glhGxhDVCaJn+lVzvPo+rJg1nixl6P8SSRtifKXN7xx5HAd8KFEbFR9GGl6ZAz+94j1CNXvMOc/FSf01lyXrGzlFaANhJPQNLn4VpNF74ZKRYqdYjVrM7ng8ZmRJzrMiV4GvW8TgKJZFHp4GIfb5+oDc/JgpgihqUdl8t3BTysEb3ZGEUO8ZmYt90rt+z/K+zJbZkIJYZ17tRpW+oX0uvvP3HGRCQd0XWX3C2VqiecHs29t/WaJvbr1uSQ25i8eE0/tNwKfVRbb1CHPU7EY1ZG1r2seQwAzLHO0Kw8CeQNDw4P12u5e/ghZzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Lo/a5iBtcNYWK+SiOzClSufggZHPosyd1SdAPeL6q4=; b=LjQTxR55fJ6aMmb32KWQaBxUcT2HKp0myauir7raqWJuP5MKHBAzEG/nNWVLnuMDMoyIm3CPl+JBGOIbD+J7yS6kQGe/4xkP3y3hCQN00Hcph7SYLsIMADxOWPQZNHJ1F5LycV9Aj/dqecks1O+eBBRrpN7jRt808UUlT30uQPSv6sc8kCPK6odbDJl/dyH8XW4vyL14DL3uWoAwYVGpcFt9IfJJlHi+8sRU+bwEfdsZacOd/p0CDS2HkXWtVd9ZeaVEYSxQ5r0cd4ZzgfDvv1tlO53W62kQ5w6/2bnJz7jEauif4X+FR4c3tH3YILd6fBMhwTag1N2U0pobDnaG+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Lo/a5iBtcNYWK+SiOzClSufggZHPosyd1SdAPeL6q4=; b=pr2evCXApax+MtoGAlKDYhejwOQ1XSGvyf2lxZZMeKa6Tdj5SbF5d5vtPFsIGvtn36jSmU34w8nJqyfY6QcJNTQ5C7OTKIZrTDHieFvUzfvfm/NaDXOna+EaEvojc2jAjXd838MuHdoO6HmH7WuG/c0Q136K1W0HN0yjc9mOmOA= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SA1PR12MB8948.namprd12.prod.outlook.com (2603:10b6:806:38e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Mon, 17 Apr 2023 08:46:20 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a%6]) with mapi id 15.20.6156.028; Mon, 17 Apr 2023 08:46:20 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Thread-Topic: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Thread-Index: AQHZa51A1iODhO+tlUqTJ4CPqJL/Y68lvWQAgAl9alA= Date: Mon, 17 Apr 2023 08:46:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=29fb9626-35f2-42af-9ee5-1547cfea5742;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-17T08:45:53Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|SA1PR12MB8948:EE_ x-ms-office365-filtering-correlation-id: 0bc7caf9-79df-40a5-ec02-08db3f203734 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VZ0Kib2/NiK/g4mabE/P9XWjDNVvcWQW9FYbTSVVLd8yyorC2JFqAaEKR8j+zg4QbFNwZn2lAND3aV4ZnYKO3cnfgT/C/uzfSz8PI7cjo3yKg6dw6p5TPw5byi9v3yX0UoK6K4WgJkvreWPrj+0DVWH7p8kqsA4uIVOb4ntlQLyL/eK3oDNMSAXbkZftmx2fuc6Rj2t9Z487V62BZK/5k40g+4dqMYXallW3dBWneW1yWSeXlCPlXK5snQr/pL0L9UGkp3m4rASaNb6YaM4He5F+IVnh2re5IcQXFTB6keeXsvre/eNEHetR6yHN/Ei9gjs4Jp1WaGvwDGdT3EvYRAazOlxLsR0XyMLU5MwFUOZP0JyxDVgsdFa+0xIl+Q1qR07lBIHF/qxpgBp7fRvy+zgeLKmw/Oi3mhEQCYWU1dmdBE6/Zikf+InafZbbOdlxsJNCD2gyziNdvCxAzjN2SwFljsE1SV9iRkvIJ7jMCJco6qO5QNX4llSQgB5hMRgHX8zdnkfd5JJ2imaQCBbyMMjgzlWaN38TY7cPRyv90lPjgInspYCs4cVIZFUedf3Zq3jFc5zpztfBG1CQMThoGnkcTktaxqEjypvWhHnCbIPbyjRrZKUtNWf8hNW/YdGmryc2lDq5pjUrHE3+xgvDAQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199021)(478600001)(71200400001)(38100700002)(8936002)(8676002)(316002)(41300700001)(55016003)(66476007)(4326008)(76116006)(66946007)(66556008)(66446008)(122000001)(54906003)(110136005)(186003)(2906002)(53546011)(38070700005)(26005)(6506007)(64756008)(86362001)(9686003)(83380400001)(33656002)(52536014)(5660300002)(7696005)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+p7hqpbo9aDH8Dgx8ZI/s0SFcAim0mMAeluBEh78xPeo714K9Vd9MDis9tHi?= =?us-ascii?Q?GD6fduRX88IdVrSEWCCinjN1dzb7fIwlaIBA3kYK8dm9tUcWxStdCOMRhxVi?= =?us-ascii?Q?mMkH5aXp3dhr1tIwVoZIjzzXM3MEo8t7bUAWUan7L3gechbbI4XimITqdLiC?= =?us-ascii?Q?pvRh1ruyDeycrbRTJlTcZRlKt5QZumH/NN2p7hDU3S9cL6XqqBP2kKj63/em?= =?us-ascii?Q?5jMeAxhAVvSqj0FICpefYe+IW7dMCobnFM3ADdcOs13Dzusft2CZTpp3Z4d8?= =?us-ascii?Q?vO8MK/EPnacC7XY9esa1tI5oBD9+DyZO2aOzAuFAQsGLwYKgtI9/GObaxNUS?= =?us-ascii?Q?MwCLqUsaPYjKlpMxXgX9hErFwDx4a/oarZ5rpg5VOFSuQwZv3oEsmnFFoB+n?= =?us-ascii?Q?vwGU6l7i8R2w1SnJiAP8easBP5q5WA+BA19kCyc0ugQHpxDNid0+Rmsdsa4V?= =?us-ascii?Q?51nQgk7M3a0TpAoE55pZaxCZT+x3oIhRyFxougUYNjqrek7pES6MFxr/JShX?= =?us-ascii?Q?+gD5KqQZPGjOc1GeskpGDF31WHdIXInA7hE5T8WI2gXfuK0XBRrwMQnzoVck?= =?us-ascii?Q?UJup3FIhexSu2YL9SLPwg95IGAJZwalO8dUAMn1TGQREVxlF/z0zGh8c0ZkE?= =?us-ascii?Q?rd/a6VKQLIoydnlYtcOBysmHqNfpfk6XgBpPYgTgNVDwClyA3pN73Lh6MDDH?= =?us-ascii?Q?WURnTAKPm26E0fOY9pxwwtbHzgkhaa/CbmMtRYyClIa5PzZXugc2ru0uXRBb?= =?us-ascii?Q?B8kAQ0Fv7CPBLEbewNYvnDiChi/AKrrvuisLMpmxOzQWlP+xsogFduba8OYp?= =?us-ascii?Q?jUAgiXA15yzSg9v2HXcpLkq23JeeRCt2RiugkkTRdGoGPlRYhSeVW5i8iOiM?= =?us-ascii?Q?kp3+hMHIvlucJDVsUbQWMG204XR8cfO+V0Etr7dJArBcaO1ykooSYTx9Vcwx?= =?us-ascii?Q?VovvV3/iC1Bn8WwfKv6/KrTsiyBUw52MoL0xUYLppKoqhSHv/GUWN74rsz31?= =?us-ascii?Q?2RtwghhKRG9OWD54UBRjmZYE9JEILkYbSVX5o7Is8TBmoflX/gU5Uu39EvqY?= =?us-ascii?Q?4LxPvZKF/Wfr3Gz3WMIVYgGFTz66x55UqlskBWUtShxV/fk6p+kTEK1I2hq1?= =?us-ascii?Q?t2/1jS3/YwRQIi7IiUyouWZ3ofH3ZVHy8+pSpdzlbXnlznhaio6+UtLQ3Opu?= =?us-ascii?Q?24S3cP9yGDdDBIHt2AwRlbQgvB4N9Hln0mLRwyZ4r2ZIFlDu5WoXmtND+hts?= =?us-ascii?Q?hNSCpV1euh15TMwpgfHr2g5R3CBTomLCy8hSJynq1XvgXjwCZV7ZfU61Inx7?= =?us-ascii?Q?CGCvzJr8LrxjH7LfP8LQEI8PgKgBzb79J80FaeRMlfzCfOKHPn3a0nuLjCLS?= =?us-ascii?Q?Qw5fwhhmW4mbuun5yR2XTEMJP+GAvur5dVXE+kua6E3vXhPdRgLCwDqA4gAK?= =?us-ascii?Q?TsDRi2X6Bn+T/nfm18LFWM945GSEd/AsQ37YMGFvUW2RnNa9+3hDZk2oW9Nq?= =?us-ascii?Q?JGfpGww4EjIqp5P6XTA0Bt7xnUW5ZnpiWUE/0AO3VH4LDhwBXWk06CZGXklc?= =?us-ascii?Q?Bkcyh7V6bxA++cQhP84=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc7caf9-79df-40a5-ec02-08db3f203734 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 08:46:20.0150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8948 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks for review comment, will update accordingly. -----Original Message----- From: Ni, Ray Sent: 11 April 2023 13:21 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) Cc: Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Gerd Hoffmann Subject: RE: [edk2-devel] [PATCH v8 2/9] UefiCpuPkg: Adds SmmSmramSaveState= Lib library class Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. > + ## @libraryclass Provides functions for manipulating Smram savestate > registers. > + SmmSmramSaveSateLib|Include/Library/SmmSmramSaveStateLib.h 1. Can you please rename the lib class to MmSaveStateLib? So the lib can be= potentially linked with standalone MM CPU driver. 2. Also the lib header file name can be "MmSaveStateLib.h". > +EFI_STATUS > +EFIAPI > +SmramSaveStateReadRegister ( 3. The API can be MmSaveStateReadRegister(). > + IN UINTN CpuIndex, > + IN EFI_SMM_SAVE_STATE_REGISTER Register, 4. "EFI_MM_SAVE_STATE_REGISTER"