From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.55]) by mx.groups.io with SMTP id smtpd.web10.783.1681791614783337584 for ; Mon, 17 Apr 2023 21:20:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=I216bar7; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.93.55, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHxGFxVGRkzb4lzQhO302F53qVWqJF0JmyvIpW3s7qcGekyoYSn+60Xx2B+wt0ijjFObZyIIfZMkDw7oATizp9yFL+Qe70MV+dq0EnzuVCBvveL6XzILHQMyHhWxKskOg8Ou2J7HuK1AwrkN+U9gXCDbeFpMLB6SnammgBj94a1sQkcxDjHVjrc3LuJCVZlpIz4SwBaN+wJWZwYChAjSr7fCwT+gAAPY9k53wrsCboBQLE1UuB0V0CXU0uvEKKDqxgsADWPSOt19GLNZdNJAgT4TFun33vC+aOiZlr2XLz/HpSkbSasVS58ANs5r983POIf9bzu4mTP9Tmf1vS2aeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4nxZ8FwbfPqa4dF+fxjK/uX1hC6rrUSfyW2g9aXHCY=; b=Fmr7s9fyDEmcOu5YngQAXxpPiB35N1BR2zOnfLsX6NdmqIM1fzylVnLHDn0Z85OOW1OM57KXOLceu9OGMK0JWsdKnUdGPbWYYEWD/EtPhKIzrsifhcfeRKRVEylKE8lmX62GAMxyZH6geALE9bZ8hnFbFvJGwK6QLfeShddIBL1z1WtGNxUPVPJOfKKl1Vk2Q9pfL6NDqpOrUGKRT901Cbac/mwkNwxXw449LeqC3p7gSk3W1YqsFDfVA8yE04ldKSx6xvbSXeNxW9GtKmdm71aTNkHRzO52Ss84q2O0YXvNq2Qi0SkoDXjAypzJoG+U8gSK5ZY901g4znL10qROfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v4nxZ8FwbfPqa4dF+fxjK/uX1hC6rrUSfyW2g9aXHCY=; b=I216bar7XCzXBZJmihGk4Enq73BJO+GrpzK1Asiw+yUgsqowIej1c0gvS+12EK007ehQDp7MQpr5aKUfbH9RHggMKQUOWqCzHeGDrxe16kmodrgaU6q+UG5A+PnaHi6rhkxM9z8ijm3WgZW+OlO2o/NdkooX4y4iu8nbkazFD7I= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SJ2PR12MB8806.namprd12.prod.outlook.com (2603:10b6:a03:4d0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 04:20:10 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a%6]) with mapi id 15.20.6156.028; Tue, 18 Apr 2023 04:20:10 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Topic: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Index: AQHZcSvzMz6N9gPCYESToHVeFaify68wd2pw Date: Tue, 18 Apr 2023 04:20:10 +0000 Message-ID: References: <20230417125534.920-1-abner.chang@amd.com> <20230417125534.920-2-abner.chang@amd.com> In-Reply-To: <20230417125534.920-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e1b0b4df-3dc8-4718-acad-28b6a3b52a77;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-18T04:18:51Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|SJ2PR12MB8806:EE_ x-ms-office365-filtering-correlation-id: e1126cc6-18fb-428d-ac1e-08db3fc432c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FUep0rIOLysiy8IIk4SUtf52XTJgWpmJK7yCXjoTOGFO8aUNuFfRwVAWxlvbZ48srZDT9BBAa2qY9+2kJJgzs9N2nb8u3kBy9jxkEDjpm37sRBnr0H5Zq1T8bpHJHGGb9iIPrPk8BDITYSSAADwyFyCLXogkQV7zsj8QWVaoI9UE+mB3LavOic+U9QPIgBvSSEMEk/IqwIFBuW2KARKX2TBm0v4SW556vGt8NnQeV2AMYtFhok9E6YwdU3mPMCGARlY9OEQ2GWyBdO0Lfyuk+LGDoQgLKtU10zJ8aHTknU0u4DGLGYAZoSp7K0LVkf0/Kf0KWNuNm8RMIyXbRkme/E73/SG0LWJ3qIO8VytsWnLevkhsKnWunUCwqpr47k7Q3ZBsx4O2dYghgWzoN7NdjMM7Y9kFXPzp5QYvDdv0W0Xs0pWJkBmUvxN7BKhexWjrvMfXwzBGAeGiJL+VhPoi3T/Ce7itqLVKBSt7wf5Fwqq8Pzftn1p+KrznWPp11+aE+Gr587Y3K+M0wj3F4ICOGFLC6uVIaoHcbbzeV7rByCWXW17TrVwMoSkLn7/WuONCNLNRu4CoM/PKYSeXXXEIe7jLmgt5iiaFWCCSXOohvtw8hJW3JmIQpShXkAWvNoWb x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(451199021)(478600001)(71200400001)(38100700002)(8936002)(8676002)(316002)(41300700001)(4326008)(55016003)(76116006)(66446008)(66556008)(66946007)(54906003)(122000001)(110136005)(19627235002)(66476007)(186003)(2906002)(53546011)(38070700005)(26005)(64756008)(9686003)(6506007)(86362001)(83380400001)(33656002)(5660300002)(52536014)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BiGjtc7bvHJhFp+IMzkVxq2qFI7JR284v30VEmjyINbr6eyYpA45lRiM+OPf?= =?us-ascii?Q?Bra1lJXeSaAn5g+D5W24UI0dX9HoE85tfFmc8T4omulLZ6hNeKNgX2cULslu?= =?us-ascii?Q?qovsMs9Fm9Ccl5RkgETHnUA+UsvxcM3w08WKpj7yO86bUz1wARk/eLZqjLu9?= =?us-ascii?Q?8ycZYvR97Qj7Y789dnBFk78+AbQEAvzizfrCzett75RB5dIcbS/ShlLLMdCZ?= =?us-ascii?Q?6Shr3Oepr1DfOEEoBYqX7EK827DMMyiYhbmlo670Hdr0sCWawUVMU8YJR+Am?= =?us-ascii?Q?Uk6riOGIiGF6wNzdczR8NmEztSjZFl8rTZ9nsavN9VuMZ4FAvoWGv5dqQEZP?= =?us-ascii?Q?8ggMVhc2HocVArOsydJB8tOhyZAxoGmTk8UXciHHPf1zBpUolXLH4folPvVr?= =?us-ascii?Q?Y8KIHQ2+eza5+fd5V+sw28I1CXxoyTSBKa8m7h3g+qImxCj1DCg6MdOVmkmR?= =?us-ascii?Q?hAXmU7pPAKrtNsIrXeCkeUKettd8T2tn2z8Q1s6ELXz0D+NPavVBaSdCnAPJ?= =?us-ascii?Q?Fi/CzkRh7iGA5Ocbk1spXMChKOSvqFPVJgq86WjdEuAgry+rid0ff8YN1u41?= =?us-ascii?Q?Xeybtp2VWpR+qxokLkfzT8BLHavxSAraQL6J9BDxv7plyz1wKu/3+n8PH++A?= =?us-ascii?Q?mYIBTrkK7HXiUQPsR6zlThSMsJ+59UeiPAi2parywXLIyjtRvFht7TNFcfWC?= =?us-ascii?Q?635S3qq8TTL2+pqT+URJIjCdbSSsUIpkzyOqLynuL8MGqv77vwcBYxTzwuAq?= =?us-ascii?Q?sRjB/2Rhx3CKF6F3suDluEO4beRvznTVzHA/ndIcwGzRmlXLE1bgAMmKSfYh?= =?us-ascii?Q?9pswXwwxSH5bbqPwXuMvkwJAZ2Nbn29i3edroem9Dd7aFj5s/JsvKJ67sNf1?= =?us-ascii?Q?JkFQvooZghUkH9zM17lmRluPKDkZppRZKnQWiQgutvJWF8lckwNbZSnJD9EN?= =?us-ascii?Q?Je/vwT9yAf+mEI6bQGTC7qOUrwR6/U6+51yw0FOjYcZ3P+qe2QoDTTob87TJ?= =?us-ascii?Q?h8NGnrWfHHzimJjBfJAHt43uFMl9dRQOnBzR6A5xkjcEW/ybdzwtsDR+jze2?= =?us-ascii?Q?8V/4LA3eLxu7rf8LbKyTXbbYCLp0e3vv9vPQIVYZBOVWIPOQ0KYhx77FByiL?= =?us-ascii?Q?Ezz7utU1FS9Xkn26QcLJfgnNhHM6p1uxESpe81c8PL0m3bFOr/Cp2KhrwBj/?= =?us-ascii?Q?Ids6z/UwXb3WBff+MsdWTuJz5FPlv82P7HuDGA0ma2Dy7o87qupWB/zxa5VY?= =?us-ascii?Q?FIY0R6Os6wE+Zz+yff5hdMPcoYX8UOwMatIqR34mtIC6lSvs8NiPgbk4X2zN?= =?us-ascii?Q?ASqGP6P4iFFQxm6UQFkQsU/gNnshl/KTxTpnZ+lYGHPJU91WDAq/ZLE5VTNG?= =?us-ascii?Q?on0oFDKGhQCWPrH4ZI24jeaZ/9exfyj2I+gLQCMoUl4J6AWZfS7quOis4K4t?= =?us-ascii?Q?9XndLeIXFN4f3ju+twLOudsmPIaGU95uJI/8O9nFiGedNFkeF63FokBN1FDV?= =?us-ascii?Q?FuSdM1NZb67tBpCuwbkcf+L/zWQ4i2dzVdQZfM3aVgLJy1QuBglkisU5QxoJ?= =?us-ascii?Q?B0FiDAIwGYha+YX+7uU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1126cc6-18fb-428d-ac1e-08db3fc432c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 04:20:10.0635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8806 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -----Original Message----- From: Chang, Abner Sent: 17 April 2023 18:26 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) = ; Nickle Wang ; Tinh Nguyen = Subject: [edk2-platforms][PATCH V2 2/3] ManageabilityPkg: Use SMBUS I2C ins= tead of I2C From: Abner Chang Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++----- .../BaseManageabilityTransportHelper.inf | 2 +- .../BaseManageabilityTransportHelper.c | 14 +++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index 9a930d3e4b..3d279ef033 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -32,13 +32,13 @@ # Manageability Transport Interface type # # Manageability Transport KCS - gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { 0x= AA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } - # Manageability Transport I2C - gManageabilityTransportI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { 0x= A0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } + gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { = 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } + # Manageability Transport SMBUS I2C + gManageabilityTransportSmbusI2cGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { = 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } # Manageability Transport PCI VDM - gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { 0x= 9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } + gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { = 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } # Manageability Transport MCTP - gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { 0x= 82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } + gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { = 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } # Manageability Protocol Specification # diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Li= brary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.= inf index 95c3362ddb..5447954144 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf @@ -32,7 +32,7 @@ [Guids] gManageabilityTransportKcsGuid - gManageabilityTransportI2CGuid + gManageabilityTransportSmbusI2cGuid gManageabilityTransportPciVdmGuid gManageabilityTransportMctpGuid gManageabilityProtocolIpmiGuid diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Libr= ary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c index 81da209764..c3f35b7beb 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c @@ -15,13 +15,13 @@ // Make sure the global variables added here should be unchangable. // MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] =3D { - { &gManageabilityTransportKcsGuid, L"KCS" }, - { &gManageabilityTransportI2CGuid, L"I2C" }, - { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, - { &gManageabilityTransportMctpGuid, L"MCTP" }, - { &gManageabilityProtocolIpmiGuid, L"IPMI" }, - { &gManageabilityProtocolMctpGuid, L"MCTP" }, - { &gManageabilityProtocolPldmGuid, L"PLDM" } + { &gManageabilityTransportKcsGuid, L"KCS" }, + { &gManageabilityTransportSmbusI2cGuid, L"SMBUS I2C"}, + { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, + { &gManageabilityTransportMctpGuid, L"MCTP" }, + { &gManageabilityProtocolIpmiGuid, L"IPMI" }, + { &gManageabilityProtocolMctpGuid, L"MCTP" }, + { &gManageabilityProtocolPldmGuid, L"PLDM" } }; UINT16 mManageabilitySpecNum =3D sizeof (ManageabilitySpecNameTable)/ siz= eof (MANAGEABILITY_SPECIFICATION_NAME); -- 2.37.1.windows.1