From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.76]) by mx.groups.io with SMTP id smtpd.web08.18433.1657685942890584910 for ; Tue, 12 Jul 2022 21:19:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=vXRVOGmG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.76, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lwa8TxbakPg9FvTwik4miCxppYf77A6i6p8A+xqYGHWBkBwV0FYWaaTYIRUbwrZs8rpZ6MpgAu17UNonsGIgPeUXTt/SENkXwo5KD99sHXYlqfPiVMUrTkVe5oDRZ0FBOyYZaJMjQKE3nVmxXwrc6CRgSZP4SuEFndPL/xYz6E5ZO0jEF8cZFRWpYGJ/Plz1d0DKnyexmhxDKavmeaSMBjnx4KrrxVoFbaYA52ByPhOh0Ed6+vD5LD2XcjLXiWR7sUHf+xsIbxw8KXPeRyszYWkfjR6VNkoyXVlqI4i75sDCgpnT4kwmmWfsSjamqjmvpbyT9ZaufKOSylqus2nWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QLR3M1CqyWGmTVKOK9WQDwYfaLT+ebYzhXB0GWm4HDA=; b=NLPCnjKHaLpJ8fRAQk7CxhYGqxayyi6Spy9AWFadf1HqYEfmIrSHRRktDgyCqijLHdgPrmbprMa+lIJb6QUV8sv/aBLaYx6x8UznIhEduFAtn/rLTkWvg5irjv6c9v8OlPHgPITfaw4UvuVh8zdLCbtnS2zS6zERdd/iznOeCPh/QurT736mgLCnIifFbNNejUIyJwOJm7fgKg5R0Q44/vjqxqdjL9XVHyLoZvu1z1+8hG4gDjZYaqXyoOz9OW6ZY2oGJf4zc8/FI8tOhvMF+8+VqIfosqxFelAEre1vWBrGLBCfaicX6jtC2PTOLMt5a5nZkP3IuQTDbr1HsSHNmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QLR3M1CqyWGmTVKOK9WQDwYfaLT+ebYzhXB0GWm4HDA=; b=vXRVOGmGORUjbX/0aw3ASumALJ1IQ9BWVu1zpDquGH1GDFfDXdb8dHnBSR+38fi+sokEltq37ZrYIYAj/i3rsC2Pc43tkxFclCgV2MRL6O0+yq1odipq2YFcZ2OVdlQdJ50jfUiyte+SBIAFBOQucKJHMD3DD93tMTb+14aDYbM= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by DM6PR12MB3452.namprd12.prod.outlook.com (2603:10b6:5:115::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Wed, 13 Jul 2022 04:18:59 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::7893:dc72:25d4:8c08]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::7893:dc72:25d4:8c08%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 04:18:59 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "devel@edk2.groups.io" , Eric Dong , Liming Gao Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Topic: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path Thread-Index: AQHYOCe8DXWnwdvFRkiQYGDCSXxmgazg8qDAgB+FVpCAe/bWAA== Date: Wed, 13 Jul 2022 04:18:59 +0000 Message-ID: References: <16DC746BF95A26AB.23353@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=1fb290bd-4388-42a2-86d2-dc41e13cd412;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2022-04-05T05:54:16Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91b461ec-875d-4a8d-5576-08da6486cf53 x-ms-traffictypediagnostic: DM6PR12MB3452:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gFpY4JYOegi42zBlmZS3ch0iA5LeQ52Y0YYgbEmQTx9l5HI33z95LePvsA8dbEConVVa5ArqvU3NYo5vZiiL2q30ehUGKu+tbuAq8FVkrFcE7JM0f5A6EQQUUKYjR3bKNifJlDnHR+snD8sOGLb/eAab2Zef61O00WRGxywxU90s2r3fLtYLK8clbqBjmRAQ6TMPKzXocxs1+fWAaHROUvJV1VLFoqhwEWsqGniw8onNBM/1kfzHSfNRJnmLcwJPbVkhIxjh1m7ZaayAye4tWLgeMozeiFeb7XBGmPpQPW3DDK3zh/kIwzzINrepLOCwO0uO3ijBlZLZ7KWQmchmyaF8zuOHDbVtppsBHjhos7g5pvTBHe4Dp1vr5Xzkb6NkV6hAics1EYo7g0qY6DtN+M7hKLDsV4nanCBhGHxdWmWcKLMQPIaG6SU1ervCTNyQ44fNDYGYJTPLoJDxmRgUCuGkOboYKDMKJA1pDS9v10tLeTc+yUi65vEiPk+zS2g4r4KkiPyHkIslrTLwnR0cgg93r0MosbonLK/HI8QEssgGzNHWsjHQJb0Nup54aAgtwxnn/kWW7kxAkC1TznLPlRAXLHqgpFsw7DTY7Kj2hoZWZ8j0fMjTuMKDcKvAkBi3SnCVp4kgYM22RMTnLx4UhHJj4NPlnbgv1m6vObGSifOmiP9kQ2OiIdqfdfvZqFzI0M8/JyUWU9yiywONHuHyZbpyTUYCZl8d+TrvWUCfC2Hfcsny4MtCZZyNHxCqT+V+F2TAzIH19mv/7NB8Kmjss8p56wS2PcJ1JOljme43cBtyqD+XkZhqOS82jS3yvX6px7G/TZL/aXDYoAR/v5Pqi3vBy/mPYKS910eDQNgDZ/0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(33656002)(6506007)(7696005)(55016003)(86362001)(26005)(110136005)(122000001)(9686003)(38100700002)(41300700001)(5660300002)(2906002)(8936002)(52536014)(966005)(66946007)(71200400001)(76116006)(66476007)(66446008)(38070700005)(8676002)(186003)(478600001)(45080400002)(66556008)(53546011)(316002)(64756008)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Uu8IR6gyc34wwnsggPu0yElLo7ia2PK8dkm3hScxuk1Au+6Rebn2g0kw/+I4?= =?us-ascii?Q?cw/pZ9iKEiv3D9I5uqLjdc6ct0R06cBIbWeH16aw/tdPi7iE9ji1qf5GmywP?= =?us-ascii?Q?FIEVKh1akNPhlXBzvbGJvJtmj498F182YdxtXWWfJybxEX5ByE1xqgD/ETO8?= =?us-ascii?Q?z0QyGAoSAbhP9GfjvYz7Jj0ddL/OmWCBli+iNteTk78wiabUqVrhM9lJXmkL?= =?us-ascii?Q?eTjtWVx1DGPpBwczT3GZSNy1vcuuM6F24y5P9G0BXMeILSAIfxpb3OBQN1Ox?= =?us-ascii?Q?eZ/wSnI5gJMnLPvhRs88zxqkKrjY6wsHuIqpecMq/twxGhuf6wV/ERJSsvQW?= =?us-ascii?Q?4QijK2t6cRf7/GWcKgAovkVUdaSxAfIBaHqpm0LXFPeO+5StA7hsbJq5GCQR?= =?us-ascii?Q?+Uaw3eoQKqfV+7w93bSVf5LRfSZUagPmvbciU57A1XL6a3YBc9rc5Eg1akIl?= =?us-ascii?Q?nK511mGrUmxJBwRx4G95nDuPYwTOeeikQE1O5GFMZvdyyT4KI3kPDLiXyJ2E?= =?us-ascii?Q?/ZvspccgXNL0a5H3e0wiMjXkF5q9JiQr3at4T/37grE89VlZQ2u/y/OZBTuP?= =?us-ascii?Q?vZEz3bPNV/UQHWKqYcGlly08RIMVIgbuygxOTMDOPNo+caHt1tBpdCrikF+Q?= =?us-ascii?Q?xZYeB4H2p6OKNUW3huPZiKN4K3aSAciyQWaAKgwqQ7dErHT6Orqa2dlmJZi8?= =?us-ascii?Q?zf4R1PclhIZSKeFmoVgpQq+iXBheA3akRsqJA7bW7WRdcQ0CC9WPv9ooz735?= =?us-ascii?Q?p3bW1uTRbpNGCfvfX7qs358DsUvOg3qh6KfI8OR5TA6LCcEekIHMVlNGsThd?= =?us-ascii?Q?XFoBgjxhQ7QvTlbH2C7Cx7ZjA/Ua6JRa0I9ZyqcP7Eahgvn4PDHXmQQHMoLH?= =?us-ascii?Q?JlNqtI+5reMhfcFN65lK1TFLMvXjBcl9HbDTp4KakZNbjhvxRA7xPd8O2NO5?= =?us-ascii?Q?5xvYD4Xwn+XsEUU7P7eRd8ORG4rVqa8xvUKvMqVKalHPSbeHYvKsUX9QGaAe?= =?us-ascii?Q?JTc+P7hzXecPE1F2Ar2tPLbrfm8DgqaxRrycW4zzVTT/NtWcCI8QKyzvm//9?= =?us-ascii?Q?aOqXS68h/29bjzgqUqziYo+BzCYY7xpIorok2DYYMk/SlZTAPP2TRQNbEVzM?= =?us-ascii?Q?YgvDSCZb5Erh3nJ7Bgh9tFBNOKnF8WbEOWKp4lclZT6oCMlGb3mBroYkpDeX?= =?us-ascii?Q?7zut2iaN/IEfRSf9Jv4QlVDX5ahNvtXIZBuidmgrAQTqR48JPyzz2dEYg2IA?= =?us-ascii?Q?rTeoXuQ2nzEQnh19Hq3G4WbXUj5BII27hFeP0y3tSNyNUtSekWAX00iVe9I0?= =?us-ascii?Q?4GXjYN/BmhMY3nHJKRGTFFOaMhSYKX9S1Vob9lIEGIdPi19mg5BlBUzRIR3a?= =?us-ascii?Q?MaM0if+nB21kgMmB17Ns1fGcIzujGeUl+4jnxdIb8xoxV7AYOVOyexTGyUln?= =?us-ascii?Q?R2x2g8wtl0mSmMQ/bun1jAhpB4fe8lYVx/sTC1yKFVOzP/JVNViROps3I8OD?= =?us-ascii?Q?1ibWwjLxHkwss9AtY4Iz/Cc2UsDCupLrQ3WS70w4jjTf4nkMTO5ShJq5gMGA?= =?us-ascii?Q?TblK0eMGycZbIYcMcidZ9/4Mxo4Oqkr6tACI2MwB?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91b461ec-875d-4a8d-5576-08da6486cf53 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 04:18:59.2617 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bz6VA8/stNy6SEx3Sx8+B3CFupgU/9yWv58h9bF3kGz6hsyPua50lsX+iJFOvSDJTGqoRNOm4p/KqpU6L+7D+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3452 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Maintainers, Reviewers, please review the patch. Thanks AbduL -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: 25 April 2022 12:45 To: devel@edk2.groups.io; Eric Dong ; Liming Gao Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Cop= y device path Hi, Please review the patch. Thanks AbduL -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: 05 April 2022 11:25 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Eric Dong ; Liming Gao Subject: RE: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Cop= y device path [Public] Hi, Could you please review the patch? Thanks AbduL -----Original Message----- From: devel@edk2.groups.io On Behalf Of Abdul Lateef= Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong ; Liming Gao Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy de= vice path [CAUTION: External Email] (Resending patch with [edk2-platforms] prefix with correct emailid). GCC compiler puts the DevicePath PCDs to the read-only section. During boot= if try to process the device path after PtrGetPtr it throws a page fault e= xception. Hence making a local copy using DuplicateDevicePath() to avoid the page fau= lt exception. REF : https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= ithub.com%2Fabdattar%2Fedk2-platforms%2Ftree%2FBoardModulePkg&data=3D04= %7C01%7CAbdulLateef.Attar%40amd.com%7Cdd04fc2187754979081008da063ebd5d%7C3d= d8961fe4884e608e11a82d994e183d%7C0%7C0%7C637829164332474465%7CUnknown%7CTWF= pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D= %7C3000&sdata=3DMX%2FlzKO2jVyPHaaURb7b8kMyNWFAlMPZ%2B0gK%2Ffrh5xo%3D&am= p;reserved=3D0 Cc: Eric Dong Cc: Liming Gao Abdul Lateef Attar (1): BoardModulePkg: Copy device path before processing Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c | = 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) -- 2.25.1