From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.1440.1681795326218350896 for ; Mon, 17 Apr 2023 22:22:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=WbPWDXqg; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fHfx2gx1j+yYMLC5EXeuY3J1lul4U8aKPi+yzVDcF0ut0Ny1VLmBFuWDlHiHrDei37Oc2TkVOvW/CDiNcUjo00mpD5ZYu1sQnDariN5q88JqiXydQYf7JgtY8kBO5EBoAvjWtcUyA5Lkdk+XXwxQabOr5p3HR0cn0I7qK7CxQkm75x/0c5s55yTUtg901jpLtmXWUHSNgsyHiezig1fQbzBB/EBUj4Yw0A6+GIqamaOgUiznwWtVdZmbo0Mj3tUT6lfIrwJBip+4p61k5/SAAHjdd5+jVum4ve1QhWcnRuMSp9JtTbRbNRtqqISpzCAIJ+1gg11ngWqSoJkfioMy6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W17H+if4m5kVu4yiyunklk6+D9Abue0I9TBkwdgxB5M=; b=Mc4UamC5ARdKV426v4lm5o6WcoP+pLaK8Nq41LPI8gniuNTtBgx8x+vmWGXbC+YJcvz2MtrDsNHhpx8YgGN3o/nc9+quw34w+40obO5vylBwZJNCtzkvQoZnZR9uW6RExolP/2S2fdn1L+iE4HLyZxGcpfsdca65Jxs301dQtqgkVt/2a3Tl5HNvxsEh83Xd4v7/2eVvg0/2LDNKf0ZoRN10UiDT9u7U9InUWP0xLz5oPPrE+jI+HliVth4CXvwXqSN0sOI94XHvS4PDaXWXoqpGkA3HRCkwcuzwysKxWy7DN9GLxzGZz5jtKqB+sHvAIosDPJjia2W7vfViltCKuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W17H+if4m5kVu4yiyunklk6+D9Abue0I9TBkwdgxB5M=; b=WbPWDXqgPZFU4MG6/3VimOxcfocafaiRIvN/Glu2s5kckXYEUU+j9rbYyv7ZwCzMTwPxfzM4RaI4e1u/53+zCa6pHDxUZzM/5qonUoV6GyPBD841yRSzlF1GalOM1OGu4JbiUAUubnMij6zafuKvC1VIZ/Q5sioaxb5k9a3YITM= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by BN9PR12MB5131.namprd12.prod.outlook.com (2603:10b6:408:118::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 05:22:03 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a%6]) with mapi id 15.20.6156.028; Tue, 18 Apr 2023 05:22:03 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Ni, Ray" , "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa51EnHlhOEhRRk+9qGtfJZI3Sq8l3L6AgAAHk4CAABJa8IAAGjGAgAqBTVA= Date: Tue, 18 Apr 2023 05:22:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-11T11:15:40.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|BN9PR12MB5131:EE_ x-ms-office365-filtering-correlation-id: 8b703b33-8986-4e76-12cb-08db3fccd7c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4yMQrU87cbZsLORsX8iiqioIEnBttlDTOHxLYz5nLz3+akyxEd5cB0ygCcpwtcbcN1ZfOj3vdfyxwbqOOp5YvP9RSSBGlmAISIgJam8Ni4v5bQ5PslNuXKWpUSjMSOMQr6UEe1Jp7jlWh+B+VL08wK4XnAK1PTyP5cD+LTxmlK91+CXhaQlyYSB3jYb4pspELJQvkGGIcwz41xOUCvQqtF7uP+SnQL34I50Qwz3psZscwNfjyVf42hytc0Q5gkrQy5hJTz/nc9rdEIslQ8muxRSAaYr+tmUUKwaS/2tVNSKeLhO1orxW6oKluHV3dKs0N812LWFowHNP+x/THlH//fG7x4ggQdjEnVpCx6xLtyGG7DZ+9nqml0kLe7wrGMv5YVTz6+L6E6FNbrozRUk416YE+VXwWrMW2o/8Sw6xNyoKwXHuSncAtXZPQznHwgPXSje7D/7ZeglHw0HmZcHD+Pw6t1krsVgzY0v0SrTQouxvbnn0V6T9rMCAkT7OY41gXT9wL4JWgFMn9UIqQVdsdAKhe2r4WvBDTu99RmLSsWuTfOlwLP5k7RAFUYAV5cQIrzEQjbG1p9rFyOOYC4lvQuX7iDJ8LwDaZhFVqFEgTlyQRQXARoC6ay/DX6BOI0ql x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(966005)(7696005)(478600001)(86362001)(110136005)(19627235002)(55016003)(71200400001)(26005)(83380400001)(33656002)(9686003)(6506007)(53546011)(186003)(166002)(38070700005)(38100700002)(122000001)(64756008)(76116006)(66556008)(66946007)(66476007)(316002)(66446008)(2906002)(4326008)(8936002)(5660300002)(8676002)(52536014)(41300700001)(66899021)(54906003)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rv+okJL8LcotUZsFdUtsb+WsOMagRmtbuLoScDOpgo5lhhxieRjnOId9MK5T?= =?us-ascii?Q?UsWnfILwz5wwgO7kmFxmbwwTPW1c5p9dPkoG5nDu7RbvVIKim7i2tETqc7GO?= =?us-ascii?Q?JKvU5vEGZgVDWn/UPqdEdDUQqdnlo8FLs4OXb5Xt+emW0iO2v1e5iIrqpbQM?= =?us-ascii?Q?7bD4kpK1GxyaBjWERoGQl0uAAwB1cY8aaELsUEHhqRN/4b/zFlZ0vim+us+Q?= =?us-ascii?Q?sDe6wa+U/feeYq//qeEoCucGpody8CYuEzb4pQGSCUT0+uG4Czcbml+dJ9mN?= =?us-ascii?Q?p5Usc1g0mjecvW2DoNkbDbFGr9IqX3nu8EPBfB4PexJsU3dG2hRYMHJ0E1Ey?= =?us-ascii?Q?dKxPt5FLo1qRahkpL2ngonMXCe1VpDLbsycdhAB+YvhMxkrmeQc99jQ/oMro?= =?us-ascii?Q?PVpfB674lRachvbf+sOJ2Q6MY7b1BY6Mnv5OJw+GgkJHPeCyJLsVgCBlJ3Wu?= =?us-ascii?Q?zYJzQlM6xW69NN7vR00hr56xUhtAL6Ojo7SnoQYhzLq2IYJTK3g0tMLe+nUj?= =?us-ascii?Q?2bVT+D5MstUkZ2uBYPCsdA3WSTuJBMeq1UbKcFi3pWJk0FYxUcgHdwVXayOX?= =?us-ascii?Q?nywHkyEI9S0/b9uxLmawdhmsbV8F4sNyOcN5HT2PkVE8xYFH18MTiUiJUj8Q?= =?us-ascii?Q?3bXcmkAa6GVzhJajBpv2dedRlH0Y+QKWuQxI5vWvLEWpre6CSppjTYch2L1x?= =?us-ascii?Q?edRBh8dV1Yzc6eBOr3RqiHmBMwlSwLSYb4fKVMgglXz0RgnBbKjBKv2iZXeT?= =?us-ascii?Q?WPCP6w4YH3yy+dI68aioWMv//UPmQLdH1bXgqIJLyvV5Xi9QU6E1xtecSEAe?= =?us-ascii?Q?RnMi7v0z2b8zRCnoL70cUUsCe+YsXu7dbfQmRElEB2q+dk5l4gMQdCo5pTiq?= =?us-ascii?Q?u/2K0Jq0fWp1g5c2LzG/aYqKLFa94AzAcPNhcmP27BKoFUVNtw1uIq1p1CyA?= =?us-ascii?Q?PvOTgxKeBMWALRXjEDucqMgeJE2kxKZnChFzEwzuTSH9G7Ed9c3sBlRAYu+B?= =?us-ascii?Q?SjGzi0BfXUU5QJJIWk7+J8wf/YPx/YTuhj0WRzDcXUxlfKNBAgJ2gnhdqew8?= =?us-ascii?Q?Hc5WuJoZ2r2cburFzkCCVHC7X8R1mvIInW+Hx8Gl1h5/DfXtPLh8LNyAJv1M?= =?us-ascii?Q?8mg8M0Ttdc1v7eF6F/v5mKi0a+8oOwHMGAsYnvYKUkkHcvHWknPecE8vngGd?= =?us-ascii?Q?q8/vlz6+De72r+elkgle2YidY4uKkkiJxUeV1egk2di5iOPOPFhN7RDlSjLf?= =?us-ascii?Q?YezSwPaGoBcOnQYIX4W/f07qKga5Scyh1yy227krI+EwibknrSd3BrhpPhyi?= =?us-ascii?Q?0208zzhdSMykcQv1IGL4LBA+cJJNvoFluy9GXatIpbkXe+ZVwlrhLHLcke+q?= =?us-ascii?Q?CbpGpgqQ+VZ3HZeB4iMVjnGnszn7lPvkzCxt5VqMeaU5ebFc9AyY0I9OA2I6?= =?us-ascii?Q?dyh8QuqvTvVdClp99r9Ihe112vFHY427OhJP27gUB94eEfsx664WsaLj6u8a?= =?us-ascii?Q?9ahClIGs7rnNopZI0nPy+D9vrD/FQpo50M3/spA0fAqij/ympEYJ7Q2EZjtB?= =?us-ascii?Q?bsxwCj4/FJsuYWxq5hY=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b703b33-8986-4e76-12cb-08db3fccd7c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 05:22:02.8664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5131 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_IA1PR12MB645876A60C9CEC7520C4DBACE09D9IA1PR12MB6458namp_" --_000_IA1PR12MB645876A60C9CEC7520C4DBACE09D9IA1PR12MB6458namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Ray, From open-source code I can see OVMF still implements SmmCp= uFeaturesReadSaveStateRegister. Hence, we can't directly use SmramSaveStateReadRegister in PiSmmCpuDxe driv= er, until we implement the MmSaveStateLib for Ovmf. I think it's better to keep the code as it is, so that we will not break an= y open-source or closed-source project. Thanks AbduL From: Ni, Ray Sent: 11 April 2023 18:19 To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io; kraxel@redhat.com Cc: Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L <= jordan.l.justen@intel.com> Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. yes thanks, ray ________________________________ From: Attar, AbdulLateef (Abdul Lateef) > Sent: Tuesday, April 11, 2023 7:17:03 PM To: Ni, Ray >; devel@edk2.groups.= io >; kraxel@redhat.com > Cc: Grimes, Paul >; Kirkend= all, Garrett = >; Chang, Abner >; Dong, Er= ic >; Kumar, Rahul R >; Ard Biesheuvel >; Yao, Jiewen >; Justen, Jordan L > Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Hi Ray, You mean directly call the SmramSaveStateReadRegister instead of be= low code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ? Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width= , Buffer); if (Status =3D=3D EFI_UNSUPPORTED) { Status =3D SmramSaveStateReadRegister (CpuIndex, Register, Width, Buffe= r); } Thanks AbduL -----Original Message----- From: Ni, Ray > Sent: 11 April 2023 15:40 To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Lateef) > Cc: Attar, AbdulLateef (Abdul Lateef) >; Grimes, Paul >; Kirkendall, Garrett >; Chang, Abner >; Dong, Eric >;= Kumar, Rahul R >; = Ard Biesheuvel = >; Yao, Jiewen >; Justen,= Jordan L > Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > > Cc: devel@edk2.groups.io; Abdul Lateef Attar > >; Paul Grime= s >; > Garrett Kirkendall >; Abner Chang > >; Dong, Eric >; Ni, Ray > >; Kumar, Rahul R >; Ard > Biesheuvel >;= Yao, Jiewen > >; Justen, Jordan L > > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library > > > Uses new SmmSmramSaveStateLib library, which fix the CI failure. > > What is the exact failure you are seeing? > > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf > > This should be the AMD version. KVM uses the AMD smram state. > > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h > > take care, > Gerd > > > >=20 > --_000_IA1PR12MB645876A60C9CEC7520C4DBACE09D9IA1PR12MB6458namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Ray,

        &nbs= p;       From open-source code I can see OVMF= still implements SmmCpuFeaturesReadSaveStateRegister.

Hence, we can’t directly use SmramSaveStateRea= dRegister in PiSmmCpuDxe driver,

until we implement the MmSaveStateLib for Ovmf.=

I think it’s better to keep the code as it is,= so that we will not break any open-source or closed-source project.

 

Thanks

AbduL

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: 11 April 2023 18:19
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com&= gt;; devel@edk2.groups.io; kraxel@redhat.com
Cc: Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett &l= t;Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>;= Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@i= ntel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@= intel.com>
Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library

 

[AMD Official Use Only - General]<= /o:p>

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

yes 

 

thanks,

ray

From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Sent: Tuesday, April 11, 2023 7:17:03 PM
To: Ni, Ray <ray.ni@intel.com= >; devel@edk2.groups.io <devel@= edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Grimes, Paul <Paul.Gri= mes@amd.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>; Dong, Eric <eric.dong@intel.com<= /a>>; Kumar, Rahul R <rahu= l.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jo= rdan.l.justen@intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library

 

[AMD Official Use Onl= y - General]

Hi Ray,
        You mean directly call the Smram= SaveStateReadRegister instead of below code from edk2/UefiCpuPkg/PiSmmCpuDx= eSmm/PiSmmCpuDxeSmm.c ?

  Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, = Width, Buffer);
  if (Status =3D=3D EFI_UNSUPPORTED) {
    Status =3D SmramSaveStateReadRegister (CpuIndex, Registe= r, Width, Buffer);
  }

Thanks
AbduL

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com&= gt;
Sent: 11 April 2023 15:40
To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garret= t <Garrett.Kirkendall@amd.= com>; Chang, Abner <Abner.Chang@amd.co= m>; Dong, Eric <eric.dong@= intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.c= om>; Justen, Jordan L <jordan.l.justen@intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Gerd,
I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, April 11, 2023 5:43 PM
> To: Abdul Lateef Attar <abdatta= r@amd.com>
> Cc: devel@edk2.groups.io; = Abdul Lateef Attar
> <AbdulLateef.Attar@amd= .com>; Paul Grimes <paul.g= rimes@amd.com>;
> Garrett Kirkendall <g= arrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>= ; Dong, Eric <eric.dong@intel.com= >; Ni, Ray
> <ray.ni@intel.com>; Kuma= r, Rahul R <rahul.r.kumar@int= el.com>; Ard
> Biesheuvel <ardb+tiano= core@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com&g= t;; Justen, Jordan L <jorda= n.l.justen@intel.com>
> Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses
> SmmSmramSaveStateLib library
>
> > Uses new SmmSmramSaveStateLib library, which fix the CI failure.<= br> >
> What is the exact failure you are seeing?
>
> > +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel
> SmmSmramSaveStateLib.inf
>
> This should be the AMD version.  KVM uses the AMD smram state. >
> Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
> actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove
> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h
>
> take care,
>   Gerd
>
>
>
>
>

--_000_IA1PR12MB645876A60C9CEC7520C4DBACE09D9IA1PR12MB6458namp_--