From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.120514.1683001110617147236 for ; Mon, 01 May 2023 21:18:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=2gXY6OxA; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPBj6Zm6UG6GjRO3S+3AH3UW8v5ooYOLBGbjfciBd4VNmmRKDOl9lI+80sLMCkpXlOtBtVv+tYvpetjfIBqN5OuPlLFGz09mazniPsYQgzAMgP0Y3AbxLdESmM12v63Xoj67xUiSzBqn+2waNtByoJPgsU4XiQzaVknbN/KcNx2Q7msNdikck4T+GiQ7FEr1/Wty1QlPd3tRIHNiYbD0kYXhj1IQpqrM68eOVzsaNj6vdw9y2ICfW1nbXmnCoKsoe+eLZ8h3nHMqH0Tov9gEXFoPMqQGZMPej65lJfOetNM8d36pGHDa9y/zQii6Yd49jS0i2gwncOlkhlyKdxnB/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G9hwh2K5NIXlZloOVCOsAFVMqEd68QvT5s7lDmCaIVY=; b=JzD+TrEpUKQU9+y/Mlw4aS4iOT7z6NR7Zhy+1mhQt0KchRPfUoWt5PNGOiGpkFHsCRnGg8vm6npo1jxpz+XK3AgjiMKOjfE/abrnSEDKDMqt2iAJ7eWPclObRHXf1pD48OlTSEggbk9TEYk3NXJ8maglSJts098qqQJH1sWd9Q/FP2wr9AWZfOo30w9gZhKXNjHcOMbp59x9TCnxb7mTaEPMURlxB/KVswb41P2dJ1YuZ6rQgrVmGLdb8EKZ1+M/bzMFmFpCVoZ2gCEdOYKlzXlFdr3o8FqBtIYuODZuVHNzY+E42Bk5fDQVuouPc49dSxb2P4HTg1W7mcdgLApYxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G9hwh2K5NIXlZloOVCOsAFVMqEd68QvT5s7lDmCaIVY=; b=2gXY6OxA2LgKn3SHdmaL6lmGfzM/zjZQl3RjPX10lyxV9gbWOV8KcWkiE4yIKmBENETwNVM07d/DvgNQeKKdc2PX2MYIHnvEpxN3UxY4kHUq/MtYULY5rRndsSEb5WSTnMFv1oeksOZWPl3jad4vHYJ7tXfXMBvyKPTmrldjLzg= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by CH3PR12MB8210.namprd12.prod.outlook.com (2603:10b6:610:129::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Tue, 2 May 2023 04:18:26 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::fb82:b2bf:60f9:45a1]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::fb82:b2bf:60f9:45a1%6]) with mapi id 15.20.6340.031; Tue, 2 May 2023 04:18:25 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chang, Abner" , "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values Thread-Topic: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD values Thread-Index: AQHZa5bayW1MaorubkKo52S0dpixNK9AlUUAgAWn7OCAAAApAIAARYvA Date: Tue, 2 May 2023 04:18:25 +0000 Message-ID: References: <7e573a1e75f5f61a453f099edbf846e59b0b162e.1681122267.git.abdattar@amd.com> <175B2AF24675592E.29517@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=8a4af0e0-4edb-4e45-8967-76fe5f1e7e4b;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-04-27T02:56:15Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|CH3PR12MB8210:EE_ x-ms-office365-filtering-correlation-id: cb4ace44-64f3-4a03-3e01-08db4ac4465e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yq4Ymx4Ynr0AEeJns2IZc/ycJnNQe0Ab+hpfoe25JQeh3JngwPj1oZFXZnCbnFmzgxMNTvQQ+nFjqp9sONBKiJpYZhwjCdBLchlWjPZ3IkkG2OdqaZfkUfN+OiSmuzmX1TlQEGpqgnZ4GaBbC2Q5sRtUiAEBvsBE8ghzlcfcaHvDM9+iuPl+Ahq8bucPDOmn/2JvhiahbrYjvcndBIf73l0sxEo7LX824OALgqh8w8tSJ76K279kkj61gNn3b7q1afQeWztou+cSoT1d04rpEQthHUoyjOb0449U0PQJOGwamWsEyQXEeptMOHAVL6Xl2QfhEVJse6qGyNEiqT7ApM9jFaRxd4uLJgtFNP3EsvSiZYsbvaIZnhQ69gbZhbEIlUM6JZxt4hjfDrTo6snDLtK/+I8oabNti3qxTieHM0Oc1rKSrHDpmVt/H/xABrpD340Jl6KxzxzKgXZCB5xsytwTzBZ58upDYlZRWKluOz/eBw8jVJW+7g9u31dPGnavqaPB7idmIABdNnB1MI4y0XxeUvdG4XcbF7oyx5PVuAs6vZTrHGexcrPyIJCqST4pzZ5yyVglMWfoOLRI2Lq6LM7HQ+hjjDOpo0NIzzD//1o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(6506007)(9686003)(53546011)(122000001)(186003)(38070700005)(966005)(38100700002)(83380400001)(8676002)(8936002)(52536014)(5660300002)(41300700001)(2906002)(33656002)(15650500001)(54906003)(110136005)(55016003)(478600001)(71200400001)(7696005)(86362001)(316002)(76116006)(4326008)(64756008)(66446008)(66476007)(66556008)(66946007)(66899021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NRRG5stUsj6LlzQ9aIIyo6bqlRKaSyOJADt4TUbHka3HnV1uVWrsHnnTjLTF?= =?us-ascii?Q?PB4lBi9KvCykkKjH+SI9aCchgk+YmrjWwNj9bSzCv51W51j8TTreOu3w2Dhd?= =?us-ascii?Q?fIasEJj67JB6bpHC2oasfz4KmKDhyhze9tYfob6o3UP5997Gy0aJImBKyrkX?= =?us-ascii?Q?f0cSvx/DkAbVqKw5c0WXTkReTDq2ECVO5gtIqJChT1Eb+Tatf1vrQ2/+IckC?= =?us-ascii?Q?DI/ucF4N4f4fC+ZGzaax96DtWXVEhGtTQ8YFIErFVpMmFqnRCVN8xdFzOiNV?= =?us-ascii?Q?t/Ya8lBmPD7dcwQcaoICzUvawIWH2VP0hLLcFStg/FX7wFBKmB/Yt2vXvAHm?= =?us-ascii?Q?PsKx4YZyQBSoAXF40rCfaGkJMcaRxv/3/WqIx2NgRHUw5AHAoO5JPCTvNAKu?= =?us-ascii?Q?z9EthjUAPnje7uD2ZSIpNUz9qnreb4bSifs591VwONcMvRTWpI8sCA1oDUT8?= =?us-ascii?Q?I5N08yV/AXHzm4w2t0Gb6j4iPmARrciIOpRhZu7s0tU/qftPZGTD1kk26AUA?= =?us-ascii?Q?MXSIKj+ZW2iv2ApxSSco5+Flbhxg1ejgNfo5TBXub2wUZKdH8ezXo6gy+uS3?= =?us-ascii?Q?NtMFDWVDanQUyha3tYKDj9pAd2uEPyl93h9Mw04q86vw4T2Q4Dbhf296M5RY?= =?us-ascii?Q?XEfEPI5bwIurxlK3AnoZOW6xsQUcLgqO2+tgOHU2Hl1IUtAWVOe7lDWaLXPp?= =?us-ascii?Q?FDLCKJTstmWSaWjphoEzBwM3cWm2DYS5Sh4WCeFtRQ8pLgmDh5rPJa8nRoJV?= =?us-ascii?Q?YB1kGiy4n6qJVhRevi1nhumJD6mhRRec3Thj6tV67H5ZlBXRKVX8vBFXVM+i?= =?us-ascii?Q?xVaRSrv7QMiKBwPrwcKos4Tb9gnNSJ5VwcgZrNp3KVJIsFutb7iofDBPh0IT?= =?us-ascii?Q?QuaWdj5/CuMkDo5keRXFYUlp8Ntwc2eFdge1bkyJj2BhiiOZyQecyoQCksxu?= =?us-ascii?Q?IOXHrb+ihamnILxBRNcDTDzK6H+7k6y4JoWG6wpDB47XoJOe5bTx2m4dZchV?= =?us-ascii?Q?GYUpU/h+V1pAEJ1cM3zV5S0aXci6LOTv2sdN4t34+jYYteemRdak9LwWOGBy?= =?us-ascii?Q?s8x7fCyOsrBPt0MNyrKOHYSGRFyX/SyaXNZue+1El5E2VEFfOWIGAxHXl82Z?= =?us-ascii?Q?/aEdaRQD69a5dHnP+IMjj38G6hDpz/ZOHLjh+Rlt/QB3cbypzwN79zK3MD+W?= =?us-ascii?Q?iRXKct0DmzKSdfWDTJUTNRf+8znqlwV08Yj9fWmqUHICsow8QgA94KRgFvPR?= =?us-ascii?Q?t0Lpuw8zr48psB2rPDr5eOSXEHYO96HsXJAkKeNZXDc//ZMgCOaH7xo9gbnw?= =?us-ascii?Q?G0+MM0d1h8J4COtT69bwfYIXE8HMVbRgMxFPRreJnygXkYNH3sw1TedVONhh?= =?us-ascii?Q?dtGAvbXzuhtlvu0KBFAKJr+FzumFq+td4gXRmUwElzR9WbEah/k38JflegdU?= =?us-ascii?Q?+PhzbDzKwx2heA6L01bljQgV/687efzd3b1daklYc/LIXikz3LwXwbKzq+++?= =?us-ascii?Q?A3r8QJq37S/NDIFHkMjFp9TRjqB2Q1fDn0/4HShAEKzQkwowcHcMlEH8WQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb4ace44-64f3-4a03-3e01-08db4ac4465e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2023 04:18:25.7517 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nx1gCvGVHSOZgmcsFdzaRdbJQs5vKTBxYKYEg8ZM83Af9qHPhfleN9obT/GEgn+MWk+vXUc6fyjVjlFv7FxW/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8210 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Thanks Isaac for correcting and pushing the patch. -----Original Message----- From: Oram, Isaac W Sent: 02 May 2023 05:42 To: devel@edk2.groups.io; Oram, Isaac W ; Attar, Ab= dulLateef (Abdul Lateef) Cc: Chang, Abner ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; = Gao, Liming Subject: RE: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table= based on PCD values [Public] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Pushed as 64b06a4d19..d39c665fe3 Note I had trouble extracting the patch. I had to ignore whitespace and th= en fixup line endings to pass python \edk2\BaseTools\Scripts\PatchCheck.py = -1 Regards, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, May 1, 2023 5:08 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Chang, Abner ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; = Gao, Liming Subject: Re: [edk2-devel] [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table= based on PCD values Reviewed-by: Isaac Oram -----Original Message----- From: Attar, AbdulLateef (Abdul Lateef) Sent: Friday, April 28, 2023 2:46 AM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Chang, Abner ; Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathan= iel L ; Gao, Liming Subject: RE: [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD= values [Public] Hi Maintainers, Please review the patch. Thanks AbduL -----Original Message----- From: Abdul Lateef Attar Sent: 10 April 2023 15:56 To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, A= bner ; Sai Chaganty ; I= saac Oram ; Nate DeSimone ; Liming Gao Subject: [PATCH v1 1/1] SpcrFeaturePkg: Updated SPCR table based on PCD val= ues From: Abdul Lateef Attar Update the SPCR table based on PCD values, such as base address, register b= it width, access size and address space id etc, along with OEM data. Cc: Abner Chang Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Abdul Lateef Attar --- .../SpcrAcpiDxe/SpcrAcpiDxe.inf | 13 ++++++++++ .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 26 +++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpiDxe.inf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcp= iDxe/SpcrAcpiDxe.inf index 3fc84959a015..9a4f95e86bbf 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= iDxe.inf +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ AcpiDxe.inf @@ -2,6 +2,7 @@ # SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). # # Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -26,6 +27,7 @@ [L= ibraryClasses] [Packages] MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec SpcrFeaturePkg/SpcrFeaturePkg.dec [Sources] @@ -38,5 +40,16 @@ [Protocols] gEfiSerialIoProtocolGuid ## SOMETIMES_CONSUMES gEfiPciIoProtocolGuid ## SOMETIMES_CONSUMES +[Pcd] + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterAccessWidth + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio + [Depex] TRUE diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 7ad0c058c844..51449d0fad9e 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -3,6 +3,7 @@ SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -368,6 +369,7 @@ OutOfBandACPITableConstruction ( UINT32 FlowControl; VENDOR_DEVICE_PATH *Vendor; UINT8 Index; + UINT64 AcpiTableOemId; Handle =3D NULL; @@ -456,6 +458,30 @@ OutOfBandACPITableConstruction ( goto out; } + // Base register details + gSpcrInfo.BaseAddress.Address =3D PcdGet64 (PcdSerialRegisterBase); + gSpcrInfo.BaseAddress.RegisterBitWidth =3D PcdGet8 + (PcdSerialRegisterAccessWidth); gSpcrInfo.BaseAddress.AccessSize =3D + (UINT8)PcdGet32 (PcdSerialRegisterStride); if (PcdGetBool (PcdSerialUseM= mio)) { + gSpcrInfo.BaseAddress.AddressSpaceId =3D EFI_ACPI_3_0_SYSTEM_MEMORY; + } + + // OEM info + CopyMem ( + (VOID *) &gSpcrInfo.Header.OemId, + PcdGetPtr (PcdAcpiDefaultOemId), + sizeof (gSpcrInfo.Header.OemId) + ); + AcpiTableOemId =3D PcdGet64 (PcdAcpiDefaultOemTableId); CopyMem ( + (VOID *) &gSpcrInfo.Header.OemTableId, + (VOID *) &AcpiTableOemId, + sizeof (gSpcrInfo.Header.OemTableId) + ); + gSpcrInfo.Header.OemRevision =3D PcdGet32 (PcdAcpiDefaultOemRevision= ); + gSpcrInfo.Header.CreatorId =3D PcdGet32 (PcdAcpiDefaultCreatorId); + gSpcrInfo.Header.CreatorRevision =3D PcdGet32 + (PcdAcpiDefaultCreatorRevision); + // // Add table // -- 2.25.1