From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7286AAC09F2 for ; Wed, 25 Oct 2023 14:24:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QNkzsFEV+TdslEGdiIzfKS419jGkiunvE0kpM/O0x4g=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698243868; v=1; b=R5sZunxFW2DanEvTq+YPv6DCITJ2LxE4U1J5VQ1rimdt4aDTIjKbJYk8GrcDgYTUgMXKW0/D 3Idjrotdfxk8zQatb2+BONX3t/a8qQ0h9xtE1USJuU+bIith7y6oJjjybUYsUlM8c1sfNfwH4wK Rqzzg7sgI+naxqRgYKW8YE4I= X-Received: by 127.0.0.2 with SMTP id XTkaYY7687511xk03FFeMeCL; Wed, 25 Oct 2023 07:24:28 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.84]) by mx.groups.io with SMTP id smtpd.web11.39356.1698224162359044038 for ; Wed, 25 Oct 2023 01:56:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnDcZXrveH38big8QE+MP+l5enX6byHWF09ZAu7l8YClaQD6bdMpBBUivJSomw8MEQwO8ua9SBrW0VOL89JThDIF6UfOy3+aK2Qd7Au8obs3J67GeUUbyJpnDtBYQJE4PM8i8mhM52wB8rorulR6WQhDkPW/9e/CmzpcOSpE7uS1IrNCZTa+VXtbaZ0VwOgXwkThiHRD8Nw3KQKVYOTB3OfOEz3JlkO6D8AT4PC566fhpfWc0IYx6kyK6P27umjk+SlLqLaV+DM/N+6NST2cZgm/BDQAotsyZBJTVURukBEcqdqbBhiWS9GKTppfQX+gVGYY2+fYBECvFMdMVaA6JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCQ7+6DQJ89eyNAXEXItWKXYXspyXHPe63uKo/wb7Lg=; b=KfYpcbU5mzUEoRPIU5NIpZDFHPSeK2kBAJ7+M3sOD834ol0H4L9g8LiO6ed/lseLcutog7RIyN3SOr/DzAb99qbR7tcnul3cKnlm7XirjsetBFClRGBM6BsWzUIfjVukAJ8nqcUKKUyd0yYV8gnjlEPbvlXMOG7JAtL0h+mI3Oh5RJOLDEQe4kbH/aGQT0ak5ICgQrEFgtqljMuXXEWck/QSuwofnuVj6hLQ7vf+TPXI+2BRNJOzL/bUsmlspUMLCjy30f47VtmfzsE9k0byIbZMpPV2NzLkGjrKtVSsDn14lO6qCEHdRt9xMeBVhHV4eYmCBPfoQiTJ+gRB1NkrlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by PH0PR12MB5451.namprd12.prod.outlook.com (2603:10b6:510:ee::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 08:55:59 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6%5]) with mapi id 15.20.6907.022; Wed, 25 Oct 2023 08:55:59 +0000 From: "Attar, AbdulLateef (Abdul Lateef) via groups.io" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "Chang, Abner" , "nicklew@nvidia.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 01/16] ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure Thread-Topic: [PATCH edk2-platforms v3 01/16] ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure Thread-Index: AQHaBbGVTP0qlbUvdUirtPxSTBQvsLBaNlsg Date: Wed, 25 Oct 2023 08:55:59 +0000 Message-ID: References: <20231023130511.4521-1-aladyshev22@gmail.com> <20231023130511.4521-2-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-2-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ef538b8a-f881-46f0-8b0a-b15289169a3f;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-25T08:54:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|PH0PR12MB5451:EE_ x-ms-office365-filtering-correlation-id: 9d86777f-d391-4850-cce3-08dbd538357e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: DHQkRDSO1CH3doFwO8papBDtZdS/z5UuNAUZ+6kUmrpMIVyShWrWmvxY+PpBFGKUlWBf0axZzOivnfOWAuHFaUhhORKBukWrIz6+gPdzh9Leh6yiuLhjDt7ovqotHiopijNqDzioBWRUhBxd+1SY2f9Tu42vY6d4TaWXqFou3JYgjrNdJabf2TbAsDOTWcIPbd/2x+1m/wCmsrLPIBDmNGXz+66gt9VWipasv2tRtVD7SW9l8DuZif9CQCG/XqK9e0aLuBPduMBMpBqnQHEpEyJfrZ7YLLUQO+MuKZ9u2WqTU0p6/xwsljbFxugVVV1hWI7eJVKWL+8NeFaWIno+t8DA0CNCDhOL86Tke8pZghZqN7pd0/vfhDWZXTwibM//1lmB7yc6OueB7wGmMc4pHmGunuIn+4txM2nxfik8aHrceV84iTVkHpBT+GTzz8TAilUZVc/kiYaTwktFGwFeyyYUp/z8Ubiv8GooyCjtPzpBAG8UQRcq/WepYmgXwCtg4gRUcKVSDYWryUSgZa87DLoP9ZtdKcHqY33pujsXj7wUmGJf9a7RwjuaFQfdIEBlb6MVRQj4E+ecSzDgs8ZDIbuveXHxgjW78YXstlCSPgf0x6wbCj8ZWwjAZC3oYiFU x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YzfTYWTFIKEtzwUmClMecGYH79NvqtdRx5ZnkjRgOTR18Z9edUZyYguCUaKd?= =?us-ascii?Q?kC8VSqL+HzLBNYStkoQy7U2TpsSEODNULOxhcMSYn5oDPnVcymPfYsaqanbU?= =?us-ascii?Q?us66rI/FVppYF1sxIHtDUZhhQHA1sHPTtMzBAxzrWGRUpyCsAzqTh0BfWpn7?= =?us-ascii?Q?gYisdFvblqiT7Yw0VDXA55mtcyxkP5Cb0/t0Xb5nkdfaJrdgeXK6cG/+xRUr?= =?us-ascii?Q?1mfGdiDiQ4t9EyWOliB+/GcfCVdOly5ymbTPjB+X7gjbal268DqAdw5Pl2s3?= =?us-ascii?Q?w/5jM8jDOS3CxrGVkeQOwId4HAUyi4Djs5Khclp+RJe1HvpbIK79wVMBQ+ZG?= =?us-ascii?Q?N+eRnXzL44kbIywNzJgk3ylttdnvHKTfn0rjFBhvSERSdR25+T6elfpBUVrX?= =?us-ascii?Q?Q1EgHzCJwmzZ0/4GqjATJlatHSJM0OqtFXSUQbGXsvDx+HIrPA+y3yqb4oW3?= =?us-ascii?Q?SiIdcoJHEm0nv0wTLhqMWmU3mDW42VmhxlzHvx+PUM4BPerlndUalGQa5v4P?= =?us-ascii?Q?XlgVoDKHQDAIV0jkeL5EuQSjVtM74MaclvuTUaKMU7QiuBnD5yexV9nDrT1S?= =?us-ascii?Q?2oxmhynnwihkYfxZzJ+YZO5bMnU/+LMhxtdwwq1CLZ045lTzHH5vsXWQtjid?= =?us-ascii?Q?9y/FFllql3xREzTkCEJsebedW610Gff6M4LqmCDqpUTeTYgVfnNgnyUAZ5Tw?= =?us-ascii?Q?ljG0rfTZqp42S7zh3QgsiGuPmrDFkv4JynB5y8hM12J8+UVQ98qTxp4h0R4n?= =?us-ascii?Q?ZzPcwnaNEt4/YzTiJmAce5ITkSLJSnmQUZ3rBgQ0dBzAZgPUoWXXN2Am1ROK?= =?us-ascii?Q?vZBamA1VrYS824jeCq0fw4ftES6SmIDAowjahjRxp7i4FIqTT6XWADLz0XUT?= =?us-ascii?Q?n5jwnJPT3aFVTUMW7nuUf9/l6bwyvPf5vGs2BzYdzjdJE9FRx3d2ewIS5ZuK?= =?us-ascii?Q?Cya+mt5oHJfsB3ZtLWDNUlQtyGcPXknNxucvkiCV8EIhGHrbK/x7Cn1Lrekj?= =?us-ascii?Q?axd0W3PUEHMCJXok1N33GW6xsA7lX1oRHp9scG3E+zyMC6Pc6gKMalUzly76?= =?us-ascii?Q?tcSZIXgduBL522kqDm2pnHdUtu05kK+Aiizmwq3miZ0hbhAkmhrn97imtgjF?= =?us-ascii?Q?j4s/B09i8XBFxRYnbp5NDBcSkC/GD0a0I+BVB1kDfA/cQ/a/10eiEAh18FUD?= =?us-ascii?Q?rl8SM66ODyGw0002lrnYU78qksQiCvBEd2ONdnt+m83ZYjXFY4Qmjs18eHSS?= =?us-ascii?Q?AKhr5NJBOzb5dyc2X4Xxb9rSmUfqkhxWJFPqwRN+DRcdSa58IN9pvNfq59qi?= =?us-ascii?Q?5+ge9d2TY2vMMLpb0cka3LM4GpoQMJeCsezse/nB6en1xfMAW6meZ9jvcxvU?= =?us-ascii?Q?MTf5xC3xKTAwXiX6LpEiD+bloQ7Km5Mt5E7I6IbEzBr/cifp7z4BNfwADrPJ?= =?us-ascii?Q?dKQVC5O6EuyqAAJhT4o1QXvNOsUf7xy6ErJ5lSmPMT1twSmbJfUvpT71uct+?= =?us-ascii?Q?sTyi2Slv3ATh3k8qEH2j3BMattRoPaPrH4cw+sr/mgcBnOxM5DMn4kcZu1fL?= =?us-ascii?Q?TNA+mykRib55Hce2KIw=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d86777f-d391-4850-cce3-08dbd538357e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 08:55:59.5367 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pRgjHZMqWip8Us/fNW/F7bYNorURDoefjpzjM6ENG0VgVQLuafUC5GG+Qfj54ODo/olJUVCSBpfUPlR+UR0vog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5451 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: T0kaMboFfMaxce3usBme2KwSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R5sZunxF; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Attar, AbdulLateef (Abdul Lateef) -----Original Message----- From: Konstantin Aladyshev Sent: Monday, October 23, 2023 6:35 PM To: devel@edk2.groups.io Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) <= AbdulLateef.Attar@amd.com>; nicklew@nvidia.com; Konstantin Aladyshev Subject: [PATCH edk2-platforms v3 01/16] ManageabilityPkg: Add definition f= or the MCTP KCS TRAILER structure Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Currently there is only a definition for the MCTP KCS HEADER structure. Add definition for the MCTP KCS TRAILER structure as well. Signed-off-by: Konstantin Aladyshev Signed-off-by: Abner Chang --- .../Library/ManageabilityTransportMctpLib.h | 5 +++++ .../MctpProtocol/Common/MctpProtocolCommon.c | 14 +++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtMctpLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransp= ortMctpLib.h index 43bd142f4c..462e7436e6 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h @@ -39,6 +39,11 @@ typedef struct { UINT8 DefiningBody; ///< Message type. UINT8 ByteCount; ///< Byte count of payload. } MANAGEABILITY_MCTP_KCS_HEADER; + +typedef struct { + UINT8 Pec; ///< MCTP over KCS Packet Error Code. +} MANAGEABILITY_MCTP_KCS_TRAILER; + #define MCTP_KCS_NETFN_LUN 0xb0 #define DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP 0x01 diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 1ad48efdc7..7576007f77 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -132,7 +132,7 @@ SetupMctpRequestTransportPacket ( MANAGEABILITY_MCTP_KCS_HEADER *MctpKcsHeader; MCTP_TRANSPORT_HEADER *MctpTransportHeader; MCTP_MESSAGE_HEADER *MctpMessageHeader; - UINT8 *Pec; + MANAGEABILITY_MCTP_KCS_TRAILER *MctpKcsTrailer; UINT8 *ThisPackage; if ((PacketHeader =3D=3D NULL) || (PacketHeaderSize =3D=3D NULL) || @@ -151,8 +151,8 @@ SetupMctpRequestTransportPacket ( return EFI_OUT_OF_RESOURCES; } - Pec =3D (UINT8 *)AllocateZeroPool (sizeof (UINT8)); - if (Pec =3D=3D NULL) { + MctpKcsTrailer =3D (MANAGEABILITY_MCTP_KCS_TRAILER *)AllocateZeroPool = (sizeof (MANAGEABILITY_MCTP_KCS_TRAILER)); + if (MctpKcsTrailer =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough resource for PEC.\n", __func__)= ); FreePool (MctpKcsHeader); return EFI_OUT_OF_RESOURCES; @@ -167,7 +167,7 @@ SetupMctpRequestTransportPacket ( if (ThisPackage =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough resource for package.\n", __fun= c__)); FreePool (MctpKcsHeader); - FreePool (Pec); + FreePool (MctpKcsTrailer); return EFI_OUT_OF_RESOURCES; } @@ -193,14 +193,14 @@ SetupMctpRequestTransportPacket ( // // Generate PEC follow SMBUS 2.0 specification. - *Pec =3D HelperManageabilityGenerateCrc8 (MCTP_KCS_PACKET_ERROR_CODE_P= OLY, 0, ThisPackage, MctpKcsHeader->ByteCount); + MctpKcsTrailer->Pec =3D HelperManageabilityGenerateCrc8 (MCTP_KCS_PACK= ET_ERROR_CODE_POLY, 0, ThisPackage, MctpKcsHeader->ByteCount); *PacketBody =3D (UINT8 *)ThisPackage; *PacketBodySize =3D MctpKcsHeader->ByteCount; - *PacketTrailer =3D (MANAGEABILITY_TRANSPORT_TRAILER)Pec; + *PacketTrailer =3D (MANAGEABILITY_TRANSPORT_TRAILER)MctpKcsTrailer= ; *PacketHeader =3D (MANAGEABILITY_TRANSPORT_HEADER)MctpKcsHeader; *PacketHeaderSize =3D sizeof (MANAGEABILITY_MCTP_KCS_HEADER); - *PacketTrailerSize =3D 1; + *PacketTrailerSize =3D sizeof (MANAGEABILITY_MCTP_KCS_TRAILER); return EFI_SUCCESS; } else { DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _func__)); -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110056): https://edk2.groups.io/g/devel/message/110056 Mute This Topic: https://groups.io/mt/102134647/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-