From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.44]) by mx.groups.io with SMTP id smtpd.web11.5324.1685436439321682561 for ; Tue, 30 May 2023 01:47:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=SVDFpKHe; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.44, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XlccCVxJGN2KX7Njr336XV4Hj2HArXiPnIvHGss1Ntgyi9oj1I+nxhxUk/vQeXJbael7/5nSH/IQ+/rGOfnun4jePQElYg9Z82TKaVDEV3G2CbfhWU45feSB6qm6/4dMPUhOkRBQFe68V+TkqjYD/LtDuhpNR23ty7oC9xfKzJa+nMWA/xyFY+xABf5OTu/NSdvLkS5UyZoP0wzpFPbNqR1h7EM+BhVeNbHb8Xg2xlm5bglxCKHLx/zmhJWugtg8Irv2vVVpeS9Nal4GsJsLJwXpteaJ67lsXjWc1PfUoghCIqsKucttxfh0cYWaZk0Hd9BqVSg1K+ngSxFH/Y0biA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zkwxl4ggM/ZfCALI6fXK60IDE1H3jWyIT85HDkskhFY=; b=bFUc28T1FnQskxsxnYUSWHpfMUsewCpj947ImYj1jXanVW83gEMvuxPGv+uGA9XUXUm0Rer8jDw5/wP91d1f4Rb/8yjCIqeCFGuwiXsTyz0Tns2WmT4KsxxLc83vbrDsYAfiRsLbOgxknsrvUKrcTr+R2DXe3MfV/jHHw7Lr8QNX1pMRs2pP1sEQhRVH1AnDGgwkbSw5Qm7hWuyc9t8QM0OHf7R4aJpk2d1ngqUknLbEnZeQzD2PqVoM2zfC3YyLtOeIx9RQoiXOkQu9wZq9b5HGvv6VKL20NLyNkprk94v29gCjup3NNsqi7GvxO1FhMaMkfoISqseXeMmqY7g+0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zkwxl4ggM/ZfCALI6fXK60IDE1H3jWyIT85HDkskhFY=; b=SVDFpKHeJcJin4tbu0/EivmXihzMfqfHyWL7xdOaDI8+4a+LLkRU55dCE75LtMnPsf/AuRAraQ2gKwYjdDI45GDrQovmZVObFiYnFyspAsGqTtm7QnNc2eBUQPekLOuP//Vwy/yx8ABqmp+taiLz+fowP6JpdUVG2ZKxYlkZ7LI= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SA1PR12MB8142.namprd12.prod.outlook.com (2603:10b6:806:334::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Tue, 30 May 2023 08:47:14 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::e99b:2936:87a4:e038]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::e99b:2936:87a4:e038%4]) with mapi id 15.20.6433.022; Tue, 30 May 2023 08:47:14 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__ Thread-Topic: [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__ with __func__ Thread-Index: AQHZksCq2qei5vO490u2e3gfHYmtGq9ygPMQ Date: Tue, 30 May 2023 08:47:14 +0000 Message-ID: References: <20230530063316.46-1-abner.chang@amd.com> In-Reply-To: <20230530063316.46-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ad791dcb-4fca-4542-90e1-89497833fbb9;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-30T08:46:30Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|SA1PR12MB8142:EE_ x-ms-office365-filtering-correlation-id: 92f51085-ba04-4e6c-c5bc-08db60ea772d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C7KspeF5MBZAG7Zy4GvOXIZDBShiMaI4ov/v+i5xxjGUC3kUzj+H7ieTM3wh3hxRhsSWbMIc76Sge87sQMp8mGFjCA7wZxfHYCIm0zJZyULrWJbq1d1phGRCubr43Zkz1rTWvA+M8jzP8iRq+GN9uM0CnfVFZ3oH7XbdIKwbtxVI63Hcb8hD+1YpdDIzRieuT9E0x6d7VR52zEW7HIB8VoK7UpQGoRX6gv9f2WFo8JRDp69h3AI9Lor/1A+jBStG5OqlQgaOTShtJSusiiXKGY41cOjEevMXwk48pHkhq6JfxRitidrZ8tDwDhMJDrUxuvdWK/eWJhQAH9pHin4Yq+E/V4BIInBmdt13Aqz1FAYzA5fuY1thvLnCZciPU2fhTuHajji4MoILBVacFQnZYBuPKykgtJ3k9e2OU1PN4wDOfQ+cxX4Vimim0PNSStIND1JCiOk4kt7aKRLDeBL9HiC9EGMf033c37oWvvWFKBn3lETn/O+QdLHRB37Xgjl7CSvJjmRyOXAx2hYwtgMcjDIu7zRib6jpseXjT7FwoTBEQug5DkgUrS88yQfAOKyHQEXjLwOjEVF2V4ium2Qo/Fg5venrbOKaVbbWPhVJhpYjZbBawyz3eTPH9fHLV2aQ/goUaoW4+yzgv0ZA3+lJ/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(2906002)(30864003)(186003)(53546011)(6506007)(9686003)(26005)(52536014)(5660300002)(54906003)(478600001)(19627235002)(122000001)(8936002)(110136005)(8676002)(83380400001)(38100700002)(7696005)(38070700005)(86362001)(41300700001)(33656002)(316002)(71200400001)(76116006)(66556008)(66446008)(66476007)(64756008)(66946007)(4326008)(55016003)(559001)(579004)(44824005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?542ztWuJ+dN4jRr7hQVBGMjVYJX6kEeJNxln6aNYXa+DyqVJGR3vWG2LoZOa?= =?us-ascii?Q?97yyT2ysT5dX/wB7XJw4+/0ibgVcoblgWeSZopG8Py84P6IaC3IhjeD0Ktyj?= =?us-ascii?Q?sLskht3RWyXkg8Q19jBenj1bhlble1bS+Hsofk9Myj2bbyosM+cJBkWd0rQh?= =?us-ascii?Q?kbopbFy1egEk9QAzSnsKxTdpRWetME18caZ03d3KRr9C/97NmCyYfbhsujtZ?= =?us-ascii?Q?4f8BkjsmLVJVoNzLnDDdPcRj6Gngllu9zo+6R/C8UrPKC+Hr2S2YB+7T9ZUT?= =?us-ascii?Q?eCNv/ejPEM+5b1T9ZR5neoZtljfKmFg52AcImo3YfdibhNuj8Jq+bkJEQtfs?= =?us-ascii?Q?9yhg6Nkx7tWM28kVfbb/BawCMl4QDt/wE10oIN4kY3ayEUb31B4SuDgi1QvG?= =?us-ascii?Q?fRvCRSo5Dl3pvtBNgiKuyJiCt9QFIznmIJLzX1B3sIaVC8nw33w/v7SGllbG?= =?us-ascii?Q?C1WRLTHZ/cnpECUN11JzcsKOaAVQj86gesMJiTnT6OR+s0dANavtu38kes0n?= =?us-ascii?Q?yy2ionPMFgh6tcPzmUWyxmoHzv+e0P5h7XqMVQec9nFW/KcDqPylqbuAOWat?= =?us-ascii?Q?MQ8EUAtL5by52kKKexJrEJ5OqgYpBX2OLT134aerL/s7H1yVXWmKkxpMxwoc?= =?us-ascii?Q?mAW0o14i7cFUjVIfP5mpdgAQAAaMZFtCEnlCkndkvOp0wvW+8IO70PmYgG0Z?= =?us-ascii?Q?2UkaR5Mn8XGsMWIdYRwoQioTnlvgKdrq9j163L09SoelBYO3TNruOXEWu+BW?= =?us-ascii?Q?Vi7C+m7C1EY98cvdplVsms+YhMdIf5hHVjBd8Qdp+jMO6FtKWLL4NKKJa5YU?= =?us-ascii?Q?zu2RhdN/I5fa3y3LyZn0AXjsnN2CtaypfARq1lcqlSPD2WmTUMUfJedKMXfE?= =?us-ascii?Q?0J83k1DlH5+Br+HPlyaB5FrAFdpd+mReqeXeWMLZNId/Ydvf7JJZsqzH0nOr?= =?us-ascii?Q?9XGCSXYvivl3hkaZxxlQAYe3YR06leWAIT/Y+wVQQ3G+ogUSx48IUzXHqBmK?= =?us-ascii?Q?f1JFO+L1i1axw93hXzzLaKnewcy37Y3RySN/EdiPARZ11h48dboXFLlZT6nA?= =?us-ascii?Q?EZOLUv4nRhSsLWAJAkhbuNUe+oAR8JtBp2eL42Xnq3IFWuffdpGHePcu5VIA?= =?us-ascii?Q?x3fcIUqMULpomIzbSOWGq0KGaBpaKF1Y6N8zvOSfqcL2tb6qQxRKwmxn+/48?= =?us-ascii?Q?3tTsEPW5UpEr7EJj8xVLnj/nvKB1QlonG+YsunWbu/0DRplryn16eVIwOVj8?= =?us-ascii?Q?h/epWaJ/XQ9NoJk+1tbQx7xVR9mUOmp62F7RZ92MwaIt4q/W3NYpWQe+ODUm?= =?us-ascii?Q?A2TS5rIzcvCPiM1rZep+yOSHgCu7mBNTFCwOUzmszJ2Cx0agzIpSATAjVAos?= =?us-ascii?Q?EgCWkSb1YMna+I4UU/vJoc1NKPpWw/6i9hOrQq4cWj/l60VS7ukIJ4ruxmkp?= =?us-ascii?Q?moK+RK0FC9gpnsErafH9TGBUbk4p5t/Yr9SRP1vZhAYMYHT8kzMR3abNvK0K?= =?us-ascii?Q?PSV/yonVt/kf9m6DcBFc5v4lksLGnqKkrBDpbTiiJOdZe2vnQ4dXNtrRlbPM?= =?us-ascii?Q?tHuvDbwltJ5bNBClx4o=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92f51085-ba04-4e6c-c5bc-08db60ea772d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2023 08:47:14.1026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XK9ihuiOG7YH6G0IudPJdp+S49W1mE6dbYQ4/iVxWTAvbbZXDtjBK23+EuZH8Gondszh9J706w6VrPgTOD+EWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8142 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -----Original Message----- From: Chang, Abner Sent: Tuesday, May 30, 2023 12:03 PM To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) = ; Nickle Wang ; Tinh Nguyen = Subject: [edk2-platforms][PATCH 1/2] ManageabilityPkg: Replace __FUNCTION__= with __func__ From: Abner Chang Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- .../BaseManageabilityTransportHelper.c | 36 +++++++++---------- .../Common/KcsCommon.c | 12 +++---- .../Dxe/ManageabilityTransportKcs.c | 28 +++++++-------- .../Dxe/ManageabilityTransportMctp.c | 22 ++++++------ .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 4 +-- .../IpmiProtocol/Common/IpmiProtocolCommon.c | 14 ++++---- .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 14 ++++---- .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 18 +++++----- .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 14 ++++---- .../MctpProtocol/Common/MctpProtocolCommon.c | 30 ++++++++-------- .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 18 +++++----- .../PldmProtocol/Common/PldmProtocolCommon.c | 20 +++++------ .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 14 ++++---- .../PldmSmbiosTransferDxe.c | 22 ++++++------ 14 files changed, 133 insertions(+), 133 deletions(-) diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Libr= ary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c index ce68f89531..f72957ea7f 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c @@ -49,7 +49,7 @@ HelperManageabilitySpecName ( } if ((SpecificationGuid =3D=3D NULL) || IsZeroGuid (SpecificationGuid)) { - DEBUG ((DEBUG_ERROR, "%a: Improper input GUIDs, could be NULL or zero = GUID.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Improper input GUIDs, could be NULL or zero = GUID.\n", __func__)); return NULL; } @@ -106,7 +106,7 @@ HelperManageabilityCheckSupportedSpec ( IsZeroGuid (ManageabilityProtocolToCheck) ) { - DEBUG ((DEBUG_ERROR, "%a: Improper input GUIDs, could be NULL or zero = GUID.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Improper input GUIDs, could be NULL or zero = GUID.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -120,7 +120,7 @@ HelperManageabilityCheckSupportedSpec ( DEBUG (( DEBUG_MANAGEABILITY_INFO, "%a: Transport interface %s supports %s manageability specificatio= n.\n", - __FUNCTION__, + __func__, HelperManageabilitySpecName (TransportGuid), HelperManageabilitySpecName (ManageabilityProtocolToCheck) )); @@ -133,7 +133,7 @@ HelperManageabilityCheckSupportedSpec ( DEBUG (( DEBUG_ERROR, "%a: Transport interface %s doesn't support %s manageability specifica= tion.\n", - __FUNCTION__, + __func__, HelperManageabilitySpecName (TransportGuid), HelperManageabilitySpecName (ManageabilityProtocolToCheck) )); @@ -163,16 +163,16 @@ HelperAcquireManageabilityTransport ( CHAR16 *ManageabilityProtocolName; CHAR16 *ManageabilityTransportName; - DEBUG ((DEBUG_INFO, "%a: Entry\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Entry\n", __func__)); if ((TransportToken =3D=3D NULL) || (ManageabilityProtocolSpec =3D=3D NU= LL)) { - DEBUG ((DEBUG_ERROR, "%a: One of the required input parameters is NULL= .\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: One of the required input parameters is NULL= .\n", __func__)); return EFI_INVALID_PARAMETER; } *TransportToken =3D NULL; ManageabilityProtocolName =3D HelperManageabilitySpecName (Manageability= ProtocolSpec); if (ManageabilityProtocolName =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Unsupported Manageability Protocol Specifica= tion.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Unsupported Manageability Protocol Specifica= tion.\n", __func__)); return EFI_UNSUPPORTED; } @@ -180,7 +180,7 @@ HelperAcquireManageabilityTransport ( Status =3D AcquireTransportSession (ManageabilityProtocolSpec, Transport= Token); if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: No supported transport interface for %s pack= et.\n", __FUNCTION__, ManageabilityProtocolName)); + DEBUG ((DEBUG_ERROR, "%a: No supported transport interface for %s pack= et.\n", __func__, ManageabilityProtocolName)); return Status; } @@ -188,7 +188,7 @@ HelperAcquireManageabilityTransport ( DEBUG (( DEBUG_ERROR, "%a: Fail to acquire Manageability transport token for %s (%r).\n", - __FUNCTION__, + __func__, ManageabilityProtocolName, Status )); @@ -197,11 +197,11 @@ HelperAcquireManageabilityTransport ( ManageabilityTransportName =3D HelperManageabilitySpecName ((*TransportT= oken)->Transport->ManageabilityTransportSpecification); if (ManageabilityTransportName =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Unsupported Manageability Transport Interfac= e Specification\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Unsupported Manageability Transport Interfac= e Specification\n", __func__)); return EFI_UNSUPPORTED; } - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: This is the transfer session for = %s over %s\n", __FUNCTION__, ManageabilityProtocolName, ManageabilityTransp= ortName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: This is the transfer session for = %s over %s\n", __func__, ManageabilityProtocolName, ManageabilityTransportN= ame)); return Status; } @@ -227,7 +227,7 @@ HelperInitManageabilityTransport ( EFI_STATUS Status; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: TransportToken is invalid.\n", __FUNCTION__)= ); + DEBUG ((DEBUG_ERROR, "%a: TransportToken is invalid.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -242,20 +242,20 @@ HelperInitManageabilityTransport ( ); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: Transport interface doesn't have reset= capability.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Transport interface doesn't have reset= capability.\n", __func__)); } else { - DEBUG ((DEBUG_ERROR, "%a: Fail to reset transport interface (%r)= .\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to reset transport interface (%r)= .\n", __func__, Status)); } Status =3D EFI_DEVICE_ERROR; } else { Status =3D TransportToken->Transport->Function.Version1_0->Transpo= rtInit (TransportToken, HardwareInfo); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Transport interface is not able to use= after the reset (%r).\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Transport interface is not able to use= after the reset (%r).\n", __func__, Status)); } } } else { - DEBUG ((DEBUG_ERROR, "%a: Transport interface is not able to use (%r= ).\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Transport interface is not able to use (%r= ).\n", __func__, Status)); } } @@ -343,7 +343,7 @@ HelperManageabilitySplitPayload ( DEBUG (( DEBUG_ERROR, "%a: (Preamble 0x%x + PostambleSize 0x%x) is greater than MaximumTra= nsferUnit 0x%x.\n", - __FUNCTION__, + __func__, PreambleSize, PostambleSize, MaximumTransferUnit @@ -373,7 +373,7 @@ HelperManageabilitySplitPayload ( } if (TotalPayloadRemaining !=3D 0) { - DEBUG ((DEBUG_ERROR, "%a: Error processing multiple packages (TotalPay= loadRemaining !=3D 0)\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Error processing multiple packages (TotalPay= loadRemaining !=3D 0)\n", __func__)); FreePool (ThisMultiplePackages); return EFI_INVALID_PARAMETER; } diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib= /Common/KcsCommon.c b/Features/ManageabilityPkg/Library/ManageabilityTransp= ortKcsLib/Common/KcsCommon.c index 4693e7f06f..d5b54c04be 100644 --- a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common= /KcsCommon.c +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Common= /KcsCommon.c @@ -143,7 +143,7 @@ KcsTransportWrite ( ((RequestData !=3D NULL) && (RequestDataSize =3D=3D 0)) ) { - DEBUG ((DEBUG_ERROR, "%a: Mismatched values of RequestData or RequestD= ataSize.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Mismatched values of RequestData or RequestD= ataSize.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -152,7 +152,7 @@ KcsTransportWrite ( ((TransmitHeader !=3D NULL) && (TransmitHeaderSize =3D=3D 0)) ) { - DEBUG ((DEBUG_ERROR, "%a: Mismatched values of TransmitHeader or Trans= mitHeaderSize.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Mismatched values of TransmitHeader or Trans= mitHeaderSize.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -161,7 +161,7 @@ KcsTransportWrite ( ((TransmitTrailer !=3D NULL) && (TransmitTrailerSize =3D=3D 0)) ) { - DEBUG ((DEBUG_ERROR, "%a: Mismatched values of TransmitTrailer or Tran= smitTrailerSize.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Mismatched values of TransmitTrailer or Tran= smitTrailerSize.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -325,7 +325,7 @@ KcsTransportRead ( UINT32 ReadLength; if ((DataByte =3D=3D NULL) || (*Length =3D=3D 0)) { - DEBUG ((DEBUG_ERROR, "%a: Either DataByte is NULL or Length is 0.\n", = __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Either DataByte is NULL or Length is 0.\n", = __func__)); return EFI_INVALID_PARAMETER; } @@ -430,12 +430,12 @@ KcsTransportSendCommand ( CHAR16 *CompletionCodeStr; if ((RequestData !=3D NULL) && (RequestDataSize =3D=3D 0)) { - DEBUG ((DEBUG_ERROR, "%a: Mismatched values of RequestData and Request= DataSize\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Mismatched values of RequestData and Request= DataSize\n", __func__)); return EFI_INVALID_PARAMETER; } if ((ResponseData !=3D NULL) && ((ResponseDataSize !=3D NULL) && (*Respo= nseDataSize =3D=3D 0))) { - DEBUG ((DEBUG_ERROR, "%a: Mismatched values of ResponseData and Respon= seDataSize\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Mismatched values of ResponseData and Respon= seDataSize\n", __func__)); return EFI_INVALID_PARAMETER; } diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib= /Dxe/ManageabilityTransportKcs.c b/Features/ManageabilityPkg/Library/Manage= abilityTransportKcsLib/Dxe/ManageabilityTransportKcs.c index c690bea74e..9bd8ff4c0a 100644 --- a/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/Ma= nageabilityTransportKcs.c +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/Ma= nageabilityTransportKcs.c @@ -58,12 +58,12 @@ KcsTransportInit ( CHAR16 *ManageabilityProtocolName; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __func__)); return EFI_INVALID_PARAMETER; } if (HardwareInfo.Kcs =3D=3D NULL) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Hardware information is not pro= vided, use dfault settings.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Hardware information is not pro= vided, use dfault settings.\n", __func__)); mKcsHardwareInfo.MemoryMap =3D MANAGEABILITY_TRANSP= ORT_KCS_IO_MAP_IO; mKcsHardwareInfo.IoBaseAddress.IoAddress16 =3D PcdGet16 (PcdIpmiKcs= IoBaseAddress); mKcsHardwareInfo.IoDataInAddress.IoAddress16 =3D mKcsHardwareInfo.IoB= aseAddress.IoAddress16 + IPMI_KCS_DATA_IN_REGISTER_OFFSET; @@ -82,9 +82,9 @@ KcsTransportInit ( // Get protocol specification name. ManageabilityProtocolName =3D HelperManageabilitySpecName (TransportToke= n->ManageabilityProtocolSpecification); - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: KCS transport hardware for %s is:= \n", __FUNCTION__, ManageabilityProtocolName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: KCS transport hardware for %s is:= \n", __func__, ManageabilityProtocolName)); if (mKcsHardwareInfo.MemoryMap) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "Memory Map I/O\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "Memory Map I/O\n", __func__)); DEBUG ((DEBUG_MANAGEABILITY_INFO, "Base Memory Address : 0x%08x\n", mK= csHardwareInfo.IoBaseAddress.IoAddress32)); DEBUG ((DEBUG_MANAGEABILITY_INFO, "Data in Address : 0x%08x\n", mK= csHardwareInfo.IoDataInAddress.IoAddress32)); DEBUG ((DEBUG_MANAGEABILITY_INFO, "Data out Address : 0x%08x\n", mK= csHardwareInfo.IoDataOutAddress.IoAddress32)); @@ -134,7 +134,7 @@ KcsTransportStatus ( UINT8 TransportStatus; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -223,7 +223,7 @@ KcsTransportTransmitReceive ( MANAGEABILITY_TRANSPORT_ADDITIONAL_STATUS AdditionalStatus; if ((TransportToken =3D=3D NULL) || (TransferToken =3D=3D NULL)) { - DEBUG ((DEBUG_ERROR, "%a: Invalid transport token or transfer token.\n= ", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Invalid transport token or transfer token.\n= ", __func__)); return; } @@ -267,12 +267,12 @@ AcquireTransportSession ( MANAGEABILITY_TRANSPORT_KCS *KcsTransportToken; if (ManageabilityProtocolSpec =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: No Manageability protocol specification spec= ified.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No Manageability protocol specification spec= ified.\n", __func__)); return EFI_INVALID_PARAMETER; } if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: TransportToken is NULL.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: TransportToken is NULL.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -283,25 +283,25 @@ AcquireTransportSession ( ManageabilityProtocolSpec ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Protocol is not supported on this transport = interface.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Protocol is not supported on this transport = interface.\n", __func__)); return EFI_UNSUPPORTED; } if (mSingleSessionToken !=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: This manageability transport library only su= pports one session transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: This manageability transport library only su= pports one session transport token.\n", __func__)); return EFI_OUT_OF_RESOURCES; } KcsTransportToken =3D AllocateZeroPool (sizeof (MANAGEABILITY_TRANSPORT_= KCS)); if (KcsTransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_KCS\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_KCS\n", __func__)); return EFI_OUT_OF_RESOURCES; } KcsTransportToken->Token.Transport =3D AllocateZeroPool (sizeof (MANAGEA= BILITY_TRANSPORT)); if (KcsTransportToken->Token.Transport =3D=3D NULL) { FreePool (KcsTransportToken); - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -312,7 +312,7 @@ AcquireTransportSession ( KcsTransportToken->Token.Transport->TransportName = =3D L"KCS"; KcsTransportToken->Token.Transport->Function.Version1_0 = =3D AllocateZeroPool (sizeof (MANAGEABILITY_TRANSPORT_FUNCTION_V1_0)); if (KcsTransportToken->Token.Transport->Function.Version1_0 =3D=3D NULL)= { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_FUNCTION_V1_0\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_FUNCTION_V1_0\n", __func__)); FreePool (KcsTransportToken); FreePool (KcsTransportToken->Token.Transport); return EFI_OUT_OF_RESOURCES; @@ -406,7 +406,7 @@ ReleaseTransportSession ( } if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to release KCS transport token (%r).\n"= , __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to release KCS transport token (%r).\n"= , __func__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Library/ManageabilityTransportMctpLi= b/Dxe/ManageabilityTransportMctp.c b/Features/ManageabilityPkg/Library/Mana= geabilityTransportMctpLib/Dxe/ManageabilityTransportMctp.c index eaf02bbb0a..c520e2302d 100644 --- a/Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/M= anageabilityTransportMctp.c +++ b/Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/M= anageabilityTransportMctp.c @@ -86,7 +86,7 @@ MctpTransportStatus ( ) { if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -161,7 +161,7 @@ MctpTransportTransmitReceive ( MANAGEABILITY_MCTP_TRANSPORT_HEADER *TransmitHeader; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Invalid transport token.\n", __func__)); TransferToken->TransportAdditionalStatus =3D MANAGEABILITY_TRANSPORT_A= DDITIONAL_STATUS_NOT_AVAILABLE; return; } @@ -183,7 +183,7 @@ MctpTransportTransmitReceive ( // // Dxe MCTP Protocol is not installed. // - DEBUG ((DEBUG_ERROR, "%a: EDKII MCTP protocol is not found - %r\n", = __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: EDKII MCTP protocol is not found - %r\n", = __func__, Status)); return; } } @@ -191,7 +191,7 @@ MctpTransportTransmitReceive ( DEBUG (( DEBUG_MANAGEABILITY_INFO, "%a: MCTP message type: 0x%x, SourceEndpointId: 0x%x, DestinationEndpo= intId: 0x%x\n", - __FUNCTION__, + __func__, TransmitHeader->MessageHeader.MessageType, TransmitHeader->SourceEndpointId, TransmitHeader->DestinationEndpointId @@ -242,7 +242,7 @@ AcquireTransportSession ( MANAGEABILITY_TRANSPORT_MCTP *MctpTransportToken; if (ManageabilityProtocolSpec =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: No Manageability protocol specification spec= ified.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No Manageability protocol specification spec= ified.\n", __func__)); return EFI_INVALID_PARAMETER; } @@ -253,25 +253,25 @@ AcquireTransportSession ( ManageabilityProtocolSpec ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Protocol is not supported on this transport = interface.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Protocol is not supported on this transport = interface.\n", __func__)); return EFI_UNSUPPORTED; } if (mSingleSessionToken !=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: This manageability transport library only su= pports one session transport token.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: This manageability transport library only su= pports one session transport token.\n", __func__)); return EFI_OUT_OF_RESOURCES; } MctpTransportToken =3D (MANAGEABILITY_TRANSPORT_MCTP *)AllocateZeroPool = (sizeof (MANAGEABILITY_TRANSPORT_MCTP)); if (MctpTransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_MCTP\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_MCTP\n", __func__)); return EFI_OUT_OF_RESOURCES; } MctpTransportToken->Token.Transport =3D AllocateZeroPool (sizeof (MANAGE= ABILITY_TRANSPORT)); if (MctpTransportToken->Token.Transport =3D=3D NULL) { FreePool (MctpTransportToken); - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -282,7 +282,7 @@ AcquireTransportSession ( MctpTransportToken->Token.Transport->TransportName = =3D L"MCTP"; MctpTransportToken->Token.Transport->Function.Version1_0 = =3D AllocateZeroPool (sizeof (MANAGEABILITY_TRANSPORT_FUNCTION_V1_0)); if (MctpTransportToken->Token.Transport->Function.Version1_0 =3D=3D NULL= ) { - DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_FUNCTION_V1_0\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for MANAGEABILITY_TR= ANSPORT_FUNCTION_V1_0\n", __func__)); FreePool (MctpTransportToken); FreePool (MctpTransportToken->Token.Transport); return EFI_OUT_OF_RESOURCES; @@ -360,7 +360,7 @@ ReleaseTransportSession ( } if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to release MCTP transport token (%r).\n= ", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to release MCTP transport token (%r).\n= ", __func__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/Pldm= ProtocolLib.c b/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/P= ldmProtocolLib.c index 96727054ce..267bd8fbc1 100644 --- a/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtoco= lLib.c +++ b/Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtoco= lLib.c @@ -55,12 +55,12 @@ PldmSubmitCommand ( // // Dxe PLDM Protocol is not installed. So, PLDM device is not presen= t. // - DEBUG ((DEBUG_ERROR, "%a: EDKII PLDM protocol is not found - %r\n", = __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: EDKII PLDM protocol is not found - %r\n", = __func__, Status)); return EFI_NOT_FOUND; } } - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: PLDM Type: 0x%x, Command: 0x%x\n"= , __FUNCTION__, PldmType, Command)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: PLDM Type: 0x%x, Command: 0x%x\n"= , __func__, PldmType, Command)); if ((RequestData !=3D NULL) && (RequestDataSize !=3D 0)) { HelperManageabilityDebugPrint ((VOID *)RequestData, RequestDataSize, "= PLDM PLDM application layer Type/Command specific request payload\n"); } diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Common/Ip= miProtocolCommon.c index b055bad7da..6a09280bcc 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Common/IpmiProtocolC= ommon.c @@ -39,7 +39,7 @@ SetupIpmiTransportHardwareInformation ( KcsHardwareInfo =3D AllocatePool (sizeof (MANAGEABILITY_TRANSPORT_KCS_HA= RDWARE_INFO)); if (KcsHardwareInfo =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_TRANSPOR= T_KCS_HARDWARE_INFO.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_TRANSPOR= T_KCS_HARDWARE_INFO.\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -54,7 +54,7 @@ SetupIpmiTransportHardwareInformation ( HardwareInformation->Kcs =3D KcsHardwareInfo; return EFI_SUCCESS; } else { - DEBUG ((DEBUG_ERROR, "%a: No implementation of setting hardware inform= ation.", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No implementation of setting hardware inform= ation.", __func__)); ASSERT (FALSE); } @@ -131,7 +131,7 @@ SetupIpmiRequestTransportPacket ( *PacketBodySize =3D 0; } } else { - DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _func__)); ASSERT (FALSE); } @@ -179,7 +179,7 @@ CommonIpmiSubmitCommand ( UINT16 TrailerSize; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: No transport toke for IPMI\n", __FUNCTION__)= ); + DEBUG ((DEBUG_ERROR, "%a: No transport toke for IPMI\n", __func__)); return EFI_UNSUPPORTED; } @@ -188,7 +188,7 @@ CommonIpmiSubmitCommand ( &TransportAdd= itionalStatus ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Transport for IPMI has problem - (%r)\n", __= FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Transport for IPMI has problem - (%r)\n", __= func__, Status)); return Status; } @@ -208,7 +208,7 @@ CommonIpmiSubmitCommand ( &TrailerSize ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __FUNCTION_= _, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __func__, S= tatus)); return Status; } @@ -256,7 +256,7 @@ CommonIpmiSubmitCommand ( Status =3D TransferToken.TransferStatus; TransportAdditionalStatus =3D TransferToken.TransportAdditionalStatus; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send IPMI command.\n", __FUNCTION_= _)); + DEBUG ((DEBUG_ERROR, "%a: Failed to send IPMI command.\n", __func__)); return Status; } diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProto= col.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c index 51d5c7f0ba..1660cfbbd5 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocol.c @@ -97,26 +97,26 @@ DxeIpmiEntry ( &mTransportToken ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __func__, Status)); return Status; } Status =3D GetTransportCapability (mTransportToken, &TransportCapability= ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __fu= nc__)); return Status; } TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY (TransportCapability); if (TransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABIL= ITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __func__)); } else { TransportMaximumPayload -=3D 1; - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload %x.\n", __FUNCTION__, TransportMaximumPayload)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload %x.\n", __func__, TransportMaximumPayload)); } mTransportName =3D HelperManageabilitySpecName (mTransportToken->Transpo= rt->ManageabilityTransportSpecification); - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __FUNC= TION__, mTransportName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __func= __, mTransportName)); // // Setup hardware information according to the transport interface. @@ -126,7 +126,7 @@ DxeIpmiEntry ( ); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __FUNCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __func__, mTransportName)); } return Status; @@ -151,7 +151,7 @@ DxeIpmiEntry ( (VOID **)&mIpmiProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI protocol - %r\n", __F= UNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI protocol - %r\n", __f= unc__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c= b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c index 4bbdbf78fe..a6bdb27464 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpi.c @@ -96,13 +96,13 @@ PeiIpmiEntry ( // PeiIpmiPpiinternal =3D (PEI_IPMI_PPI_INTERNAL *)AllocateZeroPool (sizeof= (PEI_IPMI_PPI_INTERNAL)); if (PeiIpmiPpiinternal =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for PEI_IPMI_PPI_INTERNAL.= \n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for PEI_IPMI_PPI_INTERNAL.= \n", __func__)); return EFI_OUT_OF_RESOURCES; } PpiDescriptor =3D (EFI_PEI_PPI_DESCRIPTOR *)AllocateZeroPool (sizeof (EF= I_PEI_PPI_DESCRIPTOR)); if (PpiDescriptor =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for EFI_PEI_PPI_DESCRIPTOR= .\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for EFI_PEI_PPI_DESCRIPTOR= .\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -118,26 +118,26 @@ PeiIpmiEntry ( &PeiIpmiPpiinternal->TransportToken ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __func__, Status)); return Status; } Status =3D GetTransportCapability (PeiIpmiPpiinternal->TransportToken, &= PeiIpmiPpiinternal->TransportCapability); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __fu= nc__)); return Status; } PeiIpmiPpiinternal->TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_= PAYLOAD_SIZE_FROM_CAPABILITY (PeiIpmiPpiinternal->TransportCapability); if (PeiIpmiPpiinternal->TransportMaximumPayload =3D=3D (1 << MANAGEABIL= ITY_TRANSPORT_CAPABILITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __func__)); } else { PeiIpmiPpiinternal->TransportMaximumPayload -=3D 1; - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload 0x%x.\n", __FUNCTION__, PeiIpmiPpiinternal->Tran= sportMaximumPayload)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload 0x%x.\n", __func__, PeiIpmiPpiinternal->Transpor= tMaximumPayload)); } TransportName =3D HelperManageabilitySpecName (PeiIpmiPpiinternal->Trans= portToken->Transport->ManageabilityTransportSpecification); - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __FUNC= TION__, TransportName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __func= __, TransportName)); // // Setup hardware information according to the transport interface. @@ -147,7 +147,7 @@ PeiIpmiEntry ( ); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __FUNCTION__, TransportName)); + DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __func__, TransportName)); } return Status; @@ -169,7 +169,7 @@ PeiIpmiEntry ( // Status =3D PeiServicesInstallPpi (PpiDescriptor); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI PPI - %r\n", __FUNCTI= ON__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI PPI - %r\n", __func__= , Status)); } return Status; diff --git a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProto= col.c b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c index e4cd166b7a..aaa48b24e2 100644 --- a/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocol.c @@ -98,26 +98,26 @@ SmmIpmiEntry ( &mTransportToken ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for IP= MI protocol - %r\n", __func__, Status)); return Status; } Status =3D GetTransportCapability (mTransportToken, &TransportCapability= ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __fu= nc__)); return Status; } TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY (TransportCapability); if (TransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABIL= ITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __func__)); } else { TransportMaximumPayload -=3D 1; - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)= ); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for IPMI pr= otocol has maximum payload 0x%x.\n", __func__, TransportMaximumPayload)); } mTransportName =3D HelperManageabilitySpecName (mTransportToken->Transpo= rt->ManageabilityTransportSpecification); - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __FUNC= TION__, mTransportName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: IPMI protocol over %s.\n", __func= __, mTransportName)); // // Setup hardware information according to the transport interface. @@ -127,7 +127,7 @@ SmmIpmiEntry ( ); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __FUNCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __func__, mTransportName)); } return Status; @@ -152,7 +152,7 @@ SmmIpmiEntry ( (VOID **)&mIpmiProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI SMM protocol - %r\n",= __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to install IPMI SMM protocol - %r\n",= __func__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index db572ec85a..1ad48efdc7 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -52,7 +52,7 @@ SetupMctpTransportHardwareInformation ( if (CompareGuid (&gManageabilityTransportKcsGuid, TransportToken->Transp= ort->ManageabilityTransportSpecification)) { KcsHardwareInfo =3D AllocatePool (sizeof (MANAGEABILITY_TRANSPORT_KCS_= HARDWARE_INFO)); if (KcsHardwareInfo =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_TRANSP= ORT_KCS_HARDWARE_INFO.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_TRANSP= ORT_KCS_HARDWARE_INFO.\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -76,7 +76,7 @@ SetupMctpTransportHardwareInformation ( HardwareInformation->Kcs =3D KcsHardwareInfo; return EFI_SUCCESS; } else { - DEBUG ((DEBUG_ERROR, "%a: No implementation of setting hardware inform= ation.", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No implementation of setting hardware inform= ation.", __func__)); ASSERT (FALSE); } @@ -140,20 +140,20 @@ SetupMctpRequestTransportPacket ( (PacketTrailer =3D=3D NULL) || (PacketTrailerSize =3D=3D NULL) ) { - DEBUG ((DEBUG_ERROR, "%a: One or more than one of the input parameter = is invalid.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: One or more than one of the input parameter = is invalid.\n", __func__)); return EFI_INVALID_PARAMETER; } if (CompareGuid (&gManageabilityTransportKcsGuid, TransportToken->Transp= ort->ManageabilityTransportSpecification)) { MctpKcsHeader =3D (MANAGEABILITY_MCTP_KCS_HEADER *)AllocateZeroPool (s= izeof (MANAGEABILITY_MCTP_KCS_HEADER)); if (MctpKcsHeader =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough resource for MANAGEABILITY_MCTP= _KCS_HEADER.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough resource for MANAGEABILITY_MCTP= _KCS_HEADER.\n", __func__)); return EFI_OUT_OF_RESOURCES; } Pec =3D (UINT8 *)AllocateZeroPool (sizeof (UINT8)); if (Pec =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough resource for PEC.\n", __FUNCTIO= N__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough resource for PEC.\n", __func__)= ); FreePool (MctpKcsHeader); return EFI_OUT_OF_RESOURCES; } @@ -165,7 +165,7 @@ SetupMctpRequestTransportPacket ( ThisPackage =3D (UINT8 *)AllocateZeroPool (MctpKcsHeader->ByteCount); if (ThisPackage =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough resource for package.\n", __FUN= CTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough resource for package.\n", __fun= c__)); FreePool (MctpKcsHeader); FreePool (Pec); return EFI_OUT_OF_RESOURCES; @@ -203,7 +203,7 @@ SetupMctpRequestTransportPacket ( *PacketTrailerSize =3D 1; return EFI_SUCCESS; } else { - DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _func__)); ASSERT (FALSE); } @@ -269,7 +269,7 @@ CommonMctpSubmitMessage ( MANAGEABILITY_TRANSMISSION_PACKAGE_ATTR *ThisPackage; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: No transport toke for MCTP\n", __FUNCTION__)= ); + DEBUG ((DEBUG_ERROR, "%a: No transport toke for MCTP\n", __func__)); return EFI_UNSUPPORTED; } @@ -278,7 +278,7 @@ CommonMctpSubmitMessage ( AdditionalTra= nsferError ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Transport %s for MCTP has problem - (%r)\n",= __FUNCTION__, mTransportName, Status)); + DEBUG ((DEBUG_ERROR, "%a: Transport %s for MCTP has problem - (%r)\n",= __func__, mTransportName, Status)); return Status; } @@ -292,7 +292,7 @@ CommonMctpSubmitMessage ( &MultiPackages ); if (EFI_ERROR (Status) || (MultiPackages =3D=3D NULL)) { - DEBUG ((DEBUG_ERROR, "%a: Fails to split payload into multiple package= s - (%r)\n", __FUNCTION__, mTransportName, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fails to split payload into multiple package= s - (%r)\n", __func__, mTransportName, Status)); return Status; } @@ -342,7 +342,7 @@ CommonMctpSubmitMessage ( &MctpTransportTrailerSize ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __FUNCTIO= N__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __func__,= Status)); return Status; } @@ -373,7 +373,7 @@ CommonMctpSubmitMessage ( DEBUG (( DEBUG_MANAGEABILITY_INFO, "%a: Send MCTP message type: 0x%x, from source endpoint ID: 0x%x to = destination ID 0x%x: Request size: 0x%x, Response size: 0x%x\n", - __FUNCTION__, + __func__, MctpType, MctpSourceEndpointId, MctpDestinationEndpointId, @@ -426,7 +426,7 @@ CommonMctpSubmitMessage ( Status =3D TransferToken.TransferStatus; *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s\n", __= FUNCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s\n", __= func__, mTransportName)); FreePool (MultiPackages); return Status; } @@ -449,7 +449,7 @@ CommonMctpSubmitMessage ( DEBUG (( DEBUG_MANAGEABILITY_INFO, "%a: Retrieve MCTP message Response size: 0x%x\n", - __FUNCTION__, + __func__, TransferToken.ReceivePackage.ReceiveSizeInByte )); TransportToken->Transport->Function.Version1_0->TransportTransmitReceive= ( @@ -464,7 +464,7 @@ CommonMctpSubmitMessage ( *ResponseDataSize =3D TransferToken.ReceivePackage.ReceiveSizeInB= yte; Status =3D TransferToken.TransferStatus; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __FUNCTION__, mTransportName, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); return Status; } diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProto= col.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c index a1cac61e27..88bfd9b7e7 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c @@ -74,7 +74,7 @@ MctpSubmitMessage ( EFI_STATUS Status; if ((RequestData =3D=3D NULL) && (ResponseData =3D=3D NULL)) { - DEBUG ((DEBUG_ERROR, "%a: Both RequestData and ResponseData are NULL\n= ", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Both RequestData and ResponseData are NULL\n= ", __func__)); return EFI_INVALID_PARAMETER; } @@ -127,26 +127,26 @@ DxeMctpEntry ( &mTransportToken ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for MC= TP protocol - %r\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for MC= TP protocol - %r\n", __func__, Status)); return Status; } Status =3D GetTransportCapability (mTransportToken, &TransportCapability= ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __fu= nc__)); return Status; } mTransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_C= APABILITY (TransportCapability); if (mTransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABI= LITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __func__)); } else { mTransportMaximumPayload -=3D 1; - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for MCTP pr= otocol has maximum payload 0x%x.\n", __FUNCTION__, mTransportMaximumPayload= )); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for MCTP pr= otocol has maximum payload 0x%x.\n", __func__, mTransportMaximumPayload)); } mTransportName =3D HelperManageabilitySpecName (mTransportToken->Transpo= rt->ManageabilityTransportSpecification); - DEBUG ((DEBUG_ERROR, "%a: MCTP protocol over %s.\n", __FUNCTION__, mTran= sportName)); + DEBUG ((DEBUG_ERROR, "%a: MCTP protocol over %s.\n", __func__, mTranspor= tName)); // // Setup hardware information according to the transport interface. @@ -156,9 +156,9 @@ DxeMctpEntry ( ); if (EFI_ERROR (Status)) { if (Status =3D=3D EFI_UNSUPPORTED) { - DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __FUNCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: No hardware information of %s transport in= terface.\n", __func__, mTransportName)); } else { - DEBUG ((DEBUG_ERROR, "%a: Failed to setup hardware information of %s= transport interface.\n", __FUNCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: Failed to setup hardware information of %s= transport interface.\n", __func__, mTransportName)); } return Status; @@ -184,7 +184,7 @@ DxeMctpEntry ( (VOID **)&mMctpProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to install EDKII MCTP protocol - %r\n= ", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to install EDKII MCTP protocol - %r\n= ", __func__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index bb4d3f61a0..ce1e2cba95 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -104,17 +104,17 @@ SetupPldmRequestTransportPacket ( (PacketTrailer =3D=3D NULL) || (PacketTrailerSize =3D=3D NULL) ) { - DEBUG ((DEBUG_ERROR, "%a: One or more than one of the required paramet= ers is NULL.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: One or more than one of the required paramet= ers is NULL.\n", __func__)); return EFI_INVALID_PARAMETER; } if (CompareGuid (&gManageabilityTransportMctpGuid, TransportToken->Trans= port->ManageabilityTransportSpecification)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Setup transport header for PLDM= over MCTP.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Setup transport header for PLDM= over MCTP.\n", __func__)); // This is MCTP transport interface. MctpHeader =3D AllocateZeroPool (sizeof (MANAGEABILITY_MCTP_TRANSPORT_= HEADER)); if (MctpHeader =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_MCTP_T= RANSPORT_HEADER.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for MANAGEABILITY_MCTP_T= RANSPORT_HEADER.\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -127,7 +127,7 @@ SetupPldmRequestTransportPacket ( *PacketTrailer =3D NULL; *PacketTrailerSize =3D 0; } else { - DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.\n",= __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.\n",= __func__)); ASSERT (FALSE); } @@ -136,7 +136,7 @@ SetupPldmRequestTransportPacket ( // PldmRequestHeader =3D (PLDM_REQUEST_HEADER *)AllocateZeroPool (sizeof (P= LDM_REQUEST_HEADER) + *PacketBodySize); if (PldmRequestHeader =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: Not enough memory for final PLDM request mes= sage.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Not enough memory for final PLDM request mes= sage.\n", __func__)); return EFI_OUT_OF_RESOURCES; } @@ -202,7 +202,7 @@ CommonPldmSubmitCommand ( UINT16 TrailerSize; if (TransportToken =3D=3D NULL) { - DEBUG ((DEBUG_ERROR, "%a: No transport token for PLDM\n", __FUNCTION__= )); + DEBUG ((DEBUG_ERROR, "%a: No transport token for PLDM\n", __func__)); return EFI_UNSUPPORTED; } @@ -211,7 +211,7 @@ CommonPldmSubmitCommand ( &TransportAdd= itionalStatus ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Transport %s for PLDM has problem - (%r)\n",= __FUNCTION__, mTransportName, Status)); + DEBUG ((DEBUG_ERROR, "%a: Transport %s for PLDM has problem - (%r)\n",= __func__, mTransportName, Status)); return Status; } @@ -233,7 +233,7 @@ CommonPldmSubmitCommand ( &TrailerSize ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __FUNCTION_= _, Status)); + DEBUG ((DEBUG_ERROR, "%a: Fail to build packets - (%r)\n", __func__, S= tatus)); return Status; } @@ -274,7 +274,7 @@ CommonPldmSubmitCommand ( DEBUG (( DEBUG_MANAGEABILITY_INFO, "%a: Send PLDM type: 0x%x, Command: 0x%x: Request size: 0x%x, Response= size: 0x%x\n", - __FUNCTION__, + __func__, PldmType, PldmCommand, TransferToken.TransmitPackage.TransmitSizeInByte, @@ -409,7 +409,7 @@ CommonPldmSubmitCommand ( ErrorExit: Status =3D TransferToken.TransferStatus; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send PLDM command over %s\n", __FU= NCTION__, mTransportName)); + DEBUG ((DEBUG_ERROR, "%a: Failed to send PLDM command over %s\n", __fu= nc__, mTransportName)); } ErrorExit2: diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProto= col.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c index bb34fec16e..b2ca69b05f 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c @@ -57,7 +57,7 @@ PldmSubmitCommand ( EFI_STATUS Status; if ((RequestData =3D=3D NULL) && (ResponseData =3D=3D NULL)) { - DEBUG ((DEBUG_ERROR, "%a: Both RequestData and ResponseData are NULL\n= ", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Both RequestData and ResponseData are NULL\n= ", __func__)); return EFI_INVALID_PARAMETER; } @@ -106,26 +106,26 @@ DxePldmProtocolEntry ( &mTransportToken ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for PL= DM protocol - %r\n", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to acquire transport interface for PL= DM protocol - %r\n", __func__, Status)); return Status; } Status =3D GetTransportCapability (mTransportToken, &TransportCapability= ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __FU= NCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Failed to GetTransportCapability().\n", __fu= nc__)); return Status; } TransportMaximumPayload =3D MANAGEABILITY_TRANSPORT_PAYLOAD_SIZE_FROM_CA= PABILITY (TransportCapability); if (TransportMaximumPayload =3D=3D (1 << MANAGEABILITY_TRANSPORT_CAPABIL= ITY_MAXIMUM_PAYLOAD_NOT_AVAILABLE)) { - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __FUNCTION__)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface maximum pay= load is undefined.\n", __func__)); } else { TransportMaximumPayload -=3D 1; - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for PLDM pr= otocol has maximum payload 0x%x.\n", __FUNCTION__, TransportMaximumPayload)= ); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: Transport interface for PLDM pr= otocol has maximum payload 0x%x.\n", __func__, TransportMaximumPayload)); } mTransportName =3D HelperManageabilitySpecName (mTransportToken->Transpo= rt->ManageabilityTransportSpecification); - DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: PLDM protocol over %s.\n", __FUNC= TION__, mTransportName)); + DEBUG ((DEBUG_MANAGEABILITY_INFO, "%a: PLDM protocol over %s.\n", __func= __, mTransportName)); // Initial transport interface with the hardware information assigned. HardwareInfo.Pointer =3D NULL; @@ -149,7 +149,7 @@ DxePldmProtocolEntry ( (VOID **)&mPldmProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to install EDKII PLDM protocol - %r\n= ", __FUNCTION__, Status)); + DEBUG ((DEBUG_ERROR, "%a: Failed to install EDKII PLDM protocol - %r\n= ", __func__, Status)); } return Status; diff --git a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/Pldm= SmbiosTransferDxe.c b/Features/ManageabilityPkg/Universal/PldmSmbiosTransfe= rDxe/PldmSmbiosTransferDxe.c index 88b190757d..f897162bb5 100644 --- a/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c +++ b/Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosT= ransferDxe.c @@ -147,7 +147,7 @@ GetSmbiosStructureTableMetaData ( EFI_STATUS Status; UINT32 ResponseSize; - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table metafile.\n", __FUNC= TION__)); + DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table metafile.\n", __func= __)); ResponseSize =3D sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA); Status =3D PldmSubmitCommand ( @@ -159,7 +159,7 @@ GetSmbiosStructureTableMetaData ( &ResponseSize ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fails to get SMBIOS structure table metafile= .\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fails to get SMBIOS structure table metafile= .\n", __func__)); } if (ResponseSize !=3D 0) { @@ -194,7 +194,7 @@ SetSmbiosStructureTableMetaData ( UINT32 ResponseSize; UINT32 RequestSize; - DEBUG ((DEBUG_INFO, "%a: Get SMBIOS structure table metafile.\n", __FUNC= TION__)); + DEBUG ((DEBUG_INFO, "%a: Get SMBIOS structure table metafile.\n", __func= __)); RequestSize =3D sizeof (PLDM_SMBIOS_STRUCTURE_TABLE_METADATA); ResponseSize =3D 0; @@ -208,7 +208,7 @@ SetSmbiosStructureTableMetaData ( &ResponseSize ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fails to set SMBIOS structure table metafile= .\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fails to set SMBIOS structure table metafile= .\n", __func__)); } return Status; @@ -236,7 +236,7 @@ GetSmbiosStructureTable ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -272,7 +272,7 @@ SetSmbiosStructureTable ( EFI_SMBIOS_TABLE_HEADER *Record; PLDM_SET_SMBIOS_STRUCTURE_TABLE_REQUEST *PldmSetSmbiosStructureTable; - DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Set SMBIOS structure table.\n", __func__)); Status =3D gBS->LocateProtocol ( &gEfiSmbiosProtocolGuid, @@ -382,7 +382,7 @@ SetSmbiosStructureTable ( } if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Set SMBIOS structure table.\n", __FUNCTION__= )); + DEBUG ((DEBUG_ERROR, "%a: Set SMBIOS structure table.\n", __func__)); } if ((ResponseSize !=3D 0) && (ResponseSize <=3D sizeof (SetSmbiosStructu= reTableHandle))) { @@ -422,7 +422,7 @@ GetSmbiosStructureByType ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -451,7 +451,7 @@ GetSmbiosStructureByHandle ( OUT UINT32 *BufferSize ) { - DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Unsupported.\n", __func__)); // Only support PLDM SMBIOS Transfer push mode. return EFI_UNSUPPORTED; } @@ -486,7 +486,7 @@ DxePldmSmbiosTransferEntry ( EFI_HANDLE Handle; EFI_STATUS Status; - DEBUG ((DEBUG_INFO, "%a: Entry.\n", __FUNCTION__)); + DEBUG ((DEBUG_INFO, "%a: Entry.\n", __func__)); SetSmbiosStructureTableHandle =3D 0; @@ -500,7 +500,7 @@ DxePldmSmbiosTransferEntry ( (VOID **)&mPld= mSmbiosTransferProtocol ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Fail to install EDKII_PLDM_SMBIOS_TRANSFER_P= ROTOCOL.\n", __FUNCTION__)); + DEBUG ((DEBUG_ERROR, "%a: Fail to install EDKII_PLDM_SMBIOS_TRANSFER_P= ROTOCOL.\n", __func__)); } return Status; -- 2.37.1.windows.1