From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7355CAC1642 for ; Wed, 25 Oct 2023 14:24:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FEERVZPsKUpDpsNN26XYTqKokD2BBjBABHCUNep4z/0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698243868; v=1; b=ZREw8Iq+zY2blxtpO57fzJRhj7wnfbrlvwRomZEhCCPmjmsIM+ywQfK0tHh819nMUOtZWnG1 H6PN0fuWdIiLSNiiPR8lj31sVldcAQPom4X0ErBDT5j21DpSwPHmPN7TYQDgWurVyiFXZ1OS1A3 suLzjkosvi1kCOD6KdESXs9k= X-Received: by 127.0.0.2 with SMTP id DS3xYY7687511xcunPfIqnwM; Wed, 25 Oct 2023 07:24:28 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.69]) by mx.groups.io with SMTP id smtpd.web10.169181.1698224251003980702 for ; Wed, 25 Oct 2023 01:57:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mzwx+BZX77XT552dvfApCek5jrMZTPVZpjTSX0trj9aLgyXLZpBdt3jEhNd8nlEe6JHqvfdXFBdXpfgk/ZLCi6RkI1BM4YasZWwRKlyFhP+0uyzgkmcPm7pTdq3XoY4RAwkWK/gYga6imqndm6Rw5CS8rb9DpTOBWTE/nZfVbfHIpnQc8x1KzFMfL8JNSFcDjNxSlUYhg1VnbFaLqgqQUOOAIT9ZU2QYWlHC1m4cST9VO6emJtGBd0xybUQgUiGkQB9E6kR1Xy32QbALoZSEYBJake3+rb5ocnGfZfIaH5STw3hlEDLppeBg9IEK1VdXnc6Y4oa15J5K0SVI6aftzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ETT55qBeGIrUko98WJ0cvOILNkJcVT6Ce78SgzzRnuY=; b=MaZdCW3jAqT/a9ffULoR/qTFjQsR9FBdoZRrYVj3VUS3ZtZ55m7oVXE+/rcUMf5tqOuMfs0XnCncr958ZNg4tMO6WSWrXjS8GNqc8DHC/6M4NatB/jKw6xjdEzFKvcdHd+MObld+3qvAmQVDgvkMwIkrU8TwjlUHUDXOAjuk+Fs2mGVXBRfEq2TcOsztcaBeIQVRVIWPXf6rGQbbU7rCR7LekZQhCSglWQnvyiX29b/2bFe/FSTG3jcTaQonFiZfLQOygXMkAi5K7+oRaS0AivmKgM+zs1lw3pKANd+FE6b4LGRda0U2PLQoh3Gs+hyOjMLPsbhG5Ud9XXZIl/isLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by PH0PR12MB5451.namprd12.prod.outlook.com (2603:10b6:510:ee::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 08:57:28 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6%5]) with mapi id 15.20.6907.022; Wed, 25 Oct 2023 08:57:28 +0000 From: "Attar, AbdulLateef (Abdul Lateef) via groups.io" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "Chang, Abner" , "nicklew@nvidia.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 02/16] ManageabilityPkg: Check MCTP EIDs for reserved values Thread-Topic: [PATCH edk2-platforms v3 02/16] ManageabilityPkg: Check MCTP EIDs for reserved values Thread-Index: AQHaBbGU65SiGNRFZEy9RWmCeOHsYrBaNxXQ Date: Wed, 25 Oct 2023 08:57:28 +0000 Message-ID: References: <20231023130511.4521-1-aladyshev22@gmail.com> <20231023130511.4521-3-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-3-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=05df24c9-6937-4b99-97e4-c021f65eac27;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-25T08:57:09Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|PH0PR12MB5451:EE_ x-ms-office365-filtering-correlation-id: 798df47c-6d5f-4300-284a-08dbd5386a65 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WoR7SZ4ugBoVxmngmfO8DysFPfLRAuYSJNhs+c4Q7JNYKgHNM9BFBO4mOYBQH3EwQJKsRW/Gv5wcDxa8yCqSEduOMRdlKAr9kuOZWyTgA78X8pZtx4aImCF/iw9kMOoc1P8Y2EX50x5Ph/QQrCtd6IUlpHr+YmjNRc1nw/xwxsG9FFdtCKyo0elWguLk3dSX7nQWQjtlPlW8kt+9pf20NhclxN+wdyLS9IlHEEy4QXEILI8h90z4gb6al3M2OwwwyPaWiRB3UBQHrbLP/kpgAvLSepheCY4Ei/8TXr3rJVEpKw9NX1hmPX+R18Rz3RkDUpQ/4DnvdnSupHUFTOOPmG6w/AeMzhUKGYEvLWnmP9aPLfmX64oXJsJH3bq2uw6co34DA7RNuts2nZ8/nOynk+j7Ei0GQ0gpFBaxoG2MbqqeOMlsao0ELzii465lSiruqhe9DmHN6+gDQAmPLlGSSH6c+iHM6G2qPs6mJDCmy4fMfPVDfO6fzbsGV5K/ChrECeaKIBwS4760gnFkFUc0GyapRiQR41lpMwf+wRV7MJq25K5Sxy8CaPGyW2OqkMJS3Xht9hV0QlQbZev/C+fZTj7pzYH4LtVymUcm07qmBRM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V69vubhupVTjGtfHGxrtasmornz9Vrhf7+mMB+mz3j5k2CEqoNbCKsQjUx9x?= =?us-ascii?Q?Eypfpy3u44kipInl9tEOrzhfbec7zuFZr4fxmT3drr0NtZ209/M1thfzGrqY?= =?us-ascii?Q?f4ke76j5TgWqGVnAAPLrLKwxJBEe7gPrLc7pgWJk7jaELq4zWAjeyxF/8FYs?= =?us-ascii?Q?MFbOieh6pNljKPukbaE8CP0SVCQU2i00RswarWZD6T4TeTwEkDRog+D2TMMB?= =?us-ascii?Q?fDMPI+7m+1uiWWvk1h+FCFRoE39P7CIMOcxgGv4AFINexnqcCwky/fQ7QFTo?= =?us-ascii?Q?zB/ml9yGo5sf+5gRywXZMgvbYQPL01sKt4gHDITqZD/2neSUP6XOZ0K9Fwl1?= =?us-ascii?Q?Rbjd6Sz6MHnhOZ33XqeR6LIXl1ppqHCq+oqGQqw/53wdZARAxn46YTgki7Hr?= =?us-ascii?Q?VWCVSwzSEzfiY9Q4kUYnmWrpVZi0hxtLdj7B8U9+U2mAEtZAUOcX9/O0jAMg?= =?us-ascii?Q?7FBVd7qRxd2htlpn+ALqQk5t2ejGKMhhO/Fm1SCyOnF0mp0qO7em9becVO7Q?= =?us-ascii?Q?DsvomZUOKPu5cUAc1iNhfAOyXKKIh5AxcFkdOHzHhxPoOFWlRXEDdRxW7IFl?= =?us-ascii?Q?W3kOhcCSjPq4mzXYzz2cMBIU996V1PoxHzlIktMwL9wY3lwMKpj/PE3EjSiD?= =?us-ascii?Q?xqH75DoL9mqYMz0Rd75zKXQFmR+iuyRIiVQ1rkuU6rPkovCqnOMEp32DmEFI?= =?us-ascii?Q?bSF0rb5qaOFJEss0WdO4tU4hiq8niXDunYHDBLKkw9rSNFU/1VPpQm6X56um?= =?us-ascii?Q?WCwi7J0Nvft3bbHbr63ZJwbFQRJyQ5DgEm7+j4IxvwHhkBUgkCb1HLH1yaKM?= =?us-ascii?Q?jzOtl2yztkxi54VMB51F8kZbHs6pwXAv6zcBOhjWGE+WTuSmmYk7+3X4vOAp?= =?us-ascii?Q?eN6/TjF2VM/X3+jWGNdXXD5y1XgIFidITvA+eYfs/SyaCwxDqZPEgLOs+OYR?= =?us-ascii?Q?PqbMHCo6AthuQnKqb5ZMnEjFn5dCL6ICAoDL7k5IKu7Sw26TrOkJNT8QDulR?= =?us-ascii?Q?4NnQD5BO+g0O0py8LZXdbEgA0lC5bxRO3fSZbVNAEit8dvBPiHSoTWdXShsF?= =?us-ascii?Q?BtePeJdjpfECiA7m1OahrIpjH9suo9kXLGDNtIZ/Jezy62rT25jv3hfimvKR?= =?us-ascii?Q?YUSZsPIZ7TwMlykwiKSo4BauiZllInb2lzsYYPyUoqpQqEFI3kQsOT/W2GRm?= =?us-ascii?Q?P4ixIHRDd5ktS0HoR8IZMtAwZj1SkDvuSFcci59jsxf61sWrOaljHNaXnAK6?= =?us-ascii?Q?6hU0b19Xs5N4c8X8JfuiyZ1J2pOKlS4y1dSDDfYg8exl5lWXNpKj/6XDYPH8?= =?us-ascii?Q?Zc1vm+ulatsrIMgDRK9EqspCTT12S+IwfsloFzrHEw/YTRqYZuNLHu+rm5ZE?= =?us-ascii?Q?x7jb5552No729eRHsC3zMgoTPL33WYaUFah/wVzaBfjHDxnRrtNM/q4KpERy?= =?us-ascii?Q?u9U/lchCv2ryrcC/bS7HRzOweA08tOQc0xD9nkCcoTgRfWwT6CIG6gchaXR9?= =?us-ascii?Q?hOi30/nQim1uofaHQuSwjawU2+hbxHpDIsMPKbBAVi1ELwG18LJ6A7SXU5Yp?= =?us-ascii?Q?8Wox5YmHWkbXgUARYKs=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 798df47c-6d5f-4300-284a-08dbd5386a65 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 08:57:28.2913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BgJ2qR7+9NKzOjzb5I4I+lG6YR3xpbucBzZVrayRVU9Ims14aok8tZZ57T5R2467QQZuDpm30Ny0jbLu0cuwSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5451 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: klnCa84oNiQmqPe6gzVobvnEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZREw8Iq+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Attar, AbdulLateef (Abdul Lateef) ; -----Original Message----- From: Konstantin Aladyshev Sent: Monday, October 23, 2023 6:35 PM To: devel@edk2.groups.io Cc: Chang, Abner ; Attar, AbdulLateef (Abdul Lateef) <= AbdulLateef.Attar@amd.com>; nicklew@nvidia.com; Konstantin Aladyshev Subject: [PATCH edk2-platforms v3 02/16] ManageabilityPkg: Check MCTP EIDs = for reserved values Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. MTCP base specification marks EIDs 1-7 as reserved. Therefore return EFI_IN= VALID_PARAMETER if such EIDs were provided to the MctpSubmitMessage functio= n. Signed-off-by: Konstantin Aladyshev Signed-off-by: Abner Chang --- .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProto= col.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c index 88bfd9b7e7..d0f49a1abb 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol. +++ c @@ -78,6 +78,23 @@ MctpSubmitMessage ( return EFI_INVALID_PARAMETER; } + // + // Check source EID and destination EID + // + if ((MctpSourceEndpointId >=3D MCTP_RESERVED_ENDPOINT_START_ID) && + (MctpSourceEndpointId <=3D MCTP_RESERVED_ENDPOINT_END_ID) + ) { + DEBUG ((DEBUG_ERROR, "%a: The value of MCTP source EID (%x) is + reserved.\n", __func__, MctpSourceEndpointId)); + return EFI_INVALID_PARAMETER; + } + + if ((MctpDestinationEndpointId >=3D MCTP_RESERVED_ENDPOINT_START_ID) && + (MctpDestinationEndpointId <=3D MCTP_RESERVED_ENDPOINT_END_ID) + ) { + DEBUG ((DEBUG_ERROR, "%a: The value of MCTP destination EID (%x) is + reserved.\n", __func__, MctpDestinationEndpointId)); + return EFI_INVALID_PARAMETER; + } + Status =3D CommonMctpSubmitMessage ( mTransportToken, MctpType, -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110057): https://edk2.groups.io/g/devel/message/110057 Mute This Topic: https://groups.io/mt/102134648/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-