From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3D6967803D2 for ; Thu, 17 Aug 2023 11:47:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3pRi3E0KU8s0D4zyuuE4gHRFJjHqdrnOM/sf0NoSfLI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692272818; v=1; b=xBDMbsBs7kRBd1592MlsBWIIh5zAb3Enl2hhlnLXAzfsPF/xPrvH2JmMx9K42x1p2Xq3xmQU Lggwa5oujVwJhBivOiw8evWGu9JVyfX2t0JtFS8uccyP+n4ZjcrEnCH9OYdiFqK8eUDRn9Ba9PV 8+0PeYqJJ6VDejUhSSyobMJ8= X-Received: by 127.0.0.2 with SMTP id HogvYY7687511xPRxOYQ0Oax; Thu, 17 Aug 2023 04:46:58 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.48]) by mx.groups.io with SMTP id smtpd.web11.181139.1692254652622829516 for ; Wed, 16 Aug 2023 23:44:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ONsW6Rn42TKaZVzVnNtT1U6tQpr2XqB6dFXw/KqqdADIXpIXtTddEWsH8qRz8yAm75jdtxvmh2orZxmFhx942rSkGdrqdcDeTWZ3VFmzfixx8DVymjEH6VFIVcdSW1wtLJLDLmsoIqD1G8itYVFzefJKGQiE5Y3S8st/jncZ/HR+49KZ9CztrI7JewIso1fEoDuwGPxOLP1Ne+XXUE16oYfJtspNlq1NrzbzfWUnCKmcgJfSnK5vBE7f7MNGahqLdTvmx16qyOAZOoT/q2WJU9VpkMnC1lvejiplzp+gVUPiEvNIVe9GkxRWSTw6mYqq0y1t7fBbdWUh6U1WaHHshw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdRkEqJGcqtjFyiMnDDywINMHLo64fZMKtwjWyu9tLI=; b=d6lpyj69FEo1OpKXoOIzG/C62+bIEhEJu0YzKDN14KDw+mqy3QtQAh3ZJwzk0yDm9oxVMRj9LEXS2ytNzWXF6iRMzs/Bp05IQZ1JYcnh0gZxOxvt4+hQWrH5qB0k4CrjFo/Vv4S30KzMQBYKPDF+5UpqtpWhHBZYTNIRNZobB4hSfIFazpDQQGuGNhiqwkepKeLH2Ym7o9afgJOdWgBuwZrRf//RgKesuL3v8KOowBawtS7B+ccCI/YxCq5wYSORRQz21m2r1ZumBl+qYt2qDaI1LxP7+Jyj7YVJf9hfr+SjJMmfsKpc+EzRL5XSmILb680cvh+d3NJ9YiSM/4dl5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SA1PR12MB5637.namprd12.prod.outlook.com (2603:10b6:806:228::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.31; Thu, 17 Aug 2023 06:44:08 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::12a:1606:5669:9a9]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::12a:1606:5669:9a9%3]) with mapi id 15.20.6678.025; Thu, 17 Aug 2023 06:44:08 +0000 From: "Attar, AbdulLateef (Abdul Lateef) via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Sai Chaganty , Isaac Oram , Nate DeSimone , Liming Gao Subject: Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Topic: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Index: AQHZxdStI00mTUSPDUmp/pQ29RYc+q/YH6yAgBYBArA= Date: Thu, 17 Aug 2023 06:44:08 +0000 Message-ID: References: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=93560c2c-c3f9-48fb-9e5d-7deafc3bbea1;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-08-03T06:42:04Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|SA1PR12MB5637:EE_ x-ms-office365-filtering-correlation-id: 9b344812-3e63-4e40-842a-08db9eed5bba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AUzMun21bsLu+YyuOeTUoGrAW+kQ8IoSe2yOVzd42Aa2JTrsVIqY7j5SD1u1gUm1JBDF42Oad7GLc/XpTY3Ya1KVt/eu1M3ojzwTR7kzzl1za9h2wfPFdcbyH5D/ESkyvH//DSFaBfZQJEtqGUM6jqMdt0fRF6pQb5wlK65waTVfIQ/6PtTV9+hWI9ZT9zsfQophpjpW/bsvRxV9OR0O/9B1nogGCTqFYNXo5sTqqJWbkHzIunVASAv6lgpuaQurGhy2uwVZ7YTJx/WqmJI/Yv/Nd4MWE4gEGSmdn/BOJZGUJcSgmW71Jtd4TwRbXuGwqm859+GyI17UbYLnqCnoYz19uFIZbomj35Ooa7/CJ91OIbYNceQINawxlTGw37Q1U8lDkw8DesAxRYQa5nvcjndwi7XTGKXeaamfUE8cuPSHk3MMkU7hLgWoR8I8rMStfyHOp5dJJDcr7QwLaebzDeEratgWDRyMezVWQPI19G9P6lOYMMGOVqG2tFoz9xvR6DCe3Wj18yc+KGF3QLK3mjqezYRQq2IewRzF8HbragTGnAbXIVM5z6vXO6wQY8fQJ5sFabE88F/Ph16avjbtw7lSyfzjvxR/Xb/Rw6X/Mw47wy436fKuqEgpu+aBK6yc x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7A/nLFKSBq2HXaFK810nAbTy0za4grFmEA/CslLSSJ3xCCv1gaEpI5zT1i7L?= =?us-ascii?Q?paZEXPD/9+yPt8RKHn93H+KMQBMRTYniTIVtQnw/g7Z7HQITQREZ2QXIQuO7?= =?us-ascii?Q?igPRSOBGLX72GW5muS8lSlKwtFMXcwWUwNaBvthx7o3q+MnEzqtEOI1Lg7iK?= =?us-ascii?Q?2bhEMeH1gPRC+JsI3UVuqLmXC4jzHblx7hofSTbn3Rh4BZJBEKLF1DWFkMxw?= =?us-ascii?Q?X4Vbhy1aaqUxn7OvsuBlHsXE/F+1KA4tXPEH8m5qBN7M9HHlRHKL94FzTjle?= =?us-ascii?Q?apcTQaCB+Q7Bj8lQH2C/uhQ0RbTagFlP7KbIrKU9w5BSut0XKg1shpdj86yc?= =?us-ascii?Q?B3zAm1nRA6NZLgquSWCKpzsMIu/NaIG+QhgBHFqHtT5gaIiEGyhjicohDvHh?= =?us-ascii?Q?/EbydPhsRpIGXD2AyJa47tc2FE1UILcxQGKUJeZ9RHxtBKoAjO9KCyZDoIv7?= =?us-ascii?Q?IqY4BGd9G7gaZBojbdGbLsZ9zJsDs4M0HtQYd2UO4cz46ii7A5JrgrnPcnTg?= =?us-ascii?Q?ussCHBRaICcdpeLhdCjyyU8Rpn4G4JfRSuzu9CxvOi71QYs72DtDlBFJMH5s?= =?us-ascii?Q?XReXcJKz4euSs+P5d+YMJxSuSFY3XtmI+X94DKzxw25L7QCKgMeeXypyLia0?= =?us-ascii?Q?JJFakW1W0XVlorgH3rbg+FtnNtilkAE8Y85GRBJPuZhI15H6wLO4+xJUSkCc?= =?us-ascii?Q?Y3kEMcniucMRZRKGrPcoYTU/lPcg9knJG8fzTsJT3fTrDoI/fk/wgZasWoQs?= =?us-ascii?Q?Jc74CvoQ5kTRDD+ShdtfHC+mfEaIndFvBM1xQ13Gmr7woJMlFshKLKYNRntJ?= =?us-ascii?Q?vBlVxEfkbhzEgCKRhIFl4sVDNeBtaxM/Rs67pCMCipYqXGcPrcepln55+8VQ?= =?us-ascii?Q?Vm73FtF0zWq7BG0feQ2QD9810XcukzDa0yaNi1eeX5untD8wTe7SKs0G2AnQ?= =?us-ascii?Q?G0tiFJMsFMB8cLsfECQhfvIR4HeEaqjQLaS8W0G+ebQXchsKkqFaEfASIlqp?= =?us-ascii?Q?jP+9Jps+EOksHExYiyZ6ECiZ4THkSxy5rBX/OcSJoiZQ73AUuAGiJYN7EZNw?= =?us-ascii?Q?4/C9QZ1NPwtQkK04e90JKfcN21jhmltygzC6uwSYJq1et+LDyr7gxS6zTjkL?= =?us-ascii?Q?YxLkfFalBrCZ1GNitff33TjrKQUzq9OHkUiubX5xzVtlhYk6axDqwgi2k535?= =?us-ascii?Q?I66E5aiNe1Hlrw/OJHABHlEYDd0a09tusT+SONU+wrmxg4VEQ4UQfA/ZMRGS?= =?us-ascii?Q?ETVlzdX8J+I5Otns44wZYZFDTRiI6zMgwrAqhYT2B89YrhFIpaq6QtUTXxbz?= =?us-ascii?Q?RtIYYLYXBH4OpoIB92fK4v8sWzyOj+R4G+TEREh+v6vrMCVzu8ziv7cr8QtT?= =?us-ascii?Q?gRFTSmYhpTG4bZWWn9fDsUZrnzmlgB6aKIE2y9RLY2juKHLBuasY46AMPcBV?= =?us-ascii?Q?B/n9k8fYW4GXbyMQsPuroEBQQi1pfaPMFl0zduCR4Dj4FBeVgRYzu2vR5dxU?= =?us-ascii?Q?BjnhN7oprbCgCWy86y5+Al9YTAZxSRLOw0wyi0k1FlUdNTiGF7w95Wv+fz3n?= =?us-ascii?Q?/CJzGqed2rv9PnHcmtQ+A+GxVdBqnbV6xdvISMQX?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b344812-3e63-4e40-842a-08db9eed5bba X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2023 06:44:08.6153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YW8aI4Gb+IAymhTHtkGy6FcNGKrRa4lemn/6KwqfYGRkBH+UCSNGfn4TZVYaszBOArHC5hPewHAgQsPiLx1t+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5637 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DunxfNeelWQxvsBsKtEjHilkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=xBDMbsBs; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Gentle reminder, review please. -----Original Message----- From: Chang, Abner Sent: Thursday, August 3, 2023 12:12 PM To: Attar, AbdulLateef (Abdul Lateef) ; devel@ed= k2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai Chag= anty ; Isaac Oram ; = Nate DeSimone ; Liming Gao Subject: RE: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/= GSI [AMD Official Use Only - General] Acked-by: Abner Chang > -----Original Message----- > From: Abdul Lateef Attar > Sent: Thursday, August 3, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai > Chaganty ; Isaac Oram > ; Nate DeSimone > ; Liming Gao > ; Chang, Abner > Subject: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based > IRQ/GSI > > From: Abdul Lateef Attar > > Create a new PCD to hold the IRQ or GSI number for SPCR, with default > values of 4. > Update the ACPI SPCR table's IRQ value based on PCD. > > Cc: Sai Chaganty > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Abner Chang > Signed-off-by: Abdul Lateef Attar > > Change-Id: I7218903fa5572f8139ad45db598ab085f079713b > --- > .../OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec | 5 +++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf | 4 ++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.h | 3 +++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 7 ++++--- > 4 files changed, 16 insertions(+), 3 deletions(-) > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > index b084fad89220..d69d650f3f20 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > @@ -7,6 +7,7 @@ > # for the build infrastructure. > # > # Copyright (c) 2020, Intel Corporation. All rights reserved.
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +25,10 @@ > [Includes] [Guids] > gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { > 0xb8, 0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} > > +[PcdsFixedAtBuild] > + # SPCR default IRQ set to 4 > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt|4|UINT8|0x00000010 > + > [PcdsFeatureFlag] > > gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x > 00000001 > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > index 9a4f95e86bbf..cd43afea5242 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > @@ -24,6 +24,7 @@ [LibraryClasses] > UefiDriverEntryPoint > UefiLib > SpcrDeviceLib > + PcdLib > > [Packages] > MdePkg/MdePkg.dec > @@ -51,5 +52,8 @@ [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio > > +[FixedPcd] > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt > + > [Depex] > TRUE > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > index c11da439fcb8..245a847762c5 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > @@ -3,6 +3,8 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights > reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -23,6 +25,7 @@ > #include > #include #include > > +#include > > #include > #include > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > index 51449d0fad9e..e92db96caaa9 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > @@ -3,7 +3,7 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights > reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -83,8 +83,8 @@ > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE gSpcrInfo =3D { > }, > > 0x03, //INTERRUPT_TYPE, > - 0x04, //IRQ, > - 0x04, //GLOBAL_SYSTEM_INTERRUPT, > + FixedPcdGet8 (PcdSpcrInterrupt), // IRQ, > + FixedPcdGet8 (PcdSpcrInterrupt), // GLOBAL_SYSTEM_INTERRUPT, > 0x07, //BAUD_RATE, > 0x00, //PARITY, > 0x01, //STOP_BITS, > @@ -441,6 +441,7 @@ OutOfBandACPITableConstruction ( > gSpcrInfo.FlowControl =3D UART_FLOW_CONTROL_HARDWARE; > } > > + > if (HasIsaSerialNode(SavedDevicePath)) { > GetIsaTypeInfo (SavedDevicePath); > } else { > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107830): https://edk2.groups.io/g/devel/message/107830 Mute This Topic: https://groups.io/mt/100521521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-