From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.75]) by mx.groups.io with SMTP id smtpd.web10.47150.1681707005191498952 for ; Sun, 16 Apr 2023 21:50:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=NG87DUg6; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.101.75, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGvS8XD7Oa+xvyK6xJNZbzTh+7zkyTE1CNtsVCBCJyeX8UVs7ZHLXvndcXIEwNj+wHzUkcOfff+rWsyrXUvzv5vwuG28f67E4jIVp9//oRCYSp9PRHRQRjXXwZ4rBWDX15xk0h0BH5VCNcz2/PRUZMyxo/Lja7BOF65VuFr2rfzCT8oiSCdaXeDpobc1Y2Tm4jIGPIVmNY1QP4xHSGk8drvLdZvCvUW/si25MWsp7B/thbKPfTU5jbfyKxoZiGH5HN7r8Fr2zjXMHTcJNlPQzyS51Vyjbty2O67OY6sLyVRtIIgxmQnwh8MKsUVTQOzcoY6ZmPDzZN/+dH2R5FxMdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9jSrdpPfDJznqvwKvqFjsK2uhqnT5TDZ0a0hlRM9D74=; b=oV3sh+r/08qx2r1GMmZ5ptl26T/GkSq4v1wtVXSWk4t453n6iqnnDqNqZ7lj3FH93rI2rg6Md1u3kbNN9KTP+0cSYfyVy4O2kSTusVtu8l4cWsHnnHeeluVf2xPjlcPbhlU8zI7Ih+Om1/lyanlNVX250sBdLMIQNnTYtJlyyLxKcFthCm6CL84I4CBbz4N9hhOy+saCk4pPNE3aE/wW4Y6dHFlmUg0UYkdBRfZiYW+qKQCGuM/d6C5eGIh9pWWfjHtQCTjorFCkE6WNz+nC13maYC+dJdNv5GIxnkqkQuyobznr7/Zj3ePIjS9guKbLHgwf1mD3Q+q21I2nUHNP+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9jSrdpPfDJznqvwKvqFjsK2uhqnT5TDZ0a0hlRM9D74=; b=NG87DUg6YQXrgwElEZB8+OL0xqMYKpJNF5KH1hj/d78TskpLeS2/bB/tQdECqkOEqYNGTGD25mEeDIkmk9gyozAlVbYjyGB61u6FB+wCNm0GPvmKOzas2b0ZPSmYuB78FDcCfJIEPFKgnIUZan1sTvr/zKjE6IhxAN1hszoathE= Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by SJ0PR12MB5612.namprd12.prod.outlook.com (2603:10b6:a03:427::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Mon, 17 Apr 2023 04:50:02 +0000 Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::13d6:2b92:5ed1:361a%6]) with mapi id 15.20.6156.028; Mon, 17 Apr 2023 04:50:01 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Topic: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Thread-Index: AQHZb5GDQGu6D71tCkGmy6eYG8qzla8u74vA Date: Mon, 17 Apr 2023 04:50:01 +0000 Message-ID: References: <20230415115727.805-1-abner.chang@amd.com> <20230415115727.805-2-abner.chang@amd.com> In-Reply-To: <20230415115727.805-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-17T04:49:59Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=da3dadb0-0c7e-49a1-88d0-ccc6606f8843; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|SJ0PR12MB5612:EE_ x-ms-office365-filtering-correlation-id: 6bf62109-50c2-4138-577c-08db3eff3439 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ue3AwJFQlng/FSm/bxyMUcI36XRWlRb5rl/zqRTEm7Da2aHbl4e9NtqHD0h/oxVigWNVD3sl8u/y1bV8PE8o92CsMdgfeMEhjrqkN4XL11o5cHYFOHLW2HAoIqEzuROxp7Alzc6ksCZftc7v6mqZS8MlbbCMqCs4i0AB31CLllsB9XeoS48LEXi0Qbkz/1YpqwqYghOvNH4w5EBg1zYaXnmSFYx9+/DBwsNbbbsfgoMpB//px+TkIm7hXvlx+roSo3Iaso4C2/Sx69DNJHnWfr1OfK4njYun/qbKnpt0jj8njntyjKzdsQ6WyrrK7EjI7CJSX+nkniH/z9aundawrZMxN8prqSDhCsTn6HMcSCad+pAWX2o5LOyAafzaERACtcNu+yb4+oC1DcHXiE6wkr34Fkb0AT5CvCNd2CUZv1tQw/+UFtNcM5pF9Ayqyi44D73a3BpzHLxpuICShLql/VtxidG4hzyKPEYDVmuV4E57GIGqFfFGHYClBZ3oiOSstebIKSOmVpJms11RdA19UXDko4GT5AOCNowL4CDqIZ2FmaufmSalDuraJklNUwPW/bXPL0UuBsuPriqCaY/OMaQKrLWPHalAunG/lskW8+hynLHCPexhbfKRHPoREKMS x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR12MB6458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199021)(86362001)(64756008)(83380400001)(53546011)(38070700005)(26005)(9686003)(6506007)(33656002)(186003)(2906002)(7696005)(52536014)(5660300002)(38100700002)(71200400001)(8936002)(8676002)(478600001)(54906003)(122000001)(19627235002)(110136005)(41300700001)(316002)(66446008)(76116006)(66556008)(66946007)(55016003)(66476007)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cI1fMRAoZmKe2xl+xSNNZTrJjL+ZLIH/e3uKVm36DeflYtmzC72pXDsFFlBi?= =?us-ascii?Q?H91iOfLZoag+YHFhrIMiyJ+Qx0y6tz2jvHZQYymPjF5ckaDKwPEHKG2tGtnQ?= =?us-ascii?Q?AutnXHR9MH7B5bMcAvUkCBIx//JocmaYoh2Em7pZsBtbkefbiwp38as3qHCF?= =?us-ascii?Q?fCxHtcsTvHbJ1jMOUhT9R/DqKQSas9vCCvtoem82dOfOu2bCP2JLqFU1ZMth?= =?us-ascii?Q?5yj3cWPpdNxAc1xDHEJUxAim0iW7uVJTgArdhlcBJuQ/OJgVIBxCwuO8sIaP?= =?us-ascii?Q?A6V8CIcxOn2w5LdbFZuVX94iz54FAHn9WLBrdERtiGkLk/yT+yfoFdFvaE71?= =?us-ascii?Q?7+Zm0AqTtWZthQsfX71KNnLi3nyBATIBa1oxvzqfrs5wIEuZcdXJ5vLYo6Hy?= =?us-ascii?Q?N/FvVy3ntod1+L5ejjmugAFI5VCvj1OdUNSbr1U4aMaa4civoRcrIyF81ZC1?= =?us-ascii?Q?9kwo3vD8PjSgp1jQic4hrATHFKlWpJZSWZx2rXaKIen4il3NK35dha6rGLad?= =?us-ascii?Q?llVCugA2qUjbilruhMy1geJRpH9hX0EQ/f5xkdY7ljEJqxuxJ9pxEwYlMzH9?= =?us-ascii?Q?hhoMtpX86wf68hzCqmx04RkXaNwtquWijKXn8KWPdmRNl3XU9oWtNWd3F6C5?= =?us-ascii?Q?nSc/xMb2DugyuDImMkOK//cV9BS1Um6Y3Rgjmrpnkz0AtgbtrwnvcN71jkOa?= =?us-ascii?Q?Tr11JRGI5Yf0BJcZ0g5J6RorIIhojubj5cUKuKoEPQlttc7tU/L8zjMbrl1q?= =?us-ascii?Q?MA5naPdfGvh+M/5w8QhSclgQAjjD59CETteFTEZatighDwzfApjHeTDZ5JtX?= =?us-ascii?Q?9x6neUq0EeHDHTkmrWDtLkbAdqH7FEbTEu7naFxtsC6tOEptsUCNU4dZJwTo?= =?us-ascii?Q?gurqR8Vqa5hTh89oKYuFfHBqps7J9lnnXt7qxhBXUUYjBFZIrd3TRlONT9mD?= =?us-ascii?Q?Ubg7g3rE7+V7uk7/XJG0Um9mDeYf4jImwGH7bOU0ldtGcnSSLzuNZp9skNL8?= =?us-ascii?Q?LBjNTMwbV86nGheyy+As3zeINhOaJn1O5nL4ZflYAM4XvGUfPQf0EyfxEUAe?= =?us-ascii?Q?jojTQ5cgnnmFI+LXdRqqRw6CDCt0YOTPlhkmdvS7tzkbd3W+5LOBuEL4S/3P?= =?us-ascii?Q?4va1jRB7maJsxbbqtVd23O2+VSFlNOWjOWfo1bbZuVEPkYEXA5pg90zcolzs?= =?us-ascii?Q?XZKDnh9Xz8KilfExqI9iIVvr38EkgzZNhS3H55ClVilWHnpaFEa/os2o/T9v?= =?us-ascii?Q?V7hRqfuu+/jEOsrGkuDeMiOrjO3C2zVgWVpaTKi/cG3ygzb6ElcDPuBh/JPD?= =?us-ascii?Q?r4JTq8CEcRFpLuY4SfmZe5C5ufkd1HpD5LiGVHhIENlNtw+++JljIymTsQgf?= =?us-ascii?Q?ApxiO7BnPj835GARDMSzl6J2LehkHnhpVDk/p/StqbXsetlPQziYRKZK67fV?= =?us-ascii?Q?HCjkrCUJYHWsFVwgy9Bjj5FYMTxSCbzL/DF2r1Kr81IP63F4+zKODtZEak7R?= =?us-ascii?Q?zOChk58Ik8RMWJGdS8tc4uXOXTYt/MSItb2iV3c0KAAgICUTgn+Xc2mBGwGp?= =?us-ascii?Q?obuRNPu5Wh9rI+x2NtI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf62109-50c2-4138-577c-08db3eff3439 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 04:50:01.6343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5612 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Abner, I think EDK2 uses the below naming convention for variables which are acro= nyms. First letter is capitalized, and rest all are smaller. Its better to rename below variables from I2C to <= pre-string>I2c. -----Original Message----- From: Chang, Abner =20 Sent: Saturday, April 15, 2023 5:27 PM To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) = ; Nickle Wang ; Tinh Nguyen = Subject: [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instea= d of I2C From: Abner Chang Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 10 +++++----- .../BaseManageabilityTransportHelper.inf | 2 +- .../BaseManageabilityTransportHelper.c | 14 +++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index 9a930d3e4b..3656190a70 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -32,13 +32,13 @@ # Manageability Transport Interface type # # Manageability Transport KCS - gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { 0x= AA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } - # Manageability Transport I2C - gManageabilityTransportI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { 0x= A0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } Change to I2c + gManageabilityTransportKcsGuid =3D { 0x5A6E64E9, 0xFD47, 0x4086, { = 0xAA, 0xB0, 0x7A, 0x5F, 0xD7, 0x6B, 0x02, 0x2E } } + # Manageability Transport SMBUS I2C + gManageabilityTransportSmbusI2CGuid =3D { 0x5B174658, 0x8263, 0x4CB8, { = 0xA0, 0x0F, 0xD6, 0x82, 0xE6, 0xBC, 0x74, 0x93 } } Change to I2c # Manageability Transport PCI VDM - gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { 0x= 9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } + gManageabilityTransportPciVdmGuid =3D { 0x388021A7, 0xFB59, 0x4811, { = 0x9D, 0xA7, 0xD5, 0x63, 0x7D, 0x04, 0xA7, 0x2F } } # Manageability Transport MCTP - gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { 0x= 82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } + gManageabilityTransportMctpGuid =3D { 0x6798448D, 0x1200, 0x4577, { = 0x82, 0x50, 0xA9, 0x83, 0xBA, 0x2B, 0x45, 0xD9 } } =20 # Manageability Protocol Specification # diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.inf b/Features/ManageabilityPkg/Li= brary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.= inf index 95c3362ddb..8876e36480 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.inf @@ -32,7 +32,7 @@ =20 [Guids] gManageabilityTransportKcsGuid - gManageabilityTransportI2CGuid + gManageabilityTransportSmbusI2CGuid Change to I2c gManageabilityTransportPciVdmGuid gManageabilityTransportMctpGuid gManageabilityProtocolIpmiGuid diff --git a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHe= lperLib/BaseManageabilityTransportHelper.c b/Features/ManageabilityPkg/Libr= ary/BaseManageabilityTransportHelperLib/BaseManageabilityTransportHelper.c index 81da209764..6454f32670 100644 --- a/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c +++ b/Features/ManageabilityPkg/Library/BaseManageabilityTransportHelperLib= /BaseManageabilityTransportHelper.c @@ -15,13 +15,13 @@ // Make sure the global variables added here should be unchangable. // MANAGEABILITY_SPECIFICATION_NAME ManageabilitySpecNameTable[] =3D { - { &gManageabilityTransportKcsGuid, L"KCS" }, - { &gManageabilityTransportI2CGuid, L"I2C" }, - { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, - { &gManageabilityTransportMctpGuid, L"MCTP" }, - { &gManageabilityProtocolIpmiGuid, L"IPMI" }, - { &gManageabilityProtocolMctpGuid, L"MCTP" }, - { &gManageabilityProtocolPldmGuid, L"PLDM" } + { &gManageabilityTransportKcsGuid, L"KCS" }, + { &gManageabilityTransportSmbusI2CGuid, L"SMBUS I2C"}, Change to I2c + { &gManageabilityTransportPciVdmGuid, L"PCI VDM" }, + { &gManageabilityTransportMctpGuid, L"MCTP" }, + { &gManageabilityProtocolIpmiGuid, L"IPMI" }, + { &gManageabilityProtocolMctpGuid, L"MCTP" }, + { &gManageabilityProtocolPldmGuid, L"PLDM" } }; =20 UINT16 mManageabilitySpecNum =3D sizeof (ManageabilitySpecNameTable)/ siz= eof (MANAGEABILITY_SPECIFICATION_NAME); --=20 2.37.1.windows.1