From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 03478D80353 for ; Tue, 10 Oct 2023 15:54:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IopKxrZ42pzjYp+jUB/c3luQBe3aTMWlujrU40X0ftE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696953275; v=1; b=DrTB2I0kZpwrxjs4a1ZfLPf48AVisumyFqV7yYC9piW2sAatXlfHFNNRkmEvdzxTRAHlCqnJ H6kt7zugr2vQyUynGlbva8sto4k2vXF/amuNVOm2xztVqJ/v+Kl2TUqV0e8GeugzRcHbIyuYweT 0rAQokWdxmc3DkXExJg8v4aI= X-Received: by 127.0.0.2 with SMTP id BofkYY7687511xgJ1GFTtsme; Tue, 10 Oct 2023 08:54:35 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.75]) by mx.groups.io with SMTP id smtpd.web11.94388.1696951870696509989 for ; Tue, 10 Oct 2023 08:31:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mlX65PZVSVk+94I8eOoTlH05spT5kUIiiqPZPCtSOohCa26O4gvZN4KToBS5qKwgfHx39JnvDOFQ6/N1bFrdavS9GUSgifkzQXw1TiwHSeNjAEOFlc4hhPghgqa9kX+N2v8QL3YLLeJpZ2FOg37JIYOSwPrNWFNHA5PMtbqJUk92ZB0JtIabu3GJA8PjI1aSSTI2B7I3f1/mU63BJbfwsv0B+zDv0Sp3Xv9gUQGFD2BlHiKboGxe99H/3QGzyvV5d6eegIqIRkDyzjIT/ZWgj8kWO10sZDAKcmvmElVJteBiemp/fxiZ9CwWMCWVy7BVRXOeVBbDkoxMwzE+bM3gNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=clDQsp7DMDmi5t4Y4EHHqBRyzJvhVmP6Zu9focvo66s=; b=eFuv4OUfAhQXS1uXiJ/cOmxHWarpMBlQQY0n7Jq7KFZIyctfRkfUsHEbPBu+Ofg88hHLqYIrX7BnnPWNt0zhrHAKpm/FzM/tga8/DRdhJoqM3EUrB79nkOuIOmJuU1Xoyy0A/BBtb1O8tp+ZFH2F6XzJn95ViCdDSJ9OZ1h3/wqwr7TdtTFtDwF+9ItJZQvTXr8c+5ED69mixSC+C79T0TRQNDJAkeDzUGVnEhT2ldvYX8MGXI789INlDPkEai/0Qky+q4u5qt+YnZrDZ0C9dWbu5/wUpPublOxAkOvJgBINh4UEZiCZOlwxhafw6Zs9K0q4v/rNOJteg8nnUysekg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by BY5PR12MB4904.namprd12.prod.outlook.com (2603:10b6:a03:1d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Tue, 10 Oct 2023 15:31:06 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::d727:a124:4199:a8c6%5]) with mapi id 15.20.6838.040; Tue, 10 Oct 2023 15:31:06 +0000 From: "Attar, AbdulLateef (Abdul Lateef) via groups.io" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg/Ipmi: IPMI Get System Interface Capabilities Command Thread-Topic: [edk2-platforms][PATCH] ManageabilityPkg/Ipmi: IPMI Get System Interface Capabilities Command Thread-Index: AQHZ+4zQ4Hy5nd/QfUKWr+XaDWzyi7BDJjcA Date: Tue, 10 Oct 2023 15:31:06 +0000 Message-ID: References: <20231010151639.293-1-abner.chang@amd.com> In-Reply-To: <20231010151639.293-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a689cf9f-b683-43d1-a64e-2000c40576a0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-10T15:30:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR12MB6458:EE_|BY5PR12MB4904:EE_ x-ms-office365-filtering-correlation-id: bc602181-b8df-4057-31be-08dbc9a5eb8f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: XYx2xx3Db/LXbeGq4VM2xleB86uuMbbPYJo0wUta7pBoB0GX9/cL4aCdM8Oe2y3Rya9UZSmO4Ojb3FhRhzsTdGZDdNbq8snJzavPU2MKAqdmkcjbIrfxnoGsScZKUeiq0y6KRHR7pkE1KqgJQC9gbELF4tISUWFmGp724Whf+n1ISn9jK5JaHkqnBYmfUnihZuTfKGkQlvPupuIw80rce35Fs47FzDtKcqaIPOcgRHBagtLJ+eT8TqTNKSksG6t5SF/Zk7xL4Ns446F86BlwKzDQ8hDWKnMi9kB0DSmIgOaj31SR2spaKfxkhOjSMTc/9tLYSMD7Ym+16IMGsqql+SgRcgtRsx5sMukHcL1otuxnSj1zpKSmZXjFl9Q/+NSm4/jxXqVWt09vBAYhqNR2sfHT549gNMB9/eK8f+qVwGJDfjLwTO2BfGmXnxFyt7R1DocbPlgJsTpCyJWUyd2XiHS/TRP2eL9NPfHaoDtv7YjRqLCkyim+SIGaDc+5XWmrx5yMaEAchyGvqJNaEEOOcC8qNKEwEZRjbU1SVcCZ4kmuiBM4TlwfiZRln8NqUzK1E7uX+s7n1byB32Xp4cfRpWaVQc252Ac0pnYozvYLzfAXeisw9gb2CRWNXN83pU0e x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6tdHX1gT5vzlyDyvEXC/zQWNXU24SttCBJIuvb3DeFyXY9qR3OTQc5srpG8e?= =?us-ascii?Q?zqxHIRltzLCtDjejyenC10kETh3Ku6kyuRLbdri0huIMTXODSSzq8oFlNfIZ?= =?us-ascii?Q?3/X4xYB1uSO2JKd7RJg5pYFvsdF+5PVU26wL6ASLE1/2qePah7EBPQkEaIM0?= =?us-ascii?Q?BvogkjMOnNxNFWPfYz0UC+wXK0tPGRgd4DHXW70BQyUTbxkVF8lfyGcFd5O9?= =?us-ascii?Q?+lrNZLuotRPJYpZTpOSHKGVJ43bmQRxHeOUdmWEZG5pTn2e9dkNKyZjbMLc5?= =?us-ascii?Q?iKKrTb1SYDgsBDBHfRd/RK81mQNm1IJeNVforYcBVyf/QzUy0E0iCUw3D8bL?= =?us-ascii?Q?eBQCOpdAuFwY2eSC+fayYa/u0896ig/fVdXRkFjOtuFNn65zOLWxVOVx70lP?= =?us-ascii?Q?oGZ8EowPgZIjEhOK8YnzScV9bRdowBmKstj2wi1npQ4rjRjlMbXi0c34U3N1?= =?us-ascii?Q?AVsWbXQqafbOvSB1PR6pRfOhzTKnttM1nA6ZAjDBxq1TyrQm7N1vX4Lx+D4x?= =?us-ascii?Q?CtXqIBeYwLC7i1ycCX4W6wrlIr5LORMietqQF+/n9tIrRX0G8/1AZMlHbvs5?= =?us-ascii?Q?gUW1ePZX4ozDCoNos8TILsXPTzj4JpKq/+X5A/fmA0Vp5jjaH+0zPdOXU3tS?= =?us-ascii?Q?RNTpkZm1FtZ/6KA7fqKz+GqO9h4PV8fT2iw9Wz8zELD6+Tpc7wJWlsztHd+8?= =?us-ascii?Q?nhxqJDBfNQySoyG6qfZjmD5Qp6aLTYALWCN1R66Ke5Iu54zy9uoS3YcipYT0?= =?us-ascii?Q?XOvJKhDeUPz9/mNtDGF9NCSMAYiUmUHwa0mqSkclEeV4cGlI5W5yAVLtD//m?= =?us-ascii?Q?qGTghSrsA98rN9VFTZna8zq0X4SF69EzI5yrCGfyrjYMhCzjOJXCfiW8E5fw?= =?us-ascii?Q?wXnpJe0uXCfYGz3NByPCgp7B1d3rhcPGw5l0ra73y+B2FocoL/4hUt8mIHG6?= =?us-ascii?Q?Ogwdi2HF6NmB98ICJt5ath/b9RUMEHnPhmVstKfemAxI2j/zR/IFKVuPMFdh?= =?us-ascii?Q?dmZzxWV1C4hChH9FntEHGZpCxy+eXsVl7tq9o5xgylCyDVr0/YrTRkPWdNTu?= =?us-ascii?Q?BPz7ALPodt+mnOHG+/khiNJIputNeVTva88F6k9+UQQzRYWePX+jYUvaJpwJ?= =?us-ascii?Q?wLvZPioKXUoGAmZe802ZU1+lSVPKDHXpYHbAkauisK5gdiNdKMz3ysPPjMQz?= =?us-ascii?Q?WYl4n6zSuGUdwzrpSwmvt2Kj+3wug1ceOxtyELRdQguMYceh1WgmS66G53Io?= =?us-ascii?Q?azQ0I+eIMEdyI2hg3oM92wYxCFD+Z03aezL2pWk5k2MkeudZIzjZp/i260GB?= =?us-ascii?Q?AV8Sq83km3UcIz6DU2aGnp4HbdARSL0TYdhv0oUQ5RuRH4gAKCCcTmzut2dD?= =?us-ascii?Q?1zoMLeey2ZW7IHODsmNkfx61EmZ0Rx+m0vYI0Ix5aQQWGmEoOIGizs96r8MO?= =?us-ascii?Q?Ehr/9entc6CYvmF/tbxgF3cl/xb8xnRvV538+irhyQy6Nyml7vIb+74ISu9L?= =?us-ascii?Q?N/9sWhAe5xtTv4lgIMSS77G3WUCtF6Mf03NRjrNl+aRcjB/k1z9qfPP6Ag?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc602181-b8df-4057-31be-08dbc9a5eb8f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2023 15:31:06.1785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0jfe1mUjTSitnksSMCrVqPmbhJkClKGhH2fFUj1w/Q6HAebyYD4TNl0ysDce21LXEVw7WvCJcXvPzVA3v4loow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4904 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cSi84PFBWybM7cnjjrfWAhiRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DrTB2I0k; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Looks good. Reviewed-by: Abdul Lateef Attar -----Original Message----- From: Chang, Abner Sent: Tuesday, October 10, 2023 8:47 PM To: devel@edk2.groups.io Cc: Attar, AbdulLateef (Abdul Lateef) ; Nickle W= ang Subject: [edk2-platforms][PATCH] ManageabilityPkg/Ipmi: IPMI Get System Int= erface Capabilities Command From: Abner Chang Implment AppFn, 0x57 command. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Nickle Wang --- .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLi= bNetFnApp.c b/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandL= ibNetFnApp.c index e580ec2ece..f145e291a9 100644 --- a/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNetFnA= pp.c +++ b/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNetFnA= pp.c @@ -442,3 +442,71 @@ IpmiGetChannelInfo ( ); return Status; } + +/** + This function gets system interface capability + + @param[in] InterfaceCapabilityRequest Get system interface capabilit= y request. + @param[out] InterfaceCapabilityResponse The response of system interfa= ce capability. + That is caller's responsibilit= y to allocate + memory for the response data. + + @retval EFI_SUCCESS Command is sent successfully. + @retval Other Failure. + +**/ +EFI_STATUS +EFIAPI +IpmiGetSystemInterfaceCapability ( + IN IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST *InterfaceCapabilit= yRequest, + OUT IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RESPONSE *InterfaceCapabilit= yResponse + ) +{ + UINT8 InterfaceType; + UINT32 ResponseSize; + UINT32 ActualResponseSize; + UINT8 *ResponsePtr; + EFI_STATUS Status; + + if (InterfaceCapabilityRequest =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + InterfaceType =3D InterfaceCapabilityRequest->Bits.InterfaceType; + if ((InterfaceType !=3D IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE= _TYPE_SSIF) && + (InterfaceType !=3D IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE= _TYPE_KCS) && + (InterfaceType !=3D IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE= _TYPE_SMIC)) + { + DEBUG ((DEBUG_ERROR, "%a: Unsupported given system interface type =3D = 0x%x.\n", __func__, InterfaceType)); + return EFI_INVALID_PARAMETER; + } + + if (InterfaceType =3D=3D IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFAC= E_TYPE_SSIF) { + ResponseSize =3D sizeof (IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_R= ESPONSE); + ResponsePtr =3D (UINT8 *)InterfaceCapabilityResponse->InterfaceSsifCa= pability; + } else { + ResponseSize =3D sizeof (IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITI= ES_RESPONSE); + ResponsePtr =3D (UINT8 *)InterfaceCapabilityResponse->InterfaceKcsSmi= cCapability; + } + + ActualResponseSize =3D ResponseSize; + Status =3D IpmiSubmitCommand ( + IPMI_NETFN_APP, + IPMI_APP_GET_SYSTEM_INTERFACE_CAPABILITIES, + (UINT8 *)InterfaceCapabilityRequest, + sizeof (IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_RE= QUEST), + ResponsePtr, + &ActualResponseSize + ); + if (ActualResponseSize !=3D ResponseSize) { + DEBUG (( + DEBUG_ERROR, + "%a: The expected response size 0x%x is not equal to the returned si= ze 0x%x.\n", + __func__, + ResponseSize, + ActualResponseSize + )); + } + + return Status; +} -- 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109500): https://edk2.groups.io/g/devel/message/109500 Mute This Topic: https://groups.io/mt/101877172/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-