From: "Chris Fernald" <chris.fernald@outlook.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bob Feng <bob.c.feng@intel.com>,
Daniel Schaefer <git@danielschaefer.me>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>,
Chris Fernald <chfernal@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell
Date: Wed, 30 Nov 2022 12:44:30 -0800 [thread overview]
Message-ID: <IA1PR19MB62752D168F148F0F49D2CB00E7159@IA1PR19MB6275.namprd19.prod.outlook.com> (raw)
In-Reply-To: <CA+bRGFpOu_qDkr7k7YDiwJ8oMALKkNQxg9n10Niwd+aNcj6OoQ@mail.gmail.com>
I apologize as I think I mislead you on this. I think we can only remove
this operation for the builds using the container. I believe Windows
builds will still require this step for the time being. The Windows
pipeline on your PR is currently failing to find cspell. Sorry for not
being clear on this originally.
On 11/30/2022 12:01 PM, Oliver Steffen wrote:
> cspell is already included in the container image.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> .azurepipelines/templates/spell-check-prereq-steps.yml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml
> b/.azurepipelines/templates/spell-check-prereq-steps.yml
> index 226909d54c4e..66354ad78b5c 100644
> --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> @@ -16,7 +16,3 @@ steps:
> versionSpec: '14.x'
> #checkLatest: false # Optional
> condition: and(gt(variables.pkg_count, 0), succeeded())
> -
> -- script: npm install -g cspell@5.20.0
> - displayName: 'Install cspell npm'
> - condition: and(gt(variables.pkg_count, 0), succeeded())
next prev parent reply other threads:[~2022-11-30 20:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221130200037.1098765-1-osteffen@redhat.com>
2022-11-30 20:01 ` [PATCH v8 01/12] CI: make Python version configurable Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 02/12] OvmfPkg: CI: use Python version from defaults template Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 03/12] EmulatorPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 04/12] CI: add ~/.local/bin to PATH (Linux only) Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 05/12] CI: Allow running in a container Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 06/12] BaseTools: CI: Use Fedora 35 container (Linux only) Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 07/12] ArmVirtPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 08/12] OvmfPkg: " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 09/12] EmulatorPkg: " Oliver Steffen
2022-12-01 2:34 ` Ni, Ray
2022-11-30 20:01 ` [PATCH v8 10/12] CI: Don't install cspell Oliver Steffen
2022-11-30 20:44 ` Chris Fernald [this message]
2022-11-30 21:51 ` [edk2-devel] " Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 11/12] .pytool: CISettings.py: don't add scopes for GCC Oliver Steffen
2022-11-30 20:01 ` [PATCH v8 12/12] CI: use latest vm_image (Linux only) Oliver Steffen
2022-11-30 20:38 ` [edk2-devel] " Michael D Kinney
2022-11-30 21:53 ` Oliver Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR19MB62752D168F148F0F49D2CB00E7159@IA1PR19MB6275.namprd19.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox