From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.92.42.61]) by mx.groups.io with SMTP id smtpd.web10.23994.1669841077714738364 for ; Wed, 30 Nov 2022 12:44:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Bb89U5nO; spf=pass (domain: outlook.com, ip: 40.92.42.61, mailfrom: chris.fernald@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Br1wWrN93QpeyW94INv/UEmJwdH34fDceWD5z901S0b/iob1UOVueIgcL4v7e2lCQX32seF9Wy67iX/6YkUAjC0FXmc7wmgPlx7tShqPo/d7//8fWfmlbUsl96IhQYj2xqfJVEUsdjNmmFtWQd9z+RBfoTdtfdhDCvz7I3UCkaD/832FiEiEOFFygO0RshzilE/J1D94rKCOnnHMB0FPKnknbwtrNrskr4+/x/HH936TqPlMM5DwYLs7r2WAjZ4gV8eB2pbVZJV9ZwPFmmeUUpv0KEvjWKsrbQpeAgfBXPxljVJXew+YVEDKl+ZdfOOT8+idRZwN5VuRbd6squYMYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcV19JrSidmrQVMo2kZCGDtb/Tv9qOU3f9tEFbb1VYA=; b=SdwnAvcIFyln1Pt8W0rLmRHIggM9SgcMaGI3nYAR1O9ECoAZLZ6UEdoxQ6xV3V4ZKOQnVu9oVZO4aXRT0UEx72AvPQ8niqmIDJall7KZWiWXPMyUocMlTgyYNGT7BByDTqw39lREggAwEuZOQA1B8GmD+jbEXYigHfUoslM6fsaqXP6pX+lehJmipwp7yCrw4kWkvqXA/zEYmiz0bCOb722Cnvb1gMc/gttZVsMhaXzlGW7GomCj6QRRygBfZuXJPkrMVLEW3LXGkTaQVqYxbueZSO8m7trOcG87NTh7B74A6UDC5/G883FF2LUrZD1BD9NsVYMJcXeLZP4Ik4yNQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wcV19JrSidmrQVMo2kZCGDtb/Tv9qOU3f9tEFbb1VYA=; b=Bb89U5nOREa2mPjyBrB1KD39dasvlqc9QEinYVIwokRdKvMws4vxzrNp4Ns82v3qXKGuevi+E2i8+XY/n2IQ8hjtlaEftFFSUISR6seWVxXFJLogah2w6otAXOBXqFGccwozE+YdLj8izsDu4Po4HazeybEIsCZ0v5LjiAL5TUA5JyCP9oCEEk2AkGCG+///uvaSCv/vHhB6CvncFIDv/A+YuBs/jShRnSROhA9JdPhiQCi6xfIHFAHqcMpTZlbsCNrNPCvEk7nQ3r0WywaWgQlOB/vdTG/nvPNomvz0JHYfrv+hCBNYjqTJnyogw28GPNU0zpfJ1Omjkptpocv6eg== Received: from IA1PR19MB6275.namprd19.prod.outlook.com (2603:10b6:208:3e9::19) by CO6PR19MB5403.namprd19.prod.outlook.com (2603:10b6:303:14a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.21; Wed, 30 Nov 2022 20:44:35 +0000 Received: from IA1PR19MB6275.namprd19.prod.outlook.com ([fe80::fdf3:9da:c729:46f]) by IA1PR19MB6275.namprd19.prod.outlook.com ([fe80::fdf3:9da:c729:46f%5]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 20:44:35 +0000 Message-ID: Date: Wed, 30 Nov 2022 12:44:30 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell To: devel@edk2.groups.io, osteffen@redhat.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Daniel Schaefer , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Michael Kubacki , Ray Ni , Sami Mujawar , Sean Brogan , Sunil V L , Yuwei Chen , Zhiguang Liu , Pawel Polawski , Chris Fernald References: <20221130200037.1098765-1-osteffen@redhat.com> From: "Chris Fernald" In-Reply-To: X-TMN: [KfAMkI1xazFzeLDoVtolxj2NEyAxtPY8wwc/Dre34UA5OHE74qeIaxd+Ci16Kmlc] X-ClientProxiedBy: MW4PR03CA0061.namprd03.prod.outlook.com (2603:10b6:303:b6::6) To IA1PR19MB6275.namprd19.prod.outlook.com (2603:10b6:208:3e9::19) Return-Path: chris.fernald@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR19MB6275:EE_|CO6PR19MB5403:EE_ X-MS-Office365-Filtering-Correlation-Id: 0cacd802-2357-4c09-f934-08dad313b0c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MsodAzWOM5edZenWwsBlCLrR8JxTGv7HRJBxfPap6fw9tzREepwqXwbEvkL1LVegg5DYq+wX2MUuryqJ+8q3G7YdEwpoDACeDE9xwQfMGEiIPQXqOkrcpNIFVZAhnfsmgvyn5swUpnYs+gDehgmHOtbckA1ob1seG0NDJCp/S93kE5ltQOqA90LlVUyU1zN+86MUCaAKrLMClcsEd6PSSVkCbfJ9Md8tcivpgRAy9sc0qoEkuY8Lg/LeX8wnRQQGmLZAsiU8vyPZA/S7rrVfXa4wyCxWCmRJDEeHKJoPg1CLF1Ujx2vJbNppObT7aJ8+kot1Z7GMpAVDuAlPmnK+cr79wTZ1Vs1iXM94BxmT3cd6y3ahNfxeQRvl4m1GjcAz94cAmwYYx4lu7pkAZ7whT+FTrmQ4S0B+A/ZIjvUVjbCzrPhg/5I/6TXFPnAMpCbw5OAJBH1HOJGN3IgjF2004kI7pWoKFrgo4rrKcnj2WU30XFYKrBZ9xKENxxRwyU1zLki7+t+F8j2BcHrQ2oqGSC+CE4HCgjvXJjgNWvVMqanaNuZYwOvy+cCqICoLthjS3HGLVIbEzkTx80hU144V9MgtOPdRnF4Dmv0CMpXsX71f27GjbVd4tunqkW7j9gEq2/+Enf4Gj5q1prVKMkEAXQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akowc3lXTSs0UHlNZnZrbXo2dUhLNmZLM1BWNTArdGxpMDYrMXBKcUJRdkVF?= =?utf-8?B?NzZkellvOXNOUTg4TjRjZUgzekFVelhkMWRHd290eFlVYmg5dHZLYTVHUlR4?= =?utf-8?B?K2dWSzQ2TmNkajU5cTJVMFE3RE40M2c1SFFFejFjME9oRTlJUzZJR3VKbWpO?= =?utf-8?B?MENmKzM1UkJoWkM3ZXVac3dsdmpiRmdwYXVsYmF2YWxIM2hwWUpCSUpYYm5U?= =?utf-8?B?OG4rL21CZE5MQnZUTXRBcmxKRE9MUHRLVEJZUVV6alJlMlpSbmZBSEJvVXlT?= =?utf-8?B?dXozME9razlHOGZqTDI0aC9zMnJ5Q0NjV0RETjhmeFZqQTd2eGRuY3VycDZP?= =?utf-8?B?aXZpRkZpOUNMTHZVQVE2UzZVdFVPYWxpYnRTSDlGR090di9lcllhWUZlSU84?= =?utf-8?B?dXE3MU9HNHhndVZkZmxQNzYzK0syT2ZEUjgyU0dnOWwwdjcxMHFjYU54U2h4?= =?utf-8?B?cXdvTUdPbU8yRytRb0tBOHliRjVrYnJtdGFMempKQjRVbmJjakkxWklMY011?= =?utf-8?B?UTBlVXJCZWVOZmpxeVZhVVlxM2hkdTlBdUo3aExvVFJ0ZWpKRFhoWFNGZlVU?= =?utf-8?B?QXBMQ1NCcC9HY3dSSXZkSUpNZGZ0dDBTdldLQmo2K3BTS2FTWjhJQkFWVE1N?= =?utf-8?B?RUVIWHgrU2tkLzNsRFBZNlFmQnZzOHVBS0pjbkdFeGhWREZTT0JqQVBIN3hu?= =?utf-8?B?a2pxeW4rMWRJTG91blF2SDdBeHRhRG0ycWcvMzJaNUlMdDZ5RldaTC91VFBF?= =?utf-8?B?NW9scmc5bmorYjRCWVMrL3VyS0tJT3E1OSt3RTc1K3pRS1YzMUtvUVNDMU8x?= =?utf-8?B?bmZVbE5jVVZuUlNxUE9xSk4zN01ydmd3NkhIb2FCWFhvTlErYW1YWWEyUmlG?= =?utf-8?B?cDB4L3NZcWhrc0JLK1Z0UkNiMFZRalI0c1dQb2o5dzVYVmVnZVdER3ptbTRE?= =?utf-8?B?NlVSRytZSXh2eXo0blAyRHk2UVVUOHhaVlB6bUVOODlzMzh5bnIxMmRKYlhJ?= =?utf-8?B?dDRuRXp6QndSY1RjbGsybFFTVTNPbG42Zmo3YmRGZXk0bTlyR1FnZnl1YUE0?= =?utf-8?B?VUtoSVVtSGhFcGJtV0dHN0FvQW9LR2J2ZHhQR0ZCSnAyOVNvYmJJNnFyVTJq?= =?utf-8?B?NkhlMEpQMC9uR1VrRVNoYjQxcVNTUVlxaWZFYTJEUjhyM2ZmQ21zWHNWaFZV?= =?utf-8?B?eDlCbzBwNTRVcEZGWW5sS1RyZXVMMFM4aUF1MnlMWjFzd1pJZm9uNVBkZmJT?= =?utf-8?B?QnY4RnlMbkRnZThSVE94djhyc3Q2Vy9lY21OTWxCUlI1cUlEWmxTN3dHTm4w?= =?utf-8?B?U3hkK2ZnalZxS05BeUVKV1V5dmo5azBHdnh3QXBaVjc0WnRmdnNmZUp3OGo5?= =?utf-8?B?RUVIb2RWWnU3eGo1TExwQnArM1N0ZE9wbERGVUZLRzgxcS9JMW4zb2REMzRt?= =?utf-8?B?dkJHOUwrME1lMXVzbE9YOVFmWnJWSnZod3VUSUJ3bFBJU1dRam1jSk03Z0Zn?= =?utf-8?B?R1VCTFQ3STJSS2ZLd3dXWGtCSjVHZUxmREs3NTZQdmE2MEJiVytKaGZYWmhy?= =?utf-8?B?WG1GdmtudXY4c1EwUFpORkdLa2JYUDJBQmZ2K1VvOTRqUUdZVlhMWmw4YUoy?= =?utf-8?B?alFYNjMwQndVNVQ5Y0RHRVNhSkNvVGZuLy84U1hyVjEwR2Y1T2praGVjMHBN?= =?utf-8?B?YjZ6bUpVUVRJSFlCYlRZVGtxZTNIcjhId3NqSDNOT01rT05MZ2FYUlhNd3pG?= =?utf-8?B?QTIyNjlvZVcxeVdmclRHTUtrWkxiN1ZBKzd6VmpZaStQdFFlRjZwdDFMa2xJ?= =?utf-8?B?TWxMQnN4SFhWYmUra29mQT09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0cacd802-2357-4c09-f934-08dad313b0c8 X-MS-Exchange-CrossTenant-AuthSource: IA1PR19MB6275.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 20:44:35.3729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR19MB5403 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I apologize as I think I mislead you on this. I think we can only remove this operation for the builds using the container. I believe Windows builds will still require this step for the time being. The Windows pipeline on your PR is currently failing to find cspell. Sorry for not being clear on this originally. On 11/30/2022 12:01 PM, Oliver Steffen wrote: > cspell is already included in the container image. > > Signed-off-by: Oliver Steffen > --- > .azurepipelines/templates/spell-check-prereq-steps.yml | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml > b/.azurepipelines/templates/spell-check-prereq-steps.yml > index 226909d54c4e..66354ad78b5c 100644 > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > @@ -16,7 +16,3 @@ steps: > versionSpec: '14.x' > #checkLatest: false # Optional > condition: and(gt(variables.pkg_count, 0), succeeded()) > - > -- script: npm install -g cspell@5.20.0 > - displayName: 'Install cspell npm' > - condition: and(gt(variables.pkg_count, 0), succeeded())