From: "Chris Fernald" <chris.fernald@outlook.com>
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Bob Feng <bob.c.feng@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>,
Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Yuwei Chen <yuwei.chen@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [edk2-devel] [PATCH v5 1/4] CI: don't force python verison (Linux only)
Date: Tue, 20 Sep 2022 12:41:35 -0700 [thread overview]
Message-ID: <IA1PR19MB62757AC3290CA6455812EFEDE74C9@IA1PR19MB6275.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20220920144524.1098189-2-osteffen@redhat.com>
I think we should avoid the expectation that we are in a container if
and only if we are using GCC5. Instead I would prefer we add a boolean
parameter to allows us to explicitly use the included python. So instead
of the GCC check we would have this.
condition: not(eq('${{ parameters.useIncludedPython }}', 'true'))
Chris Fernald
Microsoft
On 9/20/2022 7:45 AM, Oliver Steffen wrote:
> Use the Python supplied by the container image.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
> .azurepipelines/templates/platform-build-run-steps.yml | 1 +
> .azurepipelines/templates/pr-gate-steps.yml | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azurepipelines/templates/platform-build-run-steps.yml
> index 40a31a509fc5..3c16fa981d5a 100644
> --- a/.azurepipelines/templates/platform-build-run-steps.yml
> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
> @@ -44,6 +44,7 @@ steps:
> inputs:
> versionSpec: ">=3.10.6"
> architecture: "x64"
> + condition: not(eq('${{ parameters.tool_chain_tag }}', 'GCC5'))
>
> - script: pip install -r pip-requirements.txt --upgrade
> displayName: 'Install/Upgrade pip modules'
> diff --git a/.azurepipelines/templates/pr-gate-steps.yml b/.azurepipelines/templates/pr-gate-steps.yml
> index cb431e53fcd1..df8802718d99 100644
> --- a/.azurepipelines/templates/pr-gate-steps.yml
> +++ b/.azurepipelines/templates/pr-gate-steps.yml
> @@ -22,6 +22,7 @@ steps:
> inputs:
> versionSpec: '>=3.10.6'
> architecture: 'x64'
> + condition: not(eq('${{ parameters.tool_chain_tag }}', 'GCC5'))
>
> - script: pip install -r pip-requirements.txt --upgrade
> displayName: 'Install/Upgrade pip modules'
next prev parent reply other threads:[~2022-09-20 19:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 14:45 [PATCH v5 0/4] CI: Use Fedora 35 container for Linux jobs Oliver Steffen
2022-09-20 14:45 ` [PATCH v5 1/4] CI: don't force python verison (Linux only) Oliver Steffen
2022-09-20 19:41 ` Chris Fernald [this message]
2022-09-21 8:31 ` [edk2-devel] " Gerd Hoffmann
2022-09-20 14:45 ` [PATCH v5 2/4] CI: add ~/.local/bin to PATH " Oliver Steffen
2022-09-20 14:45 ` [PATCH v5 3/4] CI: Use Fedora 35 container " Oliver Steffen
2022-09-20 20:01 ` [edk2-devel] " Chris Fernald
2022-09-21 8:26 ` Gerd Hoffmann
2022-09-22 0:33 ` Chris Fernald
2022-09-20 14:45 ` [PATCH v5 4/4] BaseTools: Remove ext. gcc dependencies " Oliver Steffen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IA1PR19MB62757AC3290CA6455812EFEDE74C9@IA1PR19MB6275.namprd19.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox