From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.92.40.49]) by mx.groups.io with SMTP id smtpd.web10.1561.1663702908233004547 for ; Tue, 20 Sep 2022 12:41:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=Oj4fh9wp; spf=pass (domain: outlook.com, ip: 40.92.40.49, mailfrom: chris.fernald@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLJTy/T5scZlnSxZ7uC+AzumZ+5gXQJsXENHFz/aCsYLtOSVcIUFSBM0hv+8g8/uhDCaelr7bYGKhvZD7PViRM/FwYAdWjlYzMl1ASA/roxJWLF2rBj56/roVYV3pqy2sPxL4Kkinb7+Sl7QTKFBc4q76+uf1bw0mkcTpQ5/ZzFO18UsEw7hltTqQlsui8khAryOSXkV/62xeN94KQjOK1mfoJa6KoBmrMGYrQesgD2mIuXmOhlYg0PfcG4Aoa4PBv2ZEL8kJ5DB5q+zElSVhc1viMotP4Nn5brczmqviIb/EztVoaU+ssVz+HGZMMZeklkPQ8V+y9xH5M6Y7Nmg0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eqSTDA+Ww3LqKFWkwnKvB577kGvEEjEMpDuxjtFNQBE=; b=R7pbVOYD3JaFWey6IqAqel0r7Jt/qrH9XovAV9zSzpWHWeg/0ctBTN3VwbH/zurA1ATmpf8S5+PtJN8aRtak3tRlUHUUPsD/7npfUhn77JdxtX+rE/eSz2l9ImuqedAHr5AE4FQ1DgLeCj9JpvaLSzEfxZGoUWdRunhvV9dWZ6Qao5YmKUxbctB18f9GFDC7fW9jR8hpCd8BvzodQkX35ZfBPGBYSAF1qRzFzc+EUiakZ2eZ/EYkiw9skARAr6ktQ/Rdbe1aqYjl53K+C89LMsa8TMEXEnrxMgrkB0TVg1B5WyUNZXutgPLH5y+Uv7F+zf0joQiU0n6PNlOpXiHk3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqSTDA+Ww3LqKFWkwnKvB577kGvEEjEMpDuxjtFNQBE=; b=Oj4fh9wpmIUkOQQCH7vlFuXl3ZSEjEkZ2TsOEsst6Du7dKMBskJ7l2m7M0fLdBegaW4+imFTByfJmMmILH3SfUvtwHHFKL1K/PF3CGNO5sEBvollJ5qJS3tHiS0xO1PT5YgfuqZ6OjGRIQTebG41Iudj/wFoo+o/KQKbw24gMs9JKXfpwP0kueXdgYA9K6JEb30LMPimEtfpvTtYmg9X8hEK8MD5ejPVO2a5wq/Ql13RBPPSoZfqK0l3lARp9CdOZtspJTuX2Vro9xFLKTg3Z1YJWSV2zphyrWaujSe9tVqynOOm3rNkeIWYRYLbZE0Okce4vB+sW7WYhxRDq+mczQ== Received: from IA1PR19MB6275.namprd19.prod.outlook.com (2603:10b6:208:3e9::19) by SJ1PR19MB6236.namprd19.prod.outlook.com (2603:10b6:a03:459::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Tue, 20 Sep 2022 19:41:44 +0000 Received: from IA1PR19MB6275.namprd19.prod.outlook.com ([fe80::3125:2595:a424:ae8f]) by IA1PR19MB6275.namprd19.prod.outlook.com ([fe80::3125:2595:a424:ae8f%4]) with mapi id 15.20.5632.021; Tue, 20 Sep 2022 19:41:43 +0000 Message-ID: Date: Tue, 20 Sep 2022 12:41:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v5 1/4] CI: don't force python verison (Linux only) To: devel@edk2.groups.io, osteffen@redhat.com Cc: Andrew Fish , Ard Biesheuvel , Bob Feng , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , Michael D Kinney , Michael Kubacki , Ray Ni , Sami Mujawar , Sean Brogan , Yuwei Chen , Pawel Polawski References: <20220920144524.1098189-1-osteffen@redhat.com> <20220920144524.1098189-2-osteffen@redhat.com> From: "Chris Fernald" In-Reply-To: <20220920144524.1098189-2-osteffen@redhat.com> X-TMN: [ZS14Uz1k4anskEcEAX+gfOtCV8UEAdZ4IBzJnLtjMug2EenPMClWa4qW9SIazXwm] X-ClientProxiedBy: MW4PR03CA0263.namprd03.prod.outlook.com (2603:10b6:303:b4::28) To IA1PR19MB6275.namprd19.prod.outlook.com (2603:10b6:208:3e9::19) Return-Path: chris.fernald@outlook.com X-Microsoft-Original-Message-ID: <9326a632-cf96-2b81-2911-4c4427067676@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR19MB6275:EE_|SJ1PR19MB6236:EE_ X-MS-Office365-Filtering-Correlation-Id: 2577c4c0-21f0-4dc5-3877-08da9b4022d5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sV762iO7xmkui6GtdXHMDNwaWECfcgI1r9LPN54FLYGvXQfDDc4TlWcoEJczpb/TDgqvRH3jOLICDBrrPVOqpVapRz93Wgtf8zzQvmUBdQuu57EkNU0IkfpTiNmvDTJgNNq1pZJwgvPp8444RGI9oB7h/3JW27lm5X2NTScCprfWvrS76l7UwRABJlzPyzxcnQH4kmkmOAnVeEO0uQxkD2XGJh9C1blRjIb/irt48nfbUCm/y1M/Q7cPXK3A+hv7eiZbzrpigg5viX9TuYayAlNPJb2xAtvOoRZvXzjDYN1W2m29f2vrVtYxH782YvFp37ntvzjo5XvLNr2NAjgV1pLNWk8bmw/Sd3OArGP1fC9ir8KXG8+AK7/pN9rudMM2ls136n5No8k3oDgo8fG+3oucepO39KGyZ5FFCBqDKcPB8lM/LR02m+/NSuylvSU3RFaTCOq/KtVHsfw0vf31dEJRh9kfqX54Ef1PUxGBe91D8MRJb/f4e7fChODUi5vuB5g0mWsjxKolvXnk+G8pXPS8tsw5G+31DkZH+1ymZHeOZn+70+HrpZFKnvMyJQ9mxXgLHMbx/4g8n15TgDHhn2mmGkhZMO3rL9dkxVJ2ThAjROF3YDNUv80F/6asu0ECBs+geie8TYq15o4H6coTlqvX4nvIq6UUm+TfidkSRv/5tdECexB+UMcKFxmmBZAj X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3BzWEZ5TUFDNUNjVUxvNHFYYVZBSnVIYlZjZG5tOGJITm01TjFmdlRjS2lZ?= =?utf-8?B?VmI0RmJBdTdkb1g0MEV4ZitQb2lqV2pyaHdZZTJuR2JMVjhIaG5ZV2VGbzlR?= =?utf-8?B?SDMvZnF1bElIbW9nbzVoVlN2cjBVTkNiRWFORUowUVdqV043VmVWWkxYQy94?= =?utf-8?B?ZzlXZGZ1VmVJRzFYcStlN1ZyTytxOXhvLys5bjMveGd6R0pHY0NPWGJpT05t?= =?utf-8?B?azJmTHZTVCtway81ZGRGcE1BdmJhNkVadDhIN3A0WWViMlZZVm96M25NUFVw?= =?utf-8?B?OWlneE4xcW9qUUczMVEwVVU2NENOdDA3UXVFc0FqWUdqaE5Ta1ZxV09aY1Zw?= =?utf-8?B?WW9VeGxGV3ZQK1lZaW1HTHYzSGM3ZmhRNVN3VGVzTnFNL2NwUnVIZEQwTExN?= =?utf-8?B?SC9CcTJ4TXpIeTFoZHNTdzI1R0sxRzd2SGNtTlNJejh0WkhVMmJ0d1VQZGpj?= =?utf-8?B?a2V6ZGF6aUMyOXAzZDhHZHE5aEFSZXcraGhEbkZkaUhVTGx5bzB2N0dhKysy?= =?utf-8?B?S281SUszUjB0RUR2NVVIaE82UURreDZtZUdGSnR5TkNDZUYvUGFXWUhybFpN?= =?utf-8?B?Nk1odml6dThJNHBIY0ZpZzFwWmVhNm1xREVvbU14a0lqOWY1aXhrdUVZRXhu?= =?utf-8?B?SGdsTW1qUXY0QWdTaDMzZmh2Q08rZEdwbFIvV3JTSE1MRTdKZXMvNVM5R3Z1?= =?utf-8?B?QWNhVkp6K0k1WmhHNmNuOFZaS29OdjhtdWlyTFFYUm80bzN0a1REaWw3aDFn?= =?utf-8?B?TmlPNnUzK1RrVk9kVWk1SDV1SE9PYXQ5Q2lqTzY4aDdVSmROTmQwL0NKd2xZ?= =?utf-8?B?bHpyVFJQaWw0MHNOR0tGRUx5UGVweFpucCtpTUs3Kys5bFZMNDdobE11bmJO?= =?utf-8?B?aDltaDZwOG55ZmZ2RlQ3M1FZaytsOUJCeVZxSStOOEtqMmpQY3prblJjaUV0?= =?utf-8?B?dTVMK1UrL0U2alplSGR2c3FwVlE5a3FzKzlxdWk4cUpMV0kvR2pNYUNBL1hq?= =?utf-8?B?QU1YYWFGdUpjUjlrSHpVR3R6REt3REk2MklIOTdtUldGazdIQVBBNGVVaDAr?= =?utf-8?B?TjRCSHRCNnlJKzRyeWo2Z2dtQ0M3RTRhN0d0ei9JeUovQlV3TDJ6RW03NzAz?= =?utf-8?B?SzZFOXAwR0xMUC9UMFlOWXpTUWZDaDFHWEFrVE1obmJ3dTlPa3RqblRLWGRJ?= =?utf-8?B?YmsybjRvL1ZaVEVOck1JMHI5UEFHZmpDNDB3bGRIaTBwWm52MEVEM0VncG1l?= =?utf-8?B?c2VCY2JZS1BlbUFWbWMrRjNwMWRsTkUzSXR3WjN3enBvRlk5M2szVlV3QkUw?= =?utf-8?B?RHI0OGd3WmwzYU1xYnBZT3BQem1TMW1nbHBMM24xNkNOcExvN1BTNE9Rc0lL?= =?utf-8?B?Y0VVVWRjcHk4V25KNjdjK000VmgvVVZXU1g2OE1PREhBLzJUVDZ1MFlER1Jm?= =?utf-8?B?U0xnU3pMeHYwMWpQQk0rdnFsNGxWRWs4TWd2OUM4Rlg5Ry9IWHgwa1F4NVlm?= =?utf-8?B?WU1HaUlyWGwzb3VncUpwb2hvWWI3dWZKREVyQVFLZWdVMUZzMENkb1Zycmla?= =?utf-8?B?UkJQc0ptTmsxeVFkL0V0Unc0REhxbEZqbU5Ma2wrRndSYXlCekxEOUMvR2RU?= =?utf-8?B?SjlrUlBBZW03VEp6TUMrV244eHVqcG1rTjZNVTZiT1E5N05nNHJOVUhLcEdB?= =?utf-8?B?eUREYUswRVpnMFlJSXVqRTBjc0VBN2Ftbm1MZVp5RHI4aDM1Z0tjUDVqeSs3?= =?utf-8?B?bThIYUErVzJtVS96STlMWDBXNkNkSDdWcEp6MGkxMmR6Vmk5bGdsYm8xcVBl?= =?utf-8?B?L3lUOWJhQlRKaFk2VEFOdz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2577c4c0-21f0-4dc5-3877-08da9b4022d5 X-MS-Exchange-CrossTenant-AuthSource: IA1PR19MB6275.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 19:41:42.8789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR19MB6236 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I think we should avoid the expectation that we are in a container if and only if we are using GCC5. Instead I would prefer we add a boolean parameter to allows us to explicitly use the included python. So instead of the GCC check we would have this. condition: not(eq('${{ parameters.useIncludedPython }}', 'true')) Chris Fernald Microsoft On 9/20/2022 7:45 AM, Oliver Steffen wrote: > Use the Python supplied by the container image. > > Signed-off-by: Oliver Steffen > --- > .azurepipelines/templates/platform-build-run-steps.yml | 1 + > .azurepipelines/templates/pr-gate-steps.yml | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azurepipelines/templates/platform-build-run-steps.yml > index 40a31a509fc5..3c16fa981d5a 100644 > --- a/.azurepipelines/templates/platform-build-run-steps.yml > +++ b/.azurepipelines/templates/platform-build-run-steps.yml > @@ -44,6 +44,7 @@ steps: > inputs: > versionSpec: ">=3.10.6" > architecture: "x64" > + condition: not(eq('${{ parameters.tool_chain_tag }}', 'GCC5')) > > - script: pip install -r pip-requirements.txt --upgrade > displayName: 'Install/Upgrade pip modules' > diff --git a/.azurepipelines/templates/pr-gate-steps.yml b/.azurepipelines/templates/pr-gate-steps.yml > index cb431e53fcd1..df8802718d99 100644 > --- a/.azurepipelines/templates/pr-gate-steps.yml > +++ b/.azurepipelines/templates/pr-gate-steps.yml > @@ -22,6 +22,7 @@ steps: > inputs: > versionSpec: '>=3.10.6' > architecture: 'x64' > + condition: not(eq('${{ parameters.tool_chain_tag }}', 'GCC5')) > > - script: pip install -r pip-requirements.txt --upgrade > displayName: 'Install/Upgrade pip modules'