public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chris Fernald" <chris.fernald@outlook.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, osteffen@redhat.com,
	Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Bob Feng <bob.c.feng@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Michael Kubacki <mikuback@linux.microsoft.com>,
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Yuwei Chen <yuwei.chen@intel.com>,
	Pawel Polawski <ppolawsk@redhat.com>
Subject: Re: [edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)
Date: Wed, 21 Sep 2022 17:33:49 -0700	[thread overview]
Message-ID: <IA1PR19MB6275A42184714D580B78AE37E74E9@IA1PR19MB6275.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20220921082619.ty3szh6zmqvyt4yq@sirius.home.kraxel.org>

There is probably value in having both if we want to support various 
flavors of containers in the future, but yes adding a container option 
to the template similar to vm_image.

Thanks,
Chris

On 9/21/2022 1:26 AM, Gerd Hoffmann wrote:
> On Tue, Sep 20, 2022 at 01:01:04PM -0700, Chris Fernald wrote:
>> Similar to my comment about the assumption in use of python, I believe the
>> container should be determined and passed in as a parameter from the top
>> level pipeline file rather then relying on tool chain tag. This lets the
>> templates take action on being containerized rather then assuming the tool
>> chain. Additionally, this would give consistency between the platform and PR
>> templates which currently make opposite assumption about consumer vs
>> template determining the container image.
> 
> i.e. update .azurepipelines/Ubuntu-GCC5.yml and replace "vm_image: ..."
> with "container: ..."?
> 
> take care,
>    Gerd
> 

  reply	other threads:[~2022-09-22  0:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 14:45 [PATCH v5 0/4] CI: Use Fedora 35 container for Linux jobs Oliver Steffen
2022-09-20 14:45 ` [PATCH v5 1/4] CI: don't force python verison (Linux only) Oliver Steffen
2022-09-20 19:41   ` [edk2-devel] " Chris Fernald
2022-09-21  8:31     ` Gerd Hoffmann
2022-09-20 14:45 ` [PATCH v5 2/4] CI: add ~/.local/bin to PATH " Oliver Steffen
2022-09-20 14:45 ` [PATCH v5 3/4] CI: Use Fedora 35 container " Oliver Steffen
2022-09-20 20:01   ` [edk2-devel] " Chris Fernald
2022-09-21  8:26     ` Gerd Hoffmann
2022-09-22  0:33       ` Chris Fernald [this message]
2022-09-20 14:45 ` [PATCH v5 4/4] BaseTools: Remove ext. gcc dependencies " Oliver Steffen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA1PR19MB6275A42184714D580B78AE37E74E9@IA1PR19MB6275.namprd19.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox