Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg: Correct all INF_VERSION value

["Tommy Huang" <tommy_huang@aspeedtech.com>]

Hi Ard,

	Thanks for your review.

	Because I have saw the last patch has been accepted into https://github.com/tianocore/edk2-non-osi.git
	So, I use another patch to fix the typo.
	Do you mean that I need to send my last patch again with corrected the .inf files?

	BR,

	by Tommy

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Tuesday, January 31, 2023 7:38 PM
> To: devel@edk2.groups.io; Tommy Huang <tommy_huang@aspeedtech.com>
> Cc: nathaniel.l.desimone@intel.com; isaac.w.oram@intel.com;
> quic_llindhol@quicinc.com; michael.d.kinney@intel.com; Ryan Chen
> <ryan_chen@aspeedtech.com>; BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [edk2-devel] [edk2-non-osi][PATCH V1] ASpeed/ASpeedGopBinPkg:
> Correct all INF_VERSION value
> 
> On Mon, 30 Jan 2023 at 03:09, Tommy Huang
> <tommy_huang@aspeedtech.com> wrote:
> >
> > 1. Correct all INF_VERSION value.
> >
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Ryan Chen <ryan_chen@aspeedtech.com>
> > Cc: BMC-SW <BMC-SW@aspeedtech.com>
> >
> > Signed-off-by: Tommy Huang <tommy_huang@aspeedtech.com>
> 
> This patch does not apply
> 
> Please generate your patch against
> https://github.com/tianocore/edk2-non-osi.git
> 
> 
> > ---
> >  Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf | 4 ++--
> > Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > index d6a674c..6bda488 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2500GopDxe.inf
> > @@ -10,11 +10,11 @@
> >  ##
> >
> >
> >
> >  [Defines]
> >
> > -  INF_VERSION                    = 0x00011302
> > +  INF_VERSION                    = 1.29
> >    BASE_NAME                      = ASpeedAst2500GopDxe
> >
> >    FILE_GUID                      =
> 7F81D838-F91D-4C44-8552-8FB912122FDD
> >
> >    MODULE_TYPE                    = UEFI_DRIVER
> >
> > -  VERSION_STRING                 = 1.29
> > +  VERSION_STRING                 = 1.13.02
> >
> >
> >  [Binaries.AArch64]
> >
> >    PE32|AArch64/ASpeedAst2500Gop.efi|*
> >
> > diff --git a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > index a652ced..3375407 100644
> > --- a/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > +++ b/Drivers/ASpeed/ASpeedGopBinPkg/ASpeedAst2600GopDxe.inf
> > @@ -9,11 +9,11 @@
> >  ##
> >
> >  [Defines]
> > -  INF_VERSION                    = 0x00011302
> > +  INF_VERSION                    = 1.29
> >    BASE_NAME                      = ASpeedAst2600GopDxe
> >    FILE_GUID                      =
> 36f08597-2a8d-4824-9416-59c810b0d9f3
> >    MODULE_TYPE                    = UEFI_DRIVER
> > -  VERSION_STRING                 = 1.29
> > +  VERSION_STRING                 = 1.13.02
> >
> >  [Binaries.AArch64]
> >    PE32|AArch64/ASpeedAst2600Gop.efi|*
> > --
> > 2.25.1
> >
> >
> >
> > 
> >
> >