From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7F152D8067E for ; Wed, 21 Feb 2024 02:18:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+IZpDsGDD3SOb5yU4gRa+LrYQAJl9aoSg7rCSMi5Dyk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708481920; v=1; b=hnng6AYMrxDpTMki/fY/h/KFNO4EFY8344LISFV40dqSjPWCP6m/juG9kQDR8RUUHE4U8YaE 0E+KXGditpn+Da7w9TVUJZuLIzcMi0SBxLezh14zm0VJd7FTyraP2IlCl51IMd8MCn58w1XTGIO /4gZStH0RujfQHjhv3mmy7j0= X-Received: by 127.0.0.2 with SMTP id v9UlYY7687511xOfLxrZTHkk; Tue, 20 Feb 2024 18:18:40 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.50]) by mx.groups.io with SMTP id smtpd.web11.4186.1708481919522379512 for ; Tue, 20 Feb 2024 18:18:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErE7aomt3/4dPthvynSQFZZSzN1luLKPCuL/r3+WePTSQlaMZAitDcSmHvaI2pdVSYn2DyqCskxcwVSp2mn1Aj3aSWfSIzThJ6GKg6rVY6G/+5KJFe0YhqUIbicEEA8A335k5FhB77dIvr1AMFseNEHfr9NU3KCSKPb45h+JJeb1NxBHz9iVL23c3ccAYeHW1r/M8iaCIl5RM3KPj0z4vjW9eSIaWhYAn393vO6r87dcmI0Y+CbRsrCd7g8xKPRugfDuVrFyw5pBEuvYLfpmnN/Y2gGm0DckzEmIjUyp5k0VJW2EJwy0hISn27lh+xpiR9/hH16+SX+rhDCO1ROHDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EsMt4GAtMMeVmQjvcDu9c6BpL5yDxtNJpVJZ4owKaCM=; b=UNx3Zgus90I3dfzS3/nOTgLCyTX1AtJTkMU9W2kZe/13S2gg4lhC/FXfPwOtBlKXX8J/lhU2GHkD2G+b9KYhWA1Xj5ssnXrpMVcvuxdWmrtY21J8pAYAXA81j5gU6YPVlk+GKIMdCu5tJEMBKHVg+Fhelfp/ndEeCT+P12TElnBBqvrhZXUiYksBqOb4Tymi+7Za7viwcD4su1CXDYzaSXaPcIoKvOnKegz6rzcj/QyOJoHC332z/bpQEz6jMBN2n3fZr37tFVwsGhqelJ0Y+jua+2VXeFnHIkbZbG52W7qzxiULfTxFzEYqdZPCxD8RItD1aAHtDUgIB/hnf6QgLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SA1PR12MB7343.namprd12.prod.outlook.com (2603:10b6:806:2b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Wed, 21 Feb 2024 02:18:36 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 02:18:36 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Thread-Topic: [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSettings URI. Thread-Index: AQHaZFrBOvDlpvxhU0eHkUU+GSLvAbEUD9Hw Date: Wed, 21 Feb 2024 02:18:36 +0000 Message-ID: References: <20240221001303.57384-1-mike.maslenkin@gmail.com> <20240221001303.57384-4-mike.maslenkin@gmail.com> In-Reply-To: <20240221001303.57384-4-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e5c3552b-93e6-44b3-885a-84d00f733144;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:18:30Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SA1PR12MB7343:EE_ x-ms-office365-filtering-correlation-id: 86d7169a-2752-4562-c1ef-08dc328368e0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7i9/mbuDTQ1T8eFkfeJhXGWiPzuy6DGD3+kw772t9uRS7Aoncj3Ia57RWgsqwOpBOs9m3VApblubA4MCx9U3Cu/5xfRkPVp7v+gWzW0QQs4MJMGfAQ+W4q5q4h21OrbJHtm3nBnktGc4vocg1SOuq+iUQBHXChJUwmRx/wDCS/NnzOlwUImtx6q5t6mUK3N6eLm5VPvS/u+rXupeu5Z8X+Mt70vcAP1vwcmkHExUMOXaaJ0JT+bBg8FAwn8j8XtKu2a0wFd7koouoYk9jAbewdr1ihV/4jutMF9IXXl0r3bpp59LnkU6s8ie3BtTkqsiMhAB0yESpyAY6SMmlkv8uwiT+tMN58PbHuofNO46beo1oGbWyj7ikd+egOFArcUn0Glo7aSLOufqzZB/Bt/jo5If41cTipkSTv6x1gOQ9mJsnOvxNGKRcfWHEGFMDsWy3CDlUNknXDAHpWKGLY0eNkPKBpPauXGCpNZxCtCniwUh3+EP4jENOZYQqVRUikRh+vSyp7juj9eJa3FtYY49KQTl6qpAEAYT21bR7h5OIlAr2OmaswEdsUYw0j3G/78dl5GUJD2xoMIsCjiktNQjDJoGWH0a25xwdNq9O+UCHQnt2IExs7EEJ1T2HuNoCaf4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5XvDHI3oa6M7YRGwbR/QBNTvHlMwxqf5twjKBLbBapGvh702Go1aWj8HC+4t?= =?us-ascii?Q?YX4GYLxg5vylDo5rbmV3FizA/v3DNHRcFOg8Tn+hl961bILtqJ4JHrTRzxe9?= =?us-ascii?Q?+L3Pu6U9Yck7kell+OCm2Svo7ARjzeninv54jrxQdPIKC6cyMmApDgqGyDmt?= =?us-ascii?Q?UWv9JoGtMETjeKN1XOv77LbPfa2AnFf8d1jH30moQavIsEGAptbzIdV9Mt/S?= =?us-ascii?Q?bxxp1ftwqjIy/R6K3SU6eN6WHjmjzfqPMmfFA8InHSg/XkzDYShBE/STfuBF?= =?us-ascii?Q?jNdHedijEolWEPz3EQY5e1VoQq0BHcq0F/lHqx5XHYLnYAwk5q4zlnIQobAa?= =?us-ascii?Q?LCZVOUh8mnU8IfUbw4t9VwafTZLEky5+bfC/kgfboKS/ZcOyto36B3+GW2yA?= =?us-ascii?Q?yv1IAGwCD7vHNBAz8rlBwvJ/LfYFPRXFXnFsfFPBEriFvctGhsmpeyOm2F4D?= =?us-ascii?Q?kluGPJV7KTEJi56fZNaluVxVLsS9zkZUzH9lJibetwk2uAmUXHm82APmWK9P?= =?us-ascii?Q?ZpFJIfuA2sQOv9ju3G3pa5kz21PdgNFTDmCIKOkqzDwE6ZzXzK7zqPXSr6IG?= =?us-ascii?Q?HgqRbYl6L1UsJI3hcGKmkHT10yKcmFGL0DNPmI2geou6LdbubnUeqlgf5fJA?= =?us-ascii?Q?YxIphZjIKea19qVTh+CRq5lox1/jeEV+Zv8WMhheTbExxIdWsXc7UGdyi7Sz?= =?us-ascii?Q?nwXYTjgfHD6KKO6Uj8AlF1GOZDBZq0lc0jeaXk1fiKHamixAnbkg+wVETZcr?= =?us-ascii?Q?JEZrXSVE8T5PvmOUmlg0RV2FkCOkW1yocMDNC2U88uukA+M+hh7wAwrqCXXT?= =?us-ascii?Q?s9v2Z8F8Oq9UlngTRwXu6I0VtYKdcvmU0nSPlEHC4xyV/YdFycVLfUoghNbt?= =?us-ascii?Q?gGLnFYSmw55613qSQmADAZmBzZxNnBulv731AO49m5xa4nyLdFk2JGDEMps1?= =?us-ascii?Q?wvuH26bHxVd2Anjp670/xImZ6C8GH7HLJ52lyfjJ5kwO5YzQ+rhe+dbjNZ3K?= =?us-ascii?Q?os4OJ8AcxTX+Kozu+rymL+Alqh0cEQBc2x2rAf2e1Gwm6IxHblUbQMIehPVL?= =?us-ascii?Q?X7LZ06fdfyYQURNNzkVX7W7HqI0KZGiLa4RE3Bju08/2YphwSMAhSdurPBk9?= =?us-ascii?Q?el7Qpjc9UUV7brOVyWTQPK7WF8fJIp0l30/AW1PRHiqmtVptjg9yCHjmIwD7?= =?us-ascii?Q?0zgGD+FpazYTGFViNDYoxLYqBx97losFXr5n4oPsxADXguNsGA2LwUxF4FKJ?= =?us-ascii?Q?E2BCGLzHCK7tIcb+bhmJnCsJIT9xbyvh1frASQlxSMe/hIiCDd+ZSRQWIXob?= =?us-ascii?Q?ahX90tzcZ3KHTfjNsGl4D/h3yOJQRLIKD/j3GYT6bUBLvtO5ng6oFMeadhDB?= =?us-ascii?Q?J6WtNd5EVHN/H9TSe7IRuMG7xpZwQ1t0NqGl2PyBuc/ilsO3JGeEzwJzRiZ1?= =?us-ascii?Q?AhNyFi0gep5wx5jDJnUqoCfl9brF6bpIvWPpdcgbt2xohukK077TpI7A5x+m?= =?us-ascii?Q?QqNoC96oJo2R4nbTlrsr3T7roCbbmqDb58tQEQXIbZTysIsLzrVy9tueVZ9u?= =?us-ascii?Q?nJX9erlcoFrsqikGOyotpb3AqeFA6CbUa4tsH/ne?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86d7169a-2752-4562-c1ef-08dc328368e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 02:18:36.1250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Jf3or2v311p7cX/+yqD2wEGFczrVCGG4OR+yYWXZpTzV7CiWNXSMTnRMonrKObVhSJRGuCHhYUN8CPy1Wpwzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7343 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tvRIDPwGXYU2TZZhNDnqaIyDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hnng6AYM; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, February 21, 2024 8:13 AM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Chang, Abner > ; Nickle Wang ; Igor > Kulchytskyy > Subject: [PATCH 3/4] RedfishClientPkg/Bios: fix leak of GetPendingSetting= s > URI. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > index 396ec22969b5..8548425c9c83 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c > @@ -132,6 +132,7 @@ RedfishResourceConsumeResource ( > // Check and see if "@Redfish.Settings" exist or not. > > // > > ZeroMem (&PendingSettingResponse, sizeof (REDFISH_RESPONSE)); > > + PendingSettingUri =3D NULL; > > Status =3D GetPendingSettings ( > > Private->RedfishService, > > Response.Payload, > > @@ -206,6 +207,10 @@ RedfishResourceConsumeResource ( > FreePool (Etag); > > } > > > > + if (PendingSettingUri !=3D NULL) { > > + FreePool (PendingSettingUri); > > + } > > + > > return Status; > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115698): https://edk2.groups.io/g/devel/message/115698 Mute This Topic: https://groups.io/mt/104479573/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-