From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 966E494110F for ; Tue, 23 Jan 2024 05:14:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Y7xPBLDNFwyw5ARgsUqC8BlchyhSpvCfH3/F8NvwY3w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705986870; v=1; b=dTHrfINO0zs+CK0lRfjNmw0rVWpRGiXL/JuHfDDt4/QM7SKz9eF4nrVwU2S2z7Wk1j7ChSSC 3S039LCYeRPzzNey5v/mlSrL4ryxfV45+XOr46FhpXrkirgfOB0HzAG5ZbFA9FP+F9HNUNkD1hp mU4hQd1rcCYvjzGzcs5cZILI= X-Received: by 127.0.0.2 with SMTP id KBkjYY7687511xb3brTlj1Nx; Mon, 22 Jan 2024 21:14:30 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.46]) by mx.groups.io with SMTP id smtpd.web10.5087.1705986869358556121 for ; Mon, 22 Jan 2024 21:14:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2ybzxEMsugczR+yyh4g0oIVdYIBVsv4wBZXFOx+dpKCPFPaAepPPK7mjE5jp8mKXGQZy3eEfAf/Hf+5LI4ZvYX7xlCjVeA0ILfB+jc24SZi0AeKLD5aGuCGhZl6bzw7Cj/DzoGjO3vUhFq3bDswzDfFG6CZyfY9KlgWZgjpcw/Ge6Vp4jtcNftE0G5IWt+Ndn3CbcEZ005at6XBRjPbKVu0GYWj9PLrJQsFtuOFM8Cl26KXthiXFbTsIM1TSpi309sbEsp2SHZRTBNf9N+1WHxfGwt6y4Z7bjZ7cYf4NMgvlNRm0MVPMFsEfXEKoUp+Lf2Z/NQ2f/PWyXiUvdLeVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5eTKwO2vEt5iYzeNSTbWAmiUdDZzAuhaDp6ZmAUCjTg=; b=Npo9BZ0TX/VuAVSKWyMAOA2SBPT677bBUyoEq5oIWgtFVVPsI3EN4FuLnu1GIlfr7gFPNH71r7wLM/6hW+tWahNYEEHOoWdyBqVjJZhcVeinCBQ2pSHpjaKK8YEznDmMAsTTaVC9iME6A3mpg30SGhul/uS4wH5qeNlBM9gn2jlcIrmGKqUw17e1qPNAK2R8i+Rxfh2h5VuEGIxCN3TCzi6u0B+ikVudINtT1hoIcYPJDgaS241SWQHDXPW/3f7aRawbNjWbgOpzQxxwRBBDXPPiRMPFi0w7EtA60re9dVZ7eVwz+TuMIVWzhBSMTUshcud81SuYZtF08AyCLBrYHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by CY8PR12MB7587.namprd12.prod.outlook.com (2603:10b6:930:9a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Tue, 23 Jan 2024 05:14:26 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::67bd:f1b9:58a3:d2e6%7]) with mapi id 15.20.7202.031; Tue, 23 Jan 2024 05:14:26 +0000 From: "Chang, Abner via groups.io" To: "Zhai, MingXin (Duke)" , "devel@edk2.groups.io" CC: "Xing, Eric" , "Yao, Ken" , "Fu, Igniculus" Subject: Re: [edk2-devel] [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module. Thread-Topic: [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module. Thread-Index: AQHaSdr8hql0P1W9E0S+mwcLKzOiKLDm4fAA Date: Tue, 23 Jan 2024 05:14:26 +0000 Message-ID: References: <20240118065046.961-1-duke.zhai@amd.com> <20240118065046.961-29-duke.zhai@amd.com> In-Reply-To: <20240118065046.961-29-duke.zhai@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=503c29b9-b7b6-4ba1-9809-9bbf25d437a9;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-01-23T05:12:56Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|CY8PR12MB7587:EE_ x-ms-office365-filtering-correlation-id: 98285d45-8289-48b4-730a-08dc1bd22b2e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +dzOcVdOmRO91Ijq/eaaNb7BtghrTR5AjbDMmk9OTgguFktDVgdRC2C4ip6UtKh4WCi8x1UDS8n6mNBw1Iqp3a0eVCi7udaHlDnE9XTbYtGMo93vz22K6VprW3/3ZhCDrIhOq3ZfZuRQgjQsTBKuQjWWEJxUnmdGKyp93dYwXaV8mvjPVOgya0sMuyBpKOoZ2GHVBEA0LaZhLxKs77SDZRsuRnOD+wXm8beGYPFocbAZPwyVmt4NPrB1jY+dOVvdkSkvDlcFOTB+DnNgOf7WFCH9GHnzybEAXe6bfrbeM6S784ljDMOFVbi87E6Ylro9BgGbc6Jiw4LNdQc+Uzpw7cIB1RSfOcR59wdRSUscKVATwD8PoYMngMXUILM8ZYqVdHzSVfhnoFfqFKoyDurBzug3BhxcTjtoHN4nwoUIKjSjq+xt2yBg8XOYqoG/Em9AprqlV9ZY7NpQ7AwvcchhkCbTX1amMTcUhwB652tMnhbD8E5gnVfOlsK5A8nylPJyxb3cjTji6k7KlP/C7/ivugunFGpg58NRT/gmCl0yhpbnOxyJh1AQPhX45q7d0oCmqoF20EbYsaRZf5Hsii8cPcf+Qscakw1UKWdoUaxvNp9+qzDsqecGFEIleE5grLdN4Nvuxvh0UTHupLtIBDF3Qg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1rwC3+YnWNv4z/068FxUqce0CAPMUFBXGb7xqhsIiczhVHs+PONA5v9peXS4?= =?us-ascii?Q?JawRYdO86pUv3sOcWMzzpezRLLJFYPXWZamYe9GCiJ54reZGCJvbHRsMUKJG?= =?us-ascii?Q?XawHVUQfTjSlp4k+EOTSkNzoNELr06mebEejqXCZVYHnJKCbo0fd6BAi/Umd?= =?us-ascii?Q?xxMaRN/ZWK4FzTBikRwp6aRURYh7EaMcmqB37owdsDC0F3yk5+23YsPxhFn1?= =?us-ascii?Q?JeN2o5BbhSUBtM/Mub10D+S8Z6Rf3KwiZ7z68u99bxcjNncpE90O1QGl5Tdc?= =?us-ascii?Q?A8n65p2dbk2WN6pX4qw+NcUlq5Y6GLsUCQtgJ+3A7RWfY/NnzTNXLBuN+hoX?= =?us-ascii?Q?neT6XW3loBxvFwauIyd/Gwl+sTylo9oXAL9mlcxWawbmFYNDUpqcFgO0em4P?= =?us-ascii?Q?b8k3X4+iyLHpQvFulAcAXUJMf3oO+QmEdhYZdy8rscJZgZYkiHjtpxY1cI1w?= =?us-ascii?Q?o0Zg7RKvfx7l5qwtRPNO2fZUHUycoUAR3dRuCI58SwtYOqqalY0RC4npJmvt?= =?us-ascii?Q?xmljCYZaOOmTUtURqU6f2pEXuuMcMB03wHpPq0L3jZ3CBLZ2YabQ+M1akity?= =?us-ascii?Q?FnAHA/WpgQDlqym4cxRXzLXxHbH8SAl9TVuJALSnIEjb5rTWAt3vHDxgAuib?= =?us-ascii?Q?EDI8Hoo5dbNokzX/rAzO4B40a8WM2uSguEFVSN/poS4SZtlSITpXuTQhoK3b?= =?us-ascii?Q?Fhlp7Xo68RXBkCMguKlZeYWcecR5sQqcbPaLlVESMbsApFb9Z7aSCxdlfHyf?= =?us-ascii?Q?mJ0h6uvn7K7JLVWZ3TlXjuFBnJRDvGi556RBFU1U7iofF9gmbxSmtnp00PRk?= =?us-ascii?Q?SlpKrOiFwE25IEdVda2xEHqIuyngtsGJuSr47c4Z8bGKotzEu35X7TQXsQ1D?= =?us-ascii?Q?b/0z4NaAqiMtVtb0o9G0N7nrNa0CKYw7VCuFAs0otwxvFPpkPV0r1KCB1cH0?= =?us-ascii?Q?IuBry2O4786UYcDUqk0TZu8BQI/xocS1KUvSRLJWjqEtgD1Ja7JQRyeH4gV2?= =?us-ascii?Q?pct+RTW21R2B1QbNiWRAemQHoLKbmy7oUEPjNGSSQTkfywdAG1JFKhDcWgF1?= =?us-ascii?Q?AHpmFnXI6qROKG09tXqI0XdlqMEPmhIF28+9EXcPV41L5l2F6exk8nPNZAhM?= =?us-ascii?Q?NchtRY1xJZydDvCC8iuUe5iGODh/tq+AeDBpkGwLFUUwyx4rO2hAE5cbPc9u?= =?us-ascii?Q?4vSruXje8fVrvhPFpsgya/65kRIEEfex02QfzRm3FNLwqYfpxGxH7e7rkyNx?= =?us-ascii?Q?xSstgg0Cgci3scHZUcMpS1k/BTsp4voKa9oyZOgog82p97s0ZWjZPJ4jj6+G?= =?us-ascii?Q?iypyXkuVaQBqt9cmtQfMuOkgeQr9SpDiZiss7vEQxA/Wcr24cy2yhKEvTKJf?= =?us-ascii?Q?dRKg6FuDGcd6bXUFwo7Sf8j/YE3KRDQNzo1hWXfXyVMT/pEgW64NrQLp+IgL?= =?us-ascii?Q?L8awGjpj4pUB4ZujOn5/m2lSRpfoP1kK2JgmxLhe9TN4QkXQP+T1wTcvcSyi?= =?us-ascii?Q?OyhRyEzaEDVGB7uFlv2v/z8gmLBBb7oQNdB0k1j4YeJFonHG1NB/macQl4Qi?= =?us-ascii?Q?DyEPH35jMY1abKgDX14=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98285d45-8289-48b4-730a-08dc1bd22b2e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 05:14:26.1025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nx8XWxfqXpGyd36ca7aO4T9yH9ZZxrPipO/DYWxlMQnEZ0Sob93VetHARhiA3ciF+HMtYtz78wA2xFLqtvtNBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7587 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JHvFn9BNOljd6gqp3T233NyRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dTHrfINO; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Please confirm if the latest edk2 SmmCpuFeatureLibCommon.c and AmdSmmCpuFea= tureLib.c under SmmCpuFeatureLib can cover your changes in this patch or no= t. Thanks Abner > -----Original Message----- > From: duke.zhai@amd.com > Sent: Thursday, January 18, 2024 2:51 PM > To: devel@edk2.groups.io > Cc: Xing, Eric ; Yao, Ken ; Fu, > Igniculus ; Chang, Abner > Subject: [PATCH 28/33] AMD/VanGoghBoard: Check in > SmmCpuFeaturesLibCommon module. > > From: Duke Zhai > > > BZ #:4640 > > Initial SmmCpuFeaturesLibCommon module. The CPU specific programming > for > > PiSmmCpuDxeSmm module when STM support is not included. > > > > Signed-off-by: Duke Zhai > > Cc: Eric Xing > > Cc: Ken Yao > > Cc: Igniculus Fu > > Cc: Abner Chang > > --- > > .../SmmCpuFeaturesLibCommon.c | 629 ++++++++++++++++++ > > 1 file changed, 629 insertions(+) > > create mode 100644 > Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmCpu > FeaturesLib/SmmCpuFeaturesLibCommon.c > > > > diff --git > a/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmCp > uFeaturesLib/SmmCpuFeaturesLibCommon.c > b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmC > puFeaturesLib/SmmCpuFeaturesLibCommon.c > > new file mode 100644 > > index 0000000000..7b07425336 > > --- /dev/null > > +++ > b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmC > puFeaturesLib/SmmCpuFeaturesLibCommon.c > > @@ -0,0 +1,629 @@ > > +/** @file > > + Implements AMD SmmCpuFeaturesLibCommon.c > > + > > + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +/* This file includes code originally published under the following lice= nse. */ > > +/** @file > > +Implementation shared across all library instances. > > + > > +Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> > +Copyright (c) Microsoft Corporation.
> > +SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "CpuFeaturesLib.h" > > + > > +// > > +// Machine Specific Registers (MSRs) > > +// > > +#define SMM_FEATURES_LIB_IA32_MTRR_CAP 0x0FE > > +#define SMM_FEATURES_LIB_IA32_FEATURE_CONTROL 0x03A > > +#define SMM_FEATURES_LIB_IA32_SMRR_PHYSBASE 0x1F2 > > +#define SMM_FEATURES_LIB_IA32_SMRR_PHYSMASK 0x1F3 > > +#define SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE 0x0A0 > > +#define SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSMASK 0x0A1 > > +#define EFI_MSR_SMRR_MASK 0xFFFFF000 > > +#define EFI_MSR_SMRR_PHYS_MASK_VALID BIT11 > > +#define SMM_FEATURES_LIB_SMM_FEATURE_CONTROL 0x4E0 > > + > > +// > > +// MSRs required for configuration of SMM Code Access Check > > +// > > +#define SMM_FEATURES_LIB_IA32_MCA_CAP 0x17D > > +#define SMM_CODE_ACCESS_CHK_BIT BIT58 > > + > > +extern UINT8 mSmmSaveStateRegisterLma; > > + > > +// > > +// Set default value to assume SMRR is not supported > > +// > > +BOOLEAN mSmrrSupported =3D FALSE; > > + > > +// > > +// Set default value to assume MSR_SMM_FEATURE_CONTROL is not > supported > > +// > > +BOOLEAN mSmmFeatureControlSupported =3D FALSE; > > + > > +// > > +// Set default value to assume IA-32 Architectural MSRs are used > > +// > > +UINT32 mSmrrPhysBaseMsr =3D > SMM_FEATURES_LIB_IA32_SMRR_PHYSBASE; > > +UINT32 mSmrrPhysMaskMsr =3D > SMM_FEATURES_LIB_IA32_SMRR_PHYSMASK; > > + > > +// > > +// Set default value to assume MTRRs need to be configured on each SMI > > +// > > +BOOLEAN mNeedConfigureMtrrs =3D TRUE; > > + > > +// > > +// Array for state of SMRR enable on all CPUs > > +// > > +BOOLEAN *mSmrrEnabled; > > + > > +/** > > + Performs library initialization. > > + > > + This initialization function contains common functionality shared betw= en all > > + library instance constructors. > > + > > +**/ > > +VOID > > +CpuFeaturesLibInitialization ( > > + VOID > > + ) > > +{ > > + UINT32 RegEax; > > + UINT32 RegEdx; > > + UINTN FamilyId; > > + UINTN ModelId; > > + > > + // > > + // Retrieve CPU Family and Model > > + // > > + AsmCpuid (CPUID_VERSION_INFO, &RegEax, NULL, NULL, &RegEdx); > > + FamilyId =3D (RegEax >> 8) & 0xf; > > + ModelId =3D (RegEax >> 4) & 0xf; > > + if ((FamilyId =3D=3D 0x06) || (FamilyId =3D=3D 0x0f)) { > > + ModelId =3D ModelId | ((RegEax >> 12) & 0xf0); > > + } > > + > > + // > > + // Check CPUID(CPUID_VERSION_INFO).EDX[12] for MTRR capability > > + // > > + if ((RegEdx & BIT12) !=3D 0) { > > + // > > + // Check MTRR_CAP MSR bit 11 for SMRR support > > + // > > + if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MTRR_CAP) & BIT11) !=3D > 0) { > > + mSmrrSupported =3D TRUE; > > + } > > + } > > + > > + // > > + // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > > + // Volume 3C, Section 35.3 MSRs in the Intel(R) Atom(TM) Processor Fam= ily > > + // > > + // If CPU Family/Model is 06_1CH, 06_26H, 06_27H, 06_35H or 06_36H, > then > > + // SMRR Physical Base and SMM Physical Mask MSRs are not available. > > + // > > + if (FamilyId =3D=3D 0x06) { > > + if ((ModelId =3D=3D 0x1C) || (ModelId =3D=3D 0x26) || (ModelId =3D= =3D 0x27) || > (ModelId =3D=3D 0x35) || (ModelId =3D=3D 0x36)) { > > + mSmrrSupported =3D FALSE; > > + } > > + } > > + > > + // > > + // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > > + // Volume 3C, Section 35.2 MSRs in the Intel(R) Core(TM) 2 Processor > Family > > + // > > + // If CPU Family/Model is 06_0F or 06_17, then use Intel(R) Core(TM) 2 > > + // Processor Family MSRs > > + // > > + if (FamilyId =3D=3D 0x06) { > > + if ((ModelId =3D=3D 0x17) || (ModelId =3D=3D 0x0f)) { > > + mSmrrPhysBaseMsr =3D > SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE; > > + mSmrrPhysMaskMsr =3D > SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSMASK; > > + } > > + } > > + > > + // > > + // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > > + // Volume 3C, Section 34.4.2 SMRAM Caching > > + // An IA-32 processor does not automatically write back and invalida= te its > > + // caches before entering SMM or before exiting SMM. Because of this > behavior, > > + // care must be taken in the placement of the SMRAM in system memory > and in > > + // the caching of the SMRAM to prevent cache incoherence when switch= ing > back > > + // and forth between SMM and protected mode operation. > > + // > > + // An IA-32 processor is a processor that does not support the Intel 6= 4 > > + // Architecture. Support for the Intel 64 Architecture can be detecte= d from > > + // CPUID(CPUID_EXTENDED_CPU_SIG).EDX[29] > > + // > > + // If an IA-32 processor is detected, then set mNeedConfigureMtrrs to > TRUE, > > + // so caches are flushed on SMI entry and SMI exit, the interrupted co= de > > + // MTRRs are saved/restored, and MTRRs for SMM are loaded. > > + // > > + AsmCpuid (CPUID_EXTENDED_FUNCTION, &RegEax, NULL, NULL, NULL); > > + if (RegEax >=3D CPUID_EXTENDED_CPU_SIG) { > > + AsmCpuid (CPUID_EXTENDED_CPU_SIG, NULL, NULL, NULL, &RegEdx); > > + if ((RegEdx & BIT29) !=3D 0) { > > + mNeedConfigureMtrrs =3D FALSE; > > + } > > + } > > + > > + // > > + // Allocate array for state of SMRR enable on all CPUs > > + // > > + mSmrrEnabled =3D (BOOLEAN *)AllocatePool (sizeof (BOOLEAN) * > GetCpuMaxLogicalProcessorNumber ()); > > + ASSERT (mSmrrEnabled !=3D NULL); > > +} > > + > > +/** > > + Called during the very first SMI into System Management Mode to initia= lize > > + CPU features, including SMBASE, for the currently executing CPU. Sinc= e this > > + is the first SMI, the SMRAM Save State Map is at the default address o= f > > + SMM_DEFAULT_SMBASE + SMRAM_SAVE_STATE_MAP_OFFSET. The > currently executing > > + CPU is specified by CpuIndex and CpuIndex can be used to access > information > > + about the currently executing CPU in the ProcessorInfo array and the > > + HotPlugCpuData data structure. > > + > > + @param[in] CpuIndex The index of the CPU to initialize. The va= lue > > + must be between 0 and the NumberOfCpus fiel= d in > > + the System Management System Table (SMST). > > + @param[in] IsMonarch TRUE if the CpuIndex is the index of the CP= U that > > + was elected as monarch during System Manage= ment > > + Mode initialization. > > + FALSE if the CpuIndex is not the index of t= he CPU > > + that was elected as monarch during System > > + Management Mode initialization. > > + @param[in] ProcessorInfo Pointer to an array of > EFI_PROCESSOR_INFORMATION > > + structures. ProcessorInfo[CpuIndex] contai= ns the > > + information for the currently executing CPU= . > > + @param[in] CpuHotPlugData Pointer to the CPU_HOT_PLUG_DATA > structure that > > + contains the ApidId and SmBase arrays. > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesInitializeProcessor ( > > + IN UINTN CpuIndex, > > + IN BOOLEAN IsMonarch, > > + IN EFI_PROCESSOR_INFORMATION *ProcessorInfo, > > + IN CPU_HOT_PLUG_DATA *CpuHotPlugData > > + ) > > +{ > > + SMRAM_SAVE_STATE_MAP *CpuState; > > + UINT64 FeatureControl; > > + UINT32 RegEax; > > + UINT32 RegEdx; > > + UINTN FamilyId; > > + UINTN ModelId; > > + > > + // > > + // Configure SMBASE. > > + // > > + CpuState =3D (SMRAM_SAVE_STATE_MAP > *)(UINTN)(SMM_DEFAULT_SMBASE + SMRAM_SAVE_STATE_MAP_OFFSET); > > + if (mSmmSaveStateRegisterLma =3D=3D > EFI_SMM_SAVE_STATE_REGISTER_LMA_32BIT) { > > + CpuState->x86.SMBASE =3D (UINT32)CpuHotPlugData->SmBase[CpuIndex]; > > + } else { > > + CpuState->x64.SMBASE =3D (UINT32)CpuHotPlugData->SmBase[CpuIndex]; > > + } > > + // > > + // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > > + // Volume 3C, Section 35.2 MSRs in the Intel(R) Core(TM) 2 Processor > Family > > + // > > + // If Intel(R) Core(TM) Core(TM) 2 Processor Family MSRs are being use= d, > then > > + // make sure SMRR Enable(BIT3) of MSR_FEATURE_CONTROL MSR(0x3A) is > set before > > + // accessing SMRR base/mask MSRs. If Lock(BIT0) of > MSR_FEATURE_CONTROL MSR(0x3A) > > + // is set, then the MSR is locked and can not be modified. > > + // > > + if (mSmrrSupported && (mSmrrPhysBaseMsr =3D=3D > SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE)) { > > + FeatureControl =3D AsmReadMsr64 > (SMM_FEATURES_LIB_IA32_FEATURE_CONTROL); > > + if ((FeatureControl & BIT3) =3D=3D 0) { > > + if ((FeatureControl & BIT0) =3D=3D 0) { > > + AsmWriteMsr64 (SMM_FEATURES_LIB_IA32_FEATURE_CONTROL, > FeatureControl | BIT3); > > + } else { > > + mSmrrSupported =3D FALSE; > > + } > > + } > > + } > > + // > > + // If SMRR is supported, then program SMRR base/mask MSRs. > > + // The EFI_MSR_SMRR_PHYS_MASK_VALID bit is not set until the first > normal SMI. > > + // The code that initializes SMM environment is running in normal mode > > + // from SMRAM region. If SMRR is enabled here, then the SMRAM region > > + // is protected and the normal mode code execution will fail. > > + // > > + if (mSmrrSupported) { > > + // > > + // SMRR size cannot be less than 4-KBytes > > + // SMRR size must be of length 2^n > > + // SMRR base alignment cannot be less than SMRR length > > + // > > + if ((CpuHotPlugData->SmrrSize < SIZE_4KB) || > > + (CpuHotPlugData->SmrrSize !=3D GetPowerOfTwo32 (CpuHotPlugData- > >SmrrSize)) || > > + ((CpuHotPlugData->SmrrBase & ~(CpuHotPlugData->SmrrSize - 1)) != =3D > CpuHotPlugData->SmrrBase)) > > + { > > + // > > + // Print message and halt if CPU is Monarch > > + // > > + if (IsMonarch) { > > + DEBUG ((DEBUG_ERROR, "SMM Base/Size does not meet alignment/size > requirement!\n")); > > + CpuDeadLoop (); > > + } > > + } else { > > + AsmWriteMsr64 (mSmrrPhysBaseMsr, CpuHotPlugData->SmrrBase | > MTRR_CACHE_WRITE_BACK); > > + AsmWriteMsr64 (mSmrrPhysMaskMsr, (~(CpuHotPlugData->SmrrSize - > 1) & EFI_MSR_SMRR_MASK)); > > + mSmrrEnabled[CpuIndex] =3D FALSE; > > + } > > + } > > + > > + // > > + // Retrieve CPU Family and Model > > + // > > + AsmCpuid (CPUID_VERSION_INFO, &RegEax, NULL, NULL, &RegEdx); > > + FamilyId =3D (RegEax >> 8) & 0xf; > > + ModelId =3D (RegEax >> 4) & 0xf; > > + if ((FamilyId =3D=3D 0x06) || (FamilyId =3D=3D 0x0f)) { > > + ModelId =3D ModelId | ((RegEax >> 12) & 0xf0); > > + } > > + > > + // > > + // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > > + // Volume 3C, Section 35.10.1 MSRs in 4th Generation Intel(R) Core(TM) > > + // Processor Family. > > + // > > + // If CPU Family/Model is 06_3C, 06_45, or 06_46 then use 4th Generati= on > > + // Intel(R) Core(TM) Processor Family MSRs. > > + // > > + if (FamilyId =3D=3D 0x06) { > > + if ((ModelId =3D=3D 0x3C) || (ModelId =3D=3D 0x45) || (ModelId =3D= =3D 0x46) || > > + (ModelId =3D=3D 0x3D) || (ModelId =3D=3D 0x47) || (ModelId =3D= =3D 0x4E) || > (ModelId =3D=3D 0x4F) || > > + (ModelId =3D=3D 0x3F) || (ModelId =3D=3D 0x56) || (ModelId =3D= =3D 0x57) || > (ModelId =3D=3D 0x5C) || > > + (ModelId =3D=3D 0x8C)) > > + { > > + // > > + // Check to see if the CPU supports the SMM Code Access Check feat= ure > > + // Do not access this MSR unless the CPU supports the > SmmRegFeatureControl > > + // > > + if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MCA_CAP) & > SMM_CODE_ACCESS_CHK_BIT) !=3D 0) { > > + mSmmFeatureControlSupported =3D TRUE; > > + } > > + } > > + } > > + > > + // > > + // Call internal worker function that completes the CPU initializatio= n > > + // > > + FinishSmmCpuFeaturesInitializeProcessor (); > > +} > > + > > +/** > > + This function updates the SMRAM save state on the currently executing = CPU > > + to resume execution at a specific address after an RSM instruction. T= his > > + function must evaluate the SMRAM save state to determine the execution > mode > > + the RSM instruction resumes and update the resume execution address wi= th > > + either NewInstructionPointer32 or NewInstructionPoint. The auto HALT > restart > > + flag in the SMRAM save state must always be cleared. This function re= turns > > + the value of the instruction pointer from the SMRAM save state that wa= s > > + replaced. If this function returns 0, then the SMRAM save state was n= ot > > + modified. > > + > > + This function is called during the very first SMI on each CPU after > > + SmmCpuFeaturesInitializeProcessor() to set a flag in normal execution = mode > > + to signal that the SMBASE of each CPU has been updated before the defa= ult > > + SMBASE address is used for the first SMI to the next CPU. > > + > > + @param[in] CpuIndex The index of the CPU to hook. The= value > > + must be between 0 and the NumberOf= Cpus > > + field in the System Management Sys= tem Table > > + (SMST). > > + @param[in] CpuState Pointer to SMRAM Save State Map fo= r the > > + currently executing CPU. > > + @param[in] NewInstructionPointer32 Instruction pointer to use if > resuming to > > + 32-bit execution mode from 64-bit = SMM. > > + @param[in] NewInstructionPointer Instruction pointer to use if resu= ming > to > > + same execution mode as SMM. > > + > > + @retval 0 This function did modify the SMRAM save state. > > + @retval > 0 The original instruction pointer value from the SMRAM sav= e > state > > + before it was replaced. > > +**/ > > +UINT64 > > +EFIAPI > > +SmmCpuFeaturesHookReturnFromSmm ( > > + IN UINTN CpuIndex, > > + IN SMRAM_SAVE_STATE_MAP *CpuState, > > + IN UINT64 NewInstructionPointer32, > > + IN UINT64 NewInstructionPointer > > + ) > > +{ > > + return 0; > > +} > > + > > +/** > > + Hook point in normal execution mode that allows the one CPU that was > elected > > + as monarch during System Management Mode initialization to perform > additional > > + initialization actions immediately after all of the CPUs have processe= d their > > + first SMI and called SmmCpuFeaturesInitializeProcessor() relocating > SMBASE > > + into a buffer in SMRAM and called > SmmCpuFeaturesHookReturnFromSmm(). > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesSmmRelocationComplete ( > > + VOID > > + ) > > +{ > > +} > > + > > +/** > > + Determines if MTRR registers must be configured to set SMRAM cache- > ability > > + when executing in System Management Mode. > > + > > + @retval TRUE MTRR registers must be configured to set SMRAM cache- > ability. > > + @retval FALSE MTRR registers do not need to be configured to set SMRA= M > > + cache-ability. > > +**/ > > +BOOLEAN > > +EFIAPI > > +SmmCpuFeaturesNeedConfigureMtrrs ( > > + VOID > > + ) > > +{ > > + return mNeedConfigureMtrrs; > > +} > > + > > +/** > > + Disable SMRR register if SMRR is supported and > SmmCpuFeaturesNeedConfigureMtrrs() > > + returns TRUE. > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesDisableSmrr ( > > + VOID > > + ) > > +{ > > + if (mSmrrSupported && mNeedConfigureMtrrs) { > > + AsmWriteMsr64 (mSmrrPhysMaskMsr, AsmReadMsr64 > (mSmrrPhysMaskMsr) & ~EFI_MSR_SMRR_PHYS_MASK_VALID); > > + } > > +} > > + > > +/** > > + Enable SMRR register if SMRR is supported and > SmmCpuFeaturesNeedConfigureMtrrs() > > + returns TRUE. > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesReenableSmrr ( > > + VOID > > + ) > > +{ > > + if (mSmrrSupported && mNeedConfigureMtrrs) { > > + AsmWriteMsr64 (mSmrrPhysMaskMsr, AsmReadMsr64 > (mSmrrPhysMaskMsr) | EFI_MSR_SMRR_PHYS_MASK_VALID); > > + } > > +} > > + > > +/** > > + Processor specific hook point each time a CPU enters System Management > Mode. > > + > > + @param[in] CpuIndex The index of the CPU that has entered SMM. The > value > > + must be between 0 and the NumberOfCpus field in t= he > > + System Management System Table (SMST). > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesRendezvousEntry ( > > + IN UINTN CpuIndex > > + ) > > +{ > > + // > > + // If SMRR is supported and this is the first normal SMI, then enable = SMRR > > + // > > + if (mSmrrSupported && !mSmrrEnabled[CpuIndex]) { > > + AsmWriteMsr64 (mSmrrPhysMaskMsr, AsmReadMsr64 > (mSmrrPhysMaskMsr) | EFI_MSR_SMRR_PHYS_MASK_VALID); > > + mSmrrEnabled[CpuIndex] =3D TRUE; > > + } > > +} > > + > > +/** > > + Processor specific hook point each time a CPU exits System Management > Mode. > > + > > + @param[in] CpuIndex The index of the CPU that is exiting SMM. The va= lue > must > > + be between 0 and the NumberOfCpus field in the Sy= stem > > + Management System Table (SMST). > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesRendezvousExit ( > > + IN UINTN CpuIndex > > + ) > > +{ > > +} > > + > > +/** > > + Check to see if an SMM register is supported by a specified CPU. > > + > > + @param[in] CpuIndex The index of the CPU to check for SMM register > support. > > + The value must be between 0 and the NumberOfCpus = field > > + in the System Management System Table (SMST). > > + @param[in] RegName Identifies the SMM register to check for support. > > + > > + @retval TRUE The SMM register specified by RegName is supported by t= he > CPU > > + specified by CpuIndex. > > + @retval FALSE The SMM register specified by RegName is not supported = by > the > > + CPU specified by CpuIndex. > > +**/ > > +BOOLEAN > > +EFIAPI > > +SmmCpuFeaturesIsSmmRegisterSupported ( > > + IN UINTN CpuIndex, > > + IN SMM_REG_NAME RegName > > + ) > > +{ > > + if (mSmmFeatureControlSupported && (RegName =3D=3D > SmmRegFeatureControl)) { > > + return TRUE; > > + } > > + > > + return FALSE; > > +} > > + > > +/** > > + Returns the current value of the SMM register for the specified CPU. > > + If the SMM register is not supported, then 0 is returned. > > + > > + @param[in] CpuIndex The index of the CPU to read the SMM register. T= he > > + value must be between 0 and the NumberOfCpus fiel= d in > > + the System Management System Table (SMST). > > + @param[in] RegName Identifies the SMM register to read. > > + > > + @return The value of the SMM register specified by RegName from the C= PU > > + specified by CpuIndex. > > +**/ > > +UINT64 > > +EFIAPI > > +SmmCpuFeaturesGetSmmRegister ( > > + IN UINTN CpuIndex, > > + IN SMM_REG_NAME RegName > > + ) > > +{ > > + if (mSmmFeatureControlSupported && (RegName =3D=3D > SmmRegFeatureControl)) { > > + return AsmReadMsr64 (SMM_FEATURES_LIB_SMM_FEATURE_CONTROL); > > + } > > + > > + return 0; > > +} > > + > > +/** > > + Sets the value of an SMM register on a specified CPU. > > + If the SMM register is not supported, then no action is performed. > > + > > + @param[in] CpuIndex The index of the CPU to write the SMM register. = The > > + value must be between 0 and the NumberOfCpus fiel= d in > > + the System Management System Table (SMST). > > + @param[in] RegName Identifies the SMM register to write. > > + registers are read-only. > > + @param[in] Value The value to write to the SMM register. > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesSetSmmRegister ( > > + IN UINTN CpuIndex, > > + IN SMM_REG_NAME RegName, > > + IN UINT64 Value > > + ) > > +{ > > + if (mSmmFeatureControlSupported && (RegName =3D=3D > SmmRegFeatureControl)) { > > + AsmWriteMsr64 (SMM_FEATURES_LIB_SMM_FEATURE_CONTROL, Value); > > + } > > +} > > + > > +/** > > + Read an SMM Save State register on the target processor. If this func= tion > > + returns EFI_UNSUPPORTED, then the caller is responsible for reading th= e > > + SMM Save Sate register. > > + > > + @param[in] CpuIndex The index of the CPU to read the SMM Save State. > The > > + value must be between 0 and the NumberOfCpus fie= ld in > > + the System Management System Table (SMST). > > + @param[in] Register The SMM Save State register to read. > > + @param[in] Width The number of bytes to read from the CPU save st= ate. > > + @param[out] Buffer Upon return, this holds the CPU register value r= ead > > + from the save state. > > + > > + @retval EFI_SUCCESS The register was read from Save State. > > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > > + @retval EFI_UNSUPPORTED This function does not support reading > Register. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +SmmCpuFeaturesReadSaveStateRegister ( > > + IN UINTN CpuIndex, > > + IN EFI_SMM_SAVE_STATE_REGISTER Register, > > + IN UINTN Width, > > + OUT VOID *Buffer > > + ) > > +{ > > + return EFI_UNSUPPORTED; > > +} > > + > > +/** > > + Writes an SMM Save State register on the target processor. If this fu= nction > > + returns EFI_UNSUPPORTED, then the caller is responsible for writing th= e > > + SMM Save Sate register. > > + > > + @param[in] CpuIndex The index of the CPU to write the SMM Save State. > The > > + value must be between 0 and the NumberOfCpus fiel= d in > > + the System Management System Table (SMST). > > + @param[in] Register The SMM Save State register to write. > > + @param[in] Width The number of bytes to write to the CPU save stat= e. > > + @param[in] Buffer Upon entry, this holds the new CPU register value= . > > + > > + @retval EFI_SUCCESS The register was written to Save State. > > + @retval EFI_INVALID_PARAMETER Buffer is NULL. > > + @retval EFI_UNSUPPORTED This function does not support writing > Register. > > +**/ > > +EFI_STATUS > > +EFIAPI > > +SmmCpuFeaturesWriteSaveStateRegister ( > > + IN UINTN CpuIndex, > > + IN EFI_SMM_SAVE_STATE_REGISTER Register, > > + IN UINTN Width, > > + IN CONST VOID *Buffer > > + ) > > +{ > > + return EFI_UNSUPPORTED; > > +} > > + > > +/** > > + This function is hook point called after the > gEfiSmmReadyToLockProtocolGuid > > + notification is completely processed. > > +**/ > > +VOID > > +EFIAPI > > +SmmCpuFeaturesCompleteSmmReadyToLock ( > > + VOID > > + ) > > +{ > > +} > > + > > +/** > > + This API provides a method for a CPU to allocate a specific region for= storing > page tables. > > + > > + This API can be called more once to allocate memory for page tables. > > + > > + Allocates the number of 4KB pages of type EfiRuntimeServicesData and > returns a pointer to the > > + allocated buffer. The buffer returned is aligned on a 4KB boundary. = If Pages > is 0, then NULL > > + is returned. If there is not enough memory remaining to satisfy the r= equest, > then NULL is > > + returned. > > + > > + This function can also return NULL if there is no preference on where = the > page tables are allocated in SMRAM. > > + > > + @param Pages The number of 4 KB pages to allocate. > > + > > + @return A pointer to the allocated buffer for page tables. > > + @retval NULL Fail to allocate a specific region for storing page = tables, > > + Or there is no preference on where the page tables a= re allocated in > SMRAM. > > + > > +**/ > > +VOID * > > +EFIAPI > > +SmmCpuFeaturesAllocatePageTableMemory ( > > + IN UINTN Pages > > + ) > > +{ > > + return NULL; > > +} > > -- > > 2.31.1 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114177): https://edk2.groups.io/g/devel/message/114177 Mute This Topic: https://groups.io/mt/103831197/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-