From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2D8F29413DB for ; Wed, 27 Mar 2024 07:44:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=R78khrO9y+PCmHINZWD0TLEw/a1vEJOXNJrAAu5/rsk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711525438; v=1; b=N3hqBpsBA4I48OIl2ZDnFvJQI7YI2LkcP/+S8Bc4OgbVFpTgfOHabJI8hniCFVTS/Qja8iDP H8xLzimYIzzcGg/rf4ppAhSXvsPisAuZXx+DkY5ab21YDVbOVerLvryS3Vnf47o92U5WrLS+FCy eVCr6EVLtB/RqJd51S9oyLAz6xskJ+VZ1m6WVfFZWVLVvrzJCAgx1gurDjR2WcPrFvTKa2qlpQW DoE/UPbwjjkBFSIHAKoihKglAxWQ1knVFSHMjPJ6MMg8rl6dTuAL32kATIZCcw412DLfnTRHo9J 4xcOt8S3KslaxK4UlKX0ZJpaMwF2KzABdTxCnpxS2DYng== X-Received: by 127.0.0.2 with SMTP id liFCYY7687511xiDZ2m64u42; Wed, 27 Mar 2024 00:43:58 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.32111.1711525437971474644 for ; Wed, 27 Mar 2024 00:43:58 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by MN2PR12MB4093.namprd12.prod.outlook.com (2603:10b6:208:198::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Wed, 27 Mar 2024 07:43:55 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0%5]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 07:43:55 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes Thread-Topic: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes Thread-Index: AQHaf5B2FPD4iHNDlkWUOfJWdy+6frFLNN9wgAAA1yA= Date: Wed, 27 Mar 2024 07:43:55 +0000 Message-ID: References: <20240326151503.106-1-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=481ab103-a123-4cfb-9a30-8ccb087431c6;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-27T07:43:12Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|MN2PR12MB4093:EE_ x-ms-office365-filtering-correlation-id: 666391ed-c00f-410f-faeb-08dc4e31a7b8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1WS3nnYb17C40ArUWKUvdkPKj/agG791E6DFNagvag4HqDi7AeQmE3+6DbmbjgujBl/85JRmcRDMh0mlkfCl8bpXDKo5embY0ygzX403qhLX7yp6hesCfuzWfsGe2h6HHiG8ARchWcAVkP2JVFx1vRuifHWIwnFhDWM3CzXlGMonI6uUiYEyy3GQ+174NGuNKdlygdBMqfgaoxmPVLdMCVvGSxzvSMljK4x8ndx147NOSBMtJR7pciqoI1Ld6jURVWX7bSRlw0EJ/sUIxHXfU6gTKflad/Nt3tgox59PSkIM1QZmRKB5iYl6+PSyf7puhRJtIBcdImShZAp9W13tOmwrICLAuhDveC6+GeR/mrMM/IU6RBrz/A0snsxo5Ssq1Xfm6XgbenNTiKCoujXAGE37p4XqY0gauuJSouyqjvG6ldV9frI6XYiqVPipIxg2sWuEoUBVktx2f3MBmB2H7YuIokTVD1P9/Hl1qorjXzZWAXJ27kpqPsu0iYR3P42ZpRwXvQsMWVS4HWAz1H/chzLDq3dRl5ucM8SwGg8DP3Os8obtg1Z0H60qQqKutbEQJ7OkLIYG0RlwWQnEvVDvZW++vH2ZAjnwPmpmT7OY2gqoejclogFSWJw5NBgYJfAO+qWiJpC3fnqHbR6YLQQQsvlVrW54QQs3jHjWYvKrcn2rua6zTZx86DNSnNhni0YLdibnYSlgd2NBX0zI9VlKtpg80Bp1bdE4T0AbxBoGpXU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QwPAXZAH+wElGndTVzzU2rkuhK2C8YwDV/ndVxrvBGgev+c9s/Y9Qw1D+xGK?= =?us-ascii?Q?gMbjSAIU0IWN+/ryy0XuQbFbnewOx4QTMh5VcdkOIgftbPyOWAPcXTL+oxSV?= =?us-ascii?Q?uuWF3Zd+1iv/mkKIa1lucs+TXCDeIeYEgFuu0zmFuiIjmKBKcp6BNZpT4zWU?= =?us-ascii?Q?+vySXE8eQiKyzDSSB5RCqIWJ0YHhE2BYlScvwCH5eAsCn9ajJF2gzGmuHExg?= =?us-ascii?Q?eiIRoqskQAZOD1V2gviicZ1ofQ6rgkvQNRkCvSnnYoSUcOs7p77ciaYPSWlX?= =?us-ascii?Q?XtjqU4ur2wFQtr0IGE8/q+LwcHwO3klGHJEF60fYoG/JQr5ArWeSvVrTljAs?= =?us-ascii?Q?piT5BxDFrHi1XK08V/PnWnVBcKklQH5RB16QckBfnz0CLDkVqRLL3+cMyWbn?= =?us-ascii?Q?8lWquh2nL0z2elVbkNbVe1aK9BjUpb+i+eVGyBHERP+PW8ZC0UIUv8aWM1Ze?= =?us-ascii?Q?8BLZQlUcmxENfdHiCPNv7AKQ/XWfC7V7Osx5r1CB/LzomFuJjWagcyCJ0KtY?= =?us-ascii?Q?3tGVytWUPxFXhO5VmoQh+G2n4QsNUDuN1RVuye7oZB5MOyfNBVmBBIRLRxuY?= =?us-ascii?Q?RPIRQtilPym0DAKArlANOPAm4Y2GwuZfqfMio64FB0ywsHwlCOUcskHWwvrV?= =?us-ascii?Q?S9m8gPixFRTZ1/ziCLQ8gcbZEdBCjit6tH1K8U5aR2eqUth2cGttJuS4b/Nl?= =?us-ascii?Q?dvpOhq9RRaT5Kn1xaTM/x41+Z997zuebLYjwmAY8whJtDBQilHLNs6XmpLRK?= =?us-ascii?Q?lLy4eVz4S7Tm443hb127dp/SaCHSIjeqD+AHLCLOsViWeIfhAZJD8cWNVjW7?= =?us-ascii?Q?gwVuCZDJWBNy8HEdE4oBUOabXFJuWAM4H/A8payavB5ot2Vt6MTmf6bqGCcu?= =?us-ascii?Q?3/LhxdBLQmy37IyLUbaXphvE/t84hgkJWHZss+rTgQItOGbtwKKBNPu98Ol/?= =?us-ascii?Q?KvKSbxOSNaZWU047aI4UtwSxTTdrhXMBA+QqK/N0CoZxVUo44Rlp/N5YCI0p?= =?us-ascii?Q?A1TJ9hD8UfFyw29ozD8g4hAukFKN55e5pVtKaJMV4Xi26DACaFQbfJfzSX9h?= =?us-ascii?Q?RSL1LHKfKGHzcuRdEefGs//KchnOsZk9NF8tC6qHt1Da0e3NE8XMfk4SOB0I?= =?us-ascii?Q?IMOIjTt/4oxKxh/LxlqAYyqkA8VS2i+UbAcRGj+gKaQqyvP49OjTwfAFUj6D?= =?us-ascii?Q?1Wx/R30+NBJtI6vsznIXchU7+/OeJd2ibrMlzUPVuLAGeOzXS51S6ahuCdZN?= =?us-ascii?Q?lgGA9q/UuAloXF9AN7h9oWXkJ3zz2PN4Oe2NKbyALQ9Y+sh6DAdhRu/1NyF2?= =?us-ascii?Q?uGuXFcYEQqSMv2DPyg0vDDcQppHqMEZE+uTD7Qqk+zuKu7b6VSgmNSoj4EOc?= =?us-ascii?Q?5ZO2vWeHuqr9+gSd33GCSyVT5h2uTyXteKAogVuVfU/zukv6jS+zU7aFVPd1?= =?us-ascii?Q?v7wG3srO2pUPcD3LxO9lHwqgJxq9YYL4Ep20EF+CX0mapa9SfJGnzyAHcZcz?= =?us-ascii?Q?lP1Vc57Y9WXUzZCClcCymNdqGwDpuSaL4e0AVVErKRrK9h2Ox7SO3AhRoNZm?= =?us-ascii?Q?uREoGdihR0C0lqdCQHI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 666391ed-c00f-410f-faeb-08dc4e31a7b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 07:43:55.3705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UouuxltJlVWmqQ1s4IUNM4nPd4Hvg58IqZVuUWq93ANPTsd697QhAxb+JMPm4sjH+VDnr5heFWkVFR9hW4HlCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4093 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 27 Mar 2024 00:43:58 -0700 Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DN8SHu3TiW59JoBdr1LKJqOAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=N3hqBpsB; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Igor, If time is allowed, please also review this patch set. Thanks Abner > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, March 27, 2024 3:42 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: RE: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching > algorithm enhancement and the bug fixes > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > I have tested this patch series on my system and got a lot of performance > improvements too. > > Great work, Abner! > > Regards, > Nickle > > > -----Original Message----- > > From: abner.chang@amd.com > > Sent: Tuesday, March 26, 2024 11:15 PM > > To: devel@edk2.groups.io > > Cc: Nickle Wang ; Igor Kulchytskyy > > Subject: [PATCH V2 0/6] [PATCH V2 0/5] Config language searching > algorithm > > enhancement and the bug fixes > > > > External email: Use caution opening links or attachments > > > > > > From: Abner Chang > > > > PR # 5491 > > > > In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path > > implementation based on the performance improvement. > > > > In this patch set, > > 1 We enhance the config language searching algorithm. > > As the performance of searching config language using HII GetString i= s > > pretty slow. For the example, 1800 HII BIOS options takes over 30 min= s > > to build up the metadata required for Redfish BIOS resource. With thi= s > > improvement, it only takes 4 seconds. > > > > 2.Introduce the Redfish debug framework, there are three edk2 Redfish > > debug scopes. > > a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug > message > > for edk2 Redfish. > > b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish > > component. Currently we only support RedfishPlatformConfigDxe > > module. > > c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug > > scope. This PCD is used by RedfishPlatformConfigDxe debug enableme= nt. > > > > 3 This patch set also fixes an issue that deletes HII string unexpected= ly. > > > > Signed-off-by: Abner Chang > > Co-authored-by: Nickle Wang > > Cc: Igor Kulchytskyy > > > > Abner Chang (4): > > RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro > > RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support > > RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted > > unexpectedly > > EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs > > > > Nickle Wang (1): > > RedfishPkg/RedfishPlatformConfigDxe: support menu path report > > > > abnchang (1): > > RedfishPkg/RedfishPlatformConfigDxe: Config language searching > > optimization > > > > RedfishPkg/RedfishPkg.dec | 24 + > > EmulatorPkg/EmulatorPkg.dsc | 21 + > > .../RedfishDebugLib/RedfishDebugLib.inf | 4 + > > .../RedfishPlatformConfigDxe.inf | 8 + > > RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +- > > .../RedfishPlatformConfigDxe.h | 48 +- > > .../RedfishPlatformConfigImpl.h | 135 ++- > > .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +- > > .../RedfishPlatformConfigCapability.c | 58 ++ > > .../RedfishPlatformConfigDxe.c | 89 +- > > .../RedfishPlatformConfigImpl.c | 928 ++++++++++++++++-- > > 11 files changed, 1240 insertions(+), 173 deletions(-) create mode 10= 0644 > > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigCapability.c > > > > -- > > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117158): https://edk2.groups.io/g/devel/message/117158 Mute This Topic: https://groups.io/mt/105159781/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-