From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C58D074003D for ; Wed, 6 Mar 2024 05:51:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w2XoWveh1NXWGjB2i8q845jtN1OhZOT1euzG5X+jAwM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709704260; v=1; b=uCkjP+g8zBiyEptd1Iydixihorx+kAm2cM2QbQENusjNH/YuiHyOXvc1vzbfpiSgaAfcsuOL 3NOEU5+MIgXzTrjjXF81tmN2rmKwlKZrulwY/KoXG9wdSMb1KAwcsIDCqwIkO3w1soPEqSFo0j4 hz8aE9YCF5qBx/CRwMViu+MTiGKBUDEFcnxlIHJWbA5nAlNpNzZl5jhuxu65gKw290laeAmm/F3 BGan3ES3cxIEXtylWo7Kh+HeI8UCsVAjyf3uXQnakpPQnVtSTBQs0dNgm2tK0AHJfbJC4LM11m3 D8R7MSMeZ1LK9ilfN6qlkvspzF0j4IVzSaIlAOJ66zXug== X-Received: by 127.0.0.2 with SMTP id CGqdYY7687511xAgOviAcrqD; Tue, 05 Mar 2024 21:51:00 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.71]) by mx.groups.io with SMTP id smtpd.web10.6071.1709704259411604063 for ; Tue, 05 Mar 2024 21:50:59 -0800 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SA1PR12MB6896.namprd12.prod.outlook.com (2603:10b6:806:24f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Wed, 6 Mar 2024 05:50:56 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::e006:4173:de2c:aca0%5]) with mapi id 15.20.7339.035; Wed, 6 Mar 2024 05:50:55 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol Thread-Topic: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: support config2 protocol Thread-Index: AQHabjewryCfRvJI70WaM2xm1OrNnLEqN6mg Date: Tue, 05 Mar 2024 21:50:59 -0800 Message-ID: References: <20240304132658.41244-1-nicklew@nvidia.com> In-Reply-To: <20240304132658.41244-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f3e957b4-7f74-4703-9afb-c46e67dc008f;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-03-06T05:49:26Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SA1PR12MB6896:EE_ x-ms-office365-filtering-correlation-id: bbbf1bc7-4471-4d17-3676-08dc3da16431 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6Wn3Y7Y2xhb3EzY4uAf28OTzjjRIkDwW5n+wA8jG7IwBAlOFwo9YYX2gIzGNAOR8+tv6qgFVoJQrcmax1ry0JZwtFkYv6KbKwgubWowYF6EJWFNCHtNj8H7px5E2uRkWZCEtd6TgVpQjaoQXE8iqYxkQxe+2a7vIbub+Yt8JcKYiCVT7djBH5JugPHg/fOtVCNrvxcQDqhUfCVC+lNJPG2rKRYn9SO/DRh1kQIC1k329BsY9yiT8C8vTLYqvCurIR/mz8Dp7xUvTEYbdm9AfeqYZRqNDo09qIBCZf2XeuaXAiBW/oi1LnPh2fflnhnEgi940J5HsH+f1y3uVe3G7txiO8U8iMIEd1+Owt6MIyKMdiv/CpdlVPuoodvr49zaLJrxhbWFd460t38vdlAaoardBb8RDreHAa6An2W0yn7oTfa+7hgLADNloAGZPhm/YrYH7p+kX5dCdepkcsiBErkJm81ezJwOV+chm10+K5tBKWd7n96Fer6GM/qLVb0VmQT1rNzApoI7b2llp+JwjytlPWvhOpI+5b5k/s7pQ9AK1s7ocQtFxG3d9TAP/AOSXOazwBxdd4B20L3FsOpbUX0sCMhwYP19lQD4g4KqlOxPQiYx6neJrwjbIBjbSf6OQnMSq9MSG3J6I6B0qxFyrjQLkXWZT9olbbUjg9TLporA1yeTHXQT+0T9fFgP1tRmiVXI0ZwzylxZsuaBGoBE+rpaKlqA+41NgePEaIz2WfOk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QtpqyYIYRWuT+7XydMTjzIFTEObfYEiUHCQdUhnCEntZ03dU2dqzX4t0mJ3j?= =?us-ascii?Q?T36dS14pHiqllOiS5I8dN0vFOGA9ftcKmmwCtMyWRx853UmcWr+FINqFwwD3?= =?us-ascii?Q?YPq7LWoKeXaqADK6Hf5nLIlTMR8Djq3CC8SRAQHr1UkbD6mtOa7aMfaQ5k/J?= =?us-ascii?Q?Cq80w6IKcxhQUsYwP37zLXiIPpA9Gx731mfvcxkvj6PU+7OUL0E+alO5dKBe?= =?us-ascii?Q?OwL+1yg/uHVluZXzJXmPb7VlMeBMa00KOSBv8smVNYdT5173Vjztu1DDXq+k?= =?us-ascii?Q?RCAgfT8+OPUs7CIWeg07QvN3vJqL/QZ2JkGtX9vBnYBUjyXgmSa80Ie29aPr?= =?us-ascii?Q?mA5orYCheZdSytnJtuX3meMNyLFDQJ3gpGxN30UrtA2HDF+9mcqRMmgEh/5Y?= =?us-ascii?Q?/uKL0vDx3P3vSvt0nls5KMwTQTSDRSzFegCJJfpW6tSzJC/z7JnCL46cbMYR?= =?us-ascii?Q?RDssZ/ge6p8vjJah13gYCzgReSU58mumnGfgJ5Q7h/5ACeT51XhSwdodDjY9?= =?us-ascii?Q?rQRR2tWdBcrPEaSGjwjTWcScL8dwfu7kWf3w+vvJE54oH6m8vtRQ4dF632vf?= =?us-ascii?Q?C1W3V5S1FYs2W05E3ltojz4tmBWCIEGQPcFyxpACMk4sIItBjOVk8rdRW7CX?= =?us-ascii?Q?uloAz2AD8UNRij8zq8K8Mf5w0kv2Oz4D1ER+LFdObVuE+RvP/pYoLV/r5elg?= =?us-ascii?Q?ux2F4rUkWUW32XTElwo7UK+H0rW+92HncXnudPUQiLEyREZW8oOkzWJpM6Nc?= =?us-ascii?Q?PMu1MGzW/dTyExOR8t3Tpltu5M6wAzWeDwbEiGTB/KdvqhQLADXm0Ugxf4Bj?= =?us-ascii?Q?0t+xWVDYnxTltLT7/398u59VvdQfEa28O0GSvgxx/XWlbR11uD95QqH2wunX?= =?us-ascii?Q?SxlGk3PIPn5VAXKHSzypTrm6yVLBy99cPCyBYi/CnxBSPDSC2ZkvFQmvfAlQ?= =?us-ascii?Q?FN5QTYDc1tbYnbJN9ZN9HKO+4H5ilR17v7/n8C/PiKYqROr3JKIrGkGEXbRq?= =?us-ascii?Q?4tHk2x21QeZgXoRoyYkRJq1+JLDavaZ94tTHNJ/7OsXHTxJKw90Z7hVNiQAP?= =?us-ascii?Q?BotSKIaULlpFX+Dxb2+gPNSGJm4lXxl4ovsM0eIy981Zex/DF51p136zk1RA?= =?us-ascii?Q?uks18l650bx+KokBioQhxvQbo+9JbCm8whP2RHR6pM839vMcr/4vKGk0fO1F?= =?us-ascii?Q?GdteoeVEqUYqjPZBncQj5JNydFce+PZkd95U7kei5Uz1hv7xX3MKBMA3PMII?= =?us-ascii?Q?LgWDSgScTx9lCQXRhoslNBxK+vTcwbIPF2KxfFwmGyXWfkPtJ7KO2WeLO93o?= =?us-ascii?Q?TeVjVSGUGoL6DxgyY6C4rdIWkhZv0VcHVCZFrfLSf/pKZ5vbEABx+Br6+jXM?= =?us-ascii?Q?hNBtrUAUPwYc6KQuxhChvyZO7FAvMrvoXx++P6Wh30jLOf9UAVvr3N6JKChL?= =?us-ascii?Q?hlb1+2RzlSEuC3dpt3EEhVq3Cd+1E5xwqXUS7J5Lb1Sqx0FsxaUyYpuwU+ld?= =?us-ascii?Q?sVJhCz3AmbhE6FLAE5I4Mq3q0Jdjvoyt7SBphzoPNcgMhzfnREHf+gJWfuCO?= =?us-ascii?Q?qRPhSejk/PGdiWvqIz2OuL5opwWv6eRsmLYe5CKu?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbbf1bc7-4471-4d17-3676-08dc3da16431 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 05:50:55.9704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YKsmX70NzNywFgiQOKlk6Ah+c4XU5U91ulsHYRbxUhaPRNuFjbMXbTLMlc49pMoXhi7oTNNM3M2PA3hx/gBuHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6896 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Aj0oKGDLFQir7Qxo7jmcR8Iwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=uCkjP+g8; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Nickle, I think we have to merge this patch with 2/3. Otherwise, the bui= ld will be failed on the commit of 2/3, right? Thanks Abner > -----Original Message----- > From: Nickle Wang > Sent: Monday, March 4, 2024 9:27 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/Features: supp= ort > config2 protocol > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Because EdkIIRedfishResourceConfigLib is updated to support > Redfish resource config2 protocol, update corresponding > functions in feature drivers. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 14 +++++++------- > .../BootOptionCollectionDxe.c | 14 +++++++------- > .../ComputerSystemCollectionDxe.c | 16 ++++++++-------- > .../MemoryCollectionDxe/MemoryCollectionDxe.c | 16 ++++++++-------- > 4 files changed, 30 insertions(+), 30 deletions(-) > > diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > index 1f3c30147..1eb269a84 100644 > --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c > @@ -782,7 +782,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > __func__, Uri)); > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, &SchemaInfo); > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > return Status; > @@ -795,7 +795,7 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); > ConfigLang =3D RedfishGetConfigLanguage (Uri); > if (ConfigLang =3D=3D NULL) { > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, NUL= L, > Private->InformationExchange); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n"= , > __func__, Uri)); > @@ -811,17 +811,17 @@ HandleResource ( > } > > // > - // Check and see if target property exist or not even when collection > memeber exists. > + // Check and see if target property exist or not even when collection > member exists. > // If not, we sill do provision. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > // > // The target property does not exist, do the provision to create pr= operty. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)= ); > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, > Private->InformationExchange, FALSE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri,= NULL, > Private->InformationExchange, FALSE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n"= , > __func__, Status)); > } > @@ -833,7 +833,7 @@ HandleResource ( > // Consume first. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -842,7 +842,7 @@ HandleResource ( > // Patch. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > } > diff --git > a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe > .c > b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe > .c > index 4f94a4495..cd1437f54 100644 > --- > a/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe > .c > +++ > b/RedfishClientPkg/Features/BootOptionCollection/BootOptionCollectionDxe > .c > @@ -44,7 +44,7 @@ HandleResource ( > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > process resource for: %s\n", __func__, Uri)); > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, &SchemaInfo); > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > return Status; > @@ -58,7 +58,7 @@ HandleResource ( > SystemRestDetected =3D FALSE; > ConfigLang =3D RedfishGetConfigLanguage (Uri); > if (ConfigLang =3D=3D NULL) { > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, NUL= L, > Private->InformationExchange); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > \"%s\" is not handled by us\n", __func__, Uri)); > @@ -88,7 +88,7 @@ HandleResource ( > // If not, we sill do provision. > // > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a Check > for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > \"%s\" is not handled by us\n", __func__, Uri)); > @@ -99,7 +99,7 @@ HandleResource ( > // The target property does not exist, do the provision to create pr= operty. > // > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > provision for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, > Private->InformationExchange, FALSE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri,= NULL, > Private->InformationExchange, FALSE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to provision with GET mode: %r\n"= , > __func__, Status)); > } > @@ -114,7 +114,7 @@ HandleResource ( > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > system has been reset to default setting. ignore pending settings because= they > may be stale values\n", __func__)); > } else { > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a > consume for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, NULL= ); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: %r\n= ", > __func__, Uri, Status)); > } > @@ -124,7 +124,7 @@ HandleResource ( > // Patch. > // > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a update > for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -262,7 +262,7 @@ CreateCollectionResource ( > > DEBUG ((REDFISH_BOOT_OPTION_COLLECTION_DEBUG_TRACE, "%a: > supported schema: %a %a.%a.%a\n", __func__, SchemaInfo.Schema, > SchemaInfo.Major, SchemaInfo.Minor, SchemaInfo.Errata)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > BootOptionUri, Private->InformationExchange, TRUE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, > BootOptionUri, NULL, Private->InformationExchange, TRUE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: %r\n", > __func__, BootOptionUri, Status)); > } > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > index 975ba0564..55a6d07db 100644 > --- > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > @@ -35,7 +35,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a: process resource for: %s\n", > __func__, Uri)); > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, &SchemaInfo); > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > return Status; > @@ -48,7 +48,7 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); > ConfigLang =3D RedfishGetConfigLanguage (Uri); > if (ConfigLang =3D=3D NULL) { > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, NUL= L, > Private->InformationExchange); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" is not handled by us\n"= , > __func__, Uri)); > @@ -90,11 +90,11 @@ HandleResource ( > } > > // > - // Check and see if target property exist or not even when collection > memeber exists. > + // Check and see if target property exist or not even when collection > member exists. > // If not, we sill do provision. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"%s\" is not handled by us\n", > __func__, Uri)); > @@ -105,7 +105,7 @@ HandleResource ( > // The target property does not exist, do the provision to create pr= operty. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)= ); > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, > Private->InformationExchange, FALSE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri,= NULL, > Private->InformationExchange, FALSE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to provision with PATCH mode: %r\= n", > __func__, Status)); > } > @@ -117,7 +117,7 @@ HandleResource ( > // Consume first. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -126,7 +126,7 @@ HandleResource ( > // Patch. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -236,7 +236,7 @@ CreateCollectionResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a: supported schema: %a > %a.%a.%a\n", __func__, SchemaInfo.Schema, SchemaInfo.Major, > SchemaInfo.Minor, SchemaInfo.Errata)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Privat= e- > >CollectionUri, Private->InformationExchange, TRUE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Privat= e- > >CollectionUri, NULL, Private->InformationExchange, TRUE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: %r\n", > __func__, Private->CollectionUri, Status)); > } > diff --git > a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > index 1b7d74e86..d963fb52a 100644 > --- > a/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > +++ > b/RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.c > @@ -35,7 +35,7 @@ HandleResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > __func__, Uri)); > > - Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, &SchemaInfo); > + Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, NULL, &SchemaInfo); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > return Status; > @@ -48,7 +48,7 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); > ConfigLang =3D RedfishGetConfigLanguage (Uri); > if (ConfigLang =3D=3D NULL) { > - Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > + Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, NUL= L, > Private->InformationExchange); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n"= , > __func__, Uri)); > @@ -86,17 +86,17 @@ HandleResource ( > } > > // > - // Check and see if target property exist or not even when collection > memeber exists. > + // Check and see if target property exist or not even when collection > member exists. > // If not, we sill do provision. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > // > // The target property does not exist, do the provision to create pr= operty. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)= ); > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri, > Private->InformationExchange, FALSE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Uri,= NULL, > Private->InformationExchange, FALSE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n"= , > __func__, Status)); > } > @@ -108,7 +108,7 @@ HandleResource ( > // Consume first. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -117,7 +117,7 @@ HandleResource ( > // Patch. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > - Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > + Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri, NULL); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > } > @@ -227,7 +227,7 @@ CreateCollectionResource ( > > DEBUG ((REDFISH_DEBUG_TRACE, "%a, supported schema: %a > %a.%a.%a\n", __func__, SchemaInfo.Schema, SchemaInfo.Major, > SchemaInfo.Minor, SchemaInfo.Errata)); > > - Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Privat= e- > >CollectionUri, Private->InformationExchange, TRUE); > + Status =3D EdkIIRedfishResourceConfigProvisioning (&SchemaInfo, Privat= e- > >CollectionUri, NULL, Private->InformationExchange, TRUE); > if (EFI_ERROR (Status)) { > DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: %r\n", > __func__, Private->CollectionUri, Status)); > } > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116419): https://edk2.groups.io/g/devel/message/116419 Mute This Topic: https://groups.io/mt/104721516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-