From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F85F740048 for ; Wed, 29 May 2024 14:48:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oAxtoc8F1yWXiVzDtsnfkBM+JhbnN7bXmotIUn0+fAU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1716994098; v=1; b=wjD9VKKdF8VSY1ELGlsnUQDsuwypHuHJYvatvxw3qY2+2x+uvbYfG5aC5HeFbE2l2kPPjAQn mxxnBBEs5Vj4CemN9O1E2d8XNd3P0KZe6C5eVtxxTunYCq0aDklARtFXOmk7wR+L/dNUn/3Hqzv lk7rsrD7VUpuXCp6gY2VKflxZMgUAecUR3vGuUaFvtQa+mXqV4GV7X/9tQKoDMQBmm89rgY3dUd q0kLOsE4dE5sWWD1bnT2Z4EHcTZUmGin+DuRJvT7S9tHHDp4jnz2ijM0rWzwfcdXZfRXbh6stZ+ o8Q+HtnFwphTyRl5+BiJ/FVsojwet1325LXoV1XbRvvzw== X-Received: by 127.0.0.2 with SMTP id veaaYY7687511xKVmtlYcEwa; Wed, 29 May 2024 07:48:16 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.87]) by mx.groups.io with SMTP id smtpd.web10.16179.1716994095972815122 for ; Wed, 29 May 2024 07:48:16 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by CH0PR12MB8488.namprd12.prod.outlook.com (2603:10b6:610:18d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.19; Wed, 29 May 2024 14:48:10 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%5]) with mapi id 15.20.7633.017; Wed, 29 May 2024 14:48:10 +0000 From: "Chang, Abner via groups.io" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] GitHub PR Code Review process now active Thread-Topic: GitHub PR Code Review process now active Thread-Index: AdqxKDms81p5Mq2lRy6LTkfbwilSAQAiifSgAAkO3cAAACPRHA== Date: Wed, 29 May 2024 14:48:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-29T10:24:25.0000000Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|CH0PR12MB8488:EE_ x-ms-office365-filtering-correlation-id: 8a4918cb-8339-4155-ed4a-08dc7fee5c42 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?j4tpU4QSdhkixjrJfHnzn7rrmRAr2zTiOe/S4ezgI53e3wheym7uM1KNJi9n?= =?us-ascii?Q?GzVIrx4z9YG14wZQU9EsXeVGYDPLvhW+fPupXyFK/saSwVzhgG8HYqf4ByEX?= =?us-ascii?Q?QyYF2kNXeAvlruRWVORTcWJvnTdBo6SQCcQozr2uXlb0bfPo5hEZkz0lYNUH?= =?us-ascii?Q?VdCEOB2sO8WAiS7eJcxwIlRy53FdzLyxBPqDV/u6xP0vuxtZsDCOFU+okwGV?= =?us-ascii?Q?OEcn2BeeKmn4qAjSf7TLw3P1KnxNlozmFI7TP2aNBMAOaaBPaxhHswnNpzlY?= =?us-ascii?Q?CdX6b6ufHmEM2FPq/9oOuPX0dG04ZNsRw5YO6CjJiv+0RsDgZgNylR72RoyT?= =?us-ascii?Q?QqDThfNF0Wq5iHjMJHujgoi+U34lPcCqTRMLiN671GBLbnl00gGToy1jrnkO?= =?us-ascii?Q?XghqoauW1Xa5HRaki97ChNN3NHiQoP7vdAN2ocT/azWGdE7fHc5UjSdF6k7E?= =?us-ascii?Q?lcdp4N2lUtiprxLjEyR48GZO93G851hYMNa1d1mCMRZ7vylpJR70DjpUwFsn?= =?us-ascii?Q?Ib18xfl2hyQhlj7alqmFeJUcKGA0HtIOA9BVrGoxv5AKrwsGygstFhnetBnw?= =?us-ascii?Q?n55Chzicd4r2Ky2xXUV6mBQKBq4K/6n7Mj9leTUIsCCefl+e42NE3zu0CSw8?= =?us-ascii?Q?2zLs5kgoqSlIV4MIrgEPahPnG+BD/Hjwo4mxGJ8X157aB4Ix+w+tDlkhfh51?= =?us-ascii?Q?PfeEj2P68tIg0EAGFHh9GQkPsNcZFujFHxcO2ivmFPmoyxvgds8k1yX8Yz0C?= =?us-ascii?Q?f/KbRgbhEqlOwsyESy2R5fxUEyLtPBsAJ3D5MFelsY/nVS2xs3h65FM1WGpH?= =?us-ascii?Q?R3AA1PN/LWA2A2vpUXAXE79QMkyuH41aV1KetlCQXaYBUHP431qj2sO5FJs1?= =?us-ascii?Q?BF8fg/y50TNkbrhYDXMXK94/mzcZX2F8JjEHd5IKzwG0xbiYp/vFWT7RgMz8?= =?us-ascii?Q?3lzpeaXu4AfHZc01VLlgyZl/dBFYaxrhNYReyrA4vikgVeikLTrL2E331mmq?= =?us-ascii?Q?XOLbBcb63rUK8YoX1oh0QUQYEs4EliJsXXUKnNFldAk7ThyiVGP8/FwD8eOY?= =?us-ascii?Q?EK6N/dbut450UemDQplq8tepDQ99rACLtD1BOE6gIBp6aMgd7XnL17fm7nj2?= =?us-ascii?Q?v9Sn3b9PIFhdHnxnD0YNyecPFBtiT2KpVLl41vDNHlE14noZ2yZX1guFeTjz?= =?us-ascii?Q?dgGLbsO0fpHKvgPUFK+m+d/RdaIbRVIo9CYeI/d+BrqSF7t1hPMmhF+lP5lf?= =?us-ascii?Q?BGxEvlcKNnxdGd92DAqkAIQoRVsW5Ym+NsKdfQSSkDUz1J8qnLuqFzPpjylx?= =?us-ascii?Q?+zI=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RDodZBI92w4ddI7SyAJCS+maLSoQPpyZnnc68FngqXG1dICnFJAyHFynn7MV?= =?us-ascii?Q?plxBRHllXEXrLjJAuLX80Fw/Ixlamw8fqzL+usMi0tPsQbuIxHqBqa8WWizm?= =?us-ascii?Q?bTQ7fzwYQZiiBiwzbnMqfwfZ4nO2UHTHyTGqa/KpB6d+gTlFNcuyLO2BhMrr?= =?us-ascii?Q?WZjo0W2Z9Cwq69boV6manjavl2snRs6MSmExascLZRBWQzrYFFqpIYIHfVp1?= =?us-ascii?Q?wb2vtTvxGi/IxnIsXNA5LbPsOJJBaDILpVgemdRit7Q+AxoY2b8LqkM0gi34?= =?us-ascii?Q?ZYTyIMS4WqCN8lflKwsV1opKNIz6th7L46X7iysMAbkil9vxPa1sbHbeLYKL?= =?us-ascii?Q?tPyhEZCPFdm9hdB0fwMitRZfnbraifaLbiyG3QJFm5mytHoLBd1ks0yLeAXs?= =?us-ascii?Q?L585BeoU88069kqWiUotYUtfy7JVFVKVZWwXOhfDe+ApVaVB20buMdxfuaWg?= =?us-ascii?Q?RE8JDPzm0xdaLNDx24JU7RfyH4zSweLvKv8PhFWY8cSzfIhPYrhKMllGqEQ2?= =?us-ascii?Q?ELlx1ZcS221qgpJOsgOFo/Hvp9f+8tsSwdYbDp11WSN4rw2ckt6U4JNLrSPk?= =?us-ascii?Q?KI0ik0dMM2rmL+mnw33VJVBaoDmShBWE8+og6SoUq3X23U4eHPJvMkQ1BV1n?= =?us-ascii?Q?uPYr7SVbgK8Ls9f0kf5fAitAhTRUL3uMTH+2DPLOTQuA6rXUapTg3l+hGpao?= =?us-ascii?Q?UrowpXUto1QmEIaei5c/kzDo2UefKUbOFbul408gj61s7B9ZTWQrO0Rh/tVy?= =?us-ascii?Q?PkbbY8KpvTYkX/LAcrMDoSR5vCM4l6WkvHyJa4QkL+FrOIwkQIv103b5n2MF?= =?us-ascii?Q?XAL4D2f3XAC0G4N6ZkR0gfh9NEfTzUK8CPecgTIB76BzOeDLeKc1K7pQfw6s?= =?us-ascii?Q?fwELkC+jBDY12ilp7nCOYRZXmzeFeLPnuJz8HGxVMeDC/eic5FuOjcaDe71Z?= =?us-ascii?Q?F4HqAbLzAfzxyKGgiZFwQKtfaf7H2nfkcO6DSW0v2JIbcF3LVdUMryosM8Tz?= =?us-ascii?Q?K7KppWaYp64OrkzfcvA3/V2zNlxaQkz2tmPWL+wSqhuYm2wFkpvQFqu0HgHq?= =?us-ascii?Q?TEKERIrFjZZuVkpvujxX7Sv2A27f+3eoYYraafiR7oaz4srcUFMpQyncHlAP?= =?us-ascii?Q?lSPTH1yLvCeyeTAnfeTGGhgvoEOFP1g0qVxpoK6MwwenzCrPoho/4iWrSoPx?= =?us-ascii?Q?wZNU2VGD8xnLAso2tORY3ccZ6SB/5tON23zYoY5cpDOaapVSOKBc79w0FEcA?= =?us-ascii?Q?4hYuRzJpfpWGTnqcVSqvT9m0W7DdeLcUL79kZ1+anvPNRXQECj6ZjetJl1Ny?= =?us-ascii?Q?agGg14+BEhrbMw+f9d4n5vvDOK09UAo2Ri/CBkvk4cqr7PfRi/mZSuS8cX7v?= =?us-ascii?Q?9t/XjA1jFO9yYpdpD+U+WJ9DoNvxuJZQkrDLZKNpiZe3L6GG8/l+7+nzs/MY?= =?us-ascii?Q?BWNsaFBOcXSmwOHn5Ut32I2E5Q/jubgzuRKzHTIZNepZlVQu3+RmXI1BThlF?= =?us-ascii?Q?Sb7BDW6tBcaBdmXAAj5eR2hwMN/ThDhYvRdq1TRQhmTVzqXuymRI8ZBEnG/E?= =?us-ascii?Q?MSYUF7iKWvW8g8CYHwTk31MbicufHn33H64fauoE?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a4918cb-8339-4155-ed4a-08dc7fee5c42 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 14:48:10.6563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 49qIyJEr2vcs7HGn8D66gPihHzFPndWl0KOTElB1e6MErJlMqocXIaJa6/xyoSz2rymA13DeZ2uZ5Q2hZKySLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB8488 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 07:48:16 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1AqeZAlyzQINGBWzCcF4dvWNx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_LV8PR12MB9452278F314F85B4E38290B2EAF22LV8PR12MB9452namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wjD9VKKd; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_LV8PR12MB9452278F314F85B4E38290B2EAF22LV8PR12MB9452namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - AMD Internal Distribution Only] Thanks for the clarification, Mike. Thanks Abner ________________________________ From: Kinney, Michael D Sent: Wednesday, May 29, 2024 10:44:41 PM To: Chang, Abner ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: GitHub PR Code Review process now active [AMD Official Use Only - AMD Internal Distribution Only] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, Yes. The plan is to apply to all repos. We want to use it on edk2 for a while to make sure we get the settings and process correct, then we will expand. Mike > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, May 29, 2024 3:41 AM > To: devel@edk2.groups.io; Kinney, Michael D > Subject: RE: GitHub PR Code Review process now active > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, > Wondering if we also plan to apply GitHub PR process on edk2-platforms re= po? > Or other repos under tianocore? I found there is another email thread "En= able > GitHub PR, protected branches, and 'push' label" on edk2-platforms, but n= o > further discussions then. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Michael = D > > Kinney via groups.io > > Sent: Wednesday, May 29, 2024 2:54 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D > > Subject: [edk2-devel] GitHub PR Code Review process now active > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Hello, > > > > The GitHub PR code review process is now active. Please > > use the new PR based code review process for all new > > submissions starting today. > > > > * The Wiki has been updated with the process changes. > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > > Development-Process > > > > Big thanks to Michael Kubacki for writing up all the > > changes based on the RFC proposal and community discussions. > > > > We will learn by using, so if you see anything missing or > > incorrect or clarifications needed, please send feedback > > here so the Wiki pages can be updated quickly for everyone. > > > > * The edk2 repo settings have been updated to require > > a GitHub PR code review approval before merging and > > all conversations must be resolved before merging. > > > > * A PR has been opened that removes the requirement for > > Cc: tags in the commit messages and is the first PR > > that will use the new process. This PR needs to be > > reviewed and merged to support the revised commit > > message format. > > > > https://github.com/tianocore/edk2/pull/5688 > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format > > > > * Please use "Draft" PRs to run CI without any reviews. > > Once ready for reviews, convert from "Draft" to > > "Ready for Review". > > > > * For active code reviews that are almost complete and will > > be ready for merge in the next few days, the submitter may > > choose to either complete using the email review process, > > or switch to the PR based code review process. > > > > * For active code reviews that are expected to take more than > > a few days to complete, please convert to a PR based code review. > > > > Thanks, > > > > Mike > > > > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119352): https://edk2.groups.io/g/devel/message/119352 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_LV8PR12MB9452278F314F85B4E38290B2EAF22LV8PR12MB9452namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - AMD Internal Distribution Only]


Thanks for the clarification, Mike.

Thanks
Abner
From: Kinney, Michael D <= ;michael.d.kinney@intel.com>
Sent: Wednesday, May 29, 2024 10:44:41 PM
To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io &= lt;devel@edk2.groups.io>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: GitHub PR Code Review process now active
 
[AMD Official Use Only - AMD Internal Distribution= Only]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Hi Abner,

Yes.  The plan is to apply to all repos.

We want to use it on edk2 for a while to make sure we get the
settings and process correct, then we will expand.

Mike

> -----Original Message-----
> From: Chang, Abner <Abner.Chang@amd.com>
> Sent: Wednesday, May 29, 2024 3:41 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel= .com>
> Subject: RE: GitHub PR Code Review process now active
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Mike,
> Wondering if we also plan to apply GitHub PR process on edk2-platforms= repo?
> Or other repos under tianocore? I found there is another email thread = "Enable
> GitHub PR, protected branches, and 'push' label" on edk2-platform= s, but no
> further discussions then.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf= Of Michael D
> > Kinney via groups.io
> > Sent: Wednesday, May 29, 2024 2:54 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] GitHub PR Code Review process now active > >
> > Caution: This message originated from an External Source. Use pro= per
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/= EDK-II-
> > Development-Process
> >
> >   Big thanks to Michael Kubacki for writing up all the<= br> > >   changes based on the RFC proposal and community discu= ssions.
> >
> >   We will learn by using, so if you see anything missin= g or
> >   incorrect or clarifications needed, please send feedb= ack
> >   here so the Wiki pages can be updated quickly for eve= ryone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and > >   all conversations must be resolved before merging. > >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR > >   that will use the new process. This PR needs to be > >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.=
> >   Once ready for reviews, convert from "Draft"= ; to
> >   "Ready for Review".
> >
> > * For active code reviews that are almost complete and will
> >   be ready for merge in the next few days, the submitte= r may
> >   choose to either complete using the email review proc= ess,
> >   or switch to the PR based code review process.
> >
> > * For active code reviews that are expected to take more than
> >   a few days to complete, please convert to a PR based = code review.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> >
> >

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119352) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_LV8PR12MB9452278F314F85B4E38290B2EAF22LV8PR12MB9452namp_--