[AMD Official Use Only - General]
From: Igor Kulchytskyy <igork@ami.com>
Sent: Thursday, February 29, 2024 9:38 AM
To: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: devel@edk2.groups.io; Nick Ramirez <nramirez@nvidia.com>
Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol
[AMD Official Use Only - General]
|
Caution: This message originated from an External Source. Use proper caution when opening
attachments, clicking links, or responding. |
-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Wednesday, February 28, 2024 7:31 PM
To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin <mike.maslenkin@gmail.com>; Igor Kulchytskyy <igork@ami.com>
Cc: devel@edk2.groups.io; Nick Ramirez <nramirez@nvidia.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish HTTP protocol
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
[AMD Official Use Only - General]
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, February 29, 2024 8:11 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>;
Chang, Abner
> <Abner.Chang@amd.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: RE: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish
> HTTP protocol
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > Sure!
> >
> > Reviewed-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>
> Thanks, Mike!
>
> > But I didn't see any implementation of gzip coding/encoding for edk2.
> > Do you know of any?
>
> I just talked to Aber about this. We are working to see if we can provide gzip
> implementation in edk2 or not. It seems to me that we need 3rd party library
> to edk2 for supporting gzip. Anber, please feel free to correct me if I am wrong.
Yes and we hope someone can provide the implementation. @Igor Kulchytskyy, does AMI has the implementation of gzip?
😊
BTW, we do have a proposal that introduces EFI_SOURCE_CODING_PROTOCOL long time ago while I was worked for HPE. I think we should pick up this one and promote this protocol in UEFI spec, we can work with AMI on this as well.
Thanks
Abner
Hi Abner,
Unfortunately, AMI does not have the implementation of gzip.
Why do you think AMI has it?
😊
I can investigate the 3rd party libraries to be adopted for using in UEFI environment.
Thank you,
Igor
I thought AMI has the implementation as you and Nickle considered the content encoded parameter for the Redfish HTTP protocol. I guess you have gzip implemented in AMI BIOS as Nvidia doesn’t.
😊
Abner
>
> > I hope you know that patch 5 breaks edk2-redfish-client compilation
> (Instance of
> > library class [RedfishHttpLib] is not found) But I understand these changes
> are not
> > atomic for edk2 and edk2-redfish-client.
>
> Yes, I also have patch for edk2-redfish-client to use Redfish HTTP protocol. I
> had tested Redfish HTTP protocol on edk2-redfish-client. I will send out patch
> for review after Redfish HTTP protocol gets merged in edk2.
>
> Regards,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, February 29, 2024 1:56 AM
> > To: Nickle Wang <nicklew@nvidia.com>
> > Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>;
Abner Chang
> > <abner.chang@amd.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement Redfish
> HTTP
> > protocol
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On Wed, Feb 28, 2024 at 2:47 PM Nickle Wang <nicklew@nvidia.com>
> wrote:
> > >
> > > Hi @Mike Maslenkin,
> > >
> > >
> > >
> > > May I have your reviewed-by if version 3 patch set look good to you?
> > >
> >
> > Sure!
> >
> > Reviewed-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> >
> > BTW I'm just curious, there is a mention in patch 2 "We currently only
> support
> > gzip Content-Encoding."
> > But I didn't see any implementation of gzip coding/encoding for edk2.
> > Do you know of any?
> >
> > I hope you know that patch 5 breaks edk2-redfish-client compilation
> (Instance of
> > library class [RedfishHttpLib] is not found) But I understand these changes
> are not
> > atomic for edk2 and edk2-redfish-client.
> >
> > Regards,
> > Mike.
> >
> >
> > >
> > >
> > > Thanks,
> > >
> > > Nickle
> > >
> > >
> > >
> > > > -----Original Message-----
> > >
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of
> > > > Nickle Wang
> > >
> > > > via groups.io
> > >
> > > > Sent: Tuesday, February 27, 2024 8:49 AM
> > >
> > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> > > > Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>;
Abner
> > > > Chang
> > >
> > > > <abner.chang@amd.com>; Nick Ramirez <nramirez@nvidia.com>
> > >
> > > > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement
> > > > Redfish HTTP
> > >
> > > > protocol
> > >
> > > >
> > >
> > > > External email: Use caution opening links or attachments
> > >
> > > >
> > >
> > > >
> > >
> > > > Thanks for your confirmation, Mike!
> > >
> > > >
> > >
> > > > Version 3 patch set is here:
> > > >
> > > >
> >
> k2.groups.io%2Fg%2Fdevel%2Fmessage%2F115985&data=05%7C02%7Cnic
> klew
> > %4
> > > >
> >
> 0nvidia.com%7Ca30038f7379c4f8dad3b08dc3886a03b%7C43083d157273
> 40c1b
> > 7d
> > > >
> >
> b39efd9ccc17a%7C0%7C0%7C638447398077724632%7CUnknown%7CTW
> FpbG
> > Zsb3d8e
> > > >
> >
> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7
> > C
> > > >
> >
> 0%7C%7C%7C&sdata=0tXBIuafvJuG7AM1DpAgSGGLf1QeUbOOmCq2WQCY
> peg%
> > 3D&rese
> > > > rved=0
> > >
> > > >
> > >
> > > > Regards,
> > >
> > > > Nickle
> > >
> > > >
> > >
> > > > > -----Original Message-----
> > >
> > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > >
> > > > > Sent: Tuesday, February 27, 2024 8:13 AM
> > >
> > > > > To: Nickle Wang <nicklew@nvidia.com>
> > >
> > > > > Cc: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>;
Abner
> > >
> > > > > Chang <abner.chang@amd.com>; Nick Ramirez
> > >
> > > > > Subject: Re: [edk2-devel] [PATCH v2 2/6] RedfishPkg: implement
> > > > > Redfish
> > >
> > > > > HTTP protocol
> > >
> > > > >
> > >
> > > > > External email: Use caution opening links or attachments
> > >
> > > > >
> > >
> > > > >
> > >
> > > > > Hii Nickle,
> > >
> > > > >
> > >
> > > > >
> > >
> > > > > On Mon, Feb 26, 2024 at 4:44 PM Nickle Wang <nicklew@nvidia.com>
> > wrote:
> > >
> > > > > >
> > >
> > > > > > Hi Mike,
> > >
> > > > > >
> > >
> > > > > > > So finally we have
> > >
> > > > > > > HttpFreeHeaderFields (Response->Headers,
> > > > > > > Response->HeaderCount);
> > >
> > > > > > > but
> > >
> > > > > > > Response->HeaderCount does not count partially allocated
> elements.
> > Right?
> > >
> > > > > > >
> > >
> > > > > > > To fix this, it is required to set *DstHeaderCount =
> > >
> > > > > > > SrcHeaderCount unconditionally right after DstHeaders
> > > > > > > allocation,
> > >
> > > > > > > and HttpFreeHeaderFields() will do the work then.
> > >
> > > > > >
> > >
> > > > > > I follow your suggestion to update DstHeaderCount right after
> > >
> > > > > > DstHeaders is
> > >
> > > > > allocated. So, HttpFreeHeaderFields can release headers
> > > > > correctly. I
> > >
> > > > > also create a macro to implemented AsciiStrCpy. Please check below
> > > > > link to see
> > >
> > > > my changes:
> > >
> > > > > >
> > > > > >
> >
> 2Fgi%2F&data=05%7C02%7Cnicklew%40nvidia.com%7Ca30038f7379c4f8d
> ad
> > > > > >
> >
> 3b08dc3886a03b%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7
> C6384
> > > > > >
> >
> 47398077735545%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJ
> > QI
> > > > > >
> >
> joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=d
> Zf
> > > > > >
> > %2BXZMEyp4%2BC%2BZgFnVCr12fIyXn1ZDsFfk2ejkYGO8%3D&reserved=0
> > >
> > > > > > th
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> ub.com%2Ftianocore%2Fedk2%2Fcompare%2F0f391b1c2f988d90a3ac723b
> 314a
> > >
> > > > > c28b
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> a7b0b8df..f0fa1b8fdcd933beb52fd3127c2476443c00ef8d&data=05%7C02
> %7Cni
> > > > c
> > >
> > > > > k
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> lew%40nvidia.com%7Cf3870f71360e44f3b4e208dc3728ff87%7C43083d15
> 72734
> > >
> > > > > 0c1
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> b7db39efd9ccc17a%7C0%7C0%7C638445896465360452%7CUnknown%7
> CTWFp
> > >
> > > > > bGZsb3d8
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%
> > >
> > > > > 7C0
> > >
> > > > > >
> > >
> > > > >
> > >
> > > >
> >
> %7C%7C%7C&sdata=K%2FEA2QWpk%2F8NHQ1QhzqkvQqao4db%2BILn1Jt
> %2BB
> > >
> > > > > qQ5n1E%3D
> > >
> > > > > > &reserved=0
> > >
> > > > >
> > >
> > > > > These changes looks good. Internal strings
> > >
> > > > > initialization/deinitialization code much cleaner now and possible
> > > > > leak seems to
> > >
> > > > have been fixed.
> > >
> > > > >
> > >
> > > > > Thank you!
> > >
> > > > >
> > >
> > > > > Regards,
> > >
> > > > > Mike.
> > >
> > > >
> > >
> > > >
> > >
> > > >
> > >
> > > >
> > >
> > >
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual
or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail
or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.