From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 52ED6D806C6 for ; Wed, 7 Aug 2024 07:16:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=npd7JwFMUaKwo8Od7Dwf2s6T/Ojcn6FYu67Uq0caFiI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1723015011; v=1; b=dptx1sn14qsayvJvWRPekJxR+BD+RlSH+LFMUcVef4Ws0bqOVfmtzp+rS0lIb5MGx44SV0rZ jMqovAdNm3DRGS2i64g82BTHUtmfw4rsKvQPAHWMz87ibsQ/Csc6HTSuOiQCBMGGms3deohn9ox pIEW2NApZpML8AARm9es1cBTBslr6LLuWgNQGA9HIC59nkO2uc1CtPlyT8CqwQyl8w+Al7Uu69M Rdp5VVRC3moOneuYC6yaVUpO0AXq592V7OgmFz+UWdnhEt8Vqj890rYMCdyToIq4P+m5p6Xgm6e QHz5ZWV1LJgFYASX0oHmNGvnvjE351NB4LsJQXgLEok8A== X-Received: by 127.0.0.2 with SMTP id 4G0rYY7687511xtM4xXjqSeH; Wed, 07 Aug 2024 00:16:50 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.81]) by mx.groups.io with SMTP id smtpd.web11.28081.1723015009425342540 for ; Wed, 07 Aug 2024 00:16:49 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by DM4PR12MB5724.namprd12.prod.outlook.com (2603:10b6:8:5f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.13; Wed, 7 Aug 2024 07:16:45 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%3]) with mapi id 15.20.7849.008; Wed, 7 Aug 2024 07:16:45 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , "nhi@os.amperecomputing.com" CC: "quic_llindhol@quicinc.com" , "chuong@os.amperecomputing.com" , "rebecca@os.amperecomputing.com" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Index: AQHa6JYaiUmWXOWvgEK2HfpEs97lYLIbYgWQ Date: Wed, 7 Aug 2024 07:16:45 +0000 Message-ID: References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> In-Reply-To: <20240807064731.4049764-1-nhi@os.amperecomputing.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=e7cb7dd8-e5a8-4ea9-91b8-e65ac7f6bc28;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-08-07T07:15:35Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|DM4PR12MB5724:EE_ x-ms-office365-filtering-correlation-id: 6d80a207-2113-45d1-74ab-08dcb6b0e50c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?JMQYD2vm9El0u3N2vbnAPcXCfCFHEb6k3pfikotAc9peUjGp47hj0XDqX4Hp?= =?us-ascii?Q?gxMQvZQ+LlPbgoi0YqriJwXC98ypOaBqJ82teksHAF0/3kfZO3m8m0d9NLdn?= =?us-ascii?Q?0QqSBDaduBsAK/ndUIeDbMrBeAETRBSUp3DEBo9/or374KSPkFfELf7ZEXI5?= =?us-ascii?Q?tZ7h2e6cQCLEhXMq/U6/qPoVVOuq+YdPjA89TGMoboqKdTR7ruUjhc+AKpSH?= =?us-ascii?Q?mPxnmdfOFcJsQx/44oK9DK0r3n53UEcORj3jtFQEr/68DaraEpX60hzevq3C?= =?us-ascii?Q?GnFpa9LJzyYRrgc8+/MhLokzXEJ1mU2Gfy4s+CL99H5ZdqAhKKSHJxlJKpjS?= =?us-ascii?Q?jpKallXqZZlfcow/doM9zQCISjTz2mMI1Qznk7zi8K3312N6gFofVtxQ6l/s?= =?us-ascii?Q?7sqwLF+D0PEOweqlWCczb/9saVrUC0CskErDTi9944GNzb7of0gWiikOb5hq?= =?us-ascii?Q?8OIH9h4kCU6Kz7c+i84GUSiEl32iWS+2nMPbI1z4KfhdQhFzNWjKHW98NNLK?= =?us-ascii?Q?vjsr7R22yol9OK8XebFJdxnHU+LoYCwsB/7qNQq8RJWZg6BFNXI0KVoh5aKD?= =?us-ascii?Q?IHet6jSOGXP9hWjlFb/l6793lPPZKSfDf67iBxrfUL6YdBeREHLz7r1NLdK7?= =?us-ascii?Q?eQbceOINtP+f9wARNwTpF3Z8AFms2NqK1HVmDVrtDF5CmeGAA3Ml0+FocigC?= =?us-ascii?Q?2h1t/Y6ikAcJwFO3uHWUDmW/USDKIfLEc+i5cBXWL+BH+X9dHnl7zHYmFuT3?= =?us-ascii?Q?zTTX0BNQ62xdz4ksunSh6nZ4qFefcvcXmpWIF7QfL9nmcttiUXjlQqI1+y8o?= =?us-ascii?Q?ryTnuTEeJR7Al4nuwC41w+jNzYW+RBxgFiqIcvC7EIdofPQmkLSATcIu/oN4?= =?us-ascii?Q?P+6Zw/BQS0ZP2ctdiZJrsQhFqLsoS6bPTTUghk1oHeutsJHbJOLlGTMIbeF4?= =?us-ascii?Q?ZwLy6tkBpUrSliFcnxHmXsbgaGf0l0ksxwTwumCfAVi2ATZdj2uPOJFuXWF8?= =?us-ascii?Q?oCyHKEbz6CKd/GyU88O85lUxPPvul94MnHP8jmryedN8/2X1ZTdYbSCsKb8c?= =?us-ascii?Q?ek+oLZUznBXmaj6J6POH1nT7+mX4Oq+Ffkewa9/qYEoMC04TNCAtCuk7XPYH?= =?us-ascii?Q?5uC2kzMolDgYNgVi6YNheBrdW2ZEOcK31JF3qiJvvo9g24OiWSG9iOvWk4ZX?= =?us-ascii?Q?+xLK+qFacmEbGQQIECORVhfM6WI6TM4M/FTW6R51jkPN9fCFTryKwKyTBWdv?= =?us-ascii?Q?HceKzRDz2ICmQm7idP98HvaE8FeeM13uAzKSD3um+P9WYU+hbRaCeRl2Alm4?= =?us-ascii?Q?6H+LWEBfVBUmhEd+6bK54pIY73tYfBhmaQMwBiPPQVDfGcApnfX2P6myDGkL?= =?us-ascii?Q?5dCGg4w=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ql3jQmQLS/J65H5UjIljK+N81gVRM93jKJYEa4aJ3MzxhDdRmVm3Jeb+9Qx6?= =?us-ascii?Q?SWhJT7MJN6l8D5rQ9AhXhozA8IGuEASdbXwNHfCGS01g5fZgxnxY1/e5qBiC?= =?us-ascii?Q?avk+vCdTLPDvUk9YJG67t3Y74MPCf6TXCTUijI62BdV0bISR/iR1kh3xWx6X?= =?us-ascii?Q?1xn3Zv3ZutcD7zUf/ILbxYY2dN7D6ABo0aaZQg636LEvc89xx6z261ZUETPJ?= =?us-ascii?Q?WzFTbiYM6/maH4ipEJx24zaov9beQAQO4oIJ97Mn+xG2ffnwNce/hf1+cZyb?= =?us-ascii?Q?HMKqL/2GHJM9CVU15csEtx3RkK1kdSBHHnICnj0Jt9Nxn14yS8LmgjgEz+Cy?= =?us-ascii?Q?Em7zVTdlWjrrGs1v99OcCnyD2zGSa3HdkfWtfJyP7SxdwcNxle6h45VFyeC9?= =?us-ascii?Q?p8vjc3TQLsrlZFEND+F1MVkpiM7il2Kg2h0dg7FJ8rsHyYq76LWAlK0ihbAy?= =?us-ascii?Q?mHDBUqnuxsr+xVGRywZ88Gi17a+H5X9DCsDk2NjjSCdSj2vaG8R+aeNt/90T?= =?us-ascii?Q?boPzwnMpBT2fkMB53gey1ZkOv9Js77ATT12bo54Yn0ksRK3RJzx0nl8pedAx?= =?us-ascii?Q?uIxv7ga4JOeEfrm0jlFFkmh+gJqJ1ve3z9H/O7uZA60afcwcx3P7GTa8B++4?= =?us-ascii?Q?lOMYY5J6a0JH8kMUHFEGTTFATojd/FL93fKKjh/f3Jf/YHsR4r9Rb6l6TqY7?= =?us-ascii?Q?gQID0bOwGOGlPNHwXAGeT52gMfOYvnVaQGyWWKBp+aIPKlpFbjwPuo9BjyJc?= =?us-ascii?Q?Pr41hx4GqZINCeA3n98vWjMhHTY49JjraaaZfl+LeRT3TO203PoIKmGp3N7Q?= =?us-ascii?Q?jol8za+5dJjlt9sEki1UrTHKHTxkf6sUTa57IWnP38477gQeUGa4Hy0qJiut?= =?us-ascii?Q?Fym/pMpNBgZovvfVMXGsrAnKkjVtiD0m6HMn2fJMpiFgdmx/tmWbti+O0crP?= =?us-ascii?Q?4jmZvt5T6wu66dPjNbqtIrzQFPvVAyDuOZEA35L6s4p5NawXCrJk5IV+XP+Y?= =?us-ascii?Q?bHVPWrvSCioRR3iFcF03yJJIpVNzedaOKRIZcgJKd49fqAiigQccd/NWNfY/?= =?us-ascii?Q?KiR+5dYU3S1jiEUNSTda7rIi8x9rf8id/YNAVcxT6ykgfx9vEblbrdKg4nWb?= =?us-ascii?Q?mSg+tSaVqA6rIfpAR2c6mqIsogHxHQxNytJCZHV4zUIU5otu9ka/ZzOt8+Mz?= =?us-ascii?Q?x8nRm4uHZb7646svUVzWj+kIFvAcwLXgJ/ykP/YSDv1QjsyUjGxaR4dpDD9s?= =?us-ascii?Q?pqE61jIXo5a3m7P1x2fws2qtv0pZDI3r96UuKZ/hugLwVaplg2KyED2T30JP?= =?us-ascii?Q?17Cu34LXKExB4v0ssN2Ia8pGkUJMO3rEWfLMxDorRMlH8oXCoprB9vvEh5H5?= =?us-ascii?Q?ZlU7Xxc9BW4FDvAXNEj09BPH/V5LMNYN5vyOTsD+tVcQzh/5OrxSn55YfyuW?= =?us-ascii?Q?rxgOJfUL2XN1QcPylrU43elVpVTt7IEWfBTWTR5KZaOdfdrDMa9R4hSC42DZ?= =?us-ascii?Q?Z2ZyY5WFg0ZxXhzT3Fb70ubfxnQ0yepxpRZFBXTON5A9t6ad29BfJZsEn7Os?= =?us-ascii?Q?MFjtxF6R34tgHTLUNn0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d80a207-2113-45d1-74ab-08dcb6b0e50c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2024 07:16:45.2997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k/dtd/uBwaI1tMdbSHmGAqizHBqSE3xKnsAEPhZJ/U97/f68psEU5TuqJyVfFaofizJJsOxwB65h04QRVXjDIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5724 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 00:16:49 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2VKDCVgNI8NXNWaSPAdafEZWx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dptx1sn1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please s= end the PR against edk2-platforms? Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nhi Pham > via groups.io > Sent: Wednesday, August 7, 2024 2:47 PM > To: devel@edk2.groups.io > Cc: quic_llindhol@quicinc.com; chuong@os.amperecomputing.com; > rebecca@os.amperecomputing.com; nhi@os.amperecomputing.com > Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF suppor= t > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform. > > v2: > - Refine the changes of the DwI2cLib per Leif's comments and update the > commit message accordingly. > - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. > > NOTE: Regarding the controller/target terminology, the function > prototype and comment are derived from edk2/MdePkg. In this patch set, I > am trying to avoid misusing the terms in the implementation instead of > altering the function prototype and comment with the PPI and Protocol. > > Nhi Pham (5): > AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation > AmpereSiliconPkg: Define PCDs for SMBUS and BMC > AmpereAltraPkg: Add SmbusHc PEI and DXE drivers > JadePkg: Add PlatformBmcReadyLib to support BMC ready check > Ampere/Jade: Enable IPMI SSIF > > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec = | 15 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc = | 23 ++ > Platform/Ampere/JadePkg/Jade.dsc = | 2 + > Platform/Ampere/JadePkg/Jade.fdf = | 17 ++ > > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf | 29 ++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf = | > 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf = | > 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > | 95 +++++++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h = | 11 +- > Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c > | 6 +- > > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c | 30 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > | 261 ++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c = | > 277 ++++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c = | > 263 +++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c = | 129 > ++++++++- > 15 files changed, 1227 insertions(+), 17 deletions(-) > create mode 100755 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > create mode 100644 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c > > -- > 2.25.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120267): https://edk2.groups.io/g/devel/message/120267 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-