Re: [edk2-devel] [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

As I already reviewed offline on Nickle's personal Git repo,
Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Remove RedfishLib and use RedfishHttpLib for debug printing
> Redfish response data.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++--
>  RedfishPkg/Include/Library/RedfishDebugLib.h           | 2 +-
>  RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c   | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf
> b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf
> index 048d27c6dc..d468bb213b 100644
> --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf
> +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  INF file for Redfish debug library.
>  #
> -#  Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> +#  Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -32,7 +32,7 @@
>    DebugLib
>    JsonLib
>    MemoryAllocationLib
> -  RedfishLib
> +  RedfishHttpLib
>    UefiLib
>
>  [Depex]
> diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h
> b/RedfishPkg/Include/Library/RedfishDebugLib.h
> index 3430cf1d14..ad7a697586 100644
> --- a/RedfishPkg/Include/Library/RedfishDebugLib.h
> +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h
> @@ -11,9 +11,9 @@
>  #define REDFISH_DEBUG_LIB_H_
>
>  #include <Uefi.h>
> +#include <RedfishServiceData.h>
>  #include <Library/HiiUtilityLib.h>
>  #include <Library/JsonLib.h>
> -#include <Library/RedfishLib.h>
>
>  #include <Protocol/EdkIIRedfishPlatformConfig.h>
>
> diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c
> b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c
> index 3728f51213..8b0425b8c3 100644
> --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c
> +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c
> @@ -13,6 +13,7 @@
>  #include <Library/DebugLib.h>
>  #include <Library/MemoryAllocationLib.h>
>  #include <Library/RedfishDebugLib.h>
> +#include <Library/RedfishHttpLib.h>
>  #include <Library/UefiLib.h>
>
>  #ifndef IS_EMPTY_STRING
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115695): https://edk2.groups.io/g/devel/message/115695
Mute This Topic: https://groups.io/mt/104463408/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-