From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F4D4740034 for ; Wed, 21 Feb 2024 01:55:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MleDpGJqICfRJrOjyapuHN6hR3M0ZVJQX+MTVgaI4eI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708480513; v=1; b=q9PfmQOuEVDewnsMeJ0xcdOCoDR5HzZIASmZWp/Kr6DUUmhEOU2/fa+mYtOvSgf0zRo1A4Ox MQ+aCZYmqSuJ5H32qf3eMqMfL8yZSPY7FVSO0IMjNMpSYA8InqusrvpsmYaOzOa07qjoUo5raa9 gYMawioXDvdY9WKAv6TCcQmg= X-Received: by 127.0.0.2 with SMTP id 8BUQYY7687511xOHJJde6rxc; Tue, 20 Feb 2024 17:55:13 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.73]) by mx.groups.io with SMTP id smtpd.web10.3900.1708480512253984820 for ; Tue, 20 Feb 2024 17:55:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYRtSqqUDdwGROYOvVHcMvpYqjLh9MQleLf4XNhxp46Fx9LmOY9yp79XBONY5d/8VXCvzMlrMCNT1/pS+L6cmstM5a234Xw2y8NyvKTY1ccaBlNcSEfo9RUK/JFrCTCo6//b3J0OeK2BBnc4A5/zcGLwIQuBzmZ1jjqRnEI4qFs2qykiQMj0pPuki7/rb6omZfwjq9uOmzAdcJuz3uuuguuyHjmvEuL87zdd/UYi7VgtD/Qvb8IG+2Vh7vLt2PTIuRtdHGA2EVwjRqS47xLNDkUmR1vb3n8MVPAdRdJle0Ip3F7xgcGu3QA/P1OSSNB5PHb17uWstGzIz4ZOsysRAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eMnHKWAUzi6tddsqKTvGWYw2LZrIHYHtYG1iCGLsgPI=; b=GQoRWu0QjogMr/mCCqFm1j19IjSOcq62bfHy07B9rJj+ZGiTRNvPeLLGBAjPLuvjLaqE6yDtL912PJx4v6fNlEix5NIctoOqGdOorIP3jXofmpRbf3NwDNW32H8dn+xt37DrJS6jsKx2gUKPr9wz7CMj5E7sQvnfUp7/twHVruVuO0I2FOemgkCFcsYwe3ozcldR8j8UpGSygPHglswhVFGVqQ8tYvG0OOCDbuRidmi9OyJjR11DsdlpQ7COMDygeyHGc3J7nGDOf7f6pejoxltP624QiVJxkJnhrTogT+PDyfjhhYw3Exfae/C9uEGHml6VMT++KfweXDTyGMSXGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by MW6PR12MB7088.namprd12.prod.outlook.com (2603:10b6:303:238::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 01:55:09 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::bf3e:6aec:43a1:5ae1%4]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 01:55:09 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib Thread-Topic: [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib Thread-Index: AQHaY8fpbAf2vpks2E6f0avsZ4gIf7EUCmyQ Date: Wed, 21 Feb 2024 01:55:09 +0000 Message-ID: References: <20240220064145.28575-1-nicklew@nvidia.com> In-Reply-To: <20240220064145.28575-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d3f030b4-c46c-4d49-8920-adc88afa436c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T01:55:06Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|MW6PR12MB7088:EE_ x-ms-office365-filtering-correlation-id: 5f1e1571-1ce3-480f-6cd3-08dc3280226b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aHH9d0pvOzHHIlHufdQEbD/f/FiUohprRT65Z0VIlS27E7ZR5LWW2EEM7RX3Vzww5xLkjJorqtLr34pgoMsceQKhV+OsfuDvsZQu2RPb38VzpBI/QHsMfwgHYoRwpJj6blH/dZ6uzG1e4sxPnueeUIX0YmZ1gVNA5BPvimMsvfbk+DYm8KcC85uG4PTzpqIdM1VAHYrW7orbxqNHi8B7VuXA+gGfC9Znt7ouhxhRER4DfTqjklyuzvvB5doQgAwl2FbYNmdNdnKAlkCU2xSgNcZP8Wu0nUmESqPPENjElhZJTW/JvXXXFcE9M9nfW4XBLzDIHARO1gQjeBRd/gg9g56r3rzACEe3s7SWN7NU2yh0YYBNdzKsND35B96PjF1UwEANjst85p1iu3jiXmzp/IIm9UZRZ19BsGWiOBvq4Ab9I/mQnsKjQM4Cs/XJ9t3+yyDLQtiGLtqskQ/8ORP54nVT58vhKnPfoCB6Hzy31n2z//ku0S39mJIOdkyOTfBwUNk9e071WlxYgBXLr0SXDczTp0pxltt/DsCm+VGHrqJnd3jRmrGDPt4VHEu+7jQa6T5YnnTNgCWpH+aU1GIVNNsvlHh9YoF0HTutvM11odWyL0jlF4jZQLta71bizN1v x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3k9jasgk7ZzdRI7mDmPZZ19A6YhlF35rzPif4L4poYwoN+r17lvfRI6aISvF?= =?us-ascii?Q?4Bt8U35cnr4mIpsL7uRp4PWICuqS8OH2lOpa0enJ4/rUG0w/5ClQ5NzGQatg?= =?us-ascii?Q?kgsicawnynUghXhedF2V1XII3RTnfF4pYQaTeFqAA67QSbv6SVFwHi+3riNP?= =?us-ascii?Q?fqplq3FVzxlyvf6R4/WTUMNtvxprauU7Us0BqXbA/lI3hCpCsJrifujE/UeP?= =?us-ascii?Q?j6qVgoGVJXti2AnBwXPkV9vkMHuHfztGERD/wMGLjAivXw0QX2T34BXeStk0?= =?us-ascii?Q?F9dWmMu7dwg4IOqn7eRQD2ndBoUdfShQoso9sL4c5MX1yafgOMjx56Xp9W6O?= =?us-ascii?Q?LdNP5RGIHXa/K7bjKs6ia1+G1N/S7jiBYFuIeX4JxbsZ2JN7PK8/ry87c2mO?= =?us-ascii?Q?C+xJiiuHIBPR5xu/k6ZHjpatHMbhv6AKkVhJlkdSc7M4YOyesCvlp9wF4/ib?= =?us-ascii?Q?WCL3BQRdJf4q84bo7GuuUcvCPk3RtwWBSzp8pnVYvLfgDFJFmrSHKtOtV+4e?= =?us-ascii?Q?c5utsLGwXbmUBytbl/Sl9F6VZiMsMSqDcsBVuCuPeei0XjoRi07JUL7Wxn2w?= =?us-ascii?Q?1ywQ6hDRyNMZ0h5QZoVL1AYy3lkxPWhuO1OnS1iMP7FrHR4gGnYnu4NLVqZU?= =?us-ascii?Q?bfw2k6ycNhjs9jFpmP3kf/vTqPw9DpSjfG8BvAnEya8PsC+XGZmL2TwlWVHu?= =?us-ascii?Q?6zDT0OC39vS73Xmy+1oVetEagzex2+9eLnylxag1dAeGfM5Vrtn1iZg6KW6T?= =?us-ascii?Q?3q9/df9FAXL9se4zlWNqp6jz7gA0UDEhRV/Gg5NA/HS3s8gIAyq1msBuj++Z?= =?us-ascii?Q?u3L1tZuIYb+y3tx5QzObB/Ry32HfyI7XVXoAg61IYi52rJjWRPTjt0sGRPUU?= =?us-ascii?Q?vNSjGGpagkauSLCRKNZvxNhbrzf83RTRHo+Wqls6K7wucexCXbI/NaEd8H9V?= =?us-ascii?Q?vM2pMjtcDLxSe6MFw63Co0jq6sRenWA+kxqgWULKGN9QOhWvFnUzVVeEF7C6?= =?us-ascii?Q?JkO8rfT78KmldktG8UJa75OYSCi05Pl/nNJRwYrVDA1e54yqq24a1yJ9tCWK?= =?us-ascii?Q?hnvHLBaP1I4hiops39v6BPOQcCUXlWbamnvDLIoxeZRa27YPnfoz0R+U3eVu?= =?us-ascii?Q?HQnn5LSxVtebtV57pjbI4rhjZss+Fl0PHvmk7KFU35sEZUuisdn2i2TcY7cl?= =?us-ascii?Q?ud1BJM15No7s2huwim7deNT/GJM87yoLOcdstic8619rtxHSXT7GrGQ6shYd?= =?us-ascii?Q?55oEwCyc6zq4q2zz9iHpLwOqJLFUoYGr+Ji2fdORl84aGz8EJb22H6yoABiJ?= =?us-ascii?Q?CtPRbD3WOzKToEknSCEJN7JOWaN2ZJ3S/Mqq3Tb7ZVZj8D8prqqID0ryc1W6?= =?us-ascii?Q?XUugW/9hlAtzZSokhh8FG6FLgO/QRj13yYaBJHWSMWdc8UqAowoo67Atk44H?= =?us-ascii?Q?gHg3abaEi0cg44skr4ENZ7gzB8Lu82C2Jcr7/V17JrslQ9BZanKpUhSbYEmq?= =?us-ascii?Q?2zHj9nwhUP0++Iy94mAtaIcXqKrjSp7yixVu8GqQyYVjQSzLXiL1vPDasFlW?= =?us-ascii?Q?pYNqh3ZF4YR3CxQQZq4=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1e1571-1ce3-480f-6cd3-08dc3280226b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 01:55:09.4117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t/a3rQSWZepVzAz+6JZ9bXsnO+KDhiNOFdXWzXpE1dcaTVOWwrluRPrd7KfDKErTS981CZPme02gkH9XKciGxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB7088 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZvvaQBYmnCeUfqnMev9DijEEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=q9PfmQOu; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] As I already reviewed offline on Nickle's personal Git repo, Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, February 20, 2024 2:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 5/6] RedfishPkg/RedfishDebugLib: use RedfishHttpLib > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Remove RedfishLib and use RedfishHttpLib for debug printing > Redfish response data. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf | 4 ++-- > RedfishPkg/Include/Library/RedfishDebugLib.h | 2 +- > RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c | 1 + > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf > b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf > index 048d27c6dc..d468bb213b 100644 > --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf > +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.inf > @@ -1,7 +1,7 @@ > ## @file > # INF file for Redfish debug library. > # > -# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > +# Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -32,7 +32,7 @@ > DebugLib > JsonLib > MemoryAllocationLib > - RedfishLib > + RedfishHttpLib > UefiLib > > [Depex] > diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h > b/RedfishPkg/Include/Library/RedfishDebugLib.h > index 3430cf1d14..ad7a697586 100644 > --- a/RedfishPkg/Include/Library/RedfishDebugLib.h > +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h > @@ -11,9 +11,9 @@ > #define REDFISH_DEBUG_LIB_H_ > > #include > +#include > #include > #include > -#include > > #include > > diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > index 3728f51213..8b0425b8c3 100644 > --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > > #ifndef IS_EMPTY_STRING > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115695): https://edk2.groups.io/g/devel/message/115695 Mute This Topic: https://groups.io/mt/104463408/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-