* [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue
@ 2024-02-20 6:41 Nickle Wang via groups.io
2024-02-21 2:10 ` Chang, Abner via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Nickle Wang via groups.io @ 2024-02-20 6:41 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez
-Fix below compiler error reported in edk2 CI.
ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
symbol __ftol2
-The file MathFtol.c is copied from IntrinsicLib in CryptoPkg.
-Add MathFtol.c to EccCheck IgnoreFiles.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
.../RedfishCrtLib/RedfishCrtLib.inf | 7 +++-
.../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++
RedfishPkg/RedfishPkg.ci.yaml | 2 +
3 files changed, 45 insertions(+), 1 deletion(-)
create mode 100644 RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
index 6ff5dba75c..3a5e309d1a 100644
--- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
+++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
@@ -3,6 +3,7 @@
#
# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -23,6 +24,9 @@
[Sources]
RedfishCrtLib.c
+[Sources.IA32]
+ Ia32/MathFtol.c | MSFT
+
[LibraryClasses]
BaseLib
SortLib
@@ -35,4 +39,5 @@
MdeModulePkg/MdeModulePkg.dec
RedfishPkg/RedfishPkg.dec
-
+[BuildOptions]
+ MSFT:*_*_IA32_CC_FLAGS = /GL-
diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
new file mode 100644
index 0000000000..adfe249b1d
--- /dev/null
+++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
@@ -0,0 +1,37 @@
+/** @file
+ 64-bit Math Worker Function.
+ The 32-bit versions of C compiler generate calls to library routines
+ to handle 64-bit math. These functions use non-standard calling conventions.
+
+Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+/*
+ * Floating point to integer conversion.
+ */
+__declspec(naked) void
+_ftol2 (
+ void
+ )
+{
+ _asm {
+ fistp qword ptr [esp-8]
+ mov edx, [esp-4]
+ mov eax, [esp-8]
+ ret
+ }
+}
+
+__declspec(naked) void
+_ftol2_sse (
+ void
+ )
+{
+ _asm {
+ fistp dword ptr [esp-4]
+ mov eax,[esp-4]
+ ret
+ }
+}
diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
index 69b6bf39f5..b95e8bfdc7 100644
--- a/RedfishPkg/RedfishPkg.ci.yaml
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -2,6 +2,7 @@
# CI configuration for NetworkPkg
#
# (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
+# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
@@ -38,6 +39,7 @@
"PrivateInclude/Crt/string.h",
"PrivateInclude/Crt/time.h",
"PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c",
+ "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c",
"Include/Library/RedfishCrtLib.h",
##
## For jansson library open source
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115631): https://edk2.groups.io/g/devel/message/115631
Mute This Topic: https://groups.io/mt/104463409/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue
2024-02-20 6:41 [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Nickle Wang via groups.io
@ 2024-02-21 2:10 ` Chang, Abner via groups.io
2024-02-22 9:15 ` Nickle Wang via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Chang, Abner via groups.io @ 2024-02-21 2:10 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Igor Kulchytskyy, Nick Ramirez
[AMD Official Use Only - General]
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, February 20, 2024 2:42 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> symbol issue
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> -Fix below compiler error reported in edk2 CI.
> ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
> symbol __ftol2
> -The file MathFtol.c is copied from IntrinsicLib in CryptoPkg.
> -Add MathFtol.c to EccCheck IgnoreFiles.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
> .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++-
> .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++
> RedfishPkg/RedfishPkg.ci.yaml | 2 +
> 3 files changed, 45 insertions(+), 1 deletion(-)
> create mode 100644
> RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
>
> diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> index 6ff5dba75c..3a5e309d1a 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> @@ -3,6 +3,7 @@
> #
> # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> # (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -23,6 +24,9 @@
> [Sources]
> RedfishCrtLib.c
>
> +[Sources.IA32]
> + Ia32/MathFtol.c | MSFT
> +
> [LibraryClasses]
> BaseLib
> SortLib
> @@ -35,4 +39,5 @@
> MdeModulePkg/MdeModulePkg.dec
> RedfishPkg/RedfishPkg.dec
>
> -
> +[BuildOptions]
> + MSFT:*_*_IA32_CC_FLAGS = /GL-
> diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> new file mode 100644
> index 0000000000..adfe249b1d
> --- /dev/null
> +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> @@ -0,0 +1,37 @@
> +/** @file
Hi Nickle,
Could you please add the information here after @file about where this file or the source code come from, such as the location of original file?
Thanks
Abner
> + 64-bit Math Worker Function.
> + The 32-bit versions of C compiler generate calls to library routines
> + to handle 64-bit math. These functions use non-standard calling
> conventions.
> +
> +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +/*
> + * Floating point to integer conversion.
> + */
> +__declspec(naked) void
> +_ftol2 (
> + void
> + )
> +{
> + _asm {
> + fistp qword ptr [esp-8]
> + mov edx, [esp-4]
> + mov eax, [esp-8]
> + ret
> + }
> +}
> +
> +__declspec(naked) void
> +_ftol2_sse (
> + void
> + )
> +{
> + _asm {
> + fistp dword ptr [esp-4]
> + mov eax,[esp-4]
> + ret
> + }
> +}
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
> index 69b6bf39f5..b95e8bfdc7 100644
> --- a/RedfishPkg/RedfishPkg.ci.yaml
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -2,6 +2,7 @@
> # CI configuration for NetworkPkg
> #
> # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> {
> @@ -38,6 +39,7 @@
> "PrivateInclude/Crt/string.h",
> "PrivateInclude/Crt/time.h",
> "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c",
> + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c",
> "Include/Library/RedfishCrtLib.h",
> ##
> ## For jansson library open source
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115696): https://edk2.groups.io/g/devel/message/115696
Mute This Topic: https://groups.io/mt/104463409/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue
2024-02-21 2:10 ` Chang, Abner via groups.io
@ 2024-02-22 9:15 ` Nickle Wang via groups.io
2024-02-22 13:37 ` Chang, Abner via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Nickle Wang via groups.io @ 2024-02-22 9:15 UTC (permalink / raw)
To: Chang, Abner, devel@edk2.groups.io; +Cc: Igor Kulchytskyy, Nick Ramirez
Hi Abner,
Please check v2 patch. I add the source location of MathFtol.c
Thanks,
Nickle
> -----Original Message-----
> From: Chang, Abner <Abner.Chang@amd.com>
> Sent: Wednesday, February 21, 2024 10:10 AM
> To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> symbol issue
>
> External email: Use caution opening links or attachments
>
>
> [AMD Official Use Only - General]
>
> > -----Original Message-----
> > From: Nickle Wang <nicklew@nvidia.com>
> > Sent: Tuesday, February 20, 2024 2:42 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> > symbol issue
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > -Fix below compiler error reported in edk2 CI.
> > ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
> > symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in
> > CryptoPkg.
> > -Add MathFtol.c to EccCheck IgnoreFiles.
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Cc: Nick Ramirez <nramirez@nvidia.com>
> > ---
> > .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++-
> > .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++
> > RedfishPkg/RedfishPkg.ci.yaml | 2 +
> > 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644
> > RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> >
> > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > index 6ff5dba75c..3a5e309d1a 100644
> > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > @@ -3,6 +3,7 @@
> > #
> > # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > reserved.
> > #
> > # SPDX-License-Identifier: BSD-2-Clause-Patent
> > #
> > @@ -23,6 +24,9 @@
> > [Sources]
> > RedfishCrtLib.c
> >
> > +[Sources.IA32]
> > + Ia32/MathFtol.c | MSFT
> > +
> > [LibraryClasses]
> > BaseLib
> > SortLib
> > @@ -35,4 +39,5 @@
> > MdeModulePkg/MdeModulePkg.dec
> > RedfishPkg/RedfishPkg.dec
> >
> > -
> > +[BuildOptions]
> > + MSFT:*_*_IA32_CC_FLAGS = /GL-
> > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > new file mode 100644
> > index 0000000000..adfe249b1d
> > --- /dev/null
> > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > @@ -0,0 +1,37 @@
> > +/** @file
>
> Hi Nickle,
> Could you please add the information here after @file about where this file or the
> source code come from, such as the location of original file?
> Thanks
> Abner
>
>
> > + 64-bit Math Worker Function.
> > + The 32-bit versions of C compiler generate calls to library
> > + routines to handle 64-bit math. These functions use non-standard
> > + calling
> > conventions.
> > +
> > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +/*
> > + * Floating point to integer conversion.
> > + */
> > +__declspec(naked) void
> > +_ftol2 (
> > + void
> > + )
> > +{
> > + _asm {
> > + fistp qword ptr [esp-8]
> > + mov edx, [esp-4]
> > + mov eax, [esp-8]
> > + ret
> > + }
> > +}
> > +
> > +__declspec(naked) void
> > +_ftol2_sse (
> > + void
> > + )
> > +{
> > + _asm {
> > + fistp dword ptr [esp-4]
> > + mov eax,[esp-4]
> > + ret
> > + }
> > +}
> > diff --git a/RedfishPkg/RedfishPkg.ci.yaml
> > b/RedfishPkg/RedfishPkg.ci.yaml index 69b6bf39f5..b95e8bfdc7 100644
> > --- a/RedfishPkg/RedfishPkg.ci.yaml
> > +++ b/RedfishPkg/RedfishPkg.ci.yaml
> > @@ -2,6 +2,7 @@
> > # CI configuration for NetworkPkg
> > #
> > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > reserved.
> > # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -38,6 +39,7
> > @@
> > "PrivateInclude/Crt/string.h",
> > "PrivateInclude/Crt/time.h",
> > "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c",
> > + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c",
> > "Include/Library/RedfishCrtLib.h",
> > ##
> > ## For jansson library open source
> > --
> > 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115780): https://edk2.groups.io/g/devel/message/115780
Mute This Topic: https://groups.io/mt/104463409/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue
2024-02-22 9:15 ` Nickle Wang via groups.io
@ 2024-02-22 13:37 ` Chang, Abner via groups.io
0 siblings, 0 replies; 4+ messages in thread
From: Chang, Abner via groups.io @ 2024-02-22 13:37 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Igor Kulchytskyy, Nick Ramirez
[AMD Official Use Only - General]
Thanks!
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, February 22, 2024 5:16 PM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> symbol issue
>
> [AMD Official Use Only - General]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> Please check v2 patch. I add the source location of MathFtol.c
>
> Thanks,
> Nickle
>
> > -----Original Message-----
> > From: Chang, Abner <Abner.Chang@amd.com>
> > Sent: Wednesday, February 21, 2024 10:10 AM
> > To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
> > Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez
> <nramirez@nvidia.com>
> > Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> > symbol issue
> >
> > External email: Use caution opening links or attachments
> >
> >
> > [AMD Official Use Only - General]
> >
> > > -----Original Message-----
> > > From: Nickle Wang <nicklew@nvidia.com>
> > > Sent: Tuesday, February 20, 2024 2:42 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> > > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> > > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external
> > > symbol issue
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > -Fix below compiler error reported in edk2 CI.
> > > ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external
> > > symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in
> > > CryptoPkg.
> > > -Add MathFtol.c to EccCheck IgnoreFiles.
> > >
> > > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > Cc: Nick Ramirez <nramirez@nvidia.com>
> > > ---
> > > .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++-
> > > .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++++
> > > RedfishPkg/RedfishPkg.ci.yaml | 2 +
> > > 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644
> > > RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > >
> > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > index 6ff5dba75c..3a5e309d1a 100644
> > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > @@ -3,6 +3,7 @@
> > > #
> > > # Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > > reserved.
> > > #
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent
> > > #
> > > @@ -23,6 +24,9 @@
> > > [Sources]
> > > RedfishCrtLib.c
> > >
> > > +[Sources.IA32]
> > > + Ia32/MathFtol.c | MSFT
> > > +
> > > [LibraryClasses]
> > > BaseLib
> > > SortLib
> > > @@ -35,4 +39,5 @@
> > > MdeModulePkg/MdeModulePkg.dec
> > > RedfishPkg/RedfishPkg.dec
> > >
> > > -
> > > +[BuildOptions]
> > > + MSFT:*_*_IA32_CC_FLAGS = /GL-
> > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > > new file mode 100644
> > > index 0000000000..adfe249b1d
> > > --- /dev/null
> > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c
> > > @@ -0,0 +1,37 @@
> > > +/** @file
> >
> > Hi Nickle,
> > Could you please add the information here after @file about where this file
> or the
> > source code come from, such as the location of original file?
> > Thanks
> > Abner
> >
> >
> > > + 64-bit Math Worker Function.
> > > + The 32-bit versions of C compiler generate calls to library
> > > + routines to handle 64-bit math. These functions use non-standard
> > > + calling
> > > conventions.
> > > +
> > > +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +
> > > +**/
> > > +
> > > +/*
> > > + * Floating point to integer conversion.
> > > + */
> > > +__declspec(naked) void
> > > +_ftol2 (
> > > + void
> > > + )
> > > +{
> > > + _asm {
> > > + fistp qword ptr [esp-8]
> > > + mov edx, [esp-4]
> > > + mov eax, [esp-8]
> > > + ret
> > > + }
> > > +}
> > > +
> > > +__declspec(naked) void
> > > +_ftol2_sse (
> > > + void
> > > + )
> > > +{
> > > + _asm {
> > > + fistp dword ptr [esp-4]
> > > + mov eax,[esp-4]
> > > + ret
> > > + }
> > > +}
> > > diff --git a/RedfishPkg/RedfishPkg.ci.yaml
> > > b/RedfishPkg/RedfishPkg.ci.yaml index 69b6bf39f5..b95e8bfdc7 100644
> > > --- a/RedfishPkg/RedfishPkg.ci.yaml
> > > +++ b/RedfishPkg/RedfishPkg.ci.yaml
> > > @@ -2,6 +2,7 @@
> > > # CI configuration for NetworkPkg
> > > #
> > > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> > > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > > reserved.
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -38,6 +39,7
> > > @@
> > > "PrivateInclude/Crt/string.h",
> > > "PrivateInclude/Crt/time.h",
> > > "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c",
> > > + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c",
> > > "Include/Library/RedfishCrtLib.h",
> > > ##
> > > ## For jansson library open source
> > > --
> > > 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115814): https://edk2.groups.io/g/devel/message/115814
Mute This Topic: https://groups.io/mt/104463409/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-22 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 6:41 [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Nickle Wang via groups.io
2024-02-21 2:10 ` Chang, Abner via groups.io
2024-02-22 9:15 ` Nickle Wang via groups.io
2024-02-22 13:37 ` Chang, Abner via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox