From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E815C74007A for ; Thu, 22 Feb 2024 13:37:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8EHcUZPmhsxZrMn7Vw/1bhmn08s7VoZxzGk6GwM/XNI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708609073; v=1; b=eblLwMrR2K+dnaeLYqG9bwTPOrZKlc/j/gbxabkEccR/NSprBUygKll638SolVKeaMflSIlK t3LFG0bu3VUnglbZd8GvgKJ37ZcOvX1Sd4ykADVAkeaDROPy64hCfShwsJqwtr9TOgLSDTisF/0 s+4w05JvACEfhcOTJ6XnSo+M= X-Received: by 127.0.0.2 with SMTP id nI2RYY7687511xDcM0H9HgRC; Thu, 22 Feb 2024 05:37:53 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.40]) by mx.groups.io with SMTP id smtpd.web11.12742.1708609072910223896 for ; Thu, 22 Feb 2024 05:37:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYtGLu/EQkiTXeYpS7mx8j90vH6S7NoK9hTNEb1gPN+0/Bwpn7GlVY1lq0W0nkTVUGEFnXvDGegYW+dZUaRAMhxE2Wnkz6f0H4qTUsrszD2QLuu/S0dmzK3DvUVvvZR6cs3oC/r71SJL64YN0Sg261i/NbiUj/fFK5BaIMfZfeX4g3Mpg3hayqjlR7jtP6SbbE5UNGhv8pCVxlfrVW6Pt+/wLr17IJQ3ttclzA2JFGB6cK8BXKZNJf1ryC6CyWz45FmnZT+eIVaqWAZg+1k9/tQRGtgmNWEv224HcKMbFQU5BzWdo3yGqSat2oQp0/oLb0E5F2N8RMLjp1mQhaIhqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcGX04x4CKIXIUYzrASfIpzg3ZwGK7QMFDaQG8CDzvM=; b=jVjEMBbEa4r6r8YzTIGyPfEDc69MHkT8sL3FruqcO9bprHd8gYfYzsCaUs4/GrXOIt60jzTehT/Vdnn0hAr+1+ZZsE8PlJRzZOIIBNnhLoyistJ1cELk92dBQ7ifB2YYfhNe9wMOPAtO5n1s7lpFhVG9s2hoUhbYIhP6/qxN64CCpC8k4VeznVHCJCeby/uPDABydLOPCvudjzq32PNdrzocK1QORpA08VQ49bxGvB1d1G7rO7+bFTlCkIa05yEARvrmKWXs708yhgIfUEShiNJjixB/VuMTscL7TSNx/VId6KmpQKIlpacgmDLj8pFtDN1h3vil/rkeuRXjIkxfyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by SA1PR12MB8094.namprd12.prod.outlook.com (2603:10b6:806:336::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Thu, 22 Feb 2024 13:37:49 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::7654:cffb:1938:3995]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::7654:cffb:1938:3995%4]) with mapi id 15.20.7316.023; Thu, 22 Feb 2024 13:37:48 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Thread-Topic: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue Thread-Index: AQHaY8frA5J+3l8aDUyCtPEZHqTEGrEUDdrwgAIJw7CAAElw8A== Date: Thu, 22 Feb 2024 13:37:48 +0000 Message-ID: References: <20240220064153.28651-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d1376242-3c78-4049-a8b4-421c4d78827d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-21T02:07:23Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|SA1PR12MB8094:EE_ x-ms-office365-filtering-correlation-id: 489e945a-325c-43d0-1747-08dc33ab75d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: vUv4BI0sibuW0YLAcgXUAOeBbCG/PZo2zMSLgt9Gm/myxtrQzMPMyV7ipSFE02ZKifO9HWCPwqyLBR5qGnDsBAQwCKazv5acW2n9+H+oqCxhNhz+SAsxrrtw0a3+0MiXp3HL0gPQUeoZZUJNCWK2hQp/2twxj48y2HdU1Mg9Cm6s8Ync8LQij+KHWtAOoLjrw3vjqqPPwBou63QeNkI4w8D3MyyUMzGA5kRmswe8IyGqliCWGex2n41u02ep7snOS3y5Ti4JlfGng7fa4BvN6XWxpfozAYvFCZ/xjqRzqGDHe7+nBQDkZlk2oayVjI7IGWqs4+7Y8zwLyO6IEEyzJzqJjakArEIGXnG5V6dRScAjt/xdbMSOMTNeUNq4KsTRsMUHA6sc9CsBpev2yv0O1eqz1Xt6vCC2YVMl527eLAP7SNc+rH2IqGcMCjlTjzVwe43GaZ44pWNeZIveDIha7o7HrcRwUzm7fHROw8BgxKKi49yLP56TA6YBBsLTyCwf3ISgs9asdSBuFZEPc35cQBH8VxB9D8aJFr7co92PEUMAJn2WcJaZzmf4wasQ5+imXDoBBiiuSXk2SoIpiXwFZkEEf4UbWy7EX7SjDZ33dAz6t7jVmbg8t6DbsUX7fb2m x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C1ChRWKeNx//+zIPayNVLZmsdegZ+hCEL/V2IetGUn9dTdzmCvXwVW9Ak6NJ?= =?us-ascii?Q?KMjI5IizTQo4SZiskZD1n1CU6PvPeKcMZAK9/9P6lQ8aYEeYC8EEr2SaWsif?= =?us-ascii?Q?nA6aTaMN+AYFj088EpQQd7GKGb0jMkAvXKpL8D9rTIZn7qXjuE1AoGWl9rsb?= =?us-ascii?Q?jhrDfyMCdCGtvvnR0M3FVBXGqmg1ICV5flzgmB9O1CXtvQYhw0VWDy0sKr8Y?= =?us-ascii?Q?RKXhHE4lU9syl51wnLIEdoO2ksyIJ1iiVDFjn1By1XKeS++wQqvUnedaaNt3?= =?us-ascii?Q?wWf1/q4FX18jgUNYWgKXS4BWkOkVx76pJ4x146cEvZ/DsPPHDcY7FrKw+ZUN?= =?us-ascii?Q?Pif8LCkVFg5DdPn/1y8umuZGP5TisgFSq8xlv+v7IJwm/5gDHGX9Oe57AcBv?= =?us-ascii?Q?s8j4vCUpxN5Mvj6QQN+KuF7eaUC88Qs56TAtvVUyLpGeb5MNAbPB+d9ayQHH?= =?us-ascii?Q?gOpudVyQND/pkltaOCpypuZOZF5gcAaVtaeEHTlSJeJHSZ+7jx2htKpM7uBK?= =?us-ascii?Q?4darE7Y4xUYBmc681iop2MOXBsLJwyn5BeeG8NFfsEGuL+p4hpFordN5sEbC?= =?us-ascii?Q?nA4pzZyWCh8w6qy9Wf7x2qXfsOwKc40UGbbnOwQuYK3pUe78AtGFfVUw3QT3?= =?us-ascii?Q?CXg6UtRxkTxRlnxKUUZJgCYSQ3Jhys4NaAVtOM2pl013ACqzYnKQjEp0pzzE?= =?us-ascii?Q?kIJvQc7auDOC2KffjjfYwN7xlIjDSK/azrpdWUKASZRF3jAFOjvFm8lR2Vx/?= =?us-ascii?Q?jJ2DOeEB72ccMhwjGX34WhfxuKNLtF+/Oyzyta6qMnAvDoJwsbmOWtrkaDg+?= =?us-ascii?Q?2wEHDOtFhQa7epg6roCTMtR99xQ9GomSnNOHfYW4L491dgTtFOQFviIbSBYo?= =?us-ascii?Q?ISjwsaVrezu9ZF5KgIkDeyBvutUSULhCs8nN6tlH/Luu04Bf5S9FwMmUwdhp?= =?us-ascii?Q?fnJHapbpGtuj0otWhFl/FNg6U8tFB16lfzpUmnr/tnhIT1T9AZT3SMI9OCxt?= =?us-ascii?Q?9iBLTlZVozgrxpItzvatEA7DQqpvUf4+l6krzzllpxqEXiB83ZHXnfc64/V2?= =?us-ascii?Q?BAPpIuNA9I3sILHnXIgkNHopgOz0e1DkyQ8czv+WZWZW24/jvqacmXaB6g4k?= =?us-ascii?Q?GphHGOJOOk5lLf9dfR14j2Z3hL0sTp4sAH/2XFseXN93FqdRljpPQGZ2nQqM?= =?us-ascii?Q?RJWUvIF3hir2YqDH7K8Rp9WLHbGunqlIGbwnqosg73JdtmAft2+BecZib5R9?= =?us-ascii?Q?C5r+3k6eTV51aOCuJYl2ctmpHjxSbtvM/kLyRIPTtOIPF3MsCqB0ByAfuyDp?= =?us-ascii?Q?xVbUxvxesq9u/iRMYCZPYyPJL8lJSSFDClHHkJ5wjqJKLo8MnDwbNpuA5NbZ?= =?us-ascii?Q?3Qyi9ete9KhaJEoidTIDxqEMyrSVhaDrxCSFCu77vl7C7/orSEkxWaCqGHKw?= =?us-ascii?Q?Unze88Gtc9PK6bWkOmyxZp8Lo+Lm4E/AoQOCi1ZQr7QKWceW8/MgeaW+OygY?= =?us-ascii?Q?34MfQz0ZODCpTaf0VhhwJzuBqDz4dBdscn13Gm0wZvbV+J7uCv8uOTpHlU6w?= =?us-ascii?Q?iVePamytAQrUzGi+lfI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 489e945a-325c-43d0-1747-08dc33ab75d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 13:37:48.8887 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aQHM0AHstzf9OLHhh9hy3YTO+e7fcttjBd4MNcbIxU/oVy+EOvYS2sKpLoDtp/+xc6H4dZML3Vbln1NJBOsyRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8094 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UtokPeEiSXNsoG1FQjfqTpWIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=eblLwMrR; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Thanks! Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, February 22, 2024 5:16 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved externa= l > symbol issue > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi Abner, > > Please check v2 patch. I add the source location of MathFtol.c > > Thanks, > Nickle > > > -----Original Message----- > > From: Chang, Abner > > Sent: Wednesday, February 21, 2024 10:10 AM > > To: Nickle Wang ; devel@edk2.groups.io > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > Subject: RE: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved exter= nal > > symbol issue > > > > External email: Use caution opening links or attachments > > > > > > [AMD Official Use Only - General] > > > > > -----Original Message----- > > > From: Nickle Wang > > > Sent: Tuesday, February 20, 2024 2:42 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > ; Nick Ramirez > > > Subject: [PATCH 6/6] RedfishPkg/RedfishCrtLib: fix unresolved externa= l > > > symbol issue > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > -Fix below compiler error reported in edk2 CI. > > > ERROR - Linker #2001 from JsonLib.lib(load.obj) : unresolved external > > > symbol __ftol2 -The file MathFtol.c is copied from IntrinsicLib in > > > CryptoPkg. > > > -Add MathFtol.c to EccCheck IgnoreFiles. > > > > > > Signed-off-by: Nickle Wang > > > Cc: Abner Chang > > > Cc: Igor Kulchytskyy > > > Cc: Nick Ramirez > > > --- > > > .../RedfishCrtLib/RedfishCrtLib.inf | 7 +++- > > > .../RedfishCrtLib/Ia32/MathFtol.c | 37 +++++++++++++++++= ++ > > > RedfishPkg/RedfishPkg.ci.yaml | 2 + > > > 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.in= f > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > index 6ff5dba75c..3a5e309d1a 100644 > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > @@ -3,6 +3,7 @@ > > > # > > > # Copyright (c) 2019, Intel Corporation. All rights reserved.
# > > > (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > > > reserved. > > > # > > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > > # > > > @@ -23,6 +24,9 @@ > > > [Sources] > > > RedfishCrtLib.c > > > > > > +[Sources.IA32] > > > + Ia32/MathFtol.c | MSFT > > > + > > > [LibraryClasses] > > > BaseLib > > > SortLib > > > @@ -35,4 +39,5 @@ > > > MdeModulePkg/MdeModulePkg.dec > > > RedfishPkg/RedfishPkg.dec > > > > > > - > > > +[BuildOptions] > > > + MSFT:*_*_IA32_CC_FLAGS =3D /GL- > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > > new file mode 100644 > > > index 0000000000..adfe249b1d > > > --- /dev/null > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c > > > @@ -0,0 +1,37 @@ > > > +/** @file > > > > Hi Nickle, > > Could you please add the information here after @file about where this = file > or the > > source code come from, such as the location of original file? > > Thanks > > Abner > > > > > > > + 64-bit Math Worker Function. > > > + The 32-bit versions of C compiler generate calls to library > > > + routines to handle 64-bit math. These functions use non-standard > > > + calling > > > conventions. > > > + > > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent > > > + > > > +**/ > > > + > > > +/* > > > + * Floating point to integer conversion. > > > + */ > > > +__declspec(naked) void > > > +_ftol2 ( > > > + void > > > + ) > > > +{ > > > + _asm { > > > + fistp qword ptr [esp-8] > > > + mov edx, [esp-4] > > > + mov eax, [esp-8] > > > + ret > > > + } > > > +} > > > + > > > +__declspec(naked) void > > > +_ftol2_sse ( > > > + void > > > + ) > > > +{ > > > + _asm { > > > + fistp dword ptr [esp-4] > > > + mov eax,[esp-4] > > > + ret > > > + } > > > +} > > > diff --git a/RedfishPkg/RedfishPkg.ci.yaml > > > b/RedfishPkg/RedfishPkg.ci.yaml index 69b6bf39f5..b95e8bfdc7 100644 > > > --- a/RedfishPkg/RedfishPkg.ci.yaml > > > +++ b/RedfishPkg/RedfishPkg.ci.yaml > > > @@ -2,6 +2,7 @@ > > > # CI configuration for NetworkPkg > > > # > > > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> > > +# Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights > > > reserved. > > > # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -38,6 +39,7 > > > @@ > > > "PrivateInclude/Crt/string.h", > > > "PrivateInclude/Crt/time.h", > > > "PrivateLibrary/RedfishCrtLib/RedfishCrtLib.c", > > > + "PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c", > > > "Include/Library/RedfishCrtLib.h", > > > ## > > > ## For jansson library open source > > > -- > > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115814): https://edk2.groups.io/g/devel/message/115814 Mute This Topic: https://groups.io/mt/104463409/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-