public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Nickle Wang <nicklew@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
	Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function
Date: Thu, 16 May 2024 01:07:30 +0000	[thread overview]
Message-ID: <LV8PR12MB94526E3E7B88257B866BC7BCEAED2@LV8PR12MB9452.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MW4SPRMB00245E1421F00D1128698C74D9ED2@MW4SPRMB0024.namprd12.prod.outlook.com>

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks! Will merge later after the hard freeze.

Abner

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, May 16, 2024 9:04 AM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Nick
> Ramirez <nramirez@nvidia.com>
> Subject: RE: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file
> for OEM net function
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Yes, this is pull request: https://github.com/tianocore/edk2/pull/5660
>
> Thanks,
> Nickle
>
> > -----Original Message-----
> > From: Chang, Abner <Abner.Chang@amd.com>
> > Sent: Thursday, May 16, 2024 9:01 AM
> > To: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>
> > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Nick
> > Ramirez <nramirez@nvidia.com>
> > Subject: RE: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file
> for
> > OEM net function
> >
> > External email: Use caution opening links or attachments
> >
> >
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > Hi Nickle,
> > Do you have the corresponding PR for this? I will merge it after hard freeze.
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle
> > > Wang via groups.io
> > > Sent: Wednesday, May 15, 2024 4:50 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLateef (Abdul
> > > Lateef) <AbdulLateef.Attar@amd.com>; Nick Ramirez
> > > <nramirez@nvidia.com>
> > > Subject: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file
> > > for OEM net function
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > Add net function definitions for OEM/Non-IPMI group request and
> > > response
> > >
> > > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > > Cc: Nick Ramirez <nramirez@nvidia.com>
> > > ---
> > >  MdePkg/Include/IndustryStandard/IpmiNetFnOem.h | 18
> > > ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >  create mode 100644
> MdePkg/Include/IndustryStandard/IpmiNetFnOem.h
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnOem.h
> > > b/MdePkg/Include/IndustryStandard/IpmiNetFnOem.h
> > > new file mode 100644
> > > index 0000000000..48c5dbd803
> > > --- /dev/null
> > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnOem.h
> > > @@ -0,0 +1,18 @@
> > > +/** @file
> > > +  IPMI 2.0 definitions from the IPMI Specification Version 2.0, Revision
> 1.1.
> > > +
> > > +  Copyright (c) 2024, NVIDIA CORPORATION & AFFILIATES. All rights
> > > reserved.
> > > +
> > > +  SPDX-License-Identifier: BSD-2-Clause-Patent **/
> > > +
> > > +#ifndef IPMI_NET_FN_OEM_H_
> > > +#define IPMI_NET_FN_OEM_H_
> > > +
> > > +//
> > > +// Net function definition for OEM/Group command //
> > > +#define IPMI_NETFN_OEM        0x2E
> > > +#define IPMI_NETFN_OEM_GROUP  0x2F
> > > +
> > > +#endif
> > > --
> > > 2.34.1
> > >
> > >
> > >
> > > 
> > >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118937): https://edk2.groups.io/g/devel/message/118937
Mute This Topic: https://groups.io/mt/106110708/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-05-16  1:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15  8:50 [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function Nickle Wang via groups.io
2024-05-16  1:00 ` Chang, Abner via groups.io
2024-05-16  1:03   ` Nickle Wang via groups.io
2024-05-16  1:07     ` Chang, Abner via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=LV8PR12MB94526E3E7B88257B866BC7BCEAED2@LV8PR12MB9452.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox