Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

I guess my RB misled contributors thought the patch is good to merge. However, I was thinking Eric's team should give the final RB after the validation as they are the maintainers for the subordinate VanGoghBoard platform. Suppose the impacted packages should be built successfully with the patches applied, as this is considered the base requirement of the code change. Nevertheless, the special build sauce for VanGoghBoard may be not easy for contributors to verify the build.

Eric, I have few suggestions for this failure, for the short term, you can commit another change to remove this change, as the build failure has impacts on our customer support. You can decide to recover this or not depends on your business requirement.
For the long term, besides of code base upgrade, we could consider to revise VanGoghBoard to use native edk2 build script. Maybe we can leverage prebuild mechanism to cover the platform specific build requirements.

Thanks
Abner


> -----Original Message-----
> From: Xing, Eric <Eric.Xing@amd.com>
> Sent: Friday, April 19, 2024 7:32 PM
> To: Ard Biesheuvel <ardb@kernel.org>
> Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) <duke.zhai@amd.com>;
> Lendacky, Thomas <Thomas.Lendacky@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>; Yao, Ken <Ken.Yao@amd.com>; Roth, Michael
> <Michael.Roth@amd.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Gerd Hoffmann <kraxel@redhat.com>; Min Xu <min.m.xu@intel.com>; Leif
> Lindholm <quic_llindhol@quicinc.com>
> Subject: RE: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> [AMD Official Use Only - General]
>
> Hi Ard,
>
> Agree with you, reverting code looks not a good way now. We will think about
> new method to resolve this issue. Just need a bit more time and I will hold on
> checking in code to VanGoghBoard before it.
> Thanks again for your suggestion and help us improve code in VanGoghBoard.
>
> Thanks,
> Eric
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> > Sent: Friday, April 19, 2024 5:25 PM
> > To: Xing, Eric <Eric.Xing@amd.com>
> > Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) <duke.zhai@amd.com>;
> > Lendacky, Thomas <Thomas.Lendacky@amd.com>; Chang, Abner
> > <Abner.Chang@amd.com>; Yao, Ken <Ken.Yao@amd.com>; Roth, Michael
> > <Michael.Roth@amd.com>; Attar, AbdulLateef (Abdul Lateef)
> > <AbdulLateef.Attar@amd.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Min
> > Xu <min.m.xu@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>
> > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> > required DSC files
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > On Fri, 19 Apr 2024 at 11:06, Xing, Eric <Eric.Xing@amd.com> wrote:
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Hi Ard,
> > >
> > > This checkin causes VanGoghBoard build fail now. Would you help revert it?
> > > I will merge PATCH to VanGoghBoard after the code review process done
> > and code changes are verified pass on real board.
> > >
> >
> > Please provide a solution instead that makes upstream edk2 work with
> > upstream edk2-platforms.
> >
> > For downstream builds, you can combine the old EDK2_202208 with an older
> > checkout of edk2-platforms, right?



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118028): https://edk2.groups.io/g/devel/message/118028
Mute This Topic: https://groups.io/mt/105537744/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-