public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
	"Grimes, Paul" <Paul.Grimes@amd.com>
Subject: Re: [edk2-devel] [RESEND 0/7] AmdPlatformPkg: Adds board independent modules
Date: Wed, 15 May 2024 03:59:01 +0000	[thread overview]
Message-ID: <LV8PR12MB945277B5AF93662FCF6F2BEBEAEC2@LV8PR12MB9452.namprd12.prod.outlook.com> (raw)
In-Reply-To: <cover.1715744867.git.AbdulLateef.Attar@amd.com>

[AMD Official Use Only - AMD Internal Distribution Only]

Already reviewed off-line.
For this patch set, Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Wednesday, May 15, 2024 11:50 AM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Chang,
> Abner <Abner.Chang@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>
> Subject: [RESEND 0/7] AmdPlatformPkg: Adds board independent modules
>
> PR: https://github.com/tianocore/edk2-platforms/pull/141
> Adds various libraries and drivers for AMD Platform.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Paul Grimes <paul.grimes@amd.com>
>
> Abdul Lateef Attar (7):
>   AmdPlatformPkg: Adds LogoDxe driver
>   AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library
>   AmdPlatformPkg: Implements SerialPortLib for simulator
>   AmdPlatformPkg: Adds PlatformSocLib library class
>   AmdPlatformPkg: Adds AmdConfigRouting driver
>   AmdPlatformPkg: Adds SecureBootDefaultKeysInit driver
>   AmdPlatformPkg: Adds ACPI common driver
>
>  .../AMD/AmdPlatformPkg/AmdPlatformPkg.dec     |   30 +-
>  .../AMD/AmdPlatformPkg/AmdPlatformPkg.dsc     |   56 +-
>  .../Include/Library/AmdPlatformSocLib.h       |  134 ++
>  .../BaseAlwaysFalseDepexLib.c                 |   20 +
>  .../BaseAlwaysFalseDepexLib.inf               |   35 +
>  .../BaseAlwaysFalseDepexLib.uni               |   12 +
>  .../DxePlatformSocLib/DxePlatformSocLibNull.c |   75 +
>  .../DxePlatformSocLibNull.inf                 |   26 +
>  .../DxePlatformSocLibNull.uni                 |   13 +
>  .../SimulatorSerialPortLibPort80.c            |  208 +++
>  .../SimulatorSerialPortLibPort80.inf          |   31 +
>  .../Universal/Acpi/AcpiCommon/AcpiCommon.c    |  226 +++
>  .../Universal/Acpi/AcpiCommon/AcpiCommon.h    |  118 ++
>  .../Universal/Acpi/AcpiCommon/AcpiCommon.inf  |   74 +
>  .../Universal/Acpi/AcpiCommon/CpuSsdt.c       |  345 ++++
>  .../Universal/Acpi/AcpiCommon/PciSsdt.c       | 1381 +++++++++++++++++
>  .../Universal/Acpi/AcpiCommon/Spmi.c          |  111 ++
>  .../HiiConfigRouting/AmdConfigRouting.inf     |   45 +
>  .../HiiConfigRouting/AmdConfigRoutingEntry.c  |   57 +
>  .../HiiConfigRouting/AmdHiiConfigRouting.c    | 1101 +++++++++++++
>  .../HiiConfigRouting/AmdHiiConfigRouting.h    |  189 +++
>  .../Universal/LogoDxe/LogoDxe/JpegLogo.idf    |   10 +
>  .../Universal/LogoDxe/LogoDxe/JpegLogoDxe.inf |   57 +
>  .../Universal/LogoDxe/LogoDxe/Logo.bmp        |  Bin 0 -> 522054 bytes
>  .../Universal/LogoDxe/LogoDxe/Logo.c          |  194 +++
>  .../Universal/LogoDxe/LogoDxe/Logo.h          |   23 +
>  .../Universal/LogoDxe/LogoDxe/Logo.idf        |   10 +
>  .../Universal/LogoDxe/LogoDxe/Logo.jpg        |  Bin 0 -> 75403 bytes
>  .../Universal/LogoDxe/LogoDxe/LogoDxe.inf     |   58 +
>  .../Universal/LogoDxe/LogoDxe/S3Logo.bmp      |  Bin 0 -> 964114 bytes
>  .../Universal/LogoDxe/LogoDxe/S3Logo.idf      |   10 +
>  .../Universal/LogoDxe/LogoDxe/S3LogoDxe.inf   |   57 +
>  .../SecureBootDefaultKeysInit.c               |  645 ++++++++
>  .../SecureBootDefaultKeysInit.inf             |   49 +
>  34 files changed, 5396 insertions(+), 4 deletions(-)
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Include/Library/AmdPlatformSocLib.h
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/BaseAlwaysFalseDepexLib/BaseAlwa
> ysFalseDepexLib.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/BaseAlwaysFalseDepexLib/BaseAlwa
> ysFalseDepexLib.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/BaseAlwaysFalseDepexLib/BaseAlwa
> ysFalseDepexLib.uni
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/DxePlatformSocLib/DxePlatformSocL
> ibNull.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/DxePlatformSocLib/DxePlatformSocL
> ibNull.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/DxePlatformSocLib/DxePlatformSocL
> ibNull.uni
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/SimulatorSerialPortLibPort80/Simula
> torSerialPortLibPort80.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Library/SimulatorSerialPortLibPort80/Simula
> torSerialPortLibPort80.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/AcpiCommon.
> c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/AcpiCommon.
> h
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/AcpiCommon.
> inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/CpuSsdt.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/PciSsdt.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/Acpi/AcpiCommon/Spmi.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/HiiConfigRouting/AmdConfigRou
> ting.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/HiiConfigRouting/AmdConfigRou
> tingEntry.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/HiiConfigRouting/AmdHiiConfigR
> outing.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/HiiConfigRouting/AmdHiiConfigR
> outing.h
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/JpegLogo.idf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/JpegLogoDxe.i
> nf
>  create mode 100755
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/Logo.bmp
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/Logo.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/Logo.h
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/Logo.idf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/Logo.jpg
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/LogoDxe.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/S3Logo.bmp
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/S3Logo.idf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/LogoDxe/LogoDxe/S3LogoDxe.inf
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/SecureBoot/SecureBootDefaultKe
> ysInit/SecureBootDefaultKeysInit.c
>  create mode 100644
> Platform/AMD/AmdPlatformPkg/Universal/SecureBoot/SecureBootDefaultKe
> ysInit/SecureBootDefaultKeysInit.inf
>
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118908): https://edk2.groups.io/g/devel/message/118908
Mute This Topic: https://groups.io/mt/106108329/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-05-15  3:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15  3:50 [edk2-devel] [RESEND 0/7] AmdPlatformPkg: Adds board independent modules Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 1/7] AmdPlatformPkg: Adds LogoDxe driver Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 2/7] AmdPlatformPkg: Adds BaseAlwaysFalseDepexLib Library Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 3/7] AmdPlatformPkg: Implements SerialPortLib for simulator Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 4/7] AmdPlatformPkg: Adds PlatformSocLib library class Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 5/7] AmdPlatformPkg: Adds AmdConfigRouting driver Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 6/7] AmdPlatformPkg: Adds SecureBootDefaultKeysInit driver Abdul Lateef Attar via groups.io
2024-05-15  3:50 ` [edk2-devel] [RESEND 7/7] AmdPlatformPkg: Adds ACPI common driver Abdul Lateef Attar via groups.io
2024-05-15  3:59 ` Chang, Abner via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=LV8PR12MB945277B5AF93662FCF6F2BEBEAEC2@LV8PR12MB9452.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox