From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F16C940CF7 for ; Thu, 16 May 2024 01:06:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6bZ83zcsV0buNRvHWDllVHyT5SSiUh9waGWQdJMLbMc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715821566; v=1; b=qMFvWo5UQ5xOXXG/Uc8Lm4ljfN/yDkhaaX90KCvG1M49tMjgO1PnunYaAxgrHIfHXz2F3s9l QJAfEGeZSg3oI7nYCTzj56QJjfQ5SxjfSzx0UcETlR4+nytyTTNAUrDc0/42y8QvaYyEP/H3AUL cQ8sK/D2iry1F/sGtQ4NJ/LmkAPRB9O6YvB0ugKiWDS4WbTewGJ7U79EDh8brT57n2TaRaSjU0t ZZD6NAvoG/deLI65Q0ObWRWxqm+HEQMRfXBsWs5BxvkSPDQLdaIj9gWYNW6PlInFQBxfmjljrm0 7HqUofm3moXcJeqVIfeOvgstA/ld8VXJYLSeKmgYwuIyQ== X-Received: by 127.0.0.2 with SMTP id PM2xYY7687511xyp1jyJrufx; Wed, 15 May 2024 18:06:06 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.85]) by mx.groups.io with SMTP id smtpd.web10.2405.1715821560876860569 for ; Wed, 15 May 2024 18:06:01 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by BL3PR12MB9050.namprd12.prod.outlook.com (2603:10b6:208:3b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Thu, 16 May 2024 01:05:54 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%4]) with mapi id 15.20.7544.052; Thu, 16 May 2024 01:05:54 +0000 From: "Chang, Abner via groups.io" To: Igor Kulchytskyy , Nickle Wang , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Topic: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Index: AQHapfvnY6/29aRjAk2uMEf8FEsIPrGYZZ0AgACn7qA= Date: Thu, 16 May 2024 01:05:54 +0000 Message-ID: References: <20240418122730.18204-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=02042108-8add-4e61-9fed-ea197e2b5c86;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-22T02:10:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|BL3PR12MB9050:EE_ x-ms-office365-filtering-correlation-id: bb96e269-3d4a-4a7a-e95a-08dc75445634 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?0tt0vPGENwkNIHhpH80Rbkj2c5JpRI+1eHpvVxkOkz0U8B8yRrwe8T/WbWti?= =?us-ascii?Q?BuJA96cJ4NrKy7+2lvXeYL6lbjb137kzzk4rcAzoQcVHuUiycHoeP6/MWAMj?= =?us-ascii?Q?UEb6y6sT6tw1lE3I3pd33L3x/e5p/6CFMi9Qj1v4zgfwsICap0PT3yPVAIdO?= =?us-ascii?Q?9snaz0Hz3Hdu/9+Q3Ch9KCCeBreL/2UxVV4z2DMv8+Ez8qA9itvxcAuBbeNY?= =?us-ascii?Q?fIkrxkFlFWvSH7zqVGe+rHR/31Spw0q6z+ZxlKUO7vJZrP/K8YDmBny7zkdG?= =?us-ascii?Q?TNlYBM2zEZyr8yOMCRIPZDtc6U8JdcOcUKbnBtPV2CCO2zbiJ4qZAXOgGbIF?= =?us-ascii?Q?Cob3mtRjbfvspbyruU/LJWb2u707cRJqZsbuugD2H7A7WKigDyv9UkI4RA88?= =?us-ascii?Q?SG5E4hWqMNTCSOC1qJS6ERox3pK7USZ2Tr93X967qMGX/0rF6MdQmGrR/gmC?= =?us-ascii?Q?XQNic2iKFcpYrWoLXq/W3PoxSIQL2FRSi4RkcWjism5VksVK1RR1Qp4RZG/a?= =?us-ascii?Q?6pfL76EWgGaHEgXTumoaZumGmqNx8foEZw9/JV1+IytiQ2wmtm0rHh6S6wko?= =?us-ascii?Q?zZdwBxbzQ1RdrJrtG3uCgWEqdgJKPz88+T+Z/lawextJZMF8eRY+ogu01Cpe?= =?us-ascii?Q?tMkwL2aDiEInShBJz5F+q618Dk6skkOjp0EeJOMQJimzeOB22xtlt9OOOMmR?= =?us-ascii?Q?qR2yAGn41sRRZ0hlV6yRDxFSftXlkAMqkWfAKQR3eABEuU9P1iSDCbNRFwdz?= =?us-ascii?Q?AJ3eUn87BhH8dLGN71LZVyL8zTNCz/73OqjnDPWZ08/Zc4PoKqGihvRhMtM3?= =?us-ascii?Q?V6OEwtxtcjxh8cIVrAReMQJyebNB7k3vTCmpft3A6Kg7Ak4T9N/8Ojo2YZhC?= =?us-ascii?Q?x5gaCZmO3fMrXS+p2ShEZwQbmRyTXCyZIZAe9ADneuYa8blXyDP3GjPygDrd?= =?us-ascii?Q?hu7Hc3kkoF0Gg2CFsuX71djwVPS18TYFN1Xr6/W9nxCwfh6J/FPWG8OcUXRO?= =?us-ascii?Q?+svdNYPae5n24wMEuYsn5cigkXfpy4RF8ZOVMNKwFHzBN4VgUilAH2bT5cEU?= =?us-ascii?Q?XelZEtMbxUbADwdtp+f3iVCSJhY2o/PFmwhM6N0FiXc6sTHSo9XYdmro30a8?= =?us-ascii?Q?lYwfUxukNO9OYY2zmDZOxaeik+QiFedRdFnMD6hTLND/5GowdpwzN5rriAax?= =?us-ascii?Q?OMQK3JN0TxZUaWRYpOFE/+q65YdZ7zZqHVibnYSKWi0HsgYKUxhjjEwLn57H?= =?us-ascii?Q?pl2h71NOmwP5s00Q+Xhf8qEWEMW8H9CDwAG0eI0hxw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e5h4INIxgpk5AacbzeJ+8E5SG7o1DNKppC+LPPfBfRad9R9vV2LTKbIgC/+Y?= =?us-ascii?Q?B8U8veXG1/Sn6obsxOR4mkTrN+rwoiZcyxm0yv4GaFSPZ6ie5ugIA8AP/Hct?= =?us-ascii?Q?zXeylUHwxasxY3uBoKCK5NRvlagAZ+Kx0FXE9dNoT/5+/c7ZGLR1IILSawvG?= =?us-ascii?Q?k+5PYtvvKBTqlp0RBrPP5+Lcp5y2R6QWmX99rpipOEXivH158o8RESgsRVko?= =?us-ascii?Q?i0YOlLsf1cwqLyzXPmULM/MOVvLmbVdWu/6SsNVi1SzBEj5hZcjE+3Pxq3gf?= =?us-ascii?Q?4KcDlo2zZo6QQuosBtGsvL19l6JhQXxMB6BySdt7+vJqBehN/by/Y8xe/ibW?= =?us-ascii?Q?nCZgqMqSJNcQzqqSw+GZHahthuAtCHmEQxsAuilAHErHfIL7roy5P4u+yt4o?= =?us-ascii?Q?Fgcc9TgkBR8jIN77s9K6SPqi1TeQVgNfW8bgJ5/u5EtmTQR55lfYw5hQHnp+?= =?us-ascii?Q?B6ga1uMRqxszcvLzrRBxAqErlypIPlbQ3BrOiXLU+aA0QEfGAnDA6IRYe+xZ?= =?us-ascii?Q?ktVF1eY+EZvZm16aLw4frO6e5AqWuy7NOMIbw/5eFQZd4O9rK+8wX4vfmwm/?= =?us-ascii?Q?5OimZhxUK0MjoDnIgsgWjuJi4j3ZR2hqglSRIRJt437vt44p4hiPYcPeckJu?= =?us-ascii?Q?WvrVBafGN58s14Wjf6ja0MHmA8/v4nurCrREy2oAM7cPw80C3hWm19CF8A9f?= =?us-ascii?Q?HyfLueiP4gwN/tyY/uPXKzb+G0sSuyH4z9Q4B5/tyEDw+vM7qZJdtRBBnO+u?= =?us-ascii?Q?/03dEw68v2lc61aG27910nEgw2ps95mXoRUpKIG8CrTc+HF4844HyEQv4fZi?= =?us-ascii?Q?YSbKT3N9LWUxlEqQD/6NoPi1PYb1NfBn7hVzwsqU5jqNnawDG+prvWZ4jbwU?= =?us-ascii?Q?hlMIXSvdVZDvod7qLMvwwlqsAGQip970gIMl16MfJfHYzAsmVMSjQhtTrG2c?= =?us-ascii?Q?vb9OQvbnO7z3ZF+OgRyjXdCnfoWYUvWJnZFdJrDk6SSXAmbYTi4YBGYvseNB?= =?us-ascii?Q?YCR62tBZN7ya9fRznzrVYUvn0BQtwB58D++dcInwip2GztCp4k59RB8u9Vlu?= =?us-ascii?Q?FwEfKDxhLklVzvgeRGm+CvOOLdgeBXY+7PjWudv8osGJiNADZ6JJUj8YhM7d?= =?us-ascii?Q?Vo65sVrH6tt2B7gkJDGFgjPMmbo2v7C3kx7aF7hZXYhhnWRMCo5+tNIP1p3a?= =?us-ascii?Q?v6Kwj6SiBYcBcvrZKQsAD5NRUMJF42DAz7ykG04nU55StXWLGviCOzQfQJZV?= =?us-ascii?Q?WTD/DuAblTCFuCyaZmTUvMG3moM99iQcKJBPBbTaeDSqoZZhAozcDbCF5YID?= =?us-ascii?Q?E6SqgpNB9YqLsWDz4XPC1Xdm6P6VlBxCLEsQAnHoZ3GidQVZKYPJf9bUTZLu?= =?us-ascii?Q?TtsoChP0rFU4kW20SK/QylpL3ureKfHvxxlIDX/Mjv/t4OA7Kh/+1vJoTfWF?= =?us-ascii?Q?VI1ADQ/H1YAO9QOB7FV4UVAFWzXdlQ8hiSDpBttGHRHBYkGp5rPxlk4qThPc?= =?us-ascii?Q?CkerXr9vYqv26RCPWdRmnwT0QIZn5A6aw58OTR68Rvg6Uu7aEnfA2HgyrME/?= =?us-ascii?Q?/uEqA/yUKrecSjTXwPC7SNF1Vqu4LIkCX27qA9Z9?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb96e269-3d4a-4a7a-e95a-08dc75445634 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 01:05:54.3737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JVMFZBJUvGET+C7m5v3bvf4SLo2v54nb8JZDgTK0DbpO1wnA2DBgOKk9Qq9+BGuu1TM8fQfhu3Hk6AZd1qKgfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB9050 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 18:06:01 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VMh5z9PUgEdFvvjgBSH3OZtEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=qMFvWo5U; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] HI Igor, This sounds to me reasonable to me. As you mentioned, RedfishPkg was design= ed to support multiple Redfish applications and RedfishClientPkg is just on= e of them. I think we can review the implementation of acquiring/deleting c= redential. Thanks Abner > -----Original Message----- > From: Igor Kulchytskyy > Sent: Wednesday, May 15, 2024 11:02 PM > To: Nickle Wang ; devel@edk2.groups.io; Chang, Abner > > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] > RedfishClientPkg: introduce RedfishBootstrapAccountDxe > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Hi Nickle, > I have one more question to discuss regarding this driver. > We have a bootstrap account and creation of this account controlled by > RedfishCredentialDxe driver in RedfishPkg. > But deletion of that bootstrap account is moved to RedfishClientPkg. > What if we have another Redfish Client or some customer service which use= s > RedfishPkg for the communication. > Architecturally it is allowed. > But then RedfishBootstrapAccountDxe module would delete account just > based on the RedfishClientPkg needs. > Maybe we should consider moving RedfishBootstrapAccountDxe driver to > RedfishPkg and have some register mechanism which will be used by > interested drivers to notify that they finished their job and after that > RedfishBootstrapAccountDxe driver would delete an account. > What do you think? > Thank you, > Igor > > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, May 14, 2024 8:40 AM > To: devel@edk2.groups.io; abner.chang@amd.com; Igor Kulchytskyy > > Cc: Nick Ramirez > Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] > RedfishClientPkg: introduce RedfishBootstrapAccountDxe > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** > > Hi Abner, > > > Ok, then I don't have the problem with invoking GetAuthInfo again. > However, I > > will suggest to add more description in GetAuthInfo function header, > mention that > > we will keep the auth info in EFI variable until exist boot service. > > Also, give some more descriptions on the code you invoke to GetAuthInfo= . > > Thanks for your comment. I add descriptions to explain above before calli= ng > GetAuthInfo(). Version 2 path is here: > https://edk2.groups.io/g/devel/message/118889 > > Regards, > Nickle > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > Abner > > via groups.io > > Sent: Tuesday, April 23, 2024 3:42 PM > > To: Nickle Wang ; Igor Kulchytskyy ; > > devel@edk2.groups.io > > Cc: Nick Ramirez > > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg= : > > introduce RedfishBootstrapAccountDxe > > > > External email: Use caution opening links or attachments > > > > > > [AMD Official Use Only - General] > > > > > -----Original Message----- > > > From: Nickle Wang > > > Sent: Tuesday, April 23, 2024 3:09 PM > > > To: Igor Kulchytskyy ; Chang, Abner > > > ; devel@edk2.groups.io > > > Cc: Nick Ramirez > > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] > RedfishClientPkg: > > > introduce RedfishBootstrapAccountDxe > > > > > > [AMD Official Use Only - General] > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > Hi Igor, Abner, > > > > > > Thanks for your review. Please allow me to answer your questions > together. > > > > > > > 1. We suppose acquire the credential before we start to communicate > > > > with > > > Redfish. Will Redfish credential driver create another bootstrap > > > account here after provisioning? > > > No, according to the RedfishPlatformCredentialIpmiLib implementation, > > > Redfish credential driver requests credential from BMC and will keep > > > it for later use. So only one credential is requested for BIOS Redfis= h > > > feature drivers during POST time. > > Ok, then I don't have the problem with invoking GetAuthInfo again. > However, I > > will suggest to add more description in GetAuthInfo function header, > mention that > > we will keep the auth info in EFI variable until exist boot service. > > Also, give some more descriptions on the code you invoke to GetAuthInfo= . > > > > > > > > > 2. And why do we delete the credential after provisioning? How abou= t > > > > the > > > later Redfish property updating process? > > > In this driver, we listen to "AfterProvisioning" event. And this is > > > the event triggered after Redfish feature driver finish all jobs. > > > There is no feature driver which gets executed after this event. And > > > since we finished all Redfish operations, we remove this account on B= MC. > > Then this makes sense to me now. > > > > > > > > > Why do we need to delete those credentials? According to spec BMC > > > > should > > > delete the bootstrap credentials automatically on host or service res= et. > > > Yes, bootstrap credentials get deleted on host reset. In practice, > > > server in datacenter usually takes long time running under OS before = it gets > > rebooted. > > > The bootstrap credentials are exposed to end user at > > > "/redfish/v1/AccountService/Accounts". I got report that there is > > > concern for end user to see this unused account. > > This sounds to me reasonable as we will give bootstrap credential a hig= h > privilege > > to update Redfish resource. Leave this information in Account service s= eems > not a > > good idea. > > > > Thanks > > Abner > > > > > > > > So, I create this driver to allows us to remove bootstrap account at > > > BMC after we finish Redfish jobs. And this also release the BMC > > > account resource since this account won't be used for a long period o= f > time. > > > > > > Regards, > > > Nickle > > > > > > > -----Original Message----- > > > > From: Igor Kulchytskyy > > > > Sent: Monday, April 22, 2024 11:03 PM > > > > To: Chang, Abner ; Nickle Wang > > > > ; devel@edk2.groups.io > > > > Cc: Nick Ramirez > > > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] > RedfishClientPkg: > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > Hi Nickle and Abner, > > > > I also have the same question as Abner. > > > > Why do we need to delete those credentials? > > > > According to spec BMC should delete the bootstrap credentials > > > > automatically > > > on > > > > host or service reset. > > > > Thank you, > > > > Igor > > > > > > > > -----Original Message----- > > > > From: Chang, Abner > > > > Sent: Sunday, April 21, 2024 10:25 PM > > > > To: Nickle Wang ; devel@edk2.groups.io > > > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > > > > > Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientP= kg: > > > > introduce RedfishBootstrapAccountDxe > > > > > > > > > > > > **CAUTION: The e-mail below is from an external source. Please > > > > exercise caution before opening attachments, clicking links, or > > > > following guidance.** > > > > > > > > [AMD Official Use Only - General] > > > > > > > > Hi Nickle, > > > > One comment and few questions, > > > > > > > > > -----Original Message----- > > > > > From: Nickle Wang > > > > > Sent: Thursday, April 18, 2024 8:28 PM > > > > > To: devel@edk2.groups.io > > > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > > > ; Nick Ramirez > > > > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: introduce > > > > > RedfishBootstrapAccountDxe > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > proper caution when opening attachments, clicking links, or > responding. > > > > > > > > > > > > > > > -Introduce RedfishBootstrapAccountDxe to delete bootstrap account > > > > > from /redfish/v1/AccountService/Accounts after BIOS finished all > > > > > Redfish jobs. The bootstrap account won't be available to other > application. > > > > > So deleting bootstrap account helps to release resource at BMC. > > > > > - After bootstrap account is deleted at BMC, the Redfish service > > > > > instance is no longer usable. Close Redfish service instance to > > > > > release the HTTP connection between BIOS and BMC. > > > > > > > > > > Signed-off-by: Nickle Wang > > > > > Cc: Abner Chang > > > > > Cc: Igor Kulchytskyy > > > > > Cc: Nick Ramirez > > > > > --- > > > > > .../RedfishClientComponents.dsc.inc | 1 + > > > > > .../RedfishBootstrapAccountDxe.inf | 53 +++ > > > > > .../RedfishBootstrapAccountDxe.h | 58 ++++ > > > > > .../RedfishBootstrapAccountDxe.c | 328 ++++++++++++= ++++++ > > > > > RedfishClientPkg/RedfishClient.fdf.inc | 1 + > > > > > 5 files changed, 441 insertions(+) create mode 100644 > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > .inf > > > > > create mode 100644 > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > .h > > > > > create mode 100644 > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > .c > > > > > > > > > > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > index 42fc0c299..fe5248b62 100644 > > > > > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > > @@ -20,6 +20,7 @@ > > > > > > RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxe.inf > > > > > RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.inf > > > > > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxe.inf > > > > > + > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > > .inf > > > > > !endif > > > > > # > > > > > # Below two modules should be pulled in by build tool. > > > > > diff --git > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.in > > > > > f > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.in > > > > > f > > > > > new file mode 100644 > > > > > index 000000000..4073e95f4 > > > > > --- /dev/null > > > > > +++ > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.in > > > > > f > > > > > @@ -0,0 +1,53 @@ > > > > > +## @file > > > > > +# This driver deletes bootstrap account in BMC after BIOS > > > > > +Redfish finished # all jobs # # (C) Copyright 2021 Hewlett > > > > > +Packard Enterprise Development LP
# Copyright (c) 2023, > > > > > +NVIDIA CORPORATION & AFFILIATES. All rights reserved. > > > > > > > > > > > > Not sure if you want to update the copyright to 2024. > > > > > > > > > > > > > +# > > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent # ## > > > > > + > > > > > +[Defines] > > > > > + INF_VERSION =3D 0x0001000b > > > > > + BASE_NAME =3D RedfishBootstrapAccountDxe > > > > > + FILE_GUID =3D 87555253-2F7E-45FC-B469-FD35B2E5= 1210 > > > > > + MODULE_TYPE =3D DXE_DRIVER > > > > > + VERSION_STRING =3D 1.0 > > > > > + ENTRY_POINT =3D RedfishBootstrapAccountEntryPoin= t > > > > > + UNLOAD_IMAGE =3D RedfishBootstrapAccountUnload > > > > > + > > > > > +[Packages] > > > > > + MdePkg/MdePkg.dec > > > > > + MdeModulePkg/MdeModulePkg.dec > > > > > + RedfishPkg/RedfishPkg.dec > > > > > + RedfishClientPkg/RedfishClientPkg.dec > > > > > + > > > > > +[Sources] > > > > > + RedfishBootstrapAccountDxe.h > > > > > + RedfishBootstrapAccountDxe.c > > > > > + > > > > > +[LibraryClasses] > > > > > + BaseLib > > > > > + BaseMemoryLib > > > > > + DebugLib > > > > > + MemoryAllocationLib > > > > > + PrintLib > > > > > + RedfishEventLib > > > > > + RedfishFeatureUtilityLib > > > > > + RedfishDebugLib > > > > > + RedfishVersionLib > > > > > + RedfishHttpLib > > > > > + UefiLib > > > > > + UefiBootServicesTableLib > > > > > + UefiRuntimeServicesTableLib > > > > > + UefiDriverEntryPoint > > > > > + > > > > > +[Protocols] > > > > > + gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMES ## > > > > > + gEdkIIRedfishCredentialProtocolGuid ## CONSUMES ## > > > > > + gEfiRestExProtocolGuid ## CONSUMES ## > > > > > + > > > > > +[Depex] > > > > > + gEdkIIRedfishCredentialProtocolGuid > > > > > diff --git > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.h > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.h > > > > > new file mode 100644 > > > > > index 000000000..5262f1e6b > > > > > --- /dev/null > > > > > +++ > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.h > > > > > @@ -0,0 +1,58 @@ > > > > > +/** @file > > > > > + Common header file for RedfishBootstrapAccountDxe driver. > > > > > + > > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > > > > > + LP
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. Al= l > > > rights > > > > reserved. > > > > > + > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > + > > > > > +**/ > > > > > + > > > > > +#ifndef REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ #define > > > > > +REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ > > > > > + > > > > > +#include > > > > > +#include > > > > > + > > > > > +// > > > > > +// Libraries > > > > > +// > > > > > +#include > > > > > +#include #include > > > > > + > > > > > +#include #include > > > > > + #include > > > > > +#include > > > > > +#include #include > > > > > + #include > > > > > +#include > > > > > +#include #include > > > > > + #include > > > > > + > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#define REDFISH_BOOTSTRAP_ACCOUNT_DEBUG > DEBUG_VERBOSE > > > > > +#define REDFISH_MANAGER_ACCOUNT_COLLECTION_URI > > > > > L"AccountService/Accounts" > > > > > +#define REDFISH_URI_LENGTH 128 > > > > > + > > > > > +// > > > > > +// Definitions of REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE // typedef > > > struct > > > > > +{ > > > > > + EFI_HANDLE ImageHandle; > > > > > + EFI_HANDLE RestExHandle; > > > > > + REDFISH_SERVICE RedfishService; > > > > > + EFI_EVENT RedfishEvent; > > > > > + EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL Protocol; > > > > > +} REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE; > > > > > + > > > > > +#define > > > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL(This) \ > > > > > + BASE_CR ((This), REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE, > > > > > +Protocol) > > > > > + > > > > > +#endif > > > > > diff --git > > > > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.c > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.c > > > > > new file mode 100644 > > > > > index 000000000..6fe4856f8 > > > > > --- /dev/null > > > > > +++ > > > > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > > xe.c > > > > > @@ -0,0 +1,328 @@ > > > > > +/** @file > > > > > + This driver deletes bootstrap account in BMC after BIOS Redfis= h > > > > > +finished > > > > > + all jobs. > > > > > + > > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > > > > > + LP
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. Al= l > > > rights > > > > reserved. > > > > > + > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > + > > > > > +**/ > > > > > + > > > > > +#include "RedfishBootstrapAccountDxe.h" > > > > > + > > > > > +REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *mBootstrapPrivate =3D > NULL; > > > > > + > > > > > +/** > > > > > + Close Redfish service instance by calling RestEx protocol to > > > > > +release > > > instance. > > > > > + > > > > > + @param[in] RestExHandle Handle of RestEx protocol. > > > > > + > > > > > + @retval EFI_SUCCESS The Redfish service is closed su= ccessfully. > > > > > + @retval EFI_INVALID_PARAMETER RestExHandle is NULL. > > > > > + @retval Others Error occurs. > > > > > + > > > > > +**/ > > > > > +EFI_STATUS > > > > > +CloseRedfishService ( > > > > > + IN EFI_HANDLE RestExHandle > > > > > + ) > > > > > +{ > > > > > + EFI_REST_EX_PROTOCOL *RestEx; > > > > > + EFI_STATUS Status; > > > > > + > > > > > + if (RestExHandle =3D=3D NULL) { > > > > > + return EFI_INVALID_PARAMETER; } > > > > > + > > > > > + Status =3D gBS->HandleProtocol ( > > > > > + RestExHandle, > > > > > + &gEfiRestExProtocolGuid, > > > > > + (VOID **)&RestEx > > > > > + ); > > > > > + if (!EFI_ERROR (Status)) { > > > > > + Status =3D RestEx->Configure (RestEx, NULL); > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: release > RestEx > > > > > instance: %r\n", __func__, Status)); > > > > > + } > > > > > + > > > > > + return Status; > > > > > +} > > > > > + > > > > > +/** > > > > > + Callback function executed when the AfterProvisioning event > > > > > +group is > > > > > signaled. > > > > > + > > > > > + @param[in] Event Event whose notification function is bei= ng > invoked. > > > > > + @param[out] Context Pointer to the Context buffer > > > > > + > > > > > +**/ > > > > > +VOID > > > > > +EFIAPI > > > > > +RedfishBootstrapAccountOnRedfishAfterProvisioning ( > > > > > + IN EFI_EVENT Event, > > > > > + OUT VOID *Context > > > > > + ) > > > > > +{ > > > > > + EFI_STATUS Status; > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > + EDKII_REDFISH_CREDENTIAL_PROTOCOL *credentialProtocol; > > > > > + EDKII_REDFISH_AUTH_METHOD AuthMethod; > > > > > + CHAR8 *AccountName; > > > > > + CHAR8 *AccountCredential; > > > > > + CHAR16 TargetUri[REDFISH_URI_LENGT= H]; > > > > > + CHAR16 *RedfishVersion; > > > > > + REDFISH_RESPONSE RedfishResponse; > > > > > + > > > > > + RedfishVersion =3D NULL; > > > > > + > > > > > + Private =3D (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *)Context; if > > > > > + ((Private =3D=3D NULL) || (Private->RedfishService =3D=3D NULL)= ) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: Redfish service is not > > > > > + available\n", > > > > > __func__)); > > > > > + return; > > > > > + } > > > > > + > > > > > + // > > > > > + // Locate Redfish Credential Protocol to get credential for /= / > > > > > + accessing to Redfish service. > > > > > + // > > > > > + Status =3D gBS->LocateProtocol ( > > > > > + &gEdkIIRedfishCredentialProtocolGuid, > > > > > + NULL, > > > > > + (VOID **)&credentialProtocol > > > > > + ); > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: No Redfish > > > > > Credential Protocol is installed on system.", __func__)); > > > > > + return; > > > > > + } > > > > > + > > > > > + Status =3D credentialProtocol->GetAuthInfo ( > > > > > + credentialProtocol, > > > > > + &AuthMethod, > > > > > + &AccountName, > > > > > + &AccountCredential > > > > > + ); > > > > > > > > HI Nickle, I am not quite understand why do we acquire a credential > > > > here but delete it from the Redfish account service here after prov= ision. > > > > 1. We suppose acquire the credential before we start to communicate > > > > with Redfish. Will Redfish credential driver create another > > > > bootstrap account here after provisioning? > > > > 2. And why do we delete the credential after provisioning? How abou= t > > > > the > > > later > > > > Redfish property updating process? > > > > Or do I misunderstand the code logic? > > > > > > > > Regards, > > > > Abner > > > > > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get bootstrap account > > > information: > > > > > %r\n", __func__, Status)); > > > > > + return; > > > > > + } > > > > > + > > > > > + // > > > > > + // Carving the URI > > > > > + // > > > > > + RedfishVersion =3D RedfishGetVersion (Private->RedfishService)= ; > > > > > + if (RedfishVersion =3D=3D NULL) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get Redfish version\n", > > > __func__)); > > > > > + return; > > > > > + } > > > > > + > > > > > + UnicodeSPrint (TargetUri, (sizeof (CHAR16) * > > > > > + REDFISH_URI_LENGTH), > > > > > L"%s%s/%a", RedfishVersion, > > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI, > > > > > AccountName); > > > > > + > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > account: > > > > > %a\n", __func__, AccountName)); > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > > credential: %a\n", __func__, AccountCredential)); > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > URI: > > > > > %s\n", __func__, TargetUri)); > > > > > + > > > > > + // > > > > > + // Remove bootstrap account at > > > > > + /redfish/v1/AccountService/Account > > > > > + // > > > > > + ZeroMem (&RedfishResponse, sizeof (REDFISH_RESPONSE)); Status > > > > > + =3D RedfishHttpDeleteResource ( > > > > > + Private->RedfishService, > > > > > + TargetUri, > > > > > + &RedfishResponse > > > > > + ); > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not remove bootstrap account a= t > > > BMC: > > > > > %r", __func__, Status)); > > > > > + DumpRedfishResponse (__func__, DEBUG_ERROR, > > > &RedfishResponse); } > > > > > + else { > > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > account: > > > > > %a is removed from: %s\n", __func__, AccountName, > > > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI)); > > > > > + } > > > > > + > > > > > + // > > > > > + // Clean credential > > > > > + // > > > > > + ZeroMem (AccountName, AsciiStrSize (AccountName)); ZeroMem > > > > > + (AccountCredential, AsciiStrSize (AccountCredential)); > > > > > + > > > > > + // > > > > > + // Since the bootstrap account is deleted at BMC, the Redfish > > > > > + service instance > > > > > is no longer usable. > > > > > + // Close Redfish service instance to release the HTTP > > > > > + connection between > > > > > BIOS and BMC. > > > > > + // > > > > > + Status =3D CloseRedfishService (Private->RestExHandle); if > > > > > + (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: cannot close Redfish service insta= nce: > > > > > + %r\n", > > > > > __func__, Status)); > > > > > + } > > > > > + > > > > > + RedfishHttpFreeResponse (&RedfishResponse); > > > > > + > > > > > + return; > > > > > +} > > > > > + > > > > > +/** > > > > > + Initialize a Redfish configure handler. > > > > > + > > > > > + This function will be called by the Redfish config driver to > > > > > + initialize each > > > > > Redfish configure > > > > > + handler. > > > > > + > > > > > + @param[in] This Pointer to > > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > > + @param[in] RedfishConfigServiceInfo Redfish service informai= ton. > > > > > + > > > > > + @retval EFI_SUCCESS The handler has been init= ialized > > > successfully. > > > > > + @retval EFI_DEVICE_ERROR Failed to create or confi= gure the > REST > > > EX > > > > > protocol instance. > > > > > + @retval EFI_ALREADY_STARTED This handler has already = been > > > > > initialized. > > > > > + @retval Other Error happens during the = initialization. > > > > > + > > > > > +**/ > > > > > +EFI_STATUS > > > > > +EFIAPI > > > > > +RedfishBootstrapAccountInit ( > > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This, > > > > > + IN REDFISH_CONFIG_SERVICE_INFORMATION > > > *RedfishConfigServiceInfo > > > > > + ) > > > > > +{ > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > + > > > > > + Private =3D > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > > (This); > > > > > + > > > > > + Private->RedfishService =3D RedfishCreateService > > > > > + (RedfishConfigServiceInfo); if (Private->RedfishService =3D=3D= NULL) { > > > > > + return EFI_DEVICE_ERROR; > > > > > + } > > > > > + > > > > > + Private->RestExHandle =3D RedfishConfigServiceInfo- > > > > > >RedfishServiceRestExHandle; > > > > > + > > > > > + return EFI_SUCCESS; > > > > > +} > > > > > + > > > > > +/** > > > > > + Stop a Redfish configure handler. > > > > > + > > > > > + @param[in] This Pointer to > > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > > + > > > > > + @retval EFI_SUCCESS This handler has been stoped > successfully. > > > > > + @retval Others Some error happened. > > > > > + > > > > > +**/ > > > > > +EFI_STATUS > > > > > +EFIAPI > > > > > +RedfishBootstrapAccountStop ( > > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This > > > > > + ) > > > > > +{ > > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > > + > > > > > + Private =3D > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > > (This); > > > > > + > > > > > + if (Private->RedfishService !=3D NULL) { > > > > > + RedfishCleanupService (Private->RedfishService); > > > > > + Private->RedfishService =3D NULL; } > > > > > + > > > > > + return EFI_SUCCESS; > > > > > +} > > > > > + > > > > > +EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL > mRedfishConfigHandler =3D > > > { > > > > > + RedfishBootstrapAccountInit, > > > > > + RedfishBootstrapAccountStop > > > > > +}; > > > > > + > > > > > +/** > > > > > + Unloads an image. > > > > > + > > > > > + @param[in] ImageHandle Handle that identifies the i= mage to be > > > > > unloaded. > > > > > + > > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > > > handle. > > > > > + > > > > > +**/ > > > > > +EFI_STATUS > > > > > +EFIAPI > > > > > +RedfishBootstrapAccountUnload ( > > > > > + IN EFI_HANDLE ImageHandle > > > > > + ) > > > > > +{ > > > > > + EFI_STATUS Status; > > > > > + > > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > > + return EFI_SUCCESS; > > > > > + } > > > > > + > > > > > + if (mBootstrapPrivate->RedfishEvent !=3D NULL) { > > > > > + gBS->CloseEvent (mBootstrapPrivate->RedfishEvent); > > > > > + } > > > > > + > > > > > + Status =3D gBS->UninstallProtocolInterface ( > > > > > + mBootstrapPrivate->ImageHandle, > > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > > + (VOID *)&mBootstrapPrivate->Protocol > > > > > + ); > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not uninstall Redfish config > > > > > + handler > > > > > protocol: %r\n", __func__, Status)); > > > > > + } > > > > > + > > > > > + FreePool (mBootstrapPrivate); > > > > > + mBootstrapPrivate =3D NULL; > > > > > + > > > > > + return EFI_SUCCESS; > > > > > +} > > > > > + > > > > > +/** > > > > > + This is the declaration of an EFI image entry point. This entr= y > > > > > +point is > > > > > + the same for UEFI Applications, UEFI OS Loaders, and UEFI > > > > > +Drivers including > > > > > + both device drivers and bus drivers. > > > > > + > > > > > + @param[in] ImageHandle The firmware allocated handle fo= r the > UEFI > > > > > image. > > > > > + @param[in] SystemTable A pointer to the EFI System Tabl= e. > > > > > + > > > > > + @retval EFI_SUCCESS The operation completed successf= ully. > > > > > + @retval Others An unexpected error occurred. > > > > > +**/ > > > > > +EFI_STATUS > > > > > +EFIAPI > > > > > +RedfishBootstrapAccountEntryPoint ( > > > > > + IN EFI_HANDLE ImageHandle, > > > > > + IN EFI_SYSTEM_TABLE *SystemTable > > > > > + ) > > > > > +{ > > > > > + EFI_STATUS Status; > > > > > + > > > > > + if (mBootstrapPrivate !=3D NULL) { > > > > > + return EFI_ALREADY_STARTED; > > > > > + } > > > > > + > > > > > + mBootstrapPrivate =3D AllocateZeroPool (sizeof > > > > > (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE)); > > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > > + return EFI_OUT_OF_RESOURCES; > > > > > + } > > > > > + > > > > > + CopyMem (&mBootstrapPrivate->Protocol, > &mRedfishConfigHandler, > > > > > + sizeof > > > > > (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); > > > > > + Status =3D gBS->InstallProtocolInterface ( > > > > > + &ImageHandle, > > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > > + EFI_NATIVE_INTERFACE, > > > > > + &mBootstrapPrivate->Protocol > > > > > + ); > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: can not install Redfish config > > > > > + handler > > > > > protocol: %r\n", __func__, Status)); > > > > > + goto ON_ERROR; > > > > > + } > > > > > + > > > > > + // > > > > > + // Register after provisioning event to remove bootstrap accou= nt. > > > > > + // > > > > > + Status =3D CreateAfterProvisioningEvent ( > > > > > + RedfishBootstrapAccountOnRedfishAfterProvisioning, > > > > > + (VOID *)mBootstrapPrivate, > > > > > + &mBootstrapPrivate->RedfishEvent > > > > > + ); > > > > > + if (EFI_ERROR (Status)) { > > > > > + DEBUG ((DEBUG_ERROR, "%a: failed to register > > > > > + after-provisioning > > > event: > > > > > %r\n", __func__, Status)); > > > > > + goto ON_ERROR; > > > > > + } > > > > > + > > > > > + return EFI_SUCCESS; > > > > > + > > > > > +ON_ERROR: > > > > > + > > > > > + RedfishBootstrapAccountUnload (ImageHandle); > > > > > + > > > > > + return Status; > > > > > +} > > > > > diff --git a/RedfishClientPkg/RedfishClient.fdf.inc > > > > > b/RedfishClientPkg/RedfishClient.fdf.inc > > > > > index 154f641b2..47e5093f2 100644 > > > > > --- a/RedfishClientPkg/RedfishClient.fdf.inc > > > > > +++ b/RedfishClientPkg/RedfishClient.fdf.inc > > > > > @@ -15,6 +15,7 @@ > > > > > INF > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.inf > > > > > INF RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > > > > > INF > > > > > > > > > RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > > > > > + INF > > > > > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > .inf > > > > > INF > RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.inf > > > > > INF > > > > > > > > > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf > > > > > INF > > > > > > > > > > > > > RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemD > > > xe. > > > > > i > > > > > nf > > > > > -- > > > > > 2.34.1 > > > > > > > > -The information contained in this message may be confidential and > > > proprietary > > > > to American Megatrends (AMI). This communication is intended to be > > > > read > > > only by > > > > the individual or entity to whom it is addressed or by their > > > > designee. If the > > > reader > > > > of this message is not the intended recipient, you are on notice > > > > that any distribution of this message, in any form, is strictly > > > > prohibited. Please > > > promptly > > > > notify the sender by reply e-mail or by telephone at 770-246-8600, > > > > and > > > then > > > > delete or destroy all copies of the transmission. > > > > > >=20 > > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telep= hone > at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118936): https://edk2.groups.io/g/devel/message/118936 Mute This Topic: https://groups.io/mt/105596648/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-