From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 89122940FC4 for ; Fri, 9 Aug 2024 02:44:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zeEhowYJ3cnUYJB/DmZbFprZXZh69ZYrKTWZS0CEGsw=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1723171471; v=1; b=uGz/Al1Pikt4wmUUpjj8yncW+F1PwaoNGRDyR3kATe8OJ61f4oRwweYeoS/h8daNXeX2TaO4 /7gjRo878eAeUsMigWDY1wBkLnDipA55jo56cHi1Eu1+zk2yqMLgQIBlNi4rjcqGp0EBgeRprk8 G6bMk6+I3nKIJvCZ2mMYY2xnhilSl836+a4yrpTEBBfBhOBAAS0ET2H7o7Klh19qOy/E2ygUN+F R8m2l5JqaXf5Jqsyz+WyeSiIFUSllUhazuVxvJ7fTL+DO0z7dGPVcg565MUxFI/6DP/6+pyDZX3 AwgnKDiZtGBiqYY/J8lDxwDZcGPs24SYHli2mhDtU4xuA== X-Received: by 127.0.0.2 with SMTP id gGzvYY7687511xoQU5aQ2BNM; Thu, 08 Aug 2024 19:44:29 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.58]) by mx.groups.io with SMTP id smtpd.web10.76104.1723171468795047088 for ; Thu, 08 Aug 2024 19:44:29 -0700 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com (2603:10b6:408:200::8) by IA0PR12MB8645.namprd12.prod.outlook.com (2603:10b6:208:48f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.25; Fri, 9 Aug 2024 02:44:24 +0000 X-Received: from LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08]) by LV8PR12MB9452.namprd12.prod.outlook.com ([fe80::9d67:b4b7:7bad:8c08%3]) with mapi id 15.20.7849.008; Fri, 9 Aug 2024 02:44:24 +0000 From: "Chang, Abner via groups.io" To: Nhi Pham OS , "devel@edk2.groups.io" CC: "quic_llindhol@quicinc.com" , Chuong Tran OS , "Rebecca Cran OS" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Thread-Index: AQHa6JYaiUmWXOWvgEK2HfpEs97lYLIbYgWQgAAFjgCAAtI6sA== Date: Fri, 9 Aug 2024 02:44:24 +0000 Message-ID: References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_ContentBits=0;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Enabled=True;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Method=Standard;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_Name=Confidential;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SetDate=2024-08-07T07:35:27.202Z;MSIP_Label_5b82cb1d-c2e0-4643-920a-bbe7b2d7cc47_SiteId=3bc2b170-fd94-476d-b0ce-4229bdc904a7;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ActionId=e7cb7dd8-e5a8-4ea9-91b8-e65ac7f6bc28;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=true;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-08-07T07:15:35Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR12MB9452:EE_|IA0PR12MB8645:EE_ x-ms-office365-filtering-correlation-id: 6bf2307f-10fc-4caf-a2dc-08dcb81d2dbc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?0GrUu1eZNEi8tSdq51O/Olyd5EHw4ynYnazr0iLv/sUA0C+uAdwWnRRC3MFM?= =?us-ascii?Q?ernmve9hzaNCavS9yxYPbJcjBfjxG4dC5GwSn0Dn+JFb7NambzkRGsU6O9Z7?= =?us-ascii?Q?rumBGy5K+hM9GwKtuuEbfmiO6/ABj8uXL4/LQB0Ogc8+/M08hqSH+9ts4zq3?= =?us-ascii?Q?I59Va5n6LFDfr4240ONmjPUMPR/JynhoxuEa49iARpsWM/SkLQ0i+Wg35E5B?= =?us-ascii?Q?cx9ivwOhcgPJpMWk1z/5Q0Ps8W8a8Ig+8jUdJf22ir7KM0H8HVoAYEvAiZ7A?= =?us-ascii?Q?LNe2i7BZUOaB49DI3QSLQq0TNsLr8sjHaKfQRi9bzJB6K9BwsFS/2Yw/7F7r?= =?us-ascii?Q?HfqPZZVwBFTf5Qgzdf96adaE85IB5IQfphneJOWwBI+nPfjq1Nx5DJ3KrSgU?= =?us-ascii?Q?5uCuzAinUXkLJpGqE9l0waGy+mwTmMwV9PJKVtngv0ICctNWROKw3Xh0u2Ej?= =?us-ascii?Q?YtgD2TmIxmWBOoJtQZaK72s8xlE9zm3UW+T1NGTuBb5M97U0GBs+dJXiIog3?= =?us-ascii?Q?5T1jE0WVCzKSsMTUi7Qepp4R3aWv/A/c9udeXjxqINnTSIYJMU/wssI6eAwO?= =?us-ascii?Q?dFu/XswPuJnet3Jj7FWVsInveYkmZrmWF7P04mY59g/qMey2lQi8g0sITvnL?= =?us-ascii?Q?U4Ms+2sMPhRjauR9KSzO718yJbTi3guwYRtVgYIkQRTAMA73WQaD/Gb/Mp/0?= =?us-ascii?Q?zM3x70s2q66B1jtaDQsLtDKRFxiy4RYua54Id/o2WLeoSC4dslZkTI3fOXiS?= =?us-ascii?Q?Pb/i16dHDwm8OpBfL57eWuPE8694ULPvRdY1iIq8dqG1dhg5Nc4hHfmvL8LY?= =?us-ascii?Q?e/wLtF6DtidCpttQgVE8HE1ZR4VPizNJm2UbAPl/a+rPvCUYKCAts4KYY23Y?= =?us-ascii?Q?xqWu/H0toaN9c4jxTSd8bnogelvg24hFo2jvV2jQBHMOlaPYWuVTcgQlx3Gt?= =?us-ascii?Q?oVJMIjM/qcML/h6m8ZFC7YKfr103pbQNgRHE+hR5r8DeYjzvPjoHXQJhH6Ux?= =?us-ascii?Q?Bjp7mGtA+WswX+kums/UccTXvEUcPGCvgwcuTie0FxnBPc3JZEXBF6OAzRMP?= =?us-ascii?Q?2unj4tDsLWBPFb/PjkbC90qTiQPzMPH8UrhKgy4QL0g3vnfFiuzgZSpU/rHF?= =?us-ascii?Q?v4vxsMC+REBk5rSVvUDT9KTPwwt9nnrteKk18OvV9ovvmClGGgvgf/EgRqKG?= =?us-ascii?Q?3X1sDxHHRnhPhVDUZqqvXJ07MDaniywxv+bjrBkFe5upNWyeC8oiXN4sX7Pf?= =?us-ascii?Q?u55rTK+/UX4ECpQD2IWA9Lb7ysS3f1PBk+ieWezbeWwP2yoarzJNC7lJTdh7?= =?us-ascii?Q?L6yivr/DBkhAu0s9pp91/vJuv5sw2pC8+K+mTYBRXT2ttXrL7SdaAHlDoyFN?= =?us-ascii?Q?+aL0Ca0=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j+wul0Bgka2f+JtnlTbioQ8gUXx3p5Q0EijAcw9YEba9fnESmsZD5+PCgyom?= =?us-ascii?Q?WaBfn7SmKWtqf9jNeKYx+A67IR4jw86jyouRYjTE0WhyVr2NcrjD5uMIZZCT?= =?us-ascii?Q?AubLNw/Wk0eKIWJaaoSOy5klf/ecSEHJucK1Gtzj1gPZCqi4mhCrG74XEsZF?= =?us-ascii?Q?3wuVXgt1uJviujtvzPZh0Z/6vEfLBWYamCfTZS8NNtd+K2y5nD2mebfLlcxl?= =?us-ascii?Q?5PAzBYeP1W6Gj8/FQLjmlbgHjpwXaZpTWvGkEA2aFX5gWnMozKBMkOwHkXAA?= =?us-ascii?Q?Z/cZHAPCzef+ctkrGjGLqY/j41rtDqPVgV3qe3YtWW7458f7AH4WoN21LIhu?= =?us-ascii?Q?AnKV9SLQJv9trCr3gcEgN7yUxxhrs7TAhMQJo0Y+dpWiPgcjWxYWaw+K7+Hz?= =?us-ascii?Q?AIaX06jEdZWAbWIqfrmXdiXqVtgPf9nTfCp/aqZ56KPOH6alOOsGXVUZpUU3?= =?us-ascii?Q?xjxKfQlik6p+yU2LNBy8DyyIIR15La8MDG6SD4+rN8hMvm0XSt2kdNbj+4ZY?= =?us-ascii?Q?dLUgCkTlD0cbcLxT1m4/GARD68AJwqWWrqf+xdqgR7AWJDKPqNFOBsiZGasp?= =?us-ascii?Q?iJGb5uEuP8NeY+2FhqJ7IOCmn3+nPSAnAlhVJNei6Ik1LxvDWBpF87EoaIhd?= =?us-ascii?Q?g8LHCm74p7P79EUbWjty/YIrs3nEuX2SjYyiOEHuTSiXck8XeyMxcqIhGPcf?= =?us-ascii?Q?YASxOOIMroxIrgmlGUX7zYA/Ykh3jgp9ycFpqjjlnQh6ZibVRAGCQDhKGgqf?= =?us-ascii?Q?b106KHxH75aGAdSH4jNvd6R1vEZxKfcmiRQAllZxoc02hSXHzqfsbD87UJrc?= =?us-ascii?Q?rydE/Jhwea4bZkBhzevQk6rgjOc8iAg7uo/M5T6wx65SeIjzH9LDH9NIkQJi?= =?us-ascii?Q?rWXcA8OihNU+gorCRWeZ5hHSkMtDe8yJWvDLn9mJnj/tjrVYfZX2w9WP2r6H?= =?us-ascii?Q?uAfurKOQ0Fvh6LCr5Ft62Gf/xj7hsxTmkokX6hU77D+fyXoapqWF24WNMMbc?= =?us-ascii?Q?Mg9nf+tjdp/5iGhMjpkvewJhA5BftQ4nnOoYGPOJn+i7by31i03DfiOWUHfP?= =?us-ascii?Q?8L6+FzEjsJq+VGy661OtQMtdfgUY8h9sXeTp0zPehF0poxxY12cwEwOci8B3?= =?us-ascii?Q?ZmqCE/6CNUYp3f0Yv7zsNs7AxBhM0m2tK9tNRJl4tsK6t4wInSZ0b9+lv9am?= =?us-ascii?Q?sKwISP5toBDUthZxd/adjxnxj5f8tfz0v6WuFIBRjTPKp1R+5Ug2is6YNJtW?= =?us-ascii?Q?EkWGmZ2IpTSic4won2EkCdUn8aFMod1GIfcTsHXBLIyenMUygOfnCy5SK0wC?= =?us-ascii?Q?mBvY6SOonnAF0I8QQCUbKQBjC9IJeapmlnsT4Ljmj8WZLSG9B5EinzJW0V3w?= =?us-ascii?Q?3FuXAmV+dD3vIKkxoZhSmT5VB92rkUPCk/9IqwK6vm4bfCML3a2XZws30b4Z?= =?us-ascii?Q?zUZa/TqiP6yIYj9aMJzEGD1obdcnk331xDKyRysIup2XsRSpm8aib2Is7ptc?= =?us-ascii?Q?q4epjTaszBVdFS0+dj1QcynzElIfMNutDyAhRNRN60xHqiWbXSES1mN4J59b?= =?us-ascii?Q?8yTk+NByISeikcHrzp0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9452.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf2307f-10fc-4caf-a2dc-08dcb81d2dbc X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2024 02:44:24.0234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5URwbEy9FQS/BW6B/M99IffbhCI2ypeRubtHdqaKnRtAHDc+hpPZYl/uQHs1x+QKVDgEBKqcFe0J99ym3Q4gcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8645 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 08 Aug 2024 19:44:29 -0700 Resent-From: abner.chang@amd.com Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yrwF9R14yNUdceQ3Hpj6eeHRx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_LV8PR12MB94529AB10086FE185ABD9A93EABA2LV8PR12MB9452namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="uGz/Al1P"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_LV8PR12MB94529AB10086FE185ABD9A93EABA2LV8PR12MB9452namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, Just realize this patch is not for ManageabilityPkg when I go through the p= atch, I will leave this to the owner. Also, I shouldn't suggest you to crea= te PR as I am not the owner, sorry about this. Thanks Abner From: Nhi Pham OS Sent: Wednesday, August 7, 2024 3:35 PM To: Chang, Abner ; devel@edk2.groups.io Cc: quic_llindhol@quicinc.com; Chuong Tran OS ; Rebecca Cran OS Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF supp= ort [AMD Official Use Only - AMD Internal Distribution Only] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Sure, Abner. I've created this PR https://github.com/tianocore/edk2-platfor= ms/pull/178 Regards, Nhi ________________________________ From: Chang, Abner > Sent: Wednesday, August 7, 2024 2:16 PM To: devel@edk2.groups.io >; Nhi Pham OS > Cc: quic_llindhol@quicinc.com >; Chuong Tran OS >; Rebecca Cran= OS > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF supp= ort [AMD Official Use Only - AMD Internal Distribution Only] Hi Pham, We already move edk2-platforms review through GitHub PR. Could you please s= end the PR against edk2-platforms? Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Nhi Pham > via groups.io > Sent: Wednesday, August 7, 2024 2:47 PM > To: devel@edk2.groups.io > Cc: quic_llindhol@quicinc.com; chuong@o= s.amperecomputing.com; > rebecca@os.amperecomputing.com; nh= i@os.amperecomputing.com > Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF suppor= t > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform. > > v2: > - Refine the changes of the DwI2cLib per Leif's comments and update the > commit message accordingly. > - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. > > NOTE: Regarding the controller/target terminology, the function > prototype and comment are derived from edk2/MdePkg. In this patch set, I > am trying to avoid misusing the terms in the implementation instead of > altering the function prototype and comment with the PPI and Protocol. > > Nhi Pham (5): > AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation > AmpereSiliconPkg: Define PCDs for SMBUS and BMC > AmpereAltraPkg: Add SmbusHc PEI and DXE drivers > JadePkg: Add PlatformBmcReadyLib to support BMC ready check > Ampere/Jade: Enable IPMI SSIF > > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec = | 15 +- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc = | 23 ++ > Platform/Ampere/JadePkg/Jade.dsc = | 2 + > Platform/Ampere/JadePkg/Jade.fdf = | 17 ++ > > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf | 29 ++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf = | > 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf = | > 43 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > | 95 +++++++ > Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h = | 11 +- > Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c > | 6 +- > > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c | 30 +++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > | 261 ++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c = | > 277 ++++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c = | > 263 +++++++++++++++++++ > Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c = | 129 > ++++++++- > 15 files changed, 1227 insertions(+), 17 deletions(-) > create mode 100755 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > create mode 100644 > Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c > create mode 100644 > Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c > > -- > 2.25.1 > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120301): https://edk2.groups.io/g/devel/message/120301 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_LV8PR12MB94529AB10086FE185ABD9A93EABA2LV8PR12MB9452namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - AMD Internal Distribution Only]


Hi Pham,=

Just realize this p= atch is not for ManageabilityPkg when I go through the patch, I will leave = this to the owner. Also, I shouldn’t suggest you to create PR as I am= not the owner, sorry about this.

 

Thanks

Abner

 

From: Nhi Pham OS <nhi@os.amperec= omputing.com>
Sent: Wednesday, August 7, 2024 3:35 PM
To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io Cc: quic_llindhol@quicinc.com; Chuong Tran OS <chuong@os.ampereco= mputing.com>; Rebecca Cran OS <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SS= IF support

 

[AMD Official Use Only - AMD Internal= Distribution Only]

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Sure, Abner. I've created this PR https://gi= thub.com/tianocore/edk2-platforms/pull/178

Regards,
Nhi

From: Chang,= Abner <Abner.Chang@amd.com&g= t;
Sent: Wednesday, August 7, 2024 2:16 PM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Nhi Pham OS <nhi@os.ampere= computing.com>
Cc: quic_llindhol@quici= nc.com <quic_llindhol@q= uicinc.com>; Chuong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebe= cca@os.amperecomputing.com>
Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SS= IF support

 

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Pham,
We already move edk2-platforms review through GitHub PR. Could you please s= end the PR against edk2-platforms?

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Nhi Pham
> via groups.io
> Sent: Wednesday, August 7, 2024 2:47 PM
> To: devel@edk2.groups.io > Cc: quic_llindhol@quicinc= .com; chuong@os.amperecomputing.com;
> rebecca@os.amperecom= puting.com; nhi@os.amperecomputing.com
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF sup= port
>
> Caution: This message originated from an External Source. Use proper c= aution
> when opening attachments, clicking links, or responding.
>
>
> This updates the I2C library and implements SMBUS PEI/DXE drivers to > support IPMI SSIF in the Mt. Jade platform.
>
> v2:
> - Refine the changes of the DwI2cLib per Leif's comments and update th= e
>   commit message accordingly.
> - Remove the additional PCD PcdBmcSlaveAddr since it's is unused.
>
> NOTE: Regarding the controller/target terminology, the function
> prototype and comment are derived from edk2/MdePkg. In this patch set,= I
> am trying to avoid misusing the terms in the implementation instead of=
> altering the function prototype and comment with the PPI and Protocol.=
>
> Nhi Pham (5):
>   AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operati= on
>   AmpereSiliconPkg: Define PCDs for SMBUS and BMC
>   AmpereAltraPkg: Add SmbusHc PEI and DXE drivers
>   JadePkg: Add PlatformBmcReadyLib to support BMC ready chec= k
>   Ampere/Jade: Enable IPMI SSIF
>
>  Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec  =             &nb= sp;         |  15 +-
>  Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc  =             &nb= sp;         |  23 ++
>  Platform/Ampere/JadePkg/Jade.dsc     &n= bsp;            = ;            &n= bsp;            = ; |   2 +
>  Platform/Ampere/JadePkg/Jade.fdf     &n= bsp;            = ;            &n= bsp;            = ; |  17 ++
>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf |  29 ++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf&nbs= p;            &= nbsp;  |
> 43 +++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf&nbs= p;            &= nbsp;  |
> 43 +++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h > |  95 +++++++
>  Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h &nbs= p;            &= nbsp;       |  11 +-
>  Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF8506= 3.c
> |   6 +-
>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c   |  30 +++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c > | 261 ++++++++++++++++++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c =             &nb= sp;    |
> 277 ++++++++++++++++++++
>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c =             &nb= sp;    |
> 263 +++++++++++++++++++
>  Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c &= nbsp;           &nbs= p;     | 129
> ++++++++-
>  15 files changed, 1227 insertions(+), 17 deletions(-)
>  create mode 100755
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.inf
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h
>  create mode 100644
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady > Lib.c
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c
>  create mode 100644
> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c
>
> --
> 2.25.1
>
>
>
>
>

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#120301) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_LV8PR12MB94529AB10086FE185ABD9A93EABA2LV8PR12MB9452namp_--