Re: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory leak in ConverterLib

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

Hi Mike,
I just merged it.

Also Reviewed-by: Abner Chang <abner.chang@amd.com> for this two patches set. You can create a PR against edk2-redfish-client, I will merge it once it passes CI.
Thank you
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, January 30, 2024 7:15 PM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com
> Subject: Re: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory
> leak in ConverterLib
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> I created PR containing patch 2/2 with your R-b set.
>
> https://github.com/DMTF/Redfish-Schema-C-Struct-Generator/pull/5
>
> Please review and commit. Thank you!
>
> Regards,
> Mike.
>
> On Mon, Jan 29, 2024 at 5:41 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > Would you like to create a PR on below repo
> https://github.com/DMTF/Redfish-Schema-C-Struct-Generator for the 2/2
> patch? As we should fix the issue on DMTF Github as well.
> RedfishCsCommon.c is here, https://github.com/DMTF/Redfish-Schema-C-
> Struct-Generator/tree/main/src. I can also help to sync up the fix if you are ok
> with it.
> >
> > Thanks
> > Abner
> >
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Saturday, January 27, 2024 8:01 AM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Subject: [edk2-redfish-client][PATCH 2/2] RedfishClientPkg: fix memory
> leak in
> > > ConverterLib
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > The memory returned by json_dumps() must be freed.
> > >
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > ---
> > >  RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> > > b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> > > index 126200dd019c..250ef75e40de 100644
> > > --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> > > +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> > > @@ -379,15 +379,19 @@ CreateCsJsonByNode (
> > >    if (TempChar != NULL) {
> > >
> > >      Status = allocateRecordCsMemory (Cs, sizeof
> > > (RedfishCS_Type_JSON_Data), (void **)&CsTypeJson);
> > >
> > >      if (Status != RedfishCS_status_success) {
> > >
> > > +      free (TempChar);
> > >
> > >        return Status;
> > >
> > >      }
> > >
> > >
> > >
> > >      Status = allocateRecordCsMemory (Cs, (RedfishCS_int)strlen (TempChar)
> +
> > > 1, (void **)&DumpStr);
> > >
> > >      if (Status != RedfishCS_status_success) {
> > >
> > > +      free (TempChar);
> > >
> > >        return Status;
> > >
> > >      }
> > >
> > >
> > >
> > >      strncpy (DumpStr, TempChar, strlen (TempChar) + 1);
> > >
> > > +    free (TempChar);
> > >
> > > +
> > >
> > >      InitializeLinkHead (&CsTypeJson->Header.LinkEntry);
> > >
> > >      CsTypeJson->Header.ResourceType = RedfishCS_Type_JSON;
> > >
> > >      CsTypeJson->Header.ThisUri      = ParentUri;
> > >
> > > @@ -1506,9 +1510,10 @@ RemoveUnchangeableProperties (
> > >        Status = RedfishCS_status_insufficient_memory;
> > >
> > >      } else {
> > >
> > >        memcpy (NewJsonBuffer, TempChar, strlen (TempChar) + 1);
> > >
> > > -      free (TempChar);
> > >
> > >        Status = RedfishCS_status_success;
> > >
> > >      }
> > >
> > > +
> > >
> > > +    free (TempChar);
> > >
> > >    } else {
> > >
> > >      Status = RedfishCS_status_unknown_error;
> > >
> > >    }
> > >
> > > --
> > > 2.32.0 (Apple Git-132)
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114786): https://edk2.groups.io/g/devel/message/114786
Mute This Topic: https://groups.io/mt/103988340/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-