Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - General]

HI all,
I have no problem with the plan A, except the folder structure under CpuExecptionHandlerLib.
It has a LoongArch folder that contains the common source files for LoongArch and LoongArch64 folder under LoongArch for 64-buite architecture. This folder structure is different from other lib such as MpInitLib and CpuTimerLib.
Do you have 32-bit LoongArch? If not for now, then you probably can move the files under LoongArch to LoongArch64. Len you can a consistent folder structure for LoongArch.

Thanks
Abner

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Friday, January 19, 2024 9:48 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; lichao@loongson.cn;
> Sunil V L <sunilvl@ventanamicro.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Chang, Abner <Abner.Chang@amd.com>
> Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 1/19/24 11:17, Ni, Ray wrote:
> > Chao,
> >
> >
> >
> > In the plan A, CpuDxe.inf contains reference to
> > gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress in [Pcd]
> > section. But I guess it’s only needed by LoongArch64. That’s why I
> > didn’t like the common-inf idea.
> >
> >
> >
> > But after looking at the other INF changes, I changed my mind. I think
> > the common-inf looks good as the other INF files don’t have so much
> > difference between LoonArch and x86.
> >
> >
> >
> > So, I am ok with plan A. Thanks for preparing both changes for review.
> >
> >
> >
> > Mike, Laszlo, Gerd, Abner, any comments?
>
> I'm also OK with plan A.
>
> Thanks
> Laszlo
>
> >
> >
> >
> >
> >
> > Thanks,
> >
> > Ray
> >
> > *From:* Chao Li <lichao@loongson.cn>
> > *Sent:* Thursday, January 18, 2024 4:27 PM
> > *To:* Ni, Ray <ray.ni@intel.com>; Sunil V L <sunilvl@ventanamicro.com>
> > *Cc:* devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gerd
> > Hoffmann <kraxel@redhat.com>; Abner Chang <abner.chang@amd.com>
> > *Subject:* Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
> >
> >
> >
> > Hi Ray and Sunil,
> >
> > Sorry, I'm late, I have very busy these days.
> >
> > I created two PRs in my private repo.
> >
> > *Plan A:*
> >
> > Moved most of LoongArch libraries and drivers to current matching
> > folders, removed LoongArch private INF, adjusted common INF.
> >
> > URL: https://github.com/kilaterlee/edk2/pull/8
> > <https://github.com/kilaterlee/edk2/pull/8>
> >
> >
> >
> > *Plan B:*
> >
> > Moved most of LoongArch libraries and drivers to current matching
> > folders, keeping to use LoongArch private INF.
> >
> > URL: https://github.com/kilaterlee/edk2/pull/9
> > <https://github.com/kilaterlee/edk2/pull/9>
> >
> >
> >
> > After you reading these two PRs, let's discuss how to deal with INF.
> >
> > I prefer plan A, it is better to use the same INF for all ARCHs and have
> > only one INF per modules. I was discussed this plan with Ray and Abner,
> > but it was not allowed at the time.
> >
> >
> >
> > Thanks,
> > Chao
> >
> > On 2024/1/16 08:59, Chao Li wrote:
> >
> >     OK, let me finish this work tomorrow, I'm a little busy today.
> >
> >     On 2024/1/15 16:11, Ni, Ray wrote:
> >
> >         Yes. Fine to me. Thanks!
> >
> >
> >
> >         Thanks,
> >
> >         Ray
> >
> >             -----Original Message-----
> >
> >             From: Sunil V L <sunilvl@ventanamicro.com>
> <mailto:sunilvl@ventanamicro.com>
> >
> >             Sent: Monday, January 15, 2024 2:46 PM
> >
> >             To: Chao Li <lichao@loongson.cn> <mailto:lichao@loongson.cn>
> >
> >             Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ni, Ray
> <ray.ni@intel.com> <mailto:ray.ni@intel.com>; Kinney, Michael D
> >
> >             <michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com>;
> Laszlo Ersek <lersek@redhat.com> <mailto:lersek@redhat.com>; Gerd
> >
> >             Hoffmann <kraxel@redhat.com> <mailto:kraxel@redhat.com>
> >
> >             Subject: Re: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
> >
> >
> >
> >             On Mon, Jan 15, 2024 at 02:17:09PM +0800, Chao Li wrote:
> >
> >                 Ray and Sunil,
> >
> >
> >
> >                 I plan send two example PRs to github to  show how to deal the
> INFs, one to
> >
> >                 adjust current INF, and another PR to move the libraris to the current
> >
> >                 folders. I hope after these two PRs are sent we can decide what to do
> with
> >
> >                 the INF. What do you think of this plan?
> >
> >
> >
> >
> >
> >             Hi Chao, That's fine with me.
> >
> >
> >
> >             Thanks,
> >
> >             Sunil
> >
> >                 Thanks,
> >
> >                 Chao
> >
> >                 On 2024/1/15 13:44, Ni, Ray wrote:
> >
> >                     That will be great!
> >
> >
> >
> >                     Thanks,
> >
> >                     Ray
> >
> >                         -----Original Message-----
> >
> >                         From: Sunil V L<sunilvl@ventanamicro.com>
> <mailto:sunilvl@ventanamicro.com>
> >
> >                         Sent: Monday, January 15, 2024 12:44 PM
> >
> >                         To: Ni, Ray<ray.ni@intel.com> <mailto:ray.ni@intel.com>
> >
> >                         Cc:devel@edk2.groups.io;lichao@loongson.cn
> <mailto:Cc:devel@edk2.groups.io;lichao@loongson.cn>; Kinney, Michael D
> >
> >                         <michael.d.kinney@intel.com>
> <mailto:michael.d.kinney@intel.com>; Laszlo Ersek<lersek@redhat.com>
> <mailto:lersek@redhat.com>; Gerd
> >
> >                         Hoffmann<kraxel@redhat.com> <mailto:kraxel@redhat.com>
> >
> >                         Subject: Re: RFC: Folder layout change in UefiCpuPkg
> >
> >
> >
> >                         On Mon, Jan 15, 2024 at 01:13:03AM +0000, Ni, Ray wrote:
> >
> >                             Sunil,
> >
> >                             I am glad that you don't have concern about the direction.
> >
> >
> >
> >                             "RiscV" is good to me.
> >
> >
> >
> >
> >
> >                         Thanks!, Ray. So, shall I send patches to reorganize this?
> >
> >
> >
> >                         Thanks,
> >
> >                         Sunil
> >
> >     
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114166): https://edk2.groups.io/g/devel/message/114166
Mute This Topic: https://groups.io/mt/103679850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-