Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support

["Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>]

[AMD Official Use Only - AMD Internal Distribution Only]

No problem.  You can add the tag on subject like Silicon/Ampere or something else distinguishable next time. 😊

Thanks
Abner

> -----Original Message-----
> From: Nhi Pham <nhi@os.amperecomputing.com>
> Sent: Friday, August 9, 2024 11:05 AM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: quic_llindhol@quicinc.com; Chuong Tran OS
> <chuong@os.amperecomputing.com>; Rebecca Cran OS
> <rebecca@os.amperecomputing.com>
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF
> support
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Sure, it appears the patch subject makes you confused.
>
> Regards,
> Nhi
>
> On 8/9/2024 9:44 AM, Chang, Abner wrote:
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> >
> > Hi Pham,
> >
> > Just realize this patch is not for ManageabilityPkg when I go through
> > the patch, I will leave this to the owner. Also, I shouldn’t suggest you
> > to create PR as I am not the owner, sorry about this.
> >
> > Thanks
> >
> > Abner
> >
> > *From:*Nhi Pham OS <nhi@os.amperecomputing.com>
> > *Sent:* Wednesday, August 7, 2024 3:35 PM
> > *To:* Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> > *Cc:* quic_llindhol@quicinc.com; Chuong Tran OS
> > <chuong@os.amperecomputing.com>; Rebecca Cran OS
> > <rebecca@os.amperecomputing.com>
> > *Subject:* Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF
> > support
> >
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> >
> >
> > *Caution:*This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> > Sure, Abner. I've created this PR https://github.com/tianocore/edk2-
> > platforms/pull/178 <https://github.com/tianocore/edk2-
> platforms/pull/178>
> >
> > Regards,
> > Nhi
> >
> > ------------------------------------------------------------------------
> >
> > *From:*Chang, Abner <Abner.Chang@amd.com
> <mailto:Abner.Chang@amd.com>>
> > *Sent:* Wednesday, August 7, 2024 2:16 PM
> > *To:* devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> > <devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Nhi Pham OS
> > <nhi@os.amperecomputing.com <mailto:nhi@os.amperecomputing.com>>
> > *Cc:* quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>
> > <quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>>; Chuong
> > Tran OS <chuong@os.amperecomputing.com
> > <mailto:chuong@os.amperecomputing.com>>; Rebecca Cran OS
> > <rebecca@os.amperecomputing.com
> <mailto:rebecca@os.amperecomputing.com>>
> > *Subject:* RE: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF
> > support
> >
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > Hi Pham,
> > We already move edk2-platforms review through GitHub PR. Could you
> > please send the PR against edk2-platforms?
> >
> > Thanks
> > Abner
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> <devel@edk2.groups.io
> > <mailto:devel@edk2.groups.io>> On Behalf Of Nhi Pham
> >> via groups.io
> >> Sent: Wednesday, August 7, 2024 2:47 PM
> >> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
> >> Cc: quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>;
> > chuong@os.amperecomputing.com
> <mailto:chuong@os.amperecomputing.com>;
> >> rebecca@os.amperecomputing.com
> <mailto:rebecca@os.amperecomputing.com>;
> > nhi@os.amperecomputing.com <mailto:nhi@os.amperecomputing.com>
> >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF
> support
> >>
> >> Caution: This message originated from an External Source. Use proper
> caution
> >> when opening attachments, clicking links, or responding.
> >>
> >>
> >> This updates the I2C library and implements SMBUS PEI/DXE drivers to
> >> support IPMI SSIF in the Mt. Jade platform.
> >>
> >> v2:
> >> - Refine the changes of the DwI2cLib per Leif's comments and update the
> >>   commit message accordingly.
> >> - Remove the additional PCD PcdBmcSlaveAddr since it's is unused.
> >>
> >> NOTE: Regarding the controller/target terminology, the function
> >> prototype and comment are derived from edk2/MdePkg. In this patch set, I
> >> am trying to avoid misusing the terms in the implementation instead of
> >> altering the function prototype and comment with the PPI and Protocol.
> >>
> >> Nhi Pham (5):
> >>   AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation
> >>   AmpereSiliconPkg: Define PCDs for SMBUS and BMC
> >>   AmpereAltraPkg: Add SmbusHc PEI and DXE drivers
> >>   JadePkg: Add PlatformBmcReadyLib to support BMC ready check
> >>   Ampere/Jade: Enable IPMI SSIF
> >>
> >>  Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec                        |  15
> +-
> >>  Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                        |  23
> ++
> >>  Platform/Ampere/JadePkg/Jade.dsc                                            |   2 +
> >>  Platform/Ampere/JadePkg/Jade.fdf                                            |  17 ++
> >>
> >>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
> >> Lib.inf |  29 ++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf
> |
> >> 43 +++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf
> |
> >> 43 +++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h
> >> |  95 +++++++
> >>  Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h                      |  11
> +-
> >>  Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063
> .c
> >> |   6 +-
> >>
> >>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
> >> Lib.c   |  30 +++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c
> >> | 261 ++++++++++++++++++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c
> |
> >> 277 ++++++++++++++++++++
> >>  Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c
> |
> >> 263 +++++++++++++++++++
> >>  Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c                   |
> 129
> >> ++++++++-
> >>  15 files changed, 1227 insertions(+), 17 deletions(-)
> >>  create mode 100755
> >>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
> >> Lib.inf
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h
> >>  create mode 100644
> >>
> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
> >> Lib.c
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c
> >>  create mode 100644
> >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c
> >>
> >> --
> >> 2.25.1
> >>
> >>
> >>
> >> 
> >>
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120305): https://edk2.groups.io/g/devel/message/120305
Mute This Topic: https://groups.io/mt/107765352/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-